Gabriel Luong
949d66da5f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9548 - Ability to rename top sites ( https://github.com/mozilla-mobile/fenix/pull/16285 )
...
* Ability to rename top sites, closes https://github.com/mozilla-mobile/fenix/issues/9548
* Highlight the "Remove" top site action as destructive
With more menu items in the top site contextual menu, it makes sense to differentiate
* Added test for the top site renaming action
* Fixed lint check (wildcard imports, blank spaces)
* Applied suggestions from code review
* Apply suggestions from code review
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
* Implemented dialog click listener with manual dismiss/cancel
Co-authored-by: Lorenzo Stanco <lorenzo.stanco@gmail.com>
2020-10-30 15:08:04 -04:00
ekager
c4d7e19da6
[fenix] No issue: Make sure we are cleaning up test coroutines
2020-10-29 18:57:23 -07:00
mozilla-l10n-automation-bot
0a9821fdbb
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16274 )
2020-10-29 21:40:40 -04:00
ekager
986e28f100
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16161 - Fixes Saved Login toolbar layout
2020-10-29 16:10:06 -07:00
Codrut Topliceanu
2d083e853a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14637 - Fix sitePermissionsFeature breaking change + AC bump ( https://github.com/mozilla-mobile/fenix/pull/16229 )
...
* For https://github.com/mozilla-mobile/fenix/issues/14637 - Compatibility patch for AC - 8554
* Update Android Components version to 65.0.20201029143039
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2020-10-29 19:08:31 -04:00
mozilla-l10n-automation-bot
f15d1054bb
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16240 )
2020-10-29 10:42:14 -04:00
mcarare
3047ea3601
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16250 : Disable remote USB debugging for SDK <23.
2020-10-29 15:02:02 +01:00
Mihai Adrian Carare
5fb5471df1
[fenix] For # 15929: Remove the search widget discoverability experiment. ( https://github.com/mozilla-mobile/fenix/pull/16081 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove SearchWidgetCFR telemetry.
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove SearchWidgetCFR and search widget experiment.
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove unit tests references to search widget experiment.
2020-10-28 13:46:02 -07:00
mcarare
51018be388
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15413 : Use proper url when bookmarking a page.
2020-10-28 16:33:48 +02:00
Oana Horvath
0f70a8d4fc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10690 : re-enable editBookmarkTest
2020-10-28 16:09:52 +02:00
Mozilla L10n Automation Bot
29e7f50cc3
[fenix] Import l10n.
2020-10-28 10:54:41 +01:00
Arturo Mejia
df0da31c1f
[fenix] Fix AddonsManagementFragment detekt error
2020-10-27 19:23:32 -04:00
Christian Sadilek
79ab29eff2
[fenix] No issue: Fix onConfigurationChange crashes in Debug build
2020-10-27 18:54:07 -04:00
Christian Sadilek
56c98b57b8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11285 : Replace Session[Manager] observers in BaseBrowserFragment
2020-10-27 17:40:58 -04:00
Grisha Kruglov
268da65b3f
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15816 - Attempt to handle 'allowInPrivate..' pref with detached context
2020-10-27 16:18:19 -04:00
mcarare
047b712ffe
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15379 : Use proper url when sharing.
2020-10-27 14:15:56 -04:00
ekager
647e73e851
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16199 - Don't pass BrowserToolbarView in onStart when we just need parent
2020-10-27 09:13:13 -07:00
Arturo Mejia
d3faecd59c
[fenix] Fix add-on translation braking changes
2020-10-27 11:33:18 -04:00
Aaron Train
a224f0c546
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8169 - Upgrade Mockwebserver ( https://github.com/mozilla-mobile/fenix/pull/16186 )
...
Upgrades Mockwebserver to 4.9.0
2020-10-27 10:19:24 -04:00
mozilla-l10n-automation-bot
b28b69915e
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16198 )
2020-10-26 20:28:45 -04:00
Lorenzo Stanco
bd068b288a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16122 - Add a dark theme color for the top sites pin icon ( https://github.com/mozilla-mobile/fenix/pull/16180 )
2020-10-26 18:50:41 -04:00
mozilla-l10n-automation-bot
aba1e64d9a
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16163 )
2020-10-26 12:07:02 -04:00
mozilla-l10n-automation-bot
bb2a8acb16
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16154 )
2020-10-23 22:18:34 -04:00
ekager
f3d03c5e73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Set session ClearColor through Engine DefaultSettings
2020-10-22 20:36:04 -07:00
mozilla-l10n-automation-bot
18012e4cfc
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16138 )
2020-10-22 23:12:05 -04:00
Jocelyne Abi Haidar
089fe7a9fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15508 : Show error when trying to save empty or invalid bookmark URL ( https://github.com/mozilla-mobile/fenix/pull/15674 )
2020-10-22 17:22:37 -04:00
mozilla-l10n-automation-bot
6cd2d75989
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16108 )
2020-10-21 21:01:50 -04:00
Mugurell
ebcb172781
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15543 - Adjust the height of the tabs tray depending on the number of tabs ( https://github.com/mozilla-mobile/fenix/pull/15749 )
2020-10-21 19:21:37 -04:00
ekager
6ff5ec846b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Feature Flag return to browser ( https://github.com/mozilla-mobile/fenix/pull/16099 )
2020-10-21 16:29:06 -04:00
ekager
f8d0a97210
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16084 - Match elevation of Tab in Collection to header ( https://github.com/mozilla-mobile/fenix/pull/16100 )
2020-10-21 15:47:25 -04:00
ekager
29a179e8c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15910 - Adds back automatic toggle, disables slider when enabled ( https://github.com/mozilla-mobile/fenix/pull/16070 )
2020-10-21 12:20:04 -04:00
Arturo Mejia
5070c12a7b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16019 - Fix intermittent test failure TrackingProtectionPolicyFactoryTest ( https://github.com/mozilla-mobile/fenix/pull/16056 )
2020-10-21 10:25:25 -04:00
mcarare
7f82d5e052
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14619 : Show half a tab top offset when scrolling to selected tab.
2020-10-21 13:31:59 +03:00
mozilla-l10n-automation-bot
d3cb8d03f0
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16074 )
2020-10-20 20:41:54 -04:00
Mugurell
ebcf7ea907
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16054 - Enable pull to refresh webpage in Nightly and Debug ( https://github.com/mozilla-mobile/fenix/pull/16060 )
2020-10-20 20:41:14 -04:00
Elise Richards
11e73eebfa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15080 : Handle default search engine when editing or removing ( https://github.com/mozilla-mobile/fenix/pull/15768 )
2020-10-20 16:00:00 -07:00
Juan C. Goncalves
a3fce6b92d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11397 - Add lint rule for AppCompatResources instead of ContextCompat ( https://github.com/mozilla-mobile/fenix/pull/16011 )
2020-10-20 13:23:43 -07:00
Sebastian Kaspari
09efe75e27
[fenix] FennecWebAppIntentProcessor: Catch JSONException.
2020-10-20 15:46:18 +02:00
Mihai Adrian Carare
274ab54236
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11631 : Move report site issue extension to main menu. ( https://github.com/mozilla-mobile/fenix/pull/15884 )
...
* For https://github.com/mozilla-mobile/fenix/issues/11631 : Move report site issue extension to main menu.
* For https://github.com/mozilla-mobile/fenix/issues/11631 : Update UI test for installing add-on.
2020-10-20 09:34:54 +03:00
Tom Klein
85d7bb0baf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15480 - Update the UI when a collection is renamed
2020-10-19 19:32:11 -07:00
mcarare
d7c63a63c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15688 : Update UI tests.
2020-10-19 17:45:46 -07:00
mcarare
0c48e945f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15688 : Update unit tests.
2020-10-19 17:45:46 -07:00
mcarare
ff595c7854
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15688 : Navigate to home screen with arguments on new tab action.
2020-10-19 17:45:46 -07:00
Mozilla L10n Automation Bot
a9e3cb974b
[fenix] Import l10n.
2020-10-19 17:37:17 -07:00
Sebastian Kaspari
9c7e0ad770
[fenix] Update Android Components, Kotlin, Gradle plugin ( https://github.com/mozilla-mobile/fenix/pull/16021 )
...
* Closes https://github.com/mozilla-mobile/fenix/issues/13262 : Update AGP to 4
* Update to Mozilla Android Components 63.0.20201019090011.
* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.
* Fix new compiler warnings.
* Fix compilation of lint rules module.
* Pin JNA version.
* Fix new lint errors.
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
2020-10-19 14:07:47 -04:00
Mihai Adrian Carare
b931723651
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14744 : Also show Fill link from clipboard with search shortcuts. ( https://github.com/mozilla-mobile/fenix/pull/15885 )
2020-10-19 13:58:54 -04:00
Christian Sadilek
5c9e32efda
[fenix] Configure M5 AMO collection for all builds
2020-10-19 11:19:47 -04:00
mozilla-l10n-automation-bot
b763fd4449
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16014 )
2020-10-18 23:26:52 -04:00
mozilla-l10n-automation-bot
0e83246501
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16001 )
2020-10-17 21:54:08 -04:00
mozilla-l10n-automation-bot
0a5089879a
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/15986 )
2020-10-17 09:41:31 -04:00
Gabriel Luong
d1e5785dad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15796 - Use the device locale for the system locale subtitle ( https://github.com/mozilla-mobile/fenix/pull/15975 )
2020-10-17 09:40:28 -04:00
Gabriel Luong
36ab249924
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15937 - Remove topFrecentSite feature flag ( https://github.com/mozilla-mobile/fenix/pull/15967 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15937 - Remove the topFrecentSite feature flag
* For https://github.com/mozilla-mobile/fenix/issues/15937 - Hide the "Pull to refresh" preference since its visibility is managed by a feature flag
2020-10-16 18:37:27 -07:00
ekager
b7cb6aa53c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7345 - Update new shield icons, remove lottie ( https://github.com/mozilla-mobile/fenix/pull/15909 )
2020-10-16 16:01:38 -07:00
Christian Sadilek
8ec056ffb9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11286 : Add TelemetryMiddleware to remove Session[Manager] observers
2020-10-16 11:05:34 -07:00
Gabriel Luong
96e38a14eb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15796 - show device language under follow device language ( https://github.com/mozilla-mobile/fenix/pull/15966 )
2020-10-16 12:47:56 -04:00
amkcpu
37f4575e58
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10683 : Show longer tab titles
...
Also update tab tray item layout according to specs posted in the issue.
2020-10-16 15:50:29 +03:00
mozilla-l10n-automation-bot
6d9480ec2d
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/15945 )
2020-10-15 17:29:04 -07:00
Jeff Boek
81556c956a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15596 - Removes upgrade faq link from fennec builds ( https://github.com/mozilla-mobile/fenix/pull/15643 )
2020-10-15 15:02:51 -07:00
Gabriel Luong
19b4a4ef5b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14922 : Use padding instead of margin to use the full screen width for the "Add search engine" button
2020-10-15 16:09:13 -04:00
mcarare
5348bed401
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14922 : Adjust margins for add search engine preference.
2020-10-15 16:09:13 -04:00
mcarare
30bd0ed572
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14922 : Add divider above address bar preferences.
2020-10-15 16:09:13 -04:00
mcarare
fcbe467703
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15898 : Add dividers above subheadings in tabs screen.
2020-10-15 13:13:52 -04:00
mcarare
ee99347d3d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15898 : Add dividers above subheadings in customise screen.
2020-10-15 13:13:52 -04:00
Michael Comella
0a83eb56f4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : add comment for why we set the app theme in test.
2020-10-15 09:53:13 -07:00
Michael Comella
aa19f541b2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : change apply to with in GleanMetricsService.
...
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.
I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
2020-10-15 09:53:13 -07:00
Michael Comella
910b7f19aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : mock package inspection dependencies in GleanMetricsService.
...
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
2020-10-15 09:53:13 -07:00
ekager
69a126cbb6
[fenix] Sets theme in FenixRobolectricTestApplication onCreate
2020-10-15 09:53:13 -07:00
Michael Comella
7cc54078d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : escalate many Performance check severity in lint.xml.
...
I exhaustively looked through the list of checks labeled performance and
marked them accordingly. To see all lint checks, type:
<android-sdk>/tools/bin/lint --show
2020-10-15 09:53:13 -07:00
Michael Comella
106a36bcdc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : remove unnecessary lint ignore.
2020-10-15 09:53:13 -07:00
Michael Comella
fec7662d8e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : escalate InefficientWeight to error.
...
All violations of this type were addressed in the previous commit.
2020-10-15 09:53:13 -07:00
ekager
74b4866e3d
[fenix] Fixes existing lint errors
2020-10-15 09:53:13 -07:00
Gabriel Luong
ef60d82caa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15907 - Remove the usage of the TabTrayGridItemDecorator
2020-10-15 10:02:07 -04:00
ekager
9d876a7076
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15347 - Adds telemetry for tabs settings
2020-10-14 22:53:31 -04:00
ekager
9f67b3df9b
[fenix] fix detekt errors
2020-10-14 18:22:02 -07:00
Sebastian Kaspari
3368ddce5c
[fenix] Use new SearchEngineProvider interface.
2020-10-14 18:22:02 -07:00
Mozilla L10n Automation Bot
d064b26fc0
[fenix] Import l10n.
2020-10-14 17:49:27 -07:00
Michael Comella
2b368b4bff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 - review: add license to lint-baseline.xml.
2020-10-14 15:20:28 -07:00
Michael Comella
30208f0345
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 : add current ConstraintLayout warnings to lint baseline.
2020-10-14 15:20:28 -07:00
Michael Comella
88cf7184ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15280 : suppress new lint rule in migration code.
2020-10-14 15:20:28 -07:00
ekager
5baed32e13
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15265 - Save cached top sites for metrics ping
2020-10-14 15:08:54 -07:00
ekager
6ee2d5a8dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Launch back to browser if we previoulsy had tabs
2020-10-14 15:05:20 -07:00
Mugurell
5cdb7f3a73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15890 - Ensure app locale switcher works for Windows builds
...
A hardcoded unix file separator prevented us from building a proper list of
locales for which we actually have packaged translations.
2020-10-14 15:34:39 +02:00
Mozilla L10n Automation Bot
ad43cd47a2
[fenix] Import l10n.
2020-10-13 20:54:10 -04:00
ekager
3726b8c98b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15853 - Always set fontSizeFactor setting with new text scale
2020-10-13 09:40:43 -07:00
Mihai Adrian Carare
26854525c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14735 : Remove debug logs from release build. ( https://github.com/mozilla-mobile/fenix/pull/15747 )
2020-10-13 09:17:58 -04:00
Mozilla L10n Automation Bot
f0a7f1bce0
[fenix] Import l10n.
2020-10-12 17:50:57 -07:00
Gabriel Luong
312626f8f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15777 - [Grid View] Set the height of the title to 30dp
2020-10-12 10:38:54 -07:00
Gabriel Luong
f977e5af36
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15758 ⁃ [Grid View] Add a divider between the tab item's title and thumbnail
2020-10-12 10:38:54 -07:00
Mozilla L10n Automation Bot
031b4687c6
[fenix] Import l10n.
2020-10-11 22:55:02 -04:00
Mozilla L10n Automation Bot
f1753eed23
[fenix] Import l10n.
2020-10-11 10:04:34 -04:00
Grisha Kruglov
53244870e9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15812 : Check for a null context during onScanResult
2020-10-09 20:40:03 -07:00
Mozilla L10n Automation Bot
993335b296
[fenix] Import l10n.
2020-10-09 20:42:16 -04:00
Shen
c63bc04bd2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13168 - Removed the close button from history navigation bar
2020-10-09 20:33:37 -04:00
Michael Comella
4fedc9d719
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - post: link to issue, data review.
2020-10-09 15:47:55 -07:00
Michael Comella
88268c18a1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: clarify init time for External...Activity.
2020-10-09 15:47:55 -07:00
Michael Comella
6c86641cbc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: change extra name to firstFramePreDrawNanos.
2020-10-09 15:47:55 -07:00
sraturi
e97a48b48f
[fenix] for https://github.com/mozilla-mobile/fenix/issues/10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types.
2020-10-09 15:47:55 -07:00
mcarare
69db319601
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13831 : Adjust buttons dimensions to improve a11y.
...
Margins were also adjusted to maintain relative placements.
2020-10-09 15:39:31 -07:00
mcarare
1ca3aab28a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13831 : Add ripple for the copy password button.
2020-10-09 15:39:31 -07:00
ekager
bf2e2d545d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14923 - Removes auto size preference toggle
2020-10-09 15:04:57 -07:00