Mihai Adrian
208d0c684b
[fenix] Temporarily fix lint issues with bad translation of string ( https://github.com/mozilla-mobile/fenix/pull/6963 )
2019-12-05 13:57:57 -08:00
mcarare
4a29b6b06b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6917 Emit mode change only when new mode is different from current
2019-12-05 11:10:14 -08:00
Mihai Adrian
b36189b3b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6910 Align shortcuts in private onboarding panel style to… ( https://github.com/mozilla-mobile/fenix/pull/6950 )
...
Divider only shows when both panel and "Search with" are visible
2019-12-05 09:37:20 -08:00
Mihai Adrian
a4be691ea0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6943 Hide supportActionBar in onResume, not onCreate ( https://github.com/mozilla-mobile/fenix/pull/6978 )
2019-12-05 09:36:39 -08:00
Mozilla L10n Automation Bot
4d9a90f293
[fenix] Import l10n.
2019-12-04 19:59:25 -08:00
Gabriel
9ed4f7f119
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5574 - Migrate SessionControl to LibState ( https://github.com/mozilla-mobile/fenix/pull/6651 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (https://github.com/mozilla-mobile/fenix/pull/6651 )
In https://github.com/mozilla-mobile/fenix/issues/2205 , the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Removes TabAction
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 15: Introduce a HomeFragmentStore (https://github.com/mozilla-mobile/fenix/pull/6651 )
- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 20: Remove the architecture module. (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 17: Remove duplicate subscribeToTabCollections in BrowserFragment.kt (https://github.com/mozilla-mobile/fenix/pull/6651 )
There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Renames SessionControlUIView to SessionControlView
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 21: Fix white screen on home fragment (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (https://github.com/mozilla-mobile/fenix/pull/6651 )
This ensures that the metrics.track will be called immediately before the tab is removed from the collection.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 24: Use the sessionManager getter in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Removes running CI against the architecture debug build varient
2019-12-04 22:06:05 -05:00
Jeff Boek
58bdd912e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6855 - Filter out duplicated bundled search engines
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 17:10:02 -08:00
mcarare
7a289d1eb1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6070 Adds telemetry for enabling search suggestions in private
2019-12-04 16:44:01 -08:00
Jeff Boek
e6709a82d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6849 - Properly select a new default search engine when you delete the current one
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
Jeff Boek
4e988fce7b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6848 - Sorts the search engine list without case sensitivity
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
Jeff Boek
e51c588fd7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6847 - Properly rebuilds the SearchEngineList on undo
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
Emily Kager
4ce302d29f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6908 - Set null anchors for snackbars with top toolbar ( https://github.com/mozilla-mobile/fenix/pull/6911 )
2019-12-04 15:01:04 -08:00
Jeff Boek
7f7685689f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6795 - Auto shows toolbar when loading a new URL ( https://github.com/mozilla-mobile/fenix/pull/6955 )
...
Co-authored-by: Severin <Baron-Severin@users.noreply.github.com>
2019-12-04 15:00:51 -08:00
Sebastian Kaspari
ad503a83c1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4976 : Reuse Fennec launcher entry in manifest.
...
With this patch Fennec users, who upgrade to Fenix, will not lose Firefox launcher icons they
have added to their home screen.
A side effect of this change is that the launcher entry for existing Fenix users may disappear
from the home screen for existing Firefox Preview users and they will have to re-add it.
Since the Preview audience is more accepting of breaking changes and since that group is
way smaller than the millions of Fennec users, I think that this is an acceptable breaking
change. I looked into supporting multiple launcher entries in parallel, but that got quite
complex with multiple build types and multiple manifest files. Especially if we decide
to keep a Firefox Preview build around (e.g. org.mozilla.fenix) then it would be good to
unify on a single launcher and do that as early as possible.
2019-12-04 12:51:48 -08:00
Oana Horvath
0cb634facc
[fenix] Added multi-selection tests for bookmarks ( https://github.com/mozilla-mobile/fenix/pull/6475 )
...
Updated bookmarking method
Fixed flaky tests
Added wait to create bookmark
2019-12-03 12:44:54 +02:00
mawen7
bbfa8aadd4
[fenix] Run lint for app module and set baseline
2019-12-02 14:45:34 -08:00
Aaron Train
0e77c47f42
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6363 - Add Downloads UI tests ( https://github.com/mozilla-mobile/fenix/pull/6574 )
...
- Initiates a download
- Verifies prompt
- Verifies notification in notification shade
2019-12-02 17:15:00 -05:00
ekager
333ff28126
[fenix] No issue: Fix search suggestions strings
2019-12-02 21:39:10 +00:00
ekager
c09e977ff7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6791 - Inflate SavedLoginsListItemViewHolder layout explicitly
2019-12-02 10:40:58 -08:00
ekager
4f0bcac5b8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6889 - Check current destination before navigating from settings
2019-12-02 10:40:21 -08:00
ekager
41af91db69
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6890 - Don't crash with no connection when adding custom search engine
2019-12-02 10:37:31 -08:00
Severin Rudie
312a66c20e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5540 : updates error page copy when no internet is available ( https://github.com/mozilla-mobile/fenix/pull/6803 )
2019-12-02 10:26:06 -08:00
cesar
8a51b43fbc
[fenix] test fixed
2019-12-02 16:18:48 +00:00
cesar
9b868c1e0b
[fenix] nested loop removed
2019-12-02 16:18:48 +00:00
cesar
51fe91d723
[fenix] klint clean up and previous nit fixed
2019-12-02 16:18:48 +00:00
cesar
cc1bfd730b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6731 - fixed BookmarkNode minus operator and deleteOperation
2019-12-02 16:18:48 +00:00
cesar
85a1b85158
[fenix] Test for 6731
2019-12-02 16:18:48 +00:00
mcarare
2ca9178898
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6835 Align Home and Browser toolbar elements to perfectly overlap
2019-12-02 16:17:07 +00:00
mcarare
10831c25ed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6401 Set false as default value for Open links in a private tab
2019-12-02 16:16:26 +00:00
mcarare
75330ca583
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6516 On browsing mode change empty tab list before displaying new list
2019-12-02 16:15:54 +00:00
Tiger Oakes
4426480f55
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6827 , https://github.com/mozilla-mobile/fenix/issues/6811 - Cast layoutParams to MarginLayoutParams
2019-12-02 14:52:31 +00:00
mcarare
b49fd6c3b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6881 Choose visible view when multiple views have same label text
2019-12-02 14:02:51 +00:00
Oana Horvath
d7bc4a96ce
[fenix] Disable UI history tests again for more investigation ( https://github.com/mozilla-mobile/fenix/pull/6837 )
2019-12-01 19:53:55 -05:00
Tiger Oakes
5bdd21e04e
[fenix] Suppress upcoming deprecation ( https://github.com/mozilla-mobile/fenix/pull/6765 )
2019-11-28 16:17:56 -08:00
Gabriel Luong
30a1862f30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6857 - Replace BackHandler with UserInteractionHandler in InflationAwareFeature and InflationAwareFeatureTest
2019-11-28 15:58:07 -05:00
Jeff Boek
5c7ec54a11
[fenix] No Issue - Fixes warnings / compiler errors with A-C update
2019-11-28 12:45:45 +01:00
mcarare
68ba4480cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6629 Align Private Browsing mode to UX specs
2019-11-27 11:13:20 -08:00
ekager
4b720e646f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5586 - Track all login copy events
2019-11-27 10:59:36 -08:00
Mozilla L10n Automation Bot
a01d3cc798
[fenix] Import l10n.
2019-11-27 10:52:38 -08:00
Will Hawkins
dc526b557e
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5183 : Initialize megazord asynchronously
...
Thanks to the work of the team at application-services, it is possible
to asynchronously initialize the Http client and logger used by megazord
Use that power to hide the time necessary to complete this initialization
within the time that it takes to warmup the gecko runtime.
2019-11-27 10:51:57 -08:00
cesar
5cd156bba2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6769 - EditText moved to be above the gradient view
2019-11-27 10:48:38 -08:00
Sebastian Kaspari
a126b92f9c
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/6622 , https://github.com/mozilla-mobile/fenix/issues/6688 : Create a "fennecBeta" and "fennecNightly" build types.
2019-11-27 10:28:22 -08:00
mcarare
a6b0fda280
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4219 Set url view not important for accessibility
...
Talkback rectangle for url view selection will include parent view
2019-11-27 10:11:16 -08:00
mcarare
bd55aaeb46
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6470 Change notification icon
...
Used private browsing icon with compulsory white color for notifications
2019-11-27 10:08:00 -08:00
mcarare
2711348828
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6470 Remove actions from notification, keep just close private tabs
...
Removed NotificationsIntentProcessor because notifications no longer open app
Added new strings
2019-11-27 10:08:00 -08:00
Mihai Branescu
6d8117f1ba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6396 - Added metrics for tracking history/bookmarks account sync toggles ( https://github.com/mozilla-mobile/fenix/pull/6601 )
2019-11-27 11:16:23 +02:00
Mihai Adrian
61b23c7a32
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6748 Move Add search engine to search engine preference category. ( https://github.com/mozilla-mobile/fenix/pull/6749 )
2019-11-27 10:45:05 +02:00
Mihai Adrian
132c68b597
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2570 : Hide 3-dots menu for all library items when in select mode. ( https://github.com/mozilla-mobile/fenix/pull/6736 )
...
notifyDataSetChanged to avoid not displayed but created items not being redrawn
2019-11-27 10:40:38 +02:00
Mihai Adrian
d4557d5a67
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5497 Align text to viewStart to keep consistency in RTL ( https://github.com/mozilla-mobile/fenix/pull/6778 )
2019-11-27 10:35:49 +02:00
Jeff Boek
11b8410367
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5972 - Fixes bugs when launching in private mode on Android 5 ( https://github.com/mozilla-mobile/fenix/pull/6702 )
2019-11-26 14:53:03 -08:00