Brais Gabín
602887e5b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23046 - Align detekt config between Fenix and Android Components
...
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2 years ago
Arturo Mejia
09d6b80724
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24224 : Send telemetry events related to the messaging framework
2 years ago
mcarare
e37d371ce4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24148 : Update tests for tracking protection metrics.
2 years ago
mcarare
09fa5135e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24098 : Update tests for tabs tray metrics.
2 years ago
Sebastian Kaspari
51f88636e9
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/22489 : Remove "Fennec to Fenix" migration code
2 years ago
Jonathan Almeida
70014e589a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24220 and https://github.com/mozilla-mobile/fenix/issues/24223 : Connect GleanPlumb messages with the new tab ui card.
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
2 years ago
Elise Richards
c181d526d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23503 : Respect studies and telemetry prefs when manually opting in to studies ( https://github.com/mozilla-mobile/fenix/pull/23955 )
...
* For https://github.com/mozilla-mobile/fenix/issues/23503 : Respect studies pref and telemetry enabled pref when manually opting in to studies
* Add button to snackbar in nimbus secret settings that allows user to go directly to their data collection prefs
* Remove refactoring
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 years ago
mike a
f841fa6f20
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/23517 : add a check to handleDeleteAbnormal() test to also verify
...
removal of items inside abnormal list
2 years ago
mike a
01f8b34f1e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/23517 : updated the tests
2 years ago
mike a
a0651401f7
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/23517 : history items are not being removed after deletion
2 years ago
Christian Sadilek
f08392bd19
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/24407 : Allow query parameters in AMO installation URLs
2 years ago
Gabriel Luong
ec1d6dfc7d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Check feature settings to show and hide home screen sections
3 years ago
Gabriel Luong
9d4c556699
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Refactor ext/HomeFragmentStateTest to ext/AppStateTest
3 years ago
Gabriel Luong
e5b6421d16
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Change all HomeFragment[Store|State|Action] usage to App[Store|State|Action] in existing tests
3 years ago
Gabriel Luong
134fb611b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Refactor HomeFragmenStoreTest to AppStoreTest
3 years ago
Arturo Mejia
3008a5337c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/24305 : Remove false wallpaper NPE Sentry report
3 years ago
Grigory Kruglov
6dede6ff6f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23697 : Treat text/x-moz-url mime type clipboard text as url
...
It seems like this is the MIME type we're getting from the clipboard in
certain scenarios, e.g. after copying a link from Chrome or Gmail on
some devices.
3 years ago
Noah Bond
ff598e99fa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24286 - Create new test for synced tabs error mapping
3 years ago
mcarare
c150e4c96f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19929 : Use AC extension functions for window insets compat.
3 years ago
Roger Yang
2ca16e15cf
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/12717 : Add bookmark search
3 years ago
Gabriel Luong
13af68853e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24235 - Remove Tip from HomeFragmentStore
3 years ago
Gabriel Luong
e7ecd285a6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24229 - Remove unused MigrationTipProvider
3 years ago
Gabriel Luong
130fd3ec5f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24252 - Rename destructive attribute to textWarning
3 years ago
Gabriel Luong
63d7796407
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24246 - Refactor Tab from HomeFragmentStore
3 years ago
Roger Yang
094630c613
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/14313 : Always add copy to clipboard action in share actions
3 years ago
Gabriel Luong
86ab03ac93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24130 - Change Shortcuts setting to toggle the display of Top Sites
3 years ago
Alexandru2909
f55e88ce94
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22189 - Replace app name with 'Firefox' for Sync strings
3 years ago
Grigory Kruglov
1adf409b19
[fenix] Bump Android-Components version to 100.0.20220309001717
3 years ago
Gabriel Luong
a0f48f5533
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23893 - Add telemetry for Contile services
3 years ago
mcarare
fd8596ea80
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23399 : Add tabs tray multi-select telemetry.
3 years ago
Arturo Mejia
9ce5a7dd27
[fenix] Add remote wallpapers
3 years ago
Alexandru2909
96bda01189
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23936 - Show dialog on credit card delete
3 years ago
mcarare
cb362b1685
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21743 : Use isNumericAddress to validate Ipv4 and Ipv6 for SDK>=29.
3 years ago
Gabriel Luong
6a0128aafb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24006 - Return a null change payload if the new top sites list is larger than the old
3 years ago
MatthewTighe
8468ef9c13
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/23981 : open download function and override for test
3 years ago
Sarah541
910d13bbd1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23821 - Add telemtry for RecentlyVisted Homepage ( https://github.com/mozilla-mobile/fenix/pull/23909 )
...
Add test
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ryan VanderMeulen <rvandermeulen@mozilla.com>
3 years ago
Roger Yang
ba3bf788e3
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/13336 : Open bookmark in current tab if browsing mode is not private or previous fragment is not home
3 years ago
Gabriel Luong
0289b38806
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23888 - Replace @color/white_color with @color/fx_mobile_[icon|text]_color_oncolor
...
@color/white_color and @color/fx_mobile_[icon|text]_color_oncolor are equivalent
3 years ago
Roger Yang
d1a94de89e
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/13336 : Open bookmarks in current tab ( https://github.com/mozilla-mobile/fenix/pull/23169 )"
...
This reverts commit 52157add58e5ed6accc64e1e4fae69e655432d91.
3 years ago
MatthewTighe
ce058f1abf
[fenix] for https://github.com/mozilla-mobile/fenix/issues/23069 : add blocklist middleware for home
3 years ago
Noah Bond
1a4e821c92
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23808 - Add secret setting for enabling Task Continuity feature
3 years ago
Alexandru2909
fc08df845f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22189 - Replace the 'Firefox' word in all strings with placeholder
3 years ago
Gabriel Luong
948e9c4e85
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23771 - Set correct destructive text color for card editor error messages ( https://github.com/mozilla-mobile/fenix/pull/23803 )
...
Co-authored-by: tristan-jea <>
Co-authored-by: Tristan <99796140+tristan-jea@users.noreply.github.com>
3 years ago
Noah Bond
b8d7a53f49
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19942 - Add support for sticky headers to the synced tabs list
3 years ago
Roger Yang
924ad2e229
[fenix] No issue: Renew/remove metrics set to expire in March 2022
3 years ago
Gabriel Luong
4c40cd09be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23456 ⁃ Use lifecycleScope in TopSiteItemViewHolder
3 years ago
Roger Yang
ac81ce5b8f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/23694 : Add telemetry for history search
3 years ago
Mugurell
dc56238b4c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22722 - Rename CrashReporterFragment to CrashContentView
...
Rename in a separate patch for git to not merge this to previous changes and in
such think that the the old file was deleted and a new one was created.
3 years ago
Mugurell
bb85952d10
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22722 - Reacting to the crashed flag
...
Whenever the ".crashed" property of the currently displayed
TabSessionState -> EngineState is true we will show an in-app crash reporter
with the usual close tab / restore tab options and also the option to report
all current non-fatal crashes to Mozilla if the setting for sending the crash
reports is enabled in app settings.
This closely mimics the previous crash reporter UI but there might be some
subtle differences stemming from migrating to using a ComposeView.
Whenever the ".crashed" property of the currently displayed
TabSessionState -> EngineState is false we will set the in-app crash reporter
to have a View.GONE visibility effectively removing it from the layout.
The functionality for receiving the non-fatal crashes from the AC CrashReporter
through an Intent is still kept and these crashes will be persisted in memory
until the user closes / restores a tab and so also makes a decision about
sending or not these crashes.
Currently more tabs can crash following just one since more share the same
process and as such there is no way to differentiate between them or link a
certain Crash to a certain tab.
They will all be acted upon at once from any tab the user chooses to close or
restore.
3 years ago
Grigory Kruglov
bd54134349
[fenix] Convert recently closed tabs code to use light-weight TabState
...
To lighten-up our memory usage and startup performance, all of the RecentlyClosed
machinery was converted to use a light-weight TabState - specifically, it's missing
EngineSessionState, which is expensive to obtain during startup, and potentially
very costly to keep in-memory.
When we actually need EngineSessionState (at the point of restoration of a tab), we
read and rehydrate it using provided storage implementation.
3 years ago
Noah Bond
25817127da
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21900 - Delete files from Synced Tabs XML implementation
3 years ago
Noah Bond
71f539bf4e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21900 - Delete files from Synced Tabs XML implementation
3 years ago
Rohan Maity
bee88db440
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20634 remove some lint issues from baseline
3 years ago
Gabriel Luong
19a695ec15
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23431 - Display the order of Contile Top Sites correctly
3 years ago
Mugurell
795683c6ef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21854 - Split the big ComposeView in 3 smaller ones
...
This would shorten the time needed to layout all Pocket recommended stories
content in one go, though it may lead to shorten hiccups over a bigger period
of time.
3 years ago
Noah Bond
5458565097
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23526 - Add telemetry for Contile interactions
3 years ago
Matt Tighe
4f2899d299
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/23619 : use well-defined name for fetching remote wallpaper assets
3 years ago
Sarah Khan
ab9bc7c071
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23596 and https://github.com/mozilla-mobile/fenix/issues/23309 - Add deeplink to wallpaper settings
3 years ago
Roger Yang
2066f6731e
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/10046 : Add history search
3 years ago
mcarare
d7cce03106
[fenix] Add VisitInfo.isRemote parameter.
3 years ago
Matt Tighe
72a0985403
[fenix] closes https://github.com/mozilla-mobile/fenix/issues/23565 : expire remote wallpapers but let users keep selected
3 years ago
Mugurell
a0dd1ee6e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21009 - New Recently closed tabs telemetry
...
This adds a new `recently_closed_tabs` category with then events for all user
interactions on the screen.
The already existent `events.recently_closed_tabs_opened` is still kept for a
bit more time to still have this data available while the new telemetry ride
the trains but can later be removed in favor of this newly added events.
3 years ago
Lucius C
d2e016eac9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13336 : Open bookmarks in current tab ( https://github.com/mozilla-mobile/fenix/pull/23169 )
...
* For https://github.com/mozilla-mobile/fenix/issues/13336 : Open bookmarks in current tab
* For https://github.com/mozilla-mobile/fenix/issues/13336 : Fix tests to verify bookmark opening in current tab
* Change test name for handleBookmarkTapped
3 years ago
Matt Tighe
06238447a6
[fenix] closes https://github.com/mozilla-mobile/fenix/issues/23514 : add firefox wallpapers
3 years ago
Gabriel Luong
98a540b81d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23350 - Revert changes from removing duplicate icons that already exists in ui-icons ( https://github.com/mozilla-mobile/fenix/pull/23527 )
...
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Override @color/mozac_ui_icons_fill with ?primaryText attribute"
This reverts commit 4c630eba96182254daa4cdd2bbfeac23ab04690d.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_share with @drawable/mozac_ic_share"
This reverts commit 072d3a3c9f87b77ed6381c36af7d9c812b8b371d.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_storage_enabled with @drawable/mozac_ic_storage"
This reverts commit 10dde2baa6fd320443690a49dd6551938a2d83db.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_notifications_enabled with @drawable/mozac_ic_notification"
This reverts commit 90943cfda427fd06d5e77b1e4fd0463bbe21e449.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_microphone_enabled with @drawable/mozac_ic_microphone"
This reverts commit 200fd14d288b4b21c1711995f63d548f58fb1dc8.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_location_enabled with @drawable/mozac_ic_location"
This reverts commit e85998bdc24dcdd17585581bd99aab35d5147f93.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_autoplay_disabled with @drawable/mozac_ic_autoplay_blocked"
This reverts commit 0e408dc26e069719c895ae5279d3c11df6677699.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_camera_enabled with @drawable/mozac_ic_video"
This reverts commit ceab2d77490b9b9b545ebbc14ee2a7b3811d3064.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/mozac_ic_extensions_black with @drawable/mozac_ic_extensions"
This reverts commit 7bc005927acee0481c8936d000737ba7f738e2ba.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_top_sites with @drawable/mozac_ic_pin"
This reverts commit f4d58ff722baa5dc9f7f811a758de75699bb8ccb.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_search with @drawable/mozac_ic_search"
This reverts commit ac8f8632557ac07c32d040fbb0ddfa3cf1a0e5f6.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_readermode with @drawable/mozac_ic_reader_mode"
This reverts commit d1953045b062a5b6fbedd990252834e9e1a6ca4f.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_menu with @drawable/mozac_ic_menu"
This reverts commit 682b02101aa7e5ce82868de81d9b034701629976.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_login with @drawable/mozac_ic_login"
This reverts commit 982c695260aaa10fc1f0ee7e6d2e271e9a214ce3.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_internet with @drawable/mozac_ic_globe"
This reverts commit d248bfc21fff644bdc2141c4e24ae5bc125a41d2.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_download with @drawable/mozac_ic_download"
This reverts commit 4cdceb393ac411a7b59d9c0e1164fddfb62bc494.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_lock with @drawable/mozac_ic_lock"
This reverts commit 3878a83e30f318293b099bc49c690f953c2f3def.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_desktop with @drawable/mozac_ic_device_desktop"
This reverts commit 8c4e6e23e0bf1ed762d9c3ab8566aff4df0a8eb1.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_close with @drawable/mozac_ic_close"
This reverts commit 7f61c95923600eeabb8046380a31c1eaa4968525.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_delete with @drawable/mozac_ic_delete"
This reverts commit b8814f62bffde0c192f078f8cd5e808d0f07af9d.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_chevron_up with @drawable/mozac_ic_arrowhead_up"
This reverts commit 265b0a47cae6bed39ce9e8cc9af465705d1a2363.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_chevron_down with @drawable/mozac_ic_arrowhead_down"
This reverts commit fe8a0b604941bbbb9dacff176cd17ce0485431ed.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_back_button with @drawable/mozac_ic_back"
This reverts commit fb236b1c6175c1f8b5e6b1bf6d9f02c6a7fff9b9.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_arrowhead_right with @drawable/mozac_ic_arrowhead_right"
This reverts commit ae2f768ac02aa6b161b0bcbba7922f5f12e31e80.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_new with @drawable/mozac_ic_new"
This reverts commit ce5bb35a7cdbd189bb177900ec19bc6cb5a9bfa7.
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_addons_extensions with @drawable/mozac_ic_extensions"
This reverts commit 1006637673965ebf70ad5e18e9a3598cf736347b.
3 years ago
Matthew Tighe
05d80bd9aa
[fenix] closes https://github.com/mozilla-mobile/fenix/issues/23504 : download focus wallpapers at runtime ( https://github.com/mozilla-mobile/fenix/pull/23505 )
...
* closes https://github.com/mozilla-mobile/fenix/issues/23504 : download focus wallpapers at runtime
* address pr feedback
* only download wallpapers if feature flag is set
3 years ago
Gabriel Luong
17f96e433c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23424 - Part 2: Add context menu for contile top sites
3 years ago
jhugman
9b651a484b
[fenix] First use of Nimbus FML plugin ( https://github.com/mozilla-mobile/fenix/pull/23400 )
...
* Consume Nimbus FML plugin
* Convert Homescreen to use FML
* Convert nimbusValidation to use FML
* Convert legacy experiments to use the feature API and FML
Remove dead helper code and documentation
* Fixup failing test
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Matt Tighe
00cc662e9f
[fenix] add events based on feedback
3 years ago
Matt Tighe
880c34528d
[fenix] update based on PR feedback and data review
3 years ago
Matt Tighe
c599f29c47
[fenix] closes https://github.com/mozilla-mobile/fenix/issues/23381 : add telemetry for wallpapers feature
3 years ago
Sarah541
5185773477
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22576 - Indicate mutability flag for PendingIntent
...
* For https://github.com/mozilla-mobile/fenix/issues/22576 - Indicate mutability flag for PendingIntent
* Fix lint issues
* Make Analytics Pending Intent flag mutable
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Mugurell
8cfc336a55
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22314 - Reuse existing tab for search group items
3 years ago
Grigory Kruglov
abcf8f0fb1
[fenix] Account for Int->UInt changes in bookmarks API
3 years ago
Gabriel Luong
d84bdb1d93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_search with @drawable/mozac_ic_search
3 years ago
Gabriel Luong
37b4cfaa35
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_new with @drawable/mozac_ic_new
3 years ago
Roger Yang
96d0dfae36
[fenix] No issue: Remove showHistorySearchGroups feature flag
3 years ago
mcarare
94e5e66315
[fenix] Set a minimum number of sites a search group should contain.
3 years ago
mcarare
d6e29fb1c4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23256 : Close quick settings sheet when displaying clear dialog.
3 years ago
mcarare
59beaaa609
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23256 : Pass navController instance instead of lambda.
3 years ago
Roger Yang
1b420ea198
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/23250 : Remove duplicate sites within a time period in history
3 years ago
Gabriel Luong
235c026c38
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22727 - Add Contile to Top Sites
3 years ago
mcarare
47424e8f00
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22477 : Ignore null and empty values for share data title.
3 years ago
Matt Tighe
ff881bd417
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/22943 : update androidx.lifecycle to 2.4.0
3 years ago
Alexandru2909
e683694d05
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20524 - Remove redundant coroutine dispatchers from tests
3 years ago
Alexandru2909
68be05d051
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8108 - Add BrowserToolbar option to remove url from TopSites
3 years ago
Roger Yang
5cc5b50595
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22550 : Refactor search term tab grouping logic to rely on middleware
3 years ago
Grigory Kruglov
364f558857
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22795 : Stop trimming login origins on sorting
...
Due to the async nature (??) of the trimming code, this is causing severe performance issues
during search.
Looking back through commits, doesn't seem like there's a particularly good reason we were trimming here. All I could find is https://github.com/mozilla-mobile/fenix/pull/9986 (comment) which is lacking explanation of why this is actually useful.
And currently, we're dealing with an origin (not a full url when this was initially written, I think), i.e. https://accounts.firefox.com vs https://accounts.firefox.com/signin . So, the suffix stripping isn't even doing much beyond removing com in vast majority of cases.
So, seems like all of this trimming stuff can be cleaned up.
3 years ago
Brais Gabín
26a4ec05d3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23142 - Fix license formatting in tests
3 years ago
mcarare
1facaaf775
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22879 : Filter default engines when sending telemetry.
...
Filter out custom engines that are not well known search domains.
3 years ago
mavduevskiy
e88bda15df
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18160 : Show a prompt when trying to leave private browsing with active downloads ( https://github.com/mozilla-mobile/fenix/pull/22912 )
...
Co-authored-by: mike a <mavduevskiy@gmail.com>
3 years ago
Grisha Kruglov
c367072d11
[fenix] Refactor History types to eliminate nullability
...
This introduces a separate HistoryDB type at the PagedHistoryProvider
layer, that doesn't need to deal with positions. Positioning logic in
HistoryDataSource becomes a type conversion between the new type and an
existing History type that UI and ItemKeyedDataSource API is written against.
With this refactor, we entirely eliminate nullability from these types.
3 years ago
Grisha Kruglov
b13e149900
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22764 : Convert History.id to an Int position
...
We were converting Long timestamps into Ints (and getting negative
numbers back), and treating that as, basically, a position for the
paging API; the paging API would pass us back the obscure negative
number back as an offset, and we'll mishandle it resulting in an
infinite loop.
This patch removes all of the Long -> Int conversions, and introduces an
explicit 'position' that is calculated once we have a full page of
results completed.
3 years ago
Mugurell
ae7909671e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22852 - Add a new "Storage access" permission
3 years ago
mcarare
4e6406e15e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20513 : Use UrlMetricType for search engine submission url.
3 years ago
Roger Yang
11417996c8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22671 : Show correct time groups header in history
3 years ago
Grisha Kruglov
6b7cdce783
[fenix] Fix breaking change in KeyProvider
...
`key` was renamed to `getOrGenerateKey` and is now a `suspend`.
3 years ago
Grisha Kruglov
4ad2c1c592
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22569 : Remove allopen plugin and Mockable annotations
3 years ago
Matt Tighe
817760d64c
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/20833 : move home recycler bottom margin into standalone item
3 years ago
Matt Tighe
4b6a1d2256
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/22688 : remove inactive_tabs_recently_closed probe
3 years ago
mcarare
01c4bf049a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17130 : Replace hardcoded strings with string resources.
3 years ago
aime Soriano Pastor
37ec88478e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9294 : Add option to clear current site data in quick settings dialog.
3 years ago
MickeyMoz
4b3e25dcf6
[fenix] Update Android Components version to 97.0.20211208143435.
3 years ago
Christian Sadilek
6b9dc4c958
[fenix] Introduce timeout for capturing thumbnail in BrowserAnimator
3 years ago
Christian Sadilek
9150d8061b
[fenix] Prevent flash when navigating to home
3 years ago
Christian Sadilek
33e5a1ee35
[fenix] Refactor: Move historymetadata classes in separate package
3 years ago
Mugurell
f70dfb6ef9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22534 - Show history highlights and groups in "Recently visited" ( https://github.com/mozilla-mobile/fenix/pull/22535 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Update homescreen section name to "Recently visited"
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Show both history highlights and groups in Recently visited
For now the metadata groups don't support scoring so as an interim solution we
will show up to 9 items, evenly distributes, first favoring groups sorted by
date then history highlights pre-sorted by default.
Tapping a history highlight will switch to it's already open tab if available
or create a new one in which to load it if needed.
A "Remove" option will also be available for history highlights to remove it
from the screen and also from history.
Currently removing a group / highlight will not query new ones to again show up
to 9 items, this will be implemented separately.
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Rename and refactor historymetadata to recentvisits
The updated feature supports more than history metadata so updating the overall
naming scheme seems needed.
To signal that this is a homescreen feature the entire package is moved to home
* For https://github.com/mozilla-mobile/fenix/issues/22534 - Update UI tests to account for the new items space on the screen
Saw failures about not finding the collection section on screen.
This is probably happening because w are now adding the recent visits to
homescreen above the collections section pushing it off screen.
Since the collections might be obstructed by the toolbar shown on top as a
quick solution we'll scroll to the next homescreen section so that the
collections will be shown above in their entirety.
* Update app/src/main/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeature.kt
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
* Update app/src/main/java/org/mozilla/fenix/home/recentvisits/RecentVisitsFeature.kt
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Noah Bond
97e59a9717
[fenix] Tab group count telemetry ( https://github.com/mozilla-mobile/fenix/pull/22479 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Refactored tab sorter metrics into a middleware
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Created distribution metric for tab group sizes
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Created tests for tabs tray middleware
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Merge fixes
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Added PR number to metric
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Fixed unit tests post merge. Added waitUntilIdle to new tests.
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Added missing line to middleware to have the Store process actions
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Updated metric expiration to December
* For https://github.com/mozilla-mobile/fenix/issues/22410 - PR Feedback
* For https://github.com/mozilla-mobile/fenix/issues/22410 - Removed else from middleware when
3 years ago
Gabriel Luong
c7aea80bb2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22595 - Remove unused OnboardingAutomaticSignInViewHolder
3 years ago
Gabriel Luong
5b069b2ece
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22211 - Use Hero images for Recent Bookmarks
3 years ago
Arturo Mejia
72a0b5703c
[fenix] Update Android Components version to 96.0.20211125162700.
3 years ago
Arturo Mejia
4cc4e1c67d
[fenix] Improve loading URLs
3 years ago
Mugurell
e665397890
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22442 - Don't display individual tab if part of the Jump back in tabs group
...
We'll show as a recent tab the next most recent tab not part of the last active
search group.
3 years ago
Mugurell
3dea07855e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22442 - Don't display history group if already in Jump back in
3 years ago
Gabriel Luong
6b5ce4d387
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22488 - Fix intermittent test failure with InactiveTabsControllerTest
3 years ago
Gabriel Luong
100d5372ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22250 - Convert Recent Bookmarks to Jetpack Compose
3 years ago
Arturo Mejia
5737a5533c
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/5298 the same page appears in the History section multiple times
3 years ago
Grisha Kruglov
78e85949cf
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22484 - Track direct loads per tab; fix search term lookup
...
This patch fixes two problems:
1) We were treating "direct tab load" as an event which applies
uniformally to all tabs, even though it's actually an event which
happens for a specific tab. This lead to background tabs (pages opened as new tab)
setting the direct load flag, and then a simultaneously loading
parent tab would incorrectly interpret that flag for itself.
The patch switches this tracking from a simple boolean (are we direct
loading?) to a set of tab IDs that are currently direct loading.
2) In a case when a background tab was loading with a parent who's
search terms were cleared by a direct load, we were not trying to
lookup search terms on the background tab's historyMetadata key,
which exists to capture search terms for this exact scenario.
The patch adds an additional fallback lookup for that path.
3 years ago
Grisha Kruglov
fc7e707538
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22472 : Filter out redirects from History search groups
3 years ago
Roger Yang
627bc919d1
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22402 : Add top placeholder for home
3 years ago
Mugurell
ba3138ccf9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - Store inactive tabs count telemetry when user opens tabs tray
...
Setting this value in FenixApplication.onCreate was buggy because of a race
with restoring BrowserState.
Setting it here would ensure a better granularity of the events and so to more
accurate reporting.
3 years ago
Mugurell
31f98688a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22147 - New search term groups telemetry
3 years ago
Arturo Mejia
ad8f060cec
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22271 Improve URL accessing from the clipboard for Android 12 and above.
3 years ago
Jonathan Almeida
a08fcc9a9d
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22223 : Move to the selected page when switching modes
3 years ago
Grisha Kruglov
6f1ba6ca6b
[fenix] No issue: clean up code duplication in PagedHistoryProvider
3 years ago
Jonathan Almeida
7222c0220c
[fenix] No issue: Correct TabsTrayAction naming
3 years ago
Jonathan Almeida
199547f94f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22305 : Use TabsTrayStore for populating adapters
3 years ago
Jonathan Almeida
35556e4cc2
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22305 : Add tab state into the TabsTrayStore
3 years ago
Mugurell
b95234f9d5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - The inactiveTabsCount probe reports actualInactiveTabs number
3 years ago
Mugurell
f40c19f406
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - New BrowserState.actualInactiveTabs public method
...
This allows querying from all throughout the app which of the current tabs are
inactive while taking into consideration whether the feature is enabled or not
such that when the feature is disabled it will always return an empty result.
3 years ago
Sebastian Kaspari
6aa2f0c4fa
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21695 : ThreadPenaltyDeathWithIgnoresListener: Ignore stack traces containing InstrumentationHooks class
3 years ago
Roger Yang
ad076dd1c2
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22299 : Add history search term group telemetry
3 years ago
Grisha Kruglov
31c2c7bf12
[fenix] No issue: history view search group missing
...
Our boundary conditions for matching search groups to visits was wrong.
This change switches the boundary buffer to only be applied to history
items, not the metadata items.
In other words, when checking if any of the metadata items match the
current "page" of history, we'll be looking to see if the item falls
within this time window:
buffer - oldest history item <= metadata item <= newest history item +
buffer
There's a separate problem with buffer though: it's reset to 0 when requested
offset is >0, but that requires a larger refactor of this code, for a
separate PR.
3 years ago
Elise Richards
6ed1cb0c8b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21313 : Remove expiring/unused metrics for December ( https://github.com/mozilla-mobile/fenix/pull/21789 )
...
* Remove crash reporter metrics
* Remove tab counter menu item probe
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Christian Sadilek
dbceb279f4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21659 : Add SERPs to history search groups
3 years ago
Noah Bond
cbfc23f8cc
[fenix] Recent bookmark count telemetry ( https://github.com/mozilla-mobile/fenix/pull/22293 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22075 - Added event to track the count of recent bookmarks
* For https://github.com/mozilla-mobile/fenix/issues/22075 - Added data review issue number
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Arturo Mejia
b1cb88fff7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22078 Selecting search group in Jump back in switches active tab
3 years ago
Arturo Mejia
9fb7471f61
[fenix] No issue: Address tracking protection exceptions breaking changes
3 years ago
Noah Bond
5e2853ea47
[fenix] MR2 Telemetry: Recent tabs section probe ( https://github.com/mozilla-mobile/fenix/pull/22166 )
...
* For https://github.com/mozilla-mobile/fenix/issues/22107 - Added probe to track if the Recent tabs / jump back in section is visible
* For https://github.com/mozilla-mobile/fenix/issues/22107 - Fixed lint errors
* For https://github.com/mozilla-mobile/fenix/issues/22107 - added data review number to metric
* For https://github.com/mozilla-mobile/fenix/pull/22166 - fixed expiration date
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Jonathan Almeida
8393fac307
[fenix] No issue: Merge our inactive tab interactor/controllers
3 years ago
Mugurell
3342f4a54a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22155 - Inactive tabs count telemetry
...
A quantity probe in the metrics ping means we'll loose the granularity events
provided but it will be easier to extract the values.
For reporting whether the inactive tabs feature is enabled or not we already
have the "preferences.inactive_tabs_enabled" probe so I didn't duplicate this.
3 years ago
Roger Yang
ba7d325bb4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/22057 : Add search term groups telemetry
3 years ago
Christian Sadilek
517f789958
[fenix] Introduce test rule to work around intermittent mockk failures
3 years ago
Mugurell
d116c95205
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22138 - Install source metrics probe
3 years ago
Roger Yang
c0fde2bebb
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22172 : Add Recent searches telemetry
3 years ago
Roger Yang
46f9f1ae2c
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22103 : Add recent bookmarks telemetry
3 years ago
Elise Richards
015be02422
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22175 : Telemetry event for deleting a search term group from the recent searches section on home
3 years ago
Jonathan Almeida
5d8a920b5f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20704 : Add AppStore to Components
3 years ago
Arturo Mejia
d201f02bfb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22192 add telemetry for studies
3 years ago
Christian Sadilek
0732718e1c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21355 : Fix intermittent test failures in BookmarkItemMenuTest
3 years ago
Christian Sadilek
bf2a718701
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21952 : Ignore intermittently failing FenixSnackbarKtTest
3 years ago
Christian Sadilek
d03598c9a1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21438 : Ignore intermittently failing ExceptionsListItemViewHolderTest
3 years ago
Christian Sadilek
3b686cec7b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22081 : Ignore intermittently failing DefaultBrowsingModeManagerTest
3 years ago
Christian Sadilek
243a456c1b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21332 : Ignore intermittently failing WebPushEngineIntegrationTest
3 years ago
Christian Sadilek
dc552d78c6
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21952 : Ignore intermittently failing FenixSnackbarDelegateTest
3 years ago
Arturo Mejia
ecb13fa173
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22170 : Add telemetry for the auto-close prompt
3 years ago
Grisha Kruglov
ef375069eb
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/22083 - Match history groups to history pages by all items within the group
...
When deciding if we should include a history group within the "page of
history" results on the History View UI, we used to look at the most
recent timestamp of the metadata items within the group, and see if that
falls within the range of the timestamps of the history page, +/- some
buffer.
This assumes that each metadata entry will have a corresponding history
item. However, that's not true - when restarting the app, the selected
tab will be restored, and when opening History View right after we'll
record some metadata for it. However, we won't record a history visit
during the app restore for the selected tab.
That's all correct, but the assumption around group matching to history is now incorrect.
This patch changes the logic to instead look at every item within the
group, and see if any of them match the time window of the current
history page. This has a side-effect of also displaying search groups
multiple times on diffenent pages of history, if it makes sense to do so chronologically.
I think that's fine, it reflects reality at least (e.g. items within the
group may have been visited at very different points in time).
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
MickeyMoz
a68de609c2
[fenix] Update Android Components version to 95.0.20211026143215.
...
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
Gabriel Luong
45e9bf6693
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unused symbols
3 years ago
Gabriel Luong
71bfe46ac2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Local 'var' is never modified and can be declared as 'val'
3 years ago
Gabriel Luong
29dfb8ee7f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unnecessary type argument
3 years ago
Gabriel Luong
314d61d21e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove unnecessary parentheses from function call with lambda
3 years ago
Gabriel Luong
cd77dbce96
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21776 - Remove redundant qualifier name
3 years ago
Jonathan Almeida
a6d7128c7e
[fenix] No issue: Replace TabsTray.Tab with TabSessionState
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Jonathan Almeida
a672d27ca6
[fenix] No issue: Disable FenixSnackbarDelegateTest intermittents
3 years ago
Sebastian Kaspari
6f4c47613a
[fenix] Update Kotlin and Jetpack Compose versions.
3 years ago
Mugurell
fe8c112513
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22070 - Prevent crash for when a selected topic does not exist anymore
...
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
3 years ago
Roger Yang
593b08780f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22061 : Let TabSorter decide if title header should be shown in tabs tray
3 years ago
Michael Comella
ad1bcec0d9
[fenix] No issue - post: fix ProfilerMarkerFactProcessor tests.
3 years ago
Gabriel Luong
2e7f52f63a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22022 - Composify Customize Home Button and update the background color
3 years ago
Gabriel Luong
2c4ccea6cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21753 - Refactor Pocket out of sessioncontrol
3 years ago
Noah Bond
1c21e2face
[fenix] MR2 Inactive tabs telemetry ( https://github.com/mozilla-mobile/fenix/pull/21908 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added telemetry for interacting with inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added missing inactive tab delete count event to delete all event
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Added PR numbers to metrics
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated broken unit tests. Resolved critical lint warning.
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Fixed inactive tabs setting toggle metric
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated FenixApp unit test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.
* PR: addendum for last commit that missed a file
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Changed logic check for reporting inactive tab count
* PR: fixed merge conflict
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed tab close tracking when the user closes ALL inactive tabs
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Removed individual tab close metric verify from CLOSE ALL test
* For https://github.com/mozilla-mobile/fenix/issues/21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Arturo Mejia
9d3d9b3421
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21723 Align the default value of the custom cookie setting with the UI
3 years ago
Roger Yang
1647e4f613
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21893 : Keep search group when second to last search term tab is removed
3 years ago
Jonathan Almeida
c380d1e622
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21910 : Fix intermittent failures in SelectTabUseCaseWrapperTest
3 years ago
Grisha Kruglov
997fd9ba64
[fenix] Do less work while navigating Logins views
...
Fetching a set of logins from the store is quite expensive. This commit
avoids doing that while navigating back and forth between the list and
detail views:
- retain processes logins state when navigating into detail view
- use the `get` storage api to obtain specific login, instead of
`list().filter {...}`
- avoid re-sorting retained logins when navigating back into the list
view
3 years ago
Grisha Kruglov
5372f1bcca
[fenix] Make linters happy
3 years ago
Ben Dean-Kawamura
204ad8834d
[fenix] Updating Fenix to work with the new logins API
...
Switched to always using `Login` instead of the `SavedPassword` alias.
Made `MasterPasswordTipProvider.saveLogins()` call
`importLoginsAsync()`. This is needed because it's the only method that
inputs a `Login` rather than a `LoginEntry`.
Moved the `SavedLoginsStorageController.kt.syncAndUpdateList` call
to inside `add()` and `update()`. This simplifies the error handling a
bit.
Refactored dupe-checking code to use findLoginToUpdate()
Refactored `AddLoginFragment` / `EditLoginFragment` to put the username
error handling code all in 1 method. I think it's easier to follow the
logic of showing/hiding the error labels when it's all in one place.
This fixes issues https://github.com/mozilla-mobile/fenix/pull/24103 and https://github.com/mozilla-mobile/fenix/pull/24104 . I would love to address https://github.com/mozilla-mobile/fenix/issues/24102 ,
but I'm not sure what the correct behavior is there so I just kept that
the same.
3 years ago
Grisha Kruglov
7efdddcaeb
[fenix] Fix up HistoryMetadataController tests
3 years ago
Grisha Kruglov
eef2ad800a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21871 - Eagerly update UI state after search group removal
...
Before this patch, this was the behavior - 'remove' button is clicked, we'd ask
the storage to remove metadata (on its IO thread), then navigate to Home
Screen.
This resulted in a race we could end-up on the Home Screen before delete
finishes, so the search groups do not appear to be removed (but,
refreshing the Home Screen again shows that they are removed).
This also resulted in an unnecessary navigation which felt very janky
(screen will "scroll" to the top) and was way more work than necessary.
After this patch, we:
- dispatch two actions (on browserstore, on homefragmentstore) which
remove the search groups from any relevant in-memory state; any UI bound to
this state will be automatically "refreshed"
- no longer navigate as part of the remove action, so the UI doesn't
move and removal happens "in-place"
3 years ago
Christian Sadilek
0751190582
[fenix] Handle new OptimizedLoadUrlAction in history metadata middleware
...
Upgrades to A-C 95.0.20211013154351
3 years ago
sunil9211
45330287b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17393 : Dead code removed around Delete downloads
3 years ago
Arturo Mejia
0658de464f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21791 Adds tab auto-close prompt
3 years ago
Mugurell
cde1c3b911
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Simplify test to not depend on store updates.
3 years ago
Mugurell
e22e33c3c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21733 - Replace mock of an interface with mock of a fake.
3 years ago
Jonathan Almeida
363e563fc7
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21686 : Move submitList calls into TabsAdapter
...
Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
Noah Bond
39a3aacc78
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21773 - Updated "customize homepage" button to go to the new Homepage submenu in Settings
3 years ago
Mugurell
e6a73b5118
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21623 - Pocket recommended stories telemetry
3 years ago
Gabriel Luong
e3b2309ac2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21756 - Refactor TopSites out of home.sessioncontrol
3 years ago
Noah Bond
b772f6d080
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen ( https://github.com/mozilla-mobile/fenix/pull/21722 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Relocated Home-related settings to its dedicated sub screen
* For https://github.com/mozilla-mobile/fenix/issues/21437 - Updated show top sites toggle text
* PR: Fixed lint warning. Reverted preference keys
* PR: added ignore for UI test
* PR: Added ignore for UI test
3 years ago
Arturo Mejia
f4f7c1b0e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21574 : disabled the homescreen onboarding dialog.
3 years ago
Jonathan Almeida
33cf85203a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21642 : Remove in-progress media tab from homescreen
3 years ago
Christian Sadilek
5385b96abe
[fenix] Move tabs out of search group if direct load occurs
...
This regressed in our previous fix that made sure child tabs don't
mistakenly get moved out of the group if their parent is navigated
away, or in case the child tabs are redirected.
However, when a subsequent load occurs in any tab in the group the
search terms need to be cleared and the tab removed from the group
to prevent false positives.
3 years ago
Mugurell
7e65b07930
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor the coroutine from PocketStoriesShown to outside the middleware
...
In so this code will no longer have access to the MiddlewareContext which only
makes sense in the thread of the Middleware itself.
3 years ago
Mugurell
6261e570c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Persist stories categories selections in a Proto DataStore
...
A fast and easy solution with all the ACID requirements.
Also supports easy migrations if later the data we need persisted changes.
3 years ago
Mugurell
4f4586d85f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21593 - Refactor out "isSelected" from PocketRecommendedStoriesCategory
...
Having the list of categories and the list of selected categories separate in
State allows updating them independently.
3 years ago
Jonathan Almeida
884c8c2224
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21576 : Hide 'Other' title when there are no search groups
3 years ago
Arturo Mejia
8a4bb26526
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21618 : Integrate Nimbus with MR2 Home Page to enable experimentation
3 years ago
Christian Sadilek
c1f2c33a76
[fenix] Make search term grouping tolerant to (parent tab) navigation
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
Noah Bond
4f07d1a40f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups ( https://github.com/mozilla-mobile/fenix/pull/21615 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added toggle for search term tab groups
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Lint cleanup
* PR: Added missing licenses and possibly fixed UI test
* PR: Added a "scrollTo" to potentially fix a UI test
* PR: Added potential fix for alwaysStartOnHomeTest
* PR: Added temporary ignore to alwaysStartOnHomeTest
* PR: added missing ignore comment
* For https://github.com/mozilla-mobile/fenix/issues/21360 - Added missing feature flag driven visibility logic
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Christian Sadilek
1d537cb332
[fenix] Allow opening pocket stories when search dialog is active
3 years ago
Roger Yang
1f11b81bc4
[fenix] No issue: Make sure jump back in group always have more than one tab
3 years ago
Gabriel Luong
4d23db624f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21551 - Add delete history metadata in the History view
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Elise Richards
dc1e5e640e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21287 : long press menu on recently visited homescreen groups
3 years ago
Grisha Kruglov
485ca898f2
[fenix] Do not show home screen behind search if we have search terms
...
Home screen isn't actually visible in case we're displaying awesomebar
search results. The navigation is thus unnecessary and actually causes visual
jankiness as we display home for a moment before covering it up with
search results.
3 years ago
Noah Bond
f2b7eea088
[fenix] Inactive tabs changes ( https://github.com/mozilla-mobile/fenix/pull/21524 )
...
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Moved inactive tabs to the top of the normal tabs tray.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Added a delete icon to delete ALL inactive tabs.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Changed default inactive time period to 14 days
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - Hooked inactive tabs setting to UI code
Inactive tabs setting is also disabled when the user has selected the one day or week auto-close tab setting.
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21319 - File and Lint cleanup
* PR: Fixed bug causing grouped tabs to also show in "Other" when marked as inactive but inactive is OFF in Settings
* PR: Fixed lint warnings
* PR: Removed redundant feature check
* PR - Ignore test until search term tab groups switch is done
3 years ago
Mugurell
4fac910adf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21592 - Don't topup with general stories
3 years ago
Michael Comella
32c8709148
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21294 : add partial test for existing factToEvent code.
...
When we refactor, this will help ensure we've done it correctly.
3 years ago
Mugurell
ad0f428f39
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21561 - Enable/Disable the feature from the customization menu
3 years ago
Mugurell
08a71a5366
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21391 - Final design composables
...
Fonts are not exactly following the Figma design but do better suit the overall
design since the other fonts are also not respecting the latest specs.
3 years ago
Mugurell
219561d304
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21275 - Sort items by how many times they were actually shown
3 years ago
Christian Sadilek
4702a66203
[fenix] Do not capture search terms when user navigates away via app ( https://github.com/mozilla-mobile/fenix/pull/21527 )
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
Roger Yang
f65770a34f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21451 : Add active search term tab groups on home
3 years ago
Arturo Mejia
c4eb7ea28b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21493 show onboarding dialog for home sections
3 years ago
Mugurell
d701a81103
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21045 : Add categories support
3 years ago
codrut.topliceanu
7ea5cdbe39
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21087 : Updates Recently Saved design
3 years ago
Christian Sadilek
c9e1bfe3dc
[fenix] Fix mapping between history visits and groups to use createdAt
...
We currently have a 15s buffer to match metadata to its corresponding
visit. However, a existing metadata record can be updated more than
15s after it was created e.g. when closing the tab and updating
the view time.
3 years ago
Jonathan Almeida
d7c1238dac
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21366 : Speculative fix for failing test in TitleHeaderBindingTest
3 years ago
Christian Sadilek
a6a6b6f257
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20893 : Dedupe urls/site in history groups
3 years ago
Gabriel Luong
e3bc494414
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21117 - Modify layout for items displayed under "Recently Visited" in the HomeScreen to follow latest UX designs
3 years ago
Gabriel Luong
450055a729
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21413 - Remove unused OnboardingPrivateBrowsingViewHolder and OnboardingWhatsNewViewHolder
3 years ago
Gabriel Luong
bc30e53e5d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21408 - Pass the corresponding HistoryMetadataKey to openToBrowserAndLoad and addTab use case
3 years ago
Gabriel Luong
793ceb8e28
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20893 - Search term groups in history
3 years ago
Arturo Mejia
c3df9a26d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21239 add telemetry for Allow users to customize their home screen
3 years ago
Christian Sadilek
e18fbdfbfc
[fenix] Make sure to only record view time once for a given tab access
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
Grisha Kruglov
6297f2cce9
[fenix] Use UpdateUrlAction to record viewTime observations
...
We discovered that in a tab restore scenario we were recording view time
observations that were wrong - we'd record time deltas as-if user was
looking at the page while the browser wasn't running.
This happens because when we record a viewTime observation, we compare
current time with lastAccess time of the tab. In a restore scenario,
that lastAccess time happens to be from when the browser was last
running - which could be days ago.
The simplest solution was to not record a viewTime observation if the
url for a tab didn't change during a load event. To achieve this, we
needed to change which action we were using as a proxy for "navigation
events" - UpdateUrlAction contains the new url, allowing us to compare
against the current tab url.
Alternative solutions would be to keep using loading actions, but
dispatch a lastAccess event before performing a metadata update. This
would have worked, but would result in two lastAccess events being
dispatched for each navigation event instead of just one.
3 years ago
Elise Richards
48c0d7faee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21337 : rename recently saved section on home
3 years ago
Jonathan Almeida
9d6367a607
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/21366 : Fix intermittent test failure in TitleHeaderBindingTest
3 years ago
Michael Comella
8d5a7606f4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/21335 : return self instead of mock in FenixSnackbarKtTest.
...
This is a speculative fix for the intermittent issue. Typically, these
intermittents are caused by mocked lambdas but there is no mocked lambda
here. If this doesn't work, one `any()` argument fills in for a lambda:
it's possible that's causing the failure.
Unfortunately, I can't verify this fix easily because the "run test until
failure" option was removed from Android Studio.
See d396c9eb41298cc07fbf136f1de971010bc45d97 for a prior attempt to
address the intermittents in this class.
3 years ago
Jonathan Almeida
c2d385f142
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21236 : Fixes empty tray visibility logic
...
This is a bug we noticed after landing search term grouping.
An adapter can submit an empty list of items to the `ConcatAdapter`
early. This has the side-effect of triggering our `observeFirstInsert`
too soon and therefore updating the visibility to show the empty tray
placeholder and never switches back.
Our solution is to keep a constant observer on the adapter so we can
perform the visibility check on every insert/remove.
Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
Sebastian Kaspari
b239d7d934
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21291 : SearchDialogFragment: Get URL from clipboard once and not for every state update
3 years ago
Roger Yang
02cbf2953f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21236 : Separate tabs with the same search term into a different section ( https://github.com/mozilla-mobile/fenix/pull/21177 )
...
* For https://github.com/mozilla-mobile/fenix/issues/21236 : Separate tabs with the same search term into a different section in tabs tray
* Issue https://github.com/mozilla-mobile/fenix/issues/21236 : Scroll to selected tab + various tab fixes for groupings
* Issue https://github.com/mozilla-mobile/fenix/issues/21236 : Fix failing test
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
Michael Comella
2dc9cfec20
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18102 : remove intermittent failing App onCreate duration measurement test.
...
The test as it exists relies on the robolectric lifecycle, which is hard
to predict, so it doesn't seem worth fixing the test. Writing the test
any other way would require excessive mocking, which also seems
impractical.
3 years ago
Arturo Mejia
5ce4a31be5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21095 add customize home button on the home screen.
3 years ago
Gabriel Luong
b057d6a76f
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/21099 - Update items under "Jump back in" section to the latest designs
3 years ago
Christian Sadilek
d4a454442b
[fenix] Sort history metadata on home and allow limiting results
3 years ago
Elise Richards
1e1a52e6f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20654 : Handle private mode switching from home behind search dialog.
...
Add tests for controller and interactor to handle private mode switches
3 years ago
Christian Sadilek
9a78d339b5
[fenix] Fix history metadata API breakage in unit tests
3 years ago
Arturo Mejia
fc42d08c06
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18629 : add support for SmartBlock exceptions
3 years ago
Arturo Mejia
5d55e07dd3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21226 only show the "Customize Home" menu on home screen.
3 years ago
bendk
739d93372e
[fenix] Handle breaking changes from a-s 83.0.0 ( https://github.com/mozilla-mobile/fenix/pull/21215 )
3 years ago
Arturo Mejia
42a5fcc880
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21095 allow users to configure their home screen.
3 years ago
Elise Richards
d0757d386a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19947 : manually add login ( https://github.com/mozilla-mobile/fenix/pull/21199 )
...
* [WIP] New Layout for adding login and 'add login' button in 'SavedLoginsListView' to launch it.
Fixed bindings.
* [WIP] Removed "reveal password" button
* [WIP] Added interactor for the add login screen
* [WIP] Trying to check for duplicates
* [WIP] Renaming "addNew..." with "add..."
* [WIP] Check for duplicates
* [WIP] Fixes after merge
* Cleaning up the layout and making edit text for hostname selectable
* Error handling on add login screen. Tests for interactors and controllers
Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Michael Comella
88f34d654e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21183 : remove lazyMonitored wrapper functionality.
...
We're not using the functionality so there's no sense in doing the work.
However, we keep the wrapper: see the code comments for details.
3 years ago
Arturo Mejia
c42b4d7481
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20892 update connection panel strings
3 years ago
Noah Bond
691fe57943
[fenix] Issue mozilla-mobile https://github.com/mozilla-mobile/fenix/issues/21140 - Updated recent tab logic to show media tab and second-to-last tab, if the media tab was the last active tab. ( https://github.com/mozilla-mobile/fenix/pull/21141 )
...
* Issue mozilla-mobilehttps://github.com/mozilla-mobile/fenix/issues/21140 - Updated recent tab logic to show media tab and second-to-last tab, if the media tab was the last active tab.
* Fixed RecentTabsListFeatureTest unit test
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Roger Yang
e7c3145fec
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18711 : Telemetry for credit card autofill
3 years ago
Christian Sadilek
193016b662
[fenix] Remove mocked lambdas from AccountSettingsInteractorTest
3 years ago
Mickey Moz
dccc1133b1
[fenix] Update Android Components version ( https://github.com/mozilla-mobile/fenix/pull/21109 )
...
* Update Android Components version to 93.0.20210901143120.
* For https://github.com/mozilla-mobile/fenix/issues/21043 - Integrate AC changes
* Fix breaking API changes of RestoreAction
Co-authored-by: Mugurell <Mugurell@users.noreply.github.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Elise Richards
2d433166a8
[fenix] Remove banner open in app telemetry
3 years ago
Elise Richards
17ad77ea02
[fenix] Remove private browsing shortcut telemetry
3 years ago
Elise Richards
1e05446283
[fenix] Remove tip telemetry
3 years ago
Elise Richards
61d95c4967
[fenix] Remove find in page telemetry
3 years ago
Elise Richards
9c5bb84cb1
[fenix] Remove total uri count telemetry
3 years ago
Elise Richards
9a432d9f64
[fenix] Remove downloads misc telemetry.
3 years ago
Gabriel Luong
054f6b5626
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21035 - Refactor HistoryViewInteractor from HistoryView into HistoryInteractor
3 years ago
Christian Sadilek
690f3e72f5
[fenix] Dedupe history metadata in groups based on url
3 years ago
Elise Richards
d105e8bc19
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19931 : Add telemetry probes for recent bookmarks on home screen ( https://github.com/mozilla-mobile/fenix/pull/20316 )
...
* Add telemetry probes for recent bookmarks on home screen. Tests for controller.
* Make the events into counters in the metrics ping
Update tests to reflect new metrics
Add data review link for new metrics
Mock new settings for startup metrics tests
Update metrics
Add test for recent bookmark glean events
* Recent bookmarks controller tests
3 years ago
Mugurell
7b7a252ecf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20507 - Inactive tabs telemetry
...
Two new events are added:
- "inactive_tabs_expanded" for when the inactive tabs section is expanded
- "inactive_tabs_collapsed" for when the inactive tabs section is collapsed
For tracking when an inactive tab is opened / closed I've repurposed the
existing tabs tray telemetry (since the functionality uses the same code)
- tabs_tray.opened_existing_tab
- tabs_tray.closed_existing_tab
to support an extra "source" key indicating the feature from which a tab was
opened or closed. The current values for this new key are:
- "Tabs tray" for when a tab was opened/closed from tabs tray
- "Inactive tabs" for when a tab was openes/closed from the Inactive tabs
section of the tabs tray.
3 years ago
Mugurell
9959334a26
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Finish migrating all synthetics usages
3 years ago
codrut.topliceanu
ecae7a61be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20328 - Adds telemetry for recentlyClosed button
...
...from tabsTray, inactiveTabs section.
3 years ago
codrut.topliceanu
48eff4f831
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in add-ons
3 years ago
mcarare
2adea3fd40
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20927 : Replace icons with AC icons.
3 years ago
Rohan Maity
7ffaefd3fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20596 remove startup timeline probes
3 years ago
Jonathan Almeida
d2b9962319
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20945 : Fix failing test in AccountSettingsInteractorTest
3 years ago
Jonathan Almeida
eae779d231
[fenix] Speculative fixes intermittent test in DeleteAndQuitTest
3 years ago
Arturo Mejia
b50ecb92b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20919 quit the after removing a study.
3 years ago
codrut.topliceanu
4e917c5eac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in tabs tray
3 years ago
Mugurell
5b99139048
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Migrate `home` from Kotlin synthetics to View Binding.
3 years ago
Mugurell
b38f717c4b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Migrate `browser` from Kotlin synthetics to View Binding.
3 years ago
codrut.topliceanu
c0d03b3d1e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in Login Exceptions
3 years ago
Arturo Mejia
a82a02a9e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20890 when TP is off globally hide TP section on quick settings.
3 years ago
Roger Yang
0a2cdff945
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/2783 : Add snackbar to collection deletion
3 years ago
Jonathan Almeida
aded72af41
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20864 : Speculative fix for HomeFragmentTest failures
3 years ago
codrut.topliceanu
5e0b094e4f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in tracking protection(2)
3 years ago
codrut.topliceanu
a4a1f6ddaf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in Share views
3 years ago
codrut.topliceanu
179dd793ad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in Onboarding Tests
3 years ago
Jonathan Almeida
591d6744df
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796 : Additional fixes for intermittent failing test
...
Fixes for TrackingProtectionExceptionsInteractorTest to remove the lamba
mocking and test actual BrowserState changes instead (where possible).
3 years ago
Arturo Mejia
93f23aa750
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 integrate view binding.
3 years ago
Gabriel Luong
2d6dcb814c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add a back navigation to the Global Quick Settings from the Tracking Protection dialog
3 years ago
Arturo Mejia
39dc0701a8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Improve quick setting dialogs navigation
3 years ago
Gabriel Luong
c9575d0d62
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Remove tracking protection overlay CFR
3 years ago
Arturo Mejia
ab1e4228c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add connection sub-menu.
3 years ago
Gabriel Luong
7d8ca1ec98
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Add favicon to website info view
...
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Gabriel Luong
9bb39fe7b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Handle toggling tracking protection in quick settings
3 years ago
Gabriel Luong
70d55f4746
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19886 - Remove the tracking protection indicator
3 years ago
Jonathan Almeida
8c5bccf445
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20853 : Fix intermittent failing test in HomeFragmentStoreTest
3 years ago
Jonathan Almeida
632311b1ea
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/15168 : Remove intermittent failing test in ToolbarViewTest
...
This test seems to be hacking at the binding between Fenix and the
BrowserToolbar to simulate toolbar events passing to the Fenix
interactor.
This is rather clumsy test that relies on the magic working of mockk
instead of following a general unit testing strategy that would commonly
require the class to be re-written to allow for better testing instead.
It is far safer to remove this test since we are not guaranteeing
anything in it and instead we see intermittent failures that make us
lose more time.
So therefore.. 🔥
3 years ago
Jonathan Almeida
d32727eff9
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796 : Fix intermittent test failure in TrackingProtectionExceptionsInteractorTest
3 years ago
Jonathan Almeida
14735a61ae
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20795 : Speculative fix for intermittent test failures in HomeFragmentTest
...
The expectation is that replacing `return` with `answers` will compute
the return value for the extension function again in order to avoid the
error, "no answer found for: Settings".
3 years ago
Jonathan Almeida
a590fd2b74
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20797 : Fix intermittent test failures in ShortcutsSuggestionProviderTest
3 years ago
Jonathan Almeida
9b20f9c1c0
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20792 : Fix intermittent test failures in QuickSettingsFragmentReducerTest
3 years ago
Rohan Maity
620d034134
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20596 remove perf.startup probes
3 years ago
Arturo Mejia
d4a2d1ac83
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 add screen for opting out of experiments
3 years ago
Arturo Mejia
be0f7d9dcc
[fenix] Disable intermittent tests.
3 years ago
Vitaly V. Pinchuk
21fedbf45f
[fenix] Dismisses search dialog if active in (RecentTabsHeaderViewHolder, RecentBookmarksViewHolderTest) and adapts test for the changes.
3 years ago
Michael Comella
b8f673380f
[fenix] No issue: remove unnecessary robolectric annotations.
...
Theoretically, this should marginally decrease the duration of our unit
test suite. In my testing, for 1 iteration each (i.e. noise is very
possible), the duration changed from 9m 32s to 8m 21s – a 71s
improvement.
---
To identify tests that were running with robolectric that didn't need to
be, I removed the @RunWith(FenixRobo... from all relevant files:
sed -i '' "/@RunWith(FenixRobolectric/d" app/src/test/**/*.kt
I ran the tests and discovered which ones failed from the Classes tab of
the index.html test result file. Something like:
tests = document.querySelectorAll('table')[3].querySelectorAll('tr');
failureElements = tests.querySelectorAll('.failures');
// TODO: extract the test names
Then I copied these results to a text file and compared them to all the
files that had robolectric test runners to figure out which ones still
pass:
comm -1 -2 failures.txt changed_files.txt > robolectric_not_needed.txt
And undid the changes to the failing files:
for i in $(cat robolectric_not_needed.txt); do git checkout $i; done
Then I removed the import statements on those files:
for i in $(cut changed_files.txt); do sed -i '' "/import.*RunWith/d" $i; done
for i in $(cat changed_files.txt); do sed -i '' "/import.*RobolectricTestRunner/d" $i; done
3 years ago
Elise Richards
7273536742
[fenix] For FNXV2-17067: always show home in background behind search dialog ( https://github.com/mozilla-mobile/fenix/pull/20573 )
...
* Navigate to home on toolbar click. Handle back press from search dialog
Update tests to show home behind search dialog. Remove unused test.
Jump back in show all button is clickable behind search dialog
Recently saved bookmarks show all button is clickable behind search dialog
* Add feature flag
* Past explorations show all button is clickable behind search dialog
Handle keyboard in controllers instead of viewholders. Update tests.
Allow collections to be visible behind search dialog
Dismiss keyboard and search dialog with navigateUp instead of just dismissing the keyboard
Verify navigateUp in tests
Adding ignore for flaky UI test
Only resize home behind search dialog
Add ignore for collection intermittent test
Cleanup
3 years ago
mcarare
dcbd978c73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20425 : Re-add tests for class BookmarksUseCaseTest.
3 years ago
Jonathan Almeida
feb8f5e363
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20726 : Fix intermittent failure in AddonsManagementViewTest
3 years ago
Michael Comella
b4ce5abf0e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20697 : replace mockked lambda in DownloadControllerTest.
...
This is expected to fix the intermittent failure in this test.
3 years ago
Christian Sadilek
18a51be61c
[fenix] Update Android Components version to 92.0.20210806164329 ( https://github.com/mozilla-mobile/fenix/pull/20722 )
...
Addresses breaking change in ShortcutsSuggestionProvider
3 years ago
Jonathan Almeida
d4ab4f3572
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20663 : Make inactive card collapsible
...
We use make the inactive tabs section of the tabstray collapsible in
this change, with a technical quirk: we want to make the "isExpanded"
state of the tabs stay for the lifetime of the app and not the tabs
tray, but this functionality does not exist.
In this patch, we're storing the UI state in a singleton class that
exists for the lifetime of the app, but a more concrete solution is to
use an AppStore that holds content like this, which we can land in a
future patch.
3 years ago
Grisha Kruglov
39561f3644
[fenix] External source support
...
Adds handling of information about external referrer (package, category)
when dealing with external intents.
3 years ago
Roger Yang
333840f02e
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/18711 : Telemetry for credit card autofill ( https://github.com/mozilla-mobile/fenix/pull/19548 )"
...
This reverts commit 5d65ba087e6b30a2a34b73b34e15b03bfecace0d.
3 years ago
Roger Yang
cffad4f424
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/18711 - Refactor credit card telemetry under the Metrics ping ( https://github.com/mozilla-mobile/fenix/pull/19733 )"
...
This reverts commit f6dd0834df4e2a15de684292a8422279487c5a23.
3 years ago
Mugurell
b583864643
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20584 - Speculative fix for ToolbarViewTest failing in CI
...
There was an `java.lang.InstantiationError: kotlin.jvm.functions.Function1`
stemming from line 75. See if avoiding nullability helps.
3 years ago
Jonathan Almeida
cdade5b44a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20664 : Do not consider newly created tabs as inactive
3 years ago
mcarare
a710775406
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20601 : Use View binding in quick settings.
3 years ago
Christian Sadilek
24b4a03d32
[fenix] Fix intermittent test failures in ToolbarViewTest
3 years ago
Roger Yang
b901490a1b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20650 : Revert to manually close tab as default setting
3 years ago
Arturo Mejia
724fb8b60f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20601 : Undo Use View binding in quick Settings.
3 years ago
Michael Comella
d0ca64a9a4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20631 : remove @Ignore on StorageStats tests.
...
The errors that caused this to be @Ignored were addressed by a recent PR
landing on master (i.e. the one that renewed the probes this test is
testing).
3 years ago
Sebastian Kaspari
4a3576d299
[fenix] Fix intermittent test failures in TabsTouchHelperTest
3 years ago
Sebastian Kaspari
7d59c1f786
[fenix] Fix intermittent test failures in DefaultBrowserToolbarControllerTest
3 years ago
Sebastian Kaspari
5272c60934
[fenix] Fix intermittent test failures in DefaultSessionControlControllerTest.
3 years ago
Michael Comella
85309f1d25
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20627 : replace mocked lambda in HistoryItemMenuTest.
...
This will prevent intermittent failures with Java 11.
3 years ago
Elise Richards
1bad9ad91c
[fenix] No issue: fix glean metrics tests for expired metrics ( https://github.com/mozilla-mobile/fenix/pull/20621 )
...
* Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed.
* Add ignores for performance metrics that have expired.
* Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes.
* Remove metrics controller from signature and remove in tests
3 years ago
Jonathan Almeida
3fcd0878d4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20349 : Add inactive tab grouping to tabs tray
3 years ago
Christian Sadilek
bb3071457a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533 : Fix intermittent test failures of DefaultCollectionCreationControllerTest
3 years ago
Christian Sadilek
fb66b53852
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533 : Fix intermittent failures of DefaultSessionControlControllerTest
3 years ago
Sebastian Kaspari
fa26d61a8f
[fenix] Fix intermittent test failures of ModeTest
3 years ago
Sebastian Kaspari
6ea19d4b17
[fenix] Run ktlintFormat to adapt to latest formatting rules.
3 years ago
Christian Sadilek
acc5dc1220
[fenix] Fix intermittent test failures of LoginExceptionFragmentStoreTest
3 years ago
Christian Sadilek
2a67850677
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533 : Fix intermittent test failures of ExceptionsListItemViewHolderTest
3 years ago
Christian Sadilek
9ed161ff27
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533 : Fix intermittent test failures in SearchDialogControllerTest
3 years ago
Christian Sadilek
a5716396be
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533 : Fix intermittent failures of DefaultTabsTrayControllerTest
3 years ago
mcarare
e3b9c8b633
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in settings screens.
3 years ago
mcarare
cc18008cbe
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19955 https://github.com/mozilla-mobile/fenix/issues/20393 : Add telemetry for home screen recent tabs.
3 years ago
Christian Sadilek
b36321a8ed
[fenix] Fix intermittent test failures in WebPushEngineIntegrationTest
3 years ago
Christian Sadilek
2c38047d32
[fenix] Fix intermittent test failures in FenixSnackbarKtTest
3 years ago
Christian Sadilek
9e42de220f
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20531 : Fix intermittent test failures in DefaultQuickSettingsControllerTest
3 years ago
Christian Sadilek
ad8312ea31
[fenix] Fix intermittent test failures in NavigationInteractorTest
3 years ago
Christian Sadilek
696561599e
[fenix] Fix intermittent test failures in PagedHistoryProviderTest
3 years ago
Christian Sadilek
bcf051b559
[fenix] Fix intermittent test failures in TrackingProtectionExceptionsInteractorTest
3 years ago
Christian Sadilek
ddd3964fb7
[fenix] Fix intermittent test failures in BookmarkControllerTest
3 years ago
Christian Sadilek
a29d89ef7a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20533 : Fix intermittent failures of HistoryControllerTest
3 years ago
Sebastian Kaspari
d9faf84790
[fenix] RemoveTabUseCaseWrapperTest: Do not mock lambdas.
3 years ago
Sebastian Kaspari
0400ede268
[fenix] DefaultRecentlyClosedControllerTest: Do not mock functions
3 years ago
Sebastian Kaspari
3fde165e1c
[fenix] Do not mock lambdas in TrackingProtectionPanelInteractorTest.
3 years ago
Christian Sadilek
b612a76e07
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20531 : Fix intermittent failures of DefaultBrowserToolbarMenuControllerTest
3 years ago
codrut.topliceanu
8593bfd0fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20440 - Forces TopSitePager bind if no. of pages changed
3 years ago
Christian Sadilek
3bc9ed6cba
[fenix] Fix init order in TrackingProtectionExceptionsViewTest
3 years ago
Christian Sadilek
0f8e4450a2
[fenix] Fix race condition in ShareViewModelTest
3 years ago
Christian Sadilek
2a6d83146a
[fenix] Remove unused imports in PwaOnboardingObserverTest.kt
3 years ago
Christian Sadilek
a56fdc175c
[fenix] Use MainCoroutineRule in PwaOnboardingObserverTest
3 years ago
Sebastian Kaspari
2e02e54516
[fenix] Update Robolectric and mockk.
3 years ago
Sebastian Kaspari
70ae207572
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19662 : Use Java 11.
3 years ago
mcarare
9348be6526
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20425 : Update AC version
3 years ago
Mugurell
df0b2e0d59
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20402 - Re-enable "in progress media tab"
...
The crash for when media starts playing in a custom tab is now resolved in AC.
3 years ago
Gabriel Luong
229aab88f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20438 - Display a list of history metadata groups
3 years ago
Christian Sadilek
35538a209f
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/16330 : Remove remaining usages of Sentry.capture
3 years ago
codrut.topliceanu
8541d3f449
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20367 - Fixes removeAllTabs adding to recently closed
...
`removeAllTabs` will now no longer allow `UndoMiddleware` from recovering the tabs.
3 years ago
codrut.topliceanu
8e35c61327
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15499 - Smoothly updates topSites list on remove
...
To remove the flash on refresh of the topsites list we have to use submitList, however using this too high up in the hierarchy of our listAdapters within listAdapters will cause children to refresh at once. The solution to this is to use submitList lower. Using it in TopSitesPagerAdapter.kt to update the TopSitesAdapter is the way to go. I've also had to use a dummy item for the "removed" Topsite ( with id = -1) so I can manually diff that before using submitList.
3 years ago
Sebastian Kaspari
d9ca412bec
[fenix] Update Kotlin to 1.5.10 (and Coroutines to 1.5.0).
3 years ago
Jonathan Almeida
0522cbe007
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20402 : Disable LastMediaAccessMiddleware temporarily
...
The reducer in this middleware assumes the SessionState is always a
TabSessionState which holds the lastMediaAccess. This is true for the
lastAccess long which is a persistent state.
The list of MediaSessionActions however can also come from Custom Tabs
which relies on a CustomTabSessionState.
For now, the temporary fix is to disable this feature by removing the
middleware and no longer adding the last accessed media to the
recent tabs list ("Jump back in") to avoid crashing users while we think
of a real fix.
3 years ago
Roger Yang
9df7c99ed2
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19847 : Add telemetry for the default browser notification
3 years ago
Mugurell
e469026805
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19933 - Show a media tab item on homescreen for the last tab with media
3 years ago
Mugurell
1c733e918e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20229 - Use the AC common implementation for ads/search telemetry
...
Everything should work exactly as before.
3 years ago
Rohan Maity
a92ae5b9b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1268 Add Unit test for PrivateShortcutCreateManager
3 years ago
Jonathan Almeida
c12a5b98ba
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20320 : Use scope from testDispatcher in RecentBookmarksFeatureTest
3 years ago
Jonathan Almeida
c695a5c533
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20267 : Filter out network errors from Nimbus
3 years ago
Marc Leclair
4cbc383520
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19804 : Restore logic to original behavior
3 years ago
Michael Comella
f59df714f8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20127 : remove app_opened_all_startup integration.
3 years ago
Elise Richards
611774676d
[fenix] For FNX-22339: Recently saved bookmarks ( https://github.com/mozilla-mobile/fenix/pull/19835 )
...
* Title and button for home screen recently saved bookmarks section
Create bookmark item view with favicon and title
* View holders and interactors for recently saved bookmarks
Recent bookmark item view holder binding
Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items
Top level adapter for recent bookmarks section
Retrieve list of recent bookmarks on home
View holders and interactors for recently saved bookmarks
Recent bookmark item view holder binding
Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items
Top level adapter for recent bookmarks section
Retrieve list of recent bookmarks on home
Update list on app start and when bookmarks are added
View holders and interactors for recently saved bookmarks
Recent bookmark item view holder binding
Create adapter for recent bookmarks. Implement controller methods. Implement view holder bindings for items
Top level adapter for recent bookmarks section
Retrieve list of recent bookmarks on home
Update list on app start and when bookmarks are added
Make a use case for retrieving and updating the list of recently saved bookmarks
Add adapter items and define header viewholder binding
Use session interactor for header button clicks. Bind in the adapter
* Retrieve list of bookmarks asynchronously on home
Interactor and controller tests
Address review comments
Split up tests for recent bookmarks
Update to new interactors
Dark mode and light mode styles
Refactor bookmarks home stuff
* Add RecentBookmarksFeature to home
Move interactor to SessionControlInteractor
Clean up lint, styles, and dimens.
* Bookmarks use case tests for retrieving recently saved bookmarks. Linting.
* View holder tests
* Match ux to designs for colors, margins, and scrolling
* Clean up clean up
* Tests for the view bound feature
* Controller test
* Clean up: check state of store in feature tests; ellipsize textviews for bookmark item; remove unused attr; format
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
Roger Yang
048abd7f4c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19846 : Show Default Browser Notification if browser is not default
3 years ago
codrut.topliceanu
02d170a5b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20257 - Sets min no. of grid columns to 2 in TabsTray
3 years ago
codrut.topliceanu
ae19555d25
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20250 - Adds FLAG_SECURE to TabsTray dialog
3 years ago
Grisha Kruglov
21dda6b6ab
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20276 : Fall-back to URL parsing for tabs with parents to obtain search terms
3 years ago
mcarare
42bfec3846
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20029 : Remove animations when recreating activity on locale change.
3 years ago
codrut.topliceanu
58657ebdef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19131 - Fixes top sites refresh and interactability
3 years ago
Roger Yang
50101046c3
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19090 : Show snackbar on adding to bookmarks from tabs tray
3 years ago
Christian Sadilek
c3ebf3d738
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20123 : PlacesException when recording history metadata
3 years ago
Codrut Topliceanu
b1d830e323
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20195 - Adds tabsTray allowScreenshotsInPrivateMode check ( https://github.com/mozilla-mobile/fenix/pull/20203 )
...
* For https://github.com/mozilla-mobile/fenix/issues/20195 - Adds tabsTray allowScreenshotsInPrivateMode check
3 years ago
Arturo Mejia
ca851a38be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19922 Fix the default autoplay setting to be block audio only
3 years ago
Mugurell
f9c1338826
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20046 - Show the last accessed tab in Jump back in
3 years ago
Roger Yang
63775af142
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19921 : Update appcompat and fragment dependencies to 1.3.x
3 years ago
Arturo Mejia
51f0ba6668
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19922 Update the default autoplay setting to be block audio only
3 years ago
Jonathan Almeida
3e2f501795
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20054 : Update recent tab on title or icon changes
3 years ago
Arturo Mejia
10e4bf1d7f
[fenix] Improvements to site permissions
3 years ago
Mugurell
c2b11553f1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - Use the FXA email only if the account is authenticated
...
An account may exist but it may need to be re-authenticated.
In this case also the email should not be exposed to the app.
3 years ago
Mugurell
60725fc1f9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - Remove FenixAccountManager#signedInToFxa
...
After the changes from this patch this api is not used anymore so to prevent
future misuses of it this is removed in favor of the new "accountState".
3 years ago
Mugurell
4873b79123
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - Browser menu: go to problems page if account exists but not signed in
3 years ago
Mugurell
efebcc2bc8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19797 - New FenixAccountManager#getAccountState()
...
This new method allows a single source of truth for getting the up-to-date
account status without clients interesting in this needing to know what to
check for.
3 years ago
Grisha Kruglov
5ec85f2f4b
[fenix] Obtain searchTerms from previous page in tab's history
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Jonathan Almeida
8764e7dcec
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19950 : Fix intermittent failure in SearchDialogControllerTest
3 years ago
Mihai Adrian Carare
f20c7ed527
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19813 : Invalidate tab tray adapter structure on screen rotation. ( https://github.com/mozilla-mobile/fenix/pull/20044 )
3 years ago
Gabriel Luong
756e54a037
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19988 - Part 2: Load tab icon from BrowserIcons cache if needed for the recent tab
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
Gabriel Luong
71ca6f7f5d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19988 - Part 1: Move RecentTabsListFeature into recenttabs package
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
Mugurell
65f75412cd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19135 - Set different offsets for expanded trays
...
As in the previous version of tabs tray when tray is expanded while in portrait
it should have a 40dp offset and when the tray is expanded while in landscape
it should have a 0dp offset - effectively making it fullscreen.
These values were set in code, always overriding the xml set value so I
removed that xml declaration.
3 years ago
Mugurell
74a14fe91c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19135 - Expand the tabs tray in landscape
...
Track the current orientation and collapse / expand it the tabs tray depending
on the orientation and the number of opened tabs.
3 years ago
Mugurell
515ae82e9b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19135 - Refactor the behavior code to support more functionality later
...
Setup a new TabSheetBehaviorManager with all the dependencies it needs to
set the initial tray's behavior.
This same manager will later be called to update behavior's properties.
3 years ago
Christian Sadilek
0913ebfe40
[fenix] Issue FNX-22435: Introduce History metadata
...
Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
3 years ago
mcarare
7675e4e8c0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19938 : Remove a11y workaround for tab tray new tab button.
...
Historically, button was introduced in a3dc565c10
,
because FAB was not selectable by a11y in previous implementation of tab tray.
3 years ago
mcarare
3f213a1f9c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19915 : Add telemetry for the toolbar Home screen button.
3 years ago
Gabriel Luong
e8352f7d63
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19916 - Add last viewed tab to home screen
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
Christian Sadilek
1b6aa1dfff
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17800 : Cleanup and fix request desktop site from home
3 years ago
Arturo Mejia
80fb799bb7
[fenix] Fix site permissions breaking changes
3 years ago
Sebastian Kaspari
e25cfcdc48
[fenix] Complete browser-state migration and remove browser-session dependency.
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Gabriel Luong
155c119513
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19876 - Part 2: Add a Home screen button to the browser toolbar
3 years ago
Gabriel Luong
0e5e244e45
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19876 - Part 1: Refactor BrowserToolbarInteractor
...
- Renames `BrowserInteractor` to `DefaultBrowserTolbarInteractor`
- Renames `BrowserTooolbarViewInteractor` to `BrowserToolbarInteractor`
- Refactors `BrowserToolbarViewInteractor` interface from `BrowserToolbarView.kt` to `BrowserToolbarInteractor` as `BrowserToolbarInteractor`
3 years ago
rxumoz
04e9da4065
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10300 - Fix Baidu search telemetry ( https://github.com/mozilla-mobile/fenix/pull/19127 )
3 years ago
Jonathan Almeida
b26989607f
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19178 : Apply new styling to Synced Tabs list
3 years ago
codrut.topliceanu
3b5e51d2ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19738 - Adds tests for SecureTabsTrayBinding.kt
3 years ago
Arturo Mejia
42e0c6d672
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19789 Start on Home after some amount of time
3 years ago
Gabriel Luong
016379fbca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19495 - Add validation for the name on card ( https://github.com/mozilla-mobile/fenix/pull/19836 )
...
- We want to ensure that name on card in the credit card is not empty when submitted. Display an appropriate error when the field is invalid.
3 years ago
Jonathan Almeida
f5a50057a5
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19792 : Add content description for tab tray action button
3 years ago
Roger Yang
125e70ae1b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19090 : Show snackbar on adding to bookmarks from tabs tray ( https://github.com/mozilla-mobile/fenix/pull/19807 )
3 years ago
Jonathan Almeida
3225b7ae30
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19809 : Change default tab tray view to grid layout
3 years ago
Jonathan Almeida
da9d218700
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19809 : Remove Grid layout info banner in tabs tray
3 years ago
Jonathan Almeida
57df4f3fcc
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19112 : Remove old Synced Tabs code
3 years ago
Jonathan Almeida
aa8d5795b2
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19112 : Remove old tab tray code
3 years ago
ZianeA
c745b83740
[fenix] For #[15083]: Add multi select to recently closed tabs
3 years ago
Elise Richards
bcd257172b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19746 - Remove feature flag for the three-dot menu redesign ( https://github.com/mozilla-mobile/fenix/pull/19750 )
...
* Remove feature flag for the three-dot menu redesign
* Remove menu feature flag from unit tests
3 years ago
Gabriel Luong
5ab6b35346
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18711 - Refactor credit card telemetry under the Metrics ping ( https://github.com/mozilla-mobile/fenix/pull/19733 )
3 years ago
Jonathan Almeida
da6ac8459b
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19731 : Track metrics before we dismiss the tabs tray
3 years ago
Mihai Adrian Carare
fc5f56c9ba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19564 : Explicitly update switch state for a11y event announcements. ( https://github.com/mozilla-mobile/fenix/pull/19589 )
3 years ago
Elise Richards
0bedcba4e5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18711 : Telemetry for credit card autofill ( https://github.com/mozilla-mobile/fenix/pull/19548 )
3 years ago
Jonathan Almeida
369ef222fd
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19459 : Use Store.waitUntilIdle in intermittent failing test ( https://github.com/mozilla-mobile/fenix/pull/19683 )
3 years ago
Gabriel Luong
d67678c9c0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19492 - Provide the correct CreditCardNumber type to UpdatableCreditCardFields when updating a credit card ( https://github.com/mozilla-mobile/fenix/pull/19692 )
...
We were crashing because we were specifying the wrong `CreditCardNumber` type when constructing the `UpdatableCreditCardFields`.
We only had the plaintext card number from the user input, but was placing it off as an encrypted card number, which resulted in the crash.
3 years ago
Christian Sadilek
451d286705
[fenix] Migrate test code to no longer use Nimbus FeatureConfig
3 years ago
Elise Richards
c334a5ae30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18264 - Add biometric prompt to credit card settings ( https://github.com/mozilla-mobile/fenix/pull/19505 )
3 years ago
Jonathan Almeida
5dd7d94432
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19647 : Navigate to browser from home via Synced Tabs page
3 years ago
Gabriel Luong
d46ed809a6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19680 - Show the card number when editing a credit card ( https://github.com/mozilla-mobile/fenix/pull/19681 )
3 years ago
Gabriel Luong
a61586886b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18271 - [Saved cards] Display the credit card provider icon and report the correct card type ( https://github.com/mozilla-mobile/fenix/pull/19652 )
3 years ago
Ionut Cristian Bedregeanu
dc4c14400a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19653 - Address 19643 PR comments
...
Rename handleAddCreditCard to handleAddCreditCardClicked
Rename onClickAddCreditCard to onAddCreditCardClick
Format layout_add_credit_card.xml
3 years ago
Mugurell
693a65646c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19475 - Introduce a DefaultTabsTrayInteractor
...
Refactored the TabsTrayFragment to not implement the TabsTrayInteractor which
among other advantages allowed for easier testing.
3 years ago
Mugurell
2825595c5f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19475 - Cleanup - respect naming scheme in TabsTrayController
...
In our current MVI implementation the View Interactors are first called in
response to a direct user action and contain methods following the
"onXXHappened" naming scheme and then delegate other Interactors / Controllers
for specific actions.
Controllers contain the business logic for actually updating the app's state
and offer methods following the "handleXXAction" naming scheme.
3 years ago
Ionut Cristian Bedregeanu
b0caa66de7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18881 - Create a new layout for 'Add credit card' button
...
Add functionality for 'Add credit card' button
Add unit tests for 'Add credit card' functionality
3 years ago
Codrut Topliceanu
6c5d98e939
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18270 - Adds ellipses+last 4 digits to CC display ( https://github.com/mozilla-mobile/fenix/pull/19420 )
...
* For https://github.com/mozilla-mobile/fenix/issues/18270 - Adds ellipses+last 4 digits to CC display
3 years ago
mcarare
4c2c1b4473
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19600 : Change manage cards preference UI dynamically.
3 years ago
Jonathan Almeida
f10aebe8e8
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19176 : Exit select mode when removing tab ( https://github.com/mozilla-mobile/fenix/pull/19486 )
3 years ago
Roger Yang
b7ecc05811
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19147 : Move set startup metrics off main thread
3 years ago
Jonathan Almeida
8cc83017b2
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002 : Correct naming of pager viewholders
3 years ago
Jonathan Almeida
cf9a9dd6dc
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002 : Use a single BrowserTrayList for normal/private list
...
We now have a BrowserTrayList.
- Renamed from `BaseBrowserTrayList`.
- Removed the abstract `configuration` and used a `lateinit var`
instead.
- Removed `NormalBrowserTrayList` and `PrivateBrowserTrayList`.
3 years ago
Jonathan Almeida
9ace0c8551
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002 : Correct browser viewholder naming
3 years ago
Jonathan Almeida
31a0602b9b
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002 : Move TabsTrayViewHolder to browser package
3 years ago
Jonathan Almeida
8b8b96d7d4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19002 : Use AbstractBinding from lib-state
3 years ago
Jonathan Almeida
a9254b79b9
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19175 : Fix SyncTabs list not updating on changes
...
The main cause for this is that the `LifecycleProvider` needs to be set
to `State.RESUMED` to avoid the account manager's internal
`ObserverRegistry` from putting the UI observers into the paused state.
The rest of the changes is to rely the internal (safe) logic to
correctly sync and then update the tabs list.
3 years ago
Gabriel Luong
744e447c64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18993 - Nimbus: Allow internal tooling to opt into specific branches of an experiment ( https://github.com/mozilla-mobile/fenix/pull/19333 )
3 years ago
mcarare
3681f15501
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18266 : Validate credit card entry info.
3 years ago
Codrut Topliceanu
744357e211
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18262 - [Credit cards] Turn the "Sync cards across devices" button into a "Sync cards" toggle ( https://github.com/mozilla-mobile/fenix/pull/19207 )
...
* For https://github.com/mozilla-mobile/fenix/issues/18262 - Turns "Sync cards/logins" into toggle
3 years ago
Roger Yang
2d709b67a7
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19147 : Move startup metrics to right after Glean initialization ( https://github.com/mozilla-mobile/fenix/pull/19252 )
3 years ago
Jonathan Almeida
964b03a65f
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19259 : Pass CoroutineContext to nav interactor constructor
3 years ago
Roger Yang
0884711ab1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18253 : Bookmark and History open new tabs in the background ( https://github.com/mozilla-mobile/fenix/pull/19275 )
3 years ago
Roger Yang
9f608d6b0a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18253 : Remove spaces from Addons telemetry comma-separated list ( https://github.com/mozilla-mobile/fenix/pull/19292 )
3 years ago
mcarare
ee2e653ebb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19213 : Adjust synced tabs to properly show in RTL.
3 years ago
Mugurell
6acdc32aad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11819 - Show the mic in widget only if setting is enabled
...
If "Show voice search" is disabled under Settings, the mic icon should not be
shown in the search widget.
3 years ago
Arturo Mejia
00e4051b15
[fenix] Fix openFile breaking changes
3 years ago
Sebastian Kaspari
7c11a19369
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19040 : Remove Leanplum (Nightly)
3 years ago
Grisha Kruglov
632ba92ad5
[fenix] Fix breaking changes introduced by credit card encryption APIs
3 years ago
Mihai Adrian Carare
7dea66e1e2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19065 - Add extension functions to be used with credit cards. ( https://github.com/mozilla-mobile/fenix/pull/19187 )
3 years ago
Roger Yang
fffa196da9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18816 : Disable TabsTray FAB on accessibility enabled ( https://github.com/mozilla-mobile/fenix/pull/19170 )
3 years ago
mcarare
d94dcd6bd3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19125 : Move top site pin net to title.
3 years ago
mcarare
f28b815561
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18267 : Updates preferences visibility depending on creditCardsStore
3 years ago
Elise Richards
3eff41bd2d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19114 : check state of sync account when navigating from sync sign in menu item ( https://github.com/mozilla-mobile/fenix/pull/19118 )
3 years ago
Jonathan Almeida
c6fe6bd93e
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19094 : Open sign-in flow if no account is created for tabs tray
3 years ago
Jonathan Almeida
4c69372287
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19064 : Focus on tab page with the BrowsingModeManager
3 years ago
Roger Yang
cf70cb61b3
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18946 : Add undo toast for tabstray
3 years ago
Michael Comella
e83004d81b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add & integrate StartupTypeTelemetry.
3 years ago
Michael Comella
1035ad0fd0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add StartupPathProvider + tests.
3 years ago
Michael Comella
bdca7337ce
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : address lint errors for StartupStateProvider*.
3 years ago
Michael Comella
825e035db6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add getStartupStateForStartedActivity method.
3 years ago
Michael Comella
4adb237b88
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add isHotStartForStartedActivity and tests.
3 years ago
Michael Comella
b7e04b6590
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add isWarmStartForStartedActivity, tests.
3 years ago
Michael Comella
d7ad0bb813
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : shorten isColdStart... and rm questionable test.
...
The test failed with the rewrite of the code because it violates
one of our assumptions that only one Activity will be started. However,
since it doesn't rely on observed behavior and we made up the events,
it's value is questionable so it seems okay to remove, especially for
the gain of conciseness in the code.
3 years ago
Michael Comella
895f8efe13
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add VIEW to warm and hot entries.
3 years ago
Michael Comella
f5943d894c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : refactor tests to forEachHotStartEntries.
3 years ago
Michael Comella
ca1364f3b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : refactor test into forEachWarmStartEntries.
3 years ago
Michael Comella
e7d166052c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : refactor tests into forEachColdStartEntries.
3 years ago
codrut.topliceanu
2b69fd5b2a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19023 - Expands tabsTray when tabs over certain number
...
TabsTray should be collapsed when there are only a few tabs on screen, otherwise it should go straight to STATE_EXPANDED.
3 years ago
Kate Glazko
68b17ba7e8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18520 : Add Empty Tab State To Browser Tray List
3 years ago
Jonathan Almeida
2ce93ef3a4
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19024 : Fix intermittent test failure in NavigationInteractor
3 years ago
Jonathan Almeida
c6b9bf80d5
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19045 : Dismiss tabstray when last tab in a page is closed
3 years ago
Gabriel Luong
fd0b41c798
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18274 - [Edit card] Update a saved credit card information ( https://github.com/mozilla-mobile/fenix/pull/19032 )
3 years ago
Gabriel Luong
baea2cdf4d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18273 - [Edit card] Delete a saved credit card ( https://github.com/mozilla-mobile/fenix/pull/19029 )
3 years ago
Roger Yang
d72289a43d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/19003 : Add account setting to tabstray synced tab menu ( https://github.com/mozilla-mobile/fenix/pull/19034 )
3 years ago
Roger Yang
4f9a341746
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18948 : Update tabstray telemetry ( https://github.com/mozilla-mobile/fenix/pull/19004 )
3 years ago
Jonathan Almeida
d10792a96e
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19011 : Always have a click listener in TabTrayViewHolder
3 years ago
Jonathan Almeida
bc628f6770
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18934 : Do not nullify adapter on window detached
...
Previously, to fix a memory leak, we were removing the adapter reference
entirely in order to have the `onDetachedFromRecyclerView` callback
invoked. This causes a side-effect where we can no longer reference the
adapter any more when we re-attach.
The simpler solution is to just invoke the needed callback directly
instead.
3 years ago
Gabriel Luong
ac29b50dfa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18272 - [Edit card] Display a saved card information in the Edit card screen ( https://github.com/mozilla-mobile/fenix/pull/18884 )
3 years ago
MarcLeclair
4c45f615bb
[fenix] 16900 make navgraph inflation asynchronous ( https://github.com/mozilla-mobile/fenix/pull/18889 )
...
* For https://github.com/mozilla-mobile/fenix/issues/16900 : implement async navgraph inflation
For https://github.com/mozilla-mobile/fenix/issues/16900 : removed nav graph from xml
For https://github.com/mozilla-mobile/fenix/issues/16900 : inflate navGraph programatically
For https://github.com/mozilla-mobile/fenix/issues/16900 : Made NavGraph inflation asynchronous
For https://github.com/mozilla-mobile/fenix/issues/16900 : Changed to block with runBlocking
For https://github.com/mozilla-mobile/fenix/issues/16900 : Refactored blocking call into a function
For 16900: NavGraph inflation is now async
We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController).
This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key.
If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph
to the navcontroller (and the inflation of the latter too)
For 16900: rebased upstream master
For 16900: Rebase on master
For https://github.com/mozilla-mobile/fenix/issues/16900 : Fixed Async Navgraph navigation per review comments.
1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher
2)The Job is tracked through a WeakHashMap from Controller --> NavGraph
3)The Coroutine scope doesn't use MainScope() anymore
4)The Coroutine is cancelled if the Activity is destroyed
5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup()
For https://github.com/mozilla-mobile/fenix/issues/16900 : inflateNavGraphAsync now takes navController
For https://github.com/mozilla-mobile/fenix/issues/16900 : Pass lifecycleScope to NavGraphProvider
For https://github.com/mozilla-mobile/fenix/issues/16900 : removed unused mock
For https://github.com/mozilla-mobile/fenix/issues/16900 : Added linter rules for navigate calls
We need linting rules to make sure no one calls the NavController.navigate() methods
For https://github.com/mozilla-mobile/fenix/issues/16900 : Added TestRule to help abstract the mocks in the code
For 16900: Fix linting problems
For https://github.com/mozilla-mobile/fenix/issues/16900 : Cleaned duplicated code in tests
For https://github.com/mozilla-mobile/fenix/issues/16900 : cleaned up NavGraphTestRule for finished test
For https://github.com/mozilla-mobile/fenix/issues/16900 : had to revert an accidentally edited file
For https://github.com/mozilla-mobile/fenix/issues/16900 : rebased master
* For https://github.com/mozilla-mobile/fenix/issues/16900 : Review nits for async navgraph
This is composed of squash commits, the original messages can be found below:
-> DisableNavGraphProviderAssertionRule + kdoc.
Use test rule in RobolectricApplication.
Fix failing CrashReporterControllerTest
Fix blame by -> navigate in tests.
This commit was generated by the following commands only:
```
find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \;
find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \;
git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
```
Fix various blame
This is expected to be squashed into the first commit so, if so, it'd
fix the blame.
Move test rule to helpers pkg.
add missing license header
Add import change I missed
fix unused imports
Replace robolectricTestrunner with test rule.
Improve navGraphProvider docs
Remove unnecessary rule as defined by robolectric.
add clarifying comment to robolectric
remove unnecessary space
* For https://github.com/mozilla-mobile/fenix/issues/16900 : nit fixes for MozillaNavigateCheck and lint fixes
3 squash commits:
*Changed violation message and fixed the lint rule for MozillaNavigateCheck
*Added suppression to NavController.kt
*Fixed detekt violations
* For 16900: Fixed failing tests
Co-authored-by: Michael Comella <michael.l.comella@gmail.com>
3 years ago
Michael Comella
e7a15807a4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : rename CreatedActivityLogEntry -> LogEntry.ActivityCreated and similar.
...
It's too much work to squash "correctly".
3 years ago
Michael Comella
4411a9c84a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add StartupStateProvider.
3 years ago
Michael Comella
7d0024ab93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : prevent StartupActivityLog from growing infinitely.
...
We do this is as a separate commit over the original implementation
because it's simpler to implement the class without this optimization.
3 years ago
Michael Comella
7286daabe9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18836 : add StartupActivityLog, tests.
3 years ago
Jonathan Almeida
5000e54aaf
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18931 : Implement add to collections in interactor
...
We moved the collection dialog code out from the old fragment, because it
had nothing to do with tabs tray, and into the collections package to be
re-usable in other parts of the app.
In addition, we also make use of it in the new tabs tray's
NavigationInteractor.
3 years ago
Jonathan Almeida
e50350db14
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18931 : Move dialog adapter to collections package
3 years ago
Jonathan Almeida
35947762b7
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18931 : Rename class to CollectionsListAdapter
3 years ago
Jonathan Almeida
4ba99372f2
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18885 : Dismiss FAB icon when tabs tray is closed
3 years ago
mcarare
ed8d36520e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18375 : Add experiment for set default browser New Tab card.
3 years ago
Elise Richards
a5d8e40932
[fenix] Add ignores for intermittent toolbar tests
3 years ago
Roger Yang
425c9d857b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18522 : Re-add call to action in tabs tray
3 years ago
Jonathan Almeida
5819a7c0a4
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18862 : Add multi-select banner to tabs tray ( https://github.com/mozilla-mobile/fenix/pull/18932 )
...
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add new addBookmark BookmarksUseCase
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add class for state binding features
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add delete multiple tabs to tray interactor
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add new actions to navigation interactor
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Enable select mode from main tray menu
* Issue https://github.com/mozilla-mobile/fenix/issues/18862 : Add menu when in select mode
* Close https://github.com/mozilla-mobile/fenix/issues/18862 : Add multi-select banner to tabs tray
* Close https://github.com/mozilla-mobile/fenix/issues/18862 : Add select support for handle UI
We apply various layout changes to the "handle" UI in the tabs tray when
switching modes. It isn't quite clear to my, why we do this, if it's
really needed to meet the end result, and if there is a better way.
For now, we're simplying moving over that logic that we can re-evaluate
at a later time.
3 years ago
Mugurell
a7deb00521
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18616 - Update browser and toolbar layout when toolbar is at top
...
FindInPageIntegration which already updated the toolbar to make room for the
find in page bar now receives more data based on which it will be able to
better update the layout of BrowserFragment to to support showing the find in
page bar.
3 years ago
Sebastian Kaspari
a23da507c5
[fenix] Introduce process lifecycle observer to collect metrics about tabs when app goes to foreground/background.
3 years ago
Sebastian Kaspari
0d5d585dd1
[fenix] Move TelemetryMiddleware to telemetry sub package.
3 years ago
Jonathan Almeida
d2ca8da836
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18845 : Adds swipe-to-delete to tabs tray refactor
...
Copied the TabsTouchHelper from the `tabtray` package here so we don't
need to re-write our own because there's nothing more to add.
We can hook this up with our tabs tray here by putting it in the
`BaseBrowserTrayList` for our normal and private tabs list.
3 years ago
Gabriel Luong
ee594f885e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18268 , https://github.com/mozilla-mobile/fenix/issues/18269 - [Saved cards] Display a list of Saved cards fetched from the credit card storage ( https://github.com/mozilla-mobile/fenix/pull/18808 )
3 years ago
codrut.topliceanu
dc1f62eb6e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18515 - Added Icon and sync functionality
...
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
3 years ago
Jonathan Almeida
a890d0210e
[fenix] No issue: Move menu to separate integrations class
3 years ago
Jonathan Almeida
d18854c54c
[fenix] No issue: Add test for share tab in navigation interactor
...
Co-authored-by: Roger Yang <royang@mozilla.com>
3 years ago
Jonathan Almeida
3c3bf65d93
[fenix] No issue: Observe only normal tabs when updating counter
3 years ago
Jonathan Almeida
16f87e47e3
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18774 : Migrate mutli-selection to store
...
Removes the recyclerview-selection library and replaces it with the
SelectionHolder/SelectionInteractor with a Store.
This is an implementation that's similar to what we have in other UI
lists (library).
3 years ago
Arturo Mejia
d024b9bc93
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/16557 set autoplay block audio only
...
by default
3 years ago
Roger Yang
7b72b9e85b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18513 : Re-add menu to tabs tray ( https://github.com/mozilla-mobile/fenix/pull/18756 )
3 years ago
Jonathan Almeida
3ec3c16c70
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535 : Set the span count for grid view
3 years ago
Jonathan Almeida
8fa60a67af
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18535 : Do not animate first scroll to position
...
This looks less that ideal with a grid layout that swings by from the
normal tabs to private tabs.
3 years ago
Jonathan Almeida
94688bf59b
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/17821 : Add TabsTrayStore with actions and reducer ( https://github.com/mozilla-mobile/fenix/pull/18773 )
3 years ago
Jonathan Almeida
5beadfdb15
[fenix] No issue - Make TabLayoutMediator lifecycle aware ( https://github.com/mozilla-mobile/fenix/pull/18779 )
3 years ago
Gabriel Luong
a13c6f3f2d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18265 - [Add card] Integrate the credit card storage and handle adding a new credit card ( https://github.com/mozilla-mobile/fenix/pull/18719 )
3 years ago
Elise Richards
990fe44056
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17770 : New tab three-dot menu reorder ( https://github.com/mozilla-mobile/fenix/pull/18427 )
...
* Create new menu order for new tab
* Add new tab menu navigation. Dynamically update menu when sync auth is needed. Make new tab menu and browser menu consistent.
* Lint
Lint and refactoring tests
* Tests for default toolbar menu
* Feature flag for request desktop site
Add todos for UI test issue 17979
Add todos for UI tests
3 years ago
Mugurell
433b0f0bdc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18617 - Use the new EngineView#getInputResultDetail()
...
All functionality should remain the same.
3 years ago
Mihai Adrian Carare
4da13e56c1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17800 - Request desktop site from home screen. ( https://github.com/mozilla-mobile/fenix/pull/18653 )
3 years ago
Jonathan Almeida
e6d88f4669
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18521 : Focus on page corresponding to selected tab
...
This first part of https://github.com/mozilla-mobile/fenix/issues/18521 is to focus on the correct pager item first
before we land a patch for `scrollToPosition` of the selected tab.
3 years ago
Jonathan Almeida
11b1e0a461
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18668 : Add stable ID cache for TabAdapter.getItemId
3 years ago
Kershan
bd7ca49b17
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18453 - Show SUMO for default browser deeplink on Android <N
...
Lower Android versions don't offer the possibility of opening system settings
at a specific preference. In this cases we already shown a sumo article
detailing the manual steps each user is expected to perform to change the
system set default browser.
3 years ago
Mihai Adrian Carare
89321fbec1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18260 - Add pin to default sites. ( https://github.com/mozilla-mobile/fenix/pull/18618 )
4 years ago
Arturo Mejia
c9f822d0d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15372 Optimize the order and messages of onboarding cards
4 years ago
Roger Yang
e1404fab67
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17644 : Record when user taps on a add-on's setting ( https://github.com/mozilla-mobile/fenix/pull/18504 )
4 years ago
mcarare
f5c72efb38
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17790 : Remove app from recents screen on quit.
4 years ago
Elise Richards
25d14c9a8e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17190 : notifications are updated when locale is changed ( https://github.com/mozilla-mobile/fenix/pull/18179 )
...
* Add intent processor for locale changes
* Recreate notification and notify in the service
* Use locale use cases to update notification
* Use notification id instead of tag
* Add locale use cases and restore locale in application
* Send locale to service instead of string
* Controller tests for locale
* Update Android Components version to 74.0.20210323143308
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
4 years ago
Roger Yang
baa22e0645
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17791 : Use updated URL with custom tabs when copying to clipboard ( https://github.com/mozilla-mobile/fenix/pull/18590 )
4 years ago
Mugurell
ea39380daa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18585 - Don't use hardcoded String values in Onboarding unit test ( https://github.com/mozilla-mobile/fenix/pull/18597 )
...
Test if the welcome message has the expected structure and uses the expected
String values, not what the string values are.
4 years ago
Vitaly V. Pinchuk
49c057097e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18395 : Dismiss contextual menu when entering/exiting Reader Mode
4 years ago
Roger Yang
4abb852190
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17531 : Use shared preference to store top sites count for telemetry ( https://github.com/mozilla-mobile/fenix/pull/18557 )
4 years ago
Roger Yang
7e59b192b6
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17956 : Add top site telemetry to available search engines ( https://github.com/mozilla-mobile/fenix/pull/18129 )
4 years ago
Mihai Adrian Carare
02cabca0c5
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12565 : Clean up use of Context within ReviewPromptController. ( https://github.com/mozilla-mobile/fenix/pull/18537 )
4 years ago
Roger Yang
1569a8ce76
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17644 : Always update add-on's telemetry values before sending metric ping ( https://github.com/mozilla-mobile/fenix/pull/18529 )
4 years ago
Jonathan Almeida
122597ce56
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17822 : Create a tabs tray layout and fragment
...
Co-authored-by: Kate Glazko <kglazko@Kates-MacBook-Pro.local>
4 years ago
Gabriel Luong
42cc036ba5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18036 - Add TrackKeyInfo to Ad Click Metrics ( https://github.com/mozilla-mobile/fenix/pull/18159 )
4 years ago
Arturo Mejia
d296d0c9c2
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18367 run SupportedAddonsChecker only for users with unsupported extensions
4 years ago
mcarare
325e5619ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12528 : Provide fallback values for locale display name.
4 years ago
Gabriel Luong
f0ad7abee1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18241 - Refactor SyncLoginsPreferenceView to SyncPreferenceView for reusability ( https://github.com/mozilla-mobile/fenix/pull/18383 )
...
This refactors SyncLoginsPreferenceView to SyncPreferenceView so that it be can be used in the
Credit cards preference for the equivalent "Sync cards across devices" preference.
4 years ago
Roger Yang
1ca7dc61ab
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18178 : Rework History Telemetry ( https://github.com/mozilla-mobile/fenix/pull/18261 )
4 years ago
Roger Yang
f0dcb64716
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18173 : Add Telemetry When User Opens a Bookmark ( https://github.com/mozilla-mobile/fenix/pull/18174 )
4 years ago
Roger Yang
b8342ac6f0
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18068 : Use AwesomeBarFacts for AwesomeBar Telemetry ( https://github.com/mozilla-mobile/fenix/pull/18090 )
4 years ago
Roger Yang
70329154e5
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18163 : Use SyncedTabsFacts for Synced Tab Telemetry ( https://github.com/mozilla-mobile/fenix/pull/18172 )
4 years ago
Mihai Adrian Carare
bcad665bf5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17971 : Add Reader view appearance controls in three-dot main menu. ( https://github.com/mozilla-mobile/fenix/pull/18340 )
4 years ago
Sebastian Kaspari
1368a9bd19
[fenix] Fix metric types of engine telemetry.
4 years ago
Gabriel Luong
1be5240b7f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18202 - Refactor BiometricPromptFeature out of logins into settings
4 years ago
Michael Comella
a0f46da9ad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18157 : convert clock_ticks_per_second to quantity type.
...
While we could easily move this into the metrics ping, it's better to
leave it in the other ping because it's less work and because (I think)
we'll be better able to match `framework_secondary` values to the clock
ticks if we combine them in the same ping.
4 years ago
Christian Sadilek
96393f85e9
[fenix] Remove Session[Manager] references from Fennec intent processors
4 years ago
Arturo Mejia
59b50be098
[fenix] Target Android 11
4 years ago
mcarare
507b4aaf8b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16044 : Suggest search engines based on typed text.
4 years ago
Arturo Mejia
25b2805f87
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/10428 Improve download dialog error message.
4 years ago
mcarare
e70f40f0d3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18102 : Temporary ignore failing test.
4 years ago
Mugurell
f5be19d9fe
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18027 - Also fix the bottom toolbar in place when a11y is enabled
...
We previously only set the top toolbar as fixed if an a11y service was running.
4 years ago
Jonathan Almeida
1fd32cdfda
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/13892 : Remove Synced Tabs appended to tabs tray
4 years ago
Michael Comella
188fe713ed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17972 : split frameworkStart into two metrics.
...
We do this in order to make it easier to analyze in GLAM: see the metric
descriptions for more details.
Additionally, we change the time unit to milliseconds to make it easier
to analyze in GLAM.
4 years ago
Michael Comella
3ae7379a5f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17969 : add duration probes for App.onCreate and HomeActivity.onCreate.
4 years ago
Mugurell
d975ede9d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17899 - Expand toolbar when returning from fullscreen video
...
This was the previous behavior for both the top and bottom toolbars.
Regressed when changing to use a new custom behavior for the top toolbar.
When entering fullscreen we will now collapse and hide the toolbar, allow the
browser to expand to the entire screen estate and then, when exiting fullscreen
expand the toolbar.
Collapsing and then expanding the toolbar will trigger the
EngineViewBrowserToolbarBehavior to place the browser below the toolbar.
4 years ago
Roger Yang
998a10cdc9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17089 : Add metric to track both normal and private URI opened ( https://github.com/mozilla-mobile/fenix/pull/17935 )
4 years ago
Sebastian Kaspari
5fec5b8d61
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/12731 : Collect telemetry about the content process of tabs getting killed.
4 years ago
Sebastian Kaspari
4bb02ee709
[fenix] Update Kotlin to 1.4.30 and Coroutines to 1.4.2.
4 years ago
Christian Sadilek
e2d45f84e9
[fenix] Deprecate SessionManager component
4 years ago
Christian Sadilek
33b8a527ff
[fenix] Remove remaining usages of Session[Manager] in BrowserFragment
4 years ago
Christian Sadilek
70046cf635
[fenix] Refactor BrowserToolbarMenuController to use browser store
4 years ago
Arturo Mejia
99393c2d84
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/18049 Download complete dialog is not showing in custom tab.
4 years ago
Sebastian Kaspari
997b066b00
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18006 : DefaultSessionControlControllerTest: Correctly unmock SearchStateKt class.
...
The test class left SearchStateKt mocked and caused other tests to fail intermittently when
running after it.
4 years ago
Christian Sadilek
d8024b9169
[fenix] Refactor BrowserToolbarController to use browser store
4 years ago
Mugurell
7e3969c01d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17686 - Use a custom behavior to scroll InfoBanner with the top toolbar
...
Previously when the toolbar was on top the banner was inflated in the toolbar's parent - an AppBarLayout.
After migrating to use a custom behavior for scrolling the toolbar and not use
anymore the AppbarLayout for this we needed a new solution.
Using a new behavior to keep this banner in sync with the y translation of the
toolbar gives us most of the old behavior back.
4 years ago
Elise Richards
9c5bc17da9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17771 : three-dot menu reorder ( https://github.com/mozilla-mobile/fenix/pull/17838 )
...
* Feature flag for toolbar menu redesign. Add new items to menu and reorder.
* Handle toolbar items in menu controller
* Menu controller tests
* Make icons invisible
* Lint
* UI tests reflect design change
* Refactor test names
* Lint fixes
* UI tests
4 years ago
Michael Comella
2bc1605cbd
[fenix] For 17920: add ThreadPenaltyDeathWithIgnoresListener, tests, helpers.
4 years ago
Michael Comella
5836fe6f65
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17920 : add ManufacturerCodes.
4 years ago
Michael Comella
50b0c72261
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17816 : add ProfilerFactProcessor and register it, tests.
4 years ago
Codrut Topliceanu
942195bfae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17418 - Added telemetry for Google Default Top Site ( https://github.com/mozilla-mobile/fenix/pull/17637 )
...
* For https://github.com/mozilla-mobile/fenix/issues/17418 - Adds channel "ts" to TrackKey
This is used to track if the `InContentTelemetry` is a result of the user using the Google Top Site. It looks for `&channel=ts` within the uri.
* For https://github.com/mozilla-mobile/fenix/issues/17418 - Adds TopSite PerformedSearch back in
* For https://github.com/mozilla-mobile/fenix/issues/17418 - Check now looks for equality with GOOGLE_URL
* For https://github.com/mozilla-mobile/fenix/issues/17418 - Adds test for topSite changes
4 years ago
Roger Yang
f3009d5a2b
[fenix] Fix OpenSpecificTabIntentProcessorTest to remove AbstractMediaService ( https://github.com/mozilla-mobile/fenix/pull/17955 )
4 years ago
Sebastian Kaspari
ac67fc9de6
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17174 : Remove usage of old media APIs.
4 years ago
Christian Sadilek
8deddb6dcb
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17889 : Wrong tab selected/reloaded when restored from collection
4 years ago
Roger Yang
aa6190bce4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17174 : Remove the New Media Session API Feature Flag ( https://github.com/mozilla-mobile/fenix/pull/17863 )
4 years ago
Mugurell
b3930760b7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10686 - Use the AC custom behavior for both the top and bottom toolbars
...
This comes to unify the experience (with improvements but also specific issues)
for the url toolbar irrespective of it being placed at the bottom or at the top
Going further this will ease development and ensure the best UX for users.
4 years ago
Gabriel Luong
1430e127b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17418 - Add event ping telemetry for the Google Top Site click ( https://github.com/mozilla-mobile/fenix/pull/17862 )
...
Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
4 years ago
hwinnemo
36ab8d42cf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17724 : Wait for tab to be fully created before showing ETP Onboarding if ETP is active
4 years ago
Grisha Kruglov
ba388e3d88
[fenix] Exclude separators from the bookmarks UI
4 years ago
Grisha Kruglov
a1dc2c4f10
[fenix] Reuse helper functions in bookmark tests
4 years ago
Christian Sadilek
8aa8caa944
[fenix] Refactor tryReloadTabBy to use browser store
4 years ago
Roger Yang
762c10940c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17092 : Dismiss toolbar menu when configuration change occurs ( https://github.com/mozilla-mobile/fenix/pull/17682 )
4 years ago
rxu
5c17f03edb
[fenix] Pop out privacy notice in first launch in MozillaOnline builds
...
Add privacy notice related strings
Pop out privacy notice with onboarding
Using embeded geckoview to display details about privacy
Present or hide privacy pop window according to isMozillaOnline
Add activity_privacy_content_display.xml into layoutNotToTest due to EngineView
4 years ago
Codrut Topliceanu
5e78e43440
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16828 - Adds telemetry for open in app banner ( https://github.com/mozilla-mobile/fenix/pull/17049 )
...
* For https://github.com/mozilla-mobile/fenix/issues/16828 - Adds telemetry for open in app banner
Specifically: Banner displayed, Dismiss action, Go to Settings action.
4 years ago
Mihai Adrian Carare
cc56c0e127
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17655 : Do not pass threshold if showTopFrecentSites is false. ( https://github.com/mozilla-mobile/fenix/pull/17657 )
...
* For https://github.com/mozilla-mobile/fenix/issues/17655 : Do not pass threshold if showTopFrecentSites is false.
* For https://github.com/mozilla-mobile/fenix/issues/17655 : Add unit tests for getTopSitesConfig.
4 years ago
Roger Yang
bca2e3558d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17531 : Use top sites count fact for top sites telemetry ( https://github.com/mozilla-mobile/fenix/pull/17664 )
4 years ago
Roger Yang
2f2945d523
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17530 : Update has open tabs metrics when tabs are opened or closed ( https://github.com/mozilla-mobile/fenix/pull/17557 )
4 years ago
Christian Sadilek
d013bf3242
[fenix] Refactor HomeFragment to use browser store
4 years ago
Elise Richards
fcf3c5f57a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16485 : Tabs tray grid view telemetry ( https://github.com/mozilla-mobile/fenix/pull/17442 )
...
* Tabs tray CFR telemetry interactions
* Create CFR events and implementation
* Tests for tab tray controller
4 years ago
Sebastian Kaspari
086174a280
[fenix] Refactor ExternalAppBrowserActivity and ExternalAppBrowserFragment to not use Session(Manager).
4 years ago
Christian Sadilek
2ff0c55027
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17473 : Intermittent failues of PwaOnboardingObserver
4 years ago
Gabriel Luong
4c2c27d82a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17304 - Implement top site search engine attribution ( https://github.com/mozilla-mobile/fenix/pull/17580 )
4 years ago
Sebastian Kaspari
8eaf1f7a82
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/17044 : Explicitly set a new default engine when default is deleted."
...
This reverts commit 09f8e82e35f56b35865a67fd4dd4a9b0997b923d.
4 years ago
ekager
42c74bcd44
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17542 - Removes flash on renaming top site and fixes title not being updated
4 years ago
Christian Sadilek
73abe98ba7
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17548 : Remove SessionManager reference from TabTrayDialogFragment
4 years ago
Christian Sadilek
525bf428b4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17548 : Remove SessionManager reference from TabHistoryDialog
4 years ago
mcarare
2042857a3c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17044 : Explicitly set a new default engine when default is deleted.
4 years ago
Kate Glazko
e511381cf3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15181 : Remove All Downloads From Settings
4 years ago
Christian Sadilek
23496ce12b
[fenix] Refactor QuickSettingsDialog to use browser store
4 years ago
Christian Sadilek
5964b07cca
[fenix] Refactor OpenSpecificTabIntentProcessor to use browser store
4 years ago
Christian Sadilek
5e4d04bc5e
[fenix] Refactor CrashReporterFragment to use browser store
4 years ago
Christian Sadilek
f2dd0f0a18
[fenix] Remove unused SessionManager reference from RecentlyClosedController
4 years ago
Sebastian Kaspari
4e676267b7
[fenix] SearchDialogController: Pass tab ID instead of Session instance.
4 years ago
Arturo Mejia
905f243ceb
[fenix] For issue: https://github.com/mozilla-mobile/fenix/issues/16846 Add ui for controlling exceptions for auto play
4 years ago