Commit Graph

6296 Commits (073fd8939067bc7a367d8db497bcf53fbd24cdd2)

Author SHA1 Message Date
AndiAJ c9303f44b4 Improve expand/collapse collection UI test coverage 3 years ago
AndiAJ 5934c7d6b2 Improve collection deletion UI coverage 3 years ago
Grisha Kruglov 413ff7cd85 Closes #22499: Emit search group disband action on history group removal
This is needed to prevent removed search groups from coming back after
user interacts with the tab. E.g. if we don't fire this action, upon
interaction with the tab after a corresponding search group was removed
we will end up creating metadat with the deleted 'searchTerms' (they'll
be read from the 'historyMetadata' state on the tab).

At this point we probably want to start encapsulating all of this in a
use case - let's do that separately in
https://github.com/mozilla-mobile/android-components/issues/11309, and
just fix the bug for now.
3 years ago
Oana Horvath aff3e4b9dd For #21002: improves the share tabs smoke tests coverage 3 years ago
Mozilla L10n Automation Bot de30610aa6 Import l10n. 3 years ago
Arturo Mejia 7b7ef2e661 For issue #22537 crash: BookmarkFragment is attached to a context 3 years ago
Arturo Mejia 74406bef59 For issue #5298 the same page appears in the History section multiple times 3 years ago
Mugurell 888bbc770e For #22502 - Update "Jump back in" group's subtitle format 3 years ago
Mozilla L10n Automation Bot 396c51d569 Import l10n. 3 years ago
Mozilla L10n Automation Bot 708b78d3a0 Import l10n. 3 years ago
AndiAJ 378ac03e30 Improve privateTabsTrayWithOpenedTabTest UI test coverage 3 years ago
AndiAJ ec31faef7a Improve verifyOpenTabDetails UI test coverage 3 years ago
AndiAJ 4261ca7ea6 Refactor and improve coverage for empty tabs tray UI tests 3 years ago
Mozilla L10n Automation Bot f0a3653d7b Import l10n. 3 years ago
Grisha Kruglov 63154a18f9 Closes #22484 - Track direct loads per tab; fix search term lookup
This patch fixes two problems:
1) We were treating "direct tab load" as an event which applies
   uniformally to all tabs, even though it's actually an event which
   happens for a specific tab. This lead to background tabs (pages opened as new tab)
   setting the direct load flag, and then a simultaneously loading
   parent tab would incorrectly interpret that flag for itself.

   The patch switches this tracking from a simple boolean (are we direct
   loading?) to a set of tab IDs that are currently direct loading.

2) In a case when a background tab was loading with a parent who's
   search terms were cleared by a direct load, we were not trying to
   lookup search terms on the background tab's historyMetadata key,
   which exists to capture search terms for this exact scenario.

   The patch adds an additional fallback lookup for that path.
3 years ago
Oana Horvath 4892f0ddbe For #21002: add missing steps to selectSearchEnginesShortcutTest, addPredefinedSearchEngineTest 3 years ago
Grisha Kruglov 77672dfa15 Post: move group removal logic into PagedHistoryProvider
This moves the group removal logic to the place where the groups are
actually formed. This helps clean-up the fragment code a bit, and
removes the awkward 'allow mutate some random internal state' API from
the provider.
3 years ago
Grisha Kruglov 45d4807bfe Closes #22472: Filter out redirects from History search groups 3 years ago
AndiAJ 2c9efac286 Improve mainMenuAddToHomeScreenTest UI test coverage 3 years ago
AndiAJ e265da0cb4 startOnLastTab UI smoke test 3 years ago
AndiAJ 4ff64ad7ca recentBookmarksOption UI smoke test 3 years ago
AndiAJ eee83c9cbd jumpBackInOption UI smoke test 3 years ago
AndiAJ 7460461e16 startOnHomepageTest refactoring work 3 years ago
Mozilla L10n Automation Bot 364fecf9d4 Import l10n. 3 years ago
Christian Sadilek 8c88561d4b Update lastAccess timestamp of selected tab when launching to home 3 years ago
Roger Yang 24e4452cb5 Close #22402: Add top placeholder for home 3 years ago
Noah Bond dde916038d
MR2 Telemetry: Homescreen view count (#22377)
* For #22146 - Added counter for home screen views

* For #22146 - Added PR number to metrics

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Mugurell d4a6facd81 For #22155 - Store inactive tabs count telemetry when user opens tabs tray
Setting this value in FenixApplication.onCreate was buggy because of a race
with restoring BrowserState.
Setting it here would ensure a better granularity of the events and so to more
accurate reporting.
3 years ago
Mugurell 17865bdf66 For #22147 - New search term groups telemetry 3 years ago
AndiAJ f91285881d Improve homeThreeDotMenuItemsTest UI test coverage 3 years ago
Mozilla L10n Automation Bot f466d65256 Import l10n. 3 years ago
Arturo Mejia 94a543a403 For #22271 Improve URL accessing from the clipboard for Android 12 and above. 3 years ago
Mugurell c42ccb4966 For #22388 - Update content description of the delete button 3 years ago
Mozilla L10n Automation Bot abcafa55f0 Import l10n. 3 years ago
Mozilla L10n Automation Bot d29fd55c8b Import l10n. 3 years ago
Oana Horvath ba91180e85 No issue: creates new SmokeTest annotation.
Updates smoke tests list according to the ones in TestRail.
3 years ago
Mozilla L10n Automation Bot b0ad98a204 Import l10n. 3 years ago
Noah Bond 811f255b71
MR2 Telemetry: Opening screen preference (#22333)
* For #22145 - Added telemetry to the opening screen preference.

* For #22145 - Added PR number to metric

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Noah Bond 2e5555d034
MR2 telemetry - Inactive tabs CFR (#22301)
* For #22298 - Added telemetry to inactive tabs CFR

* For #22298 - added PR issue number to metrics

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Jonathan Almeida e3b6e00331 Close #22223: Move to the selected page when switching modes 3 years ago
Mozilla L10n Automation Bot 210587b735 Import l10n. 3 years ago
Grisha Kruglov 9a4a4713ac No issue: clean up code duplication in PagedHistoryProvider 3 years ago
AndiAJ 1ade096145 For #22256 re-enable editCustomSearchEngineTest UI test 3 years ago
Ben Dean-Kawamura df953b0021 Make findDuplicate() suspend
findLoginToUpdate() should be suspend, but I didn't get mark it that way
on the initial logins work.  Let's make this one suspend, then I can
update findLoginToUpdate() in a-c.
3 years ago
Mozilla L10n Automation Bot e52000bb20 Import l10n. 3 years ago
Jonathan Almeida 8ced675817 No issue: Correct TabsTrayAction naming 3 years ago
Jonathan Almeida 08b15689b1 Close #22305: Use TabsTrayStore for populating adapters 3 years ago
Jonathan Almeida f16300392d Close #22305: Add tab state into the TabsTrayStore 3 years ago
Michael Comella c026d8b28a For #21084: put git hash on About screen in release builds. 3 years ago
AndiAJ f4e7547190 Improve verifyEmptyTabTray Ui test coverage 3 years ago
Mugurell 953f6feb17 For #22155 - The inactiveTabsCount probe reports actualInactiveTabs number 3 years ago
Mugurell f9b67091c6 For #22155 - New BrowserState.actualInactiveTabs public method
This allows querying from all throughout the app which of the current tabs are
inactive while taking into consideration whether the feature is enabled or not
such that when the feature is disabled it will always return an empty result.
3 years ago
Mozilla L10n Automation Bot 2089c29fea Import l10n. 3 years ago
Grisha Kruglov 81b70122d4 No issue: rename test resource file that was causing issues on Windows 3 years ago
Mozilla L10n Automation Bot 8c2cdaa3ff Import l10n. 3 years ago
Mozilla L10n Automation Bot 06f57fdcfe Import l10n. 3 years ago
mike a d69b5ed456 For #21816: Filename in "Open" PDF dialog overflows screen
Changing the download file name length to the max allowed by AS (251 char, won’t compile if more; max would be 260 for latest windows versions, but generally it is 255), and changing the UI test to check if the long file name is fully visible.
Changing the downloaded dialog layout to properly display really long file names.
3 years ago
Grisha Kruglov 5b889fdb96 For #22342: Make layout constraint for 'recent bookmarks' the same as other sections 3 years ago
Sebastian Kaspari 8c9f0c835a Closes #21695: ThreadPenaltyDeathWithIgnoresListener: Ignore stack traces containing InstrumentationHooks class 3 years ago
Mozilla L10n Automation Bot 7e66c02363 Import l10n. 3 years ago
Roger Yang 04618983aa Close #22299: Add history search term group telemetry 3 years ago
Grisha Kruglov 294997e559 No issue: history view search group missing
Our boundary conditions for matching search groups to visits was wrong.

This change switches the boundary buffer to only be applied to history
items, not the metadata items.

In other words, when checking if any of the metadata items match the
current "page" of history, we'll be looking to see if the item falls
within this time window:
buffer - oldest history item <= metadata item <= newest history item +
buffer

There's a separate problem with buffer though: it's reset to 0 when requested
offset is >0, but that requires a larger refactor of this code, for a
separate PR.
3 years ago
Oana Horvath 4d88c521ac For #22304 & #22256: Disabled failing visitedUrlHistoryTest & editCustomSearchEngineTest tests 3 years ago
Mozilla L10n Automation Bot ed0389abe3 Import l10n. 3 years ago
Michael Comella 7d67b84a92 For #22177: add SearchDialogFragmentConstraintLayout; has markers.
Here's a profile with these changes: https://share.firefox.dev/3vTpZha
3 years ago
Michael Comella bc6d8be9c1 For #22177: change onMeasure/onLayout markers into a single track + draw.
When you want to look at one of these markers, you usually want to look
at all three so I found that having them on a single track was easier to
follow. Since they run in sequence, they should never overlap and that
should minimize confusion.
3 years ago
Michael Comella ed8f2c0bc3 For #22177: rename RootLinearLayout -> HomeActivityRoot...
This is so we can be more specific with the detail text in our markers.
3 years ago
Elise Richards 4f55f16bd7
For #21313: Remove expiring/unused metrics for December (#21789)
* Remove crash reporter metrics

* Remove tab counter menu item probe

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Christian Sadilek 76bb0c3b37 Closes #21659: Add SERPs to history search groups 3 years ago
Noah Bond 8caefbe2d5
Recent bookmark count telemetry (#22293)
* For #22075 - Added event to track the count of recent bookmarks

* For #22075 - Added data review issue number

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Arturo Mejia cff78afe27 For #22078 Selecting search group in Jump back in switches active tab 3 years ago
Matt Boris 1809bea49d For #22281 Fix studies opt out learn more link 3 years ago
Gabriel Luong 6747e9d554 For #21973 - Remove @color/search_suggestion_indicator_icon_color_dark_theme redirection 3 years ago
Gabriel Luong baa8c6582a For #21973 - Remove @color/accent_dark_theme redirection 3 years ago
Gabriel Luong 6770a70bdd For #21973 - Remove @color/foundation_dark_theme redirection 3 years ago
Gabriel Luong f7f942f2d9 For #21973 - Remove @color/tab_tray_selected_mask_dark_theme redirection 3 years ago
Gabriel Luong d6002f3307 For #21973 - Remove @color/tab_tray_item_thumbnail_icon_dark_theme redirection 3 years ago
Gabriel Luong b7c3d0ec5a For #21973 - Remove @color/tab_tray_item_thumbnail_background_dark_theme redirection 3 years ago
Gabriel Luong e304885581 For #21973 - Remove @color/tab_tray_heading_icon_menu_dark_theme redirection 3 years ago
Gabriel Luong 8d9550a6a7 For #21973 - Remove @color/tab_tray_item_media_background_dark_them redirection 3 years ago
Gabriel Luong 2b996a607c For #21973 - Remove @color/tab_tray_item_divider_dark_theme redirection 3 years ago
Gabriel Luong 19a947240b For #21973 - Remove @color/tab_tray_toolbar_background_dark_theme redirection 3 years ago
Gabriel Luong 3fd6f4c420 For #21973 - Remove @color/tab_tray_item_background_dark_theme redirection 3 years ago
Gabriel Luong ee59848064 For #21973 - Remove @color/tab_tray_item_url_dark_theme redirection 3 years ago
Gabriel Luong 498d8ccc19 For #21973 - Remove @color/tab_tray_item_text_dark_theme redirection 3 years ago
Michael Comella 0c079fde91 Closes #22213: add marker for LayoutInflater.inflate.
Here is a profile with this change: https://share.firefox.dev/3mlQSHu
3 years ago
Arturo Mejia 5a11985d22 No issue: Address tracking protection exceptions breaking changes 3 years ago
AndiAJ 1066acbe1e Improve deleteBookmarkInEditModeTest UI test coverage 3 years ago
Mozilla L10n Automation Bot 3f7cd1be8c Import l10n. 3 years ago
Arturo Mejia 2061779938 For #22170 record auto-close prompt telemetry events 3 years ago
Roger Yang 930599407c No issue: Show snackbar when opening non-http URL 3 years ago
Noah Bond a06b04ec6d
MR2 Telemetry: Recent tabs section probe (#22166)
* For #22107 - Added probe to track if the Recent tabs / jump back in section is visible

* For #22107 - Fixed lint errors

* For #22107 - added data review number to metric

* For #22166 - fixed expiration date

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Gabriel Luong 9a53a12c57 For #21973 - Remove @color/onboarding_illustration_deselected_dark_theme redirection 3 years ago
Gabriel Luong e586d27983 For #21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_dark_theme redirection 3 years ago
Gabriel Luong 5c32efa9a3 For #21973 - Remove @color/preference_section_header_dark_theme redirection 3 years ago
Gabriel Luong 0cb91151b1 For #21973 - Remove @color/prompt_login_edit_text_cursor_color_dark_theme redirection 3 years ago
Gabriel Luong f436d3ef02 For #21973 - Remove @color/add_on_private_browsing_interior_icon_background_dark_theme redirection 3 years ago
Gabriel Luong 90fd1ea363 For #21973 - Remove @color/add_on_private_browsing_exterior_circle_background_dark_theme redirection 3 years ago
Gabriel Luong 830ade29f9 For #21973 - Remove @color/sync_disconnected_background_dark_theme redirection 3 years ago
Gabriel Luong eb6de2b21c For #21973 - Remove @color/sync_disconnected_icon_fill_dark_theme redirection 3 years ago
Gabriel Luong c9afe46dd6 For #21973 - Remove @color/toolbar_[start|center|end]_gradient_dark_theme redirection 3 years ago
Gabriel Luong 6923a27be7 For #21973 - Remove @color/toolbar_divider_color_dark_theme redirection 3 years ago
Gabriel Luong 37058f596e For #21973 - Remove @color/swipe_delete_background_dark_theme redirection 3 years ago
Gabriel Luong 3cf985d09c For #21973 - Remove @color/onboarding_illustration_selected_dark_theme redirection 3 years ago
Gabriel Luong d71447a691 For #21973 - Remove @color/onboarding_card_background_[start|end]_gradient_dark_theme redirection 3 years ago
Gabriel Luong 075f3a3dd9 For #21973 - Remove @color/disabled_dark_theme redirection 3 years ago
Gabriel Luong 25592dc25c For #21973 - Remove @color/shadow_dark_theme redirection 3 years ago
Gabriel Luong 35a235c598 For #21973 - Remove @color/neutral_faded_dark_theme redirection 3 years ago
Gabriel Luong 2f4e0e14ba For #21973 - Remove @color/neutral_dark_theme redirection 3 years ago
Gabriel Luong b682f2d5c5 For #21973 - Remove @color/tab_ring_dark_theme redirection 3 years ago
Gabriel Luong 7019e32f40 For #21973 - Remove @color/scrimEnd_dark_theme redirection 3 years ago
Gabriel Luong ee96021f19 For #21973 - Remove @color/scrimStart_dark_theme redirection 3 years ago
Gabriel Luong d516eefb1d For #21973 - Remove @color/recently_used_share_menu_dark_theme redirection 3 years ago
Gabriel Luong ec259fbfd7 For #21973 - Remove @color/tab_history_item_selected_background_light_theme redirection 3 years ago
Gabriel Luong dff26e0ce1 For #21973 - Remove @color/menu_item_button_light_theme redirection 3 years ago
Gabriel Luong e50a2b3cb3 For #21973 - Remove @color/search_suggestion_indicator_icon_bookmark_color_light_theme redirection 3 years ago
Gabriel Luong f5f96d8766 For #21973 - Remove @color/search_suggestion_indicator_icon_color_light_them redirection 3 years ago
Gabriel Luong 679d7e5161 For #21973 - Remove @color/prompt_login_edit_text_cursor_color_light_them redirection 3 years ago
Jonathan Almeida 9bb49585ea No issue: Merge our inactive tab interactor/controllers 3 years ago
Jonathan Almeida f363b145f2 No issue: Remove unused InactiveTabState code 3 years ago
Mugurell 207e85e59d For #22155 - Inactive tabs count telemetry
A quantity probe in the metrics ping means we'll loose the granularity events
provided but it will be easier to extract the values.

For reporting whether the inactive tabs feature is enabled or not we already
have the "preferences.inactive_tabs_enabled" probe so I didn't duplicate this.
3 years ago
Roger Yang a46905b5e7 Issue #22057: Add search term groups telemetry 3 years ago
Christian Sadilek 687209fee8 Introduce test rule to work around intermittent mockk failures 3 years ago
AndiAJ ff0befdd1d Improve coverage for cancelCreateBookmarkFolderTest UI test 3 years ago
AndiAJ 979d8a79cd For #18421 re-enable verifyContextOpenImageNewTab, verifyContextOpenLinkNewTab & verifyContextOpenLinkPrivateTab UI tests 3 years ago
Mugurell 018fe15072 For #22138 - Install source metrics probe 3 years ago
Mugurell 9cce30b824 For #22226 - Open grouped history entries the same as individual ones 3 years ago
Roger Yang 4e5c9a3440 Close #22172: Add Recent searches telemetry 3 years ago
Roger Yang 9c970a5276 Close #22103: Add recent bookmarks telemetry 3 years ago
Mozilla L10n Automation Bot b698d6ac77 Import l10n. 3 years ago
Elise Richards e4cc22fb71 For #22175: Telemetry event for deleting a search term group from the recent searches section on home 3 years ago
Jonathan Almeida 8c43ccc0f6 Issue #20704: Use AppStore for inactive expanded state 3 years ago
Jonathan Almeida 9cef9357b1 Close #20704: Add AppStore to Components 3 years ago
Oana Horvath cee72a965b For #21397: disabled homescreen features to improve collections visibility 3 years ago
Arturo Mejia 940af156eb For #22192 add telemetry for studies 3 years ago
Mozilla L10n Automation Bot f3bf56ac60 Import l10n. 3 years ago
Mozilla L10n Automation Bot ef43107e67 Import l10n. 3 years ago
Mozilla L10n Automation Bot 57c375cea2 Import l10n. 3 years ago
Gabriel Luong e3e0b9c207
For #21973 - Reduce redirection of colors variables between dark and light theme - Part 3 (#22220)
* For #21973 - Remove @color/disabled_light_theme redirection

* For #21973 - Remove @color/scrimStart_light_theme redirection

* For #21973 - Remove @color/scrimEnd_light_theme reddirection

* For #21973 - Remove @color/synced_tabs_separator_light_theme redirection

* For #21973 - Remove @color/toolbar_[start/center/end]_gradient_light_theme redirection

* For #21973 - Remove @color/toolbar_divider_color_light_theme redirection

* For #21973 - Remove @color/fill_link_from_clipboard_light_theme redirection

* For #21973 - Remove @color/sync_disconnected_icon_fill_light_theme redirection

* For #21973 - Remove @color/sync_disconnected_background_light_theme redirection

* For #21973 - Remove @color/swipe_delete_background_light_theme redirection

* For #21973 - Remove @color/onboarding_illustration_selected_light_theme redirection

* For #21973 - Remove @color/onboarding_illustration_deselected_light_theme redirection

* For #21973 - Remove @color/add_on_private_browsing_exterior_circle_background_light_theme redirection

* For #21973 - Remove @color/add_on_private_browsing_interior_icon_background_light_theme redirection

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Mozilla L10n Automation Bot c2f0b574fd Import l10n. 3 years ago
Oana Horvath f6b83e37b1 For #15624 & #17484: improves tab drawer locator & avoids homescreen refreshing 3 years ago
Gabriel Luong a99b7d3f71 For #21973 - Remove @color/destructive_light_theme redirection 3 years ago
Gabriel Luong 1eb41ff558 For #21973 - Remove @color/shadow_light_theme redirection 3 years ago
Gabriel Luong 9331b971f8 For #21973 - Remove @color/neutral_faded_light_theme redirection 3 years ago
Gabriel Luong 58e9d3dd08 For #21973 - Remove @color/neutral_light_theme redirection 3 years ago
Gabriel Luong 7c9ae669aa For #21973 - Remove @color/tab_ring_light_theme redirection 3 years ago
Gabriel Luong 00b4688fd5 For #21973 - Remove @color/accent_high_contrast_light_theme redirection 3 years ago
Gabriel Luong cb92e48c0d For #21973 - Remove @color/about_link_dark_theme redirection 3 years ago
Gabriel Luong fe0affa167 For #21973 - Remove @color/above_light_theme redirection 3 years ago
Gabriel Luong 2336f9d9d6 For #21973 - Remove @color/caption_text_light_theme redirection 3 years ago