Commit Graph

5082 Commits (fix-addon-search)

Author SHA1 Message Date
Sebastian Kaspari 776b64f959 Issue #16435: Finish ExternalAppBrowserActivity and remove task if linked tab doesn't exist anymore.
This doesn't fix the underlying issue of #16435, but a symptom we have seen quite often in different
situations: When the ExternalAppBrowserActivity is not linked to a tab anymore then it falls back
to displaying a (partially broken) browser UI. With multiple browser activities at the same time
sooner or later we crash with a "display already acquired" error because both activities try to
render the same tab.
4 years ago
mcarare 0bd3654bc7 For #16759: Prevent crash on showing info banner. 4 years ago
Sebastian Kaspari 055c76b7ba FenixApplication: Remove unused kinto endpoint. 4 years ago
Sebastian Kaspari 23edda5f65 Introduce build flag for configuring test build type. 4 years ago
Sebastian Kaspari 0a419efa92 Introduce build flag for disabling optmization. 4 years ago
Sebastian Kaspari d84b8ebdc6 Issue #12731: Log and record breadcrumb when onTrimMemory() gets invoked. 4 years ago
Mozilla L10n Automation Bot e8fa1a66f0 Import l10n. 4 years ago
Adam Novak 0c69f4b580 Drop exception stubs because GeckoView now drags in the conflicting real ones 4 years ago
Adam Novak 6116d814cc Merge tag 'v83.1.0' into upstream-sync3 4 years ago
Mozilla L10n Automation Bot 7e56b0cd53 Import l10n. 4 years ago
Mozilla L10n Automation Bot 806ed78b7f Import l10n. 4 years ago
Oana Horvath c8f8e2e665 Updates to UI tests using the modified recyclerViewIdlingResources minItemCount 4 years ago
Oana Horvath 894b25855e For #16615: UI smoke test toggleSearchSuggestions 4 years ago
Mozilla L10n Automation Bot 2e676a047d Import l10n. 4 years ago
Mihai Adrian Carare b2b558fe39
For #16745 - Allow preference layout to increase height if needed. (#16752) 4 years ago
Mihai Adrian Carare 34b4dad614
For #16735 - Do not show grid view CFR if grid view is already selected. (#16740) 4 years ago
ekager d49d710343 For #16676 - Do not switch mode on last private tab via tab context menu 4 years ago
Mozilla L10n Automation Bot 94c59cb3ca Import l10n. 4 years ago
Oana Horvath 2d652acbf2 For #16615: UI smoke test addPredefinedSearchEngineTest 4 years ago
Mozilla L10n Automation Bot 23460fac51 Import l10n. 4 years ago
Codrut Topliceanu 4b56aeb12f
For #16592 - Fix missing collection snackbar for a11y (#16593)
Set null anchor for snackbar when using a11y services
4 years ago
Mozilla L10n Automation Bot f89f6fd2a2 Import l10n. 4 years ago
mcarare f823a5d246 For #16353: Avoid strict mode death on reading onboarding preference. 4 years ago
mcarare de1fa74ac1 For #16353: Add unit tests for onboarding finishing conditions. 4 years ago
mcarare 089c79f868 For #16353: Finish onboarding on loading a web page, with exceptions. 4 years ago
mcarare 451f60b095 For #16353: Do not finish onboarding on search dialog opening. 4 years ago
Mozilla L10n Automation Bot c5b9491619 Import l10n. 4 years ago
Mozilla L10n Automation Bot 7166cf2b48 Import l10n. 4 years ago
Mozilla L10n Automation Bot 9cd2757502 Import l10n. 4 years ago
ekager b9737bde95 For #16351 - Add divider lines for search dialog 4 years ago
Sebastian Kaspari 2b759e9d6f Integrate new search code from Android Components into Fenix. 4 years ago
MickeyMoz 2904ca8ac0 Update Android Components version to 68.0.20201120125142. 4 years ago
Mozilla L10n Automation Bot 4e598d16fc Import l10n. 4 years ago
mcarare 36475fc3fe For #15788: Remove fixed issues from lint baseline. 4 years ago
jhugman 9cdfb6db4a
Nimbus Global Opt Out (#16543) r=gl 4 years ago
Mozilla L10n Automation Bot 359759753c Import l10n. 4 years ago
ekager b7fe809ae4 For #16351 - Make homescreen interactive when search dialog is up 4 years ago
mcarare 519885da43 For #15788: Remove nested constraint layout in tabs tray. 4 years ago
mcarare cf162c69d1 For #15788: Remove nested layouts in search dialog layout. 4 years ago
Oana Horvath 2d6d49324e For #16615: UI smoke test firstRunScreenTest 4 years ago
mozilla-l10n-automation-bot 01ec558811
Import l10n. (#16625) 4 years ago
Jonathan Almeida cebab81e07
Update Android Components to 67.0.20201117165227 (#16619) 4 years ago
ekager f520586dcd
For #12062 - Remove feature flag for return to browser (#16622) 4 years ago
Mugurell ef5846dc3e
For #16614 - Ensure a stable order for the items in tabs tray. (#16618)
Items should follow the following ordering:
- current session open tabs
- collections options - currently the "Select tabs" button
- synced tabs items

This order should also be kept after returning from Multiselect mode.
4 years ago
Bryan Kok 5f9de1e261 Replace @string/tab_tray_menu_item_save with @string/tab_tray_menu_select, Remove "Share all tabs" option from tab tray's private browsing menu 4 years ago
ekager 614471495d
For #15091 - Fixes RecentlyClosedAdapter DiffCallback (#16608) 4 years ago
Mozilla L10n Automation Bot edfb85b021 Import l10n. 4 years ago
Christian Sadilek 1d5f74d865 Closes #16153: Intermittent failures of ShareControllerTest.handleShareToApp 4 years ago
mcarare 0d37c8f268 For #16420: Make search bar first view focused by a11y services on open. 4 years ago
Christian Sadilek 88f3f3564e Issue #16587: Make sure tab counter correctly reflects private/normal tab counts 4 years ago
Christian Sadilek fbbc25b54e Closes #16053: Fix crash when closing private tabs via notification 4 years ago
MickeyMoz 2c4f0624fd Update Android Components version to 67.0.20201115143123. 4 years ago
Mozilla L10n Automation Bot 4895cf4e91 Import l10n. 4 years ago
Jonathan Almeida 78715c3020
For #13477 - Move BiometricPrompt to a separate feature (#16498)
Instead of simply fixing the memory leak for this issue by directly
removing references, it makes more sense to move the whole
BiometricPrompt out of the fragment and into it's own feature to be
re-usable.
4 years ago
Mihai Adrian Carare 85dd2f8313
For #16511 - Change a11y parent of button without breaking the tab list. (#16555) 4 years ago
Mozilla L10n Automation Bot af666d8c57 Import l10n. 4 years ago
Michael Comella 94bbf90f3c No issue: move TestStrictModeManager to perf sub package. 4 years ago
Michael Comella e8bf955893 No issue: move StrictModeManager to perf package.
While StrictMode is not exclusively used for performance purposes, it's
primarily used for perf purposes so let's move it to the perf package
and code owner it.
4 years ago
Michael Comella 72ab058551 For #16376: move Startup*Test to perf pkg under code owners.
Instead of listing many different files here, we should just put them in
/perf/ packages and code owner them.
4 years ago
Michael Comella 54c7dc70e7 For #16376: assert num ConstraintLayout direct descend RecyclerView.
I'm not convinced this is a useful test because the performance
characteristics seem unfortunately nuanced: if the test fails, it implies
you shouldn't add more but that isn't necessarily true (for example, if
your RV child has a large depth). Furthermore, we haven't measured in a
variety of circumstances that layouts like LinearLayout perform better
as RecyclerView children so maybe it only held for the one small case we
used it in.
4 years ago
Michael Comella b0a1e0884e For #16376: test view hierarchy depth in StartupExcessive*Test. 4 years ago
Jocelyne Abi Haidar 88233ef42d For #15725: Set up preferences in onCreatePreferences instead of onResume
set up preferences in onCreatePreferences instead of onResume so that their visibility is determined before the screen appears rather than after
4 years ago
Oana Horvath 10dadb838e Closes #12899: fixed UI test for ETP off 4 years ago
mcarare d45bdfb0f4 For #16477: Switch to using an extension to update a11y collection info. 4 years ago
mcarare e2322a18f9 For #16477: Migrate updateAccessibilityCollectionItemInfo to extension. 4 years ago
mcarare b52f069573 For #16477: Update a11y info to collection item for both grid and list. 4 years ago
Bryan Kok 92b93081e5
Replace lingering occurence of ic_hollow_share with ic_share_filled (#16548) 4 years ago
Mugurell c6de8632de
For #16461 - Ensure the proper items order after exiting Multiselect (#16482) 4 years ago
LeoMaldonado a06b30a73d Fixes Comment on #16563: DefaultToolbarMenu registering for bookmark changes
comment link: https://github.com/mozilla-mobile/fenix/pull/16536#discussion_r522387945
4 years ago
LeoMaldonado 2d8fe7a9ad Closes #16345: Update share icon shape
updating share icon to a filled shape, like default toolbar menu across all app
4 years ago
LeoMaldonado 84eda3d38f For #16345: use same share icon across all app
replace mozac_ic_share for ic_hollow_share on DefaultToolbarMenu
4 years ago
Gabriel Luong 27ee2ba4f6
For #15761 - [Grid View] Enable the grid view and remove its feature flag (#16546)
* For #15761 - Part 1: Turn ON the showGridViewInTabsSettings feature flag

* For #15761 - Part 2: Remove the showGridViewInTabsSettings feature flag and show the Tab view preference category
4 years ago
mozilla-l10n-automation-bot 6ebc90deae
Import l10n. (#16486) 4 years ago
Gabriel Luong e9d335cb24
Revert "For #15761 - [Grid View] Enable the grid view and remove its feature flag (#16535)" (#16544)
This reverts commit 7499d33b32.
4 years ago
rxumoz 409041ae3b
For #16451 - Change default top sites to Baidu & JD in China build (#16515)
* Add top sites related strings

* Change default top sites to Baidu & JD in China build
4 years ago
Gabriel Luong 7499d33b32
For #15761 - [Grid View] Enable the grid view and remove its feature flag (#16535) 4 years ago
Mugurell d1f2705d99
For #16076 - Link data review for the share_image telemetry (#16534) 4 years ago
ekager 1ed9ebf622 For #16132 - Rename normal mode menu item, remove telemetry 4 years ago
Arturo Mejia 424370a364
For #14772: Crash in Downloads (#16531)
Co-authored-by: Kate Glazko kglazko@mozilla.com
4 years ago
Gabriel Luong ebadbdb352
For #14920 - Show a Tabs Tray CFR Banner for grid view tip (#16466) 4 years ago
Sebastian Kaspari 5530e102f1
For #16302 - Use larger heap size when running unit tests and fork new process after every 80 test classes. (#16526) 4 years ago
Codrut Topliceanu f3edce5f16
For #11376 - Reverse tabs list order (#16245) 4 years ago
Oana Horvath ae407a7367 Closes #13217: fixed UI test for main menu items 4 years ago
Johan Lorenzo 4570f5a14f Revert "Update Android Components version to 66.0.20201111143206."
This reverts commit dbdb68ac72.
4 years ago
Kate Glazko 6c68e79a22 For #14772: Crash in Downloads 4 years ago
Mugurell a097b135b3 For #16076 - Add new "share_image" telemetry event 4 years ago
MickeyMoz dbdb68ac72 Update Android Components version to 66.0.20201111143206. 4 years ago
Mugurell c3179512de
For #16500 - Ensure CardView clips ImageView on lower APIs (#16507)
ImageViews are normally not clipped but extend to cover the entire width and
height set.
CardViews as a parent can help with that but on lower APIS they still need a
shapeAppearance which is a property already in the added style.
4 years ago
Stefan Arentz 086386e8f6
String import to releases/v83 (2020-11-11) (#16504)
* Import l10n.

(cherry picked from commit 5739140ff3)

* Import l10n.

(cherry picked from commit bf69519dc9)

* Import l10n.

(cherry picked from commit e61e5b80dd)

* Import l10n.

(cherry picked from commit 1ad5ea58a2)

Co-authored-by: Mozilla L10n Automation Bot <release+l10n-automation-bot@mozilla.com>
4 years ago
mcarare c427ebf8d5 For #16416: Remove save to collection button from tab a11y list. 4 years ago
ekager a8db85fc22 For #16132 - Revise multiselect mode UI 4 years ago
mozilla-l10n-automation-bot c8aee39db1
Import l10n. (#16468) 4 years ago
Mugurell 5e58377948
For #16424 - Focus the right item in tabs tray when using Talkback (#16472)
To get the index of the current selected browser tab when using reverse layout
we should also account for items placed below of the browser tabs.
The patch here unifies the logic already used for some calls but not all.
4 years ago
Codrut Topliceanu 6e4393a199
For #15720 - Remove unused telemetry (#15887) 4 years ago
Gabriel Luong b5c25ccf3b
For #15960 - Enable Grid View in Nightly only (#16462) 4 years ago
mcarare 928d320836 For #16426: Allow multiselect title to be selected by a11y services. 4 years ago
mozilla-l10n-automation-bot 517ff91753
Import l10n. (#16447) 4 years ago
Christian Sadilek 0fbc8410a4 Closes #16430: ExternalAppBrowserActivity should not handle incoming intents 4 years ago
Adam Novak ebbf9bb352 Merge remote-tracking branch 'upstream/releases/v83.0.0' into upstream-sync2 4 years ago
Adam Novak 0082e32088 Suppress Mozilla's new lint errors 4 years ago
mozilla-l10n-automation-bot 2fb7383684
Import l10n. (#16441) 4 years ago
Mihai Adrian Carare c641ed72dc
For #15764 - Update Tabs summary description. (#16428) 4 years ago
Christian Sadilek 96e2123f86
Update Android Components version to 66.0.20201106143126 (#16439) 4 years ago
Oana Horvath 5e745d0bc3 For #15847: use Espresso's RecyclerView scrollTo action 4 years ago
Mozilla L10n Automation Bot 1ad5ea58a2 Import l10n. 4 years ago
Christian Sadilek 4abd399002 Closes #16327: Refactor MenuPresenter to use browser store 4 years ago
Arturo Mejia 50d7792330 For issue #15934 fix ConcurrentModificationException
on WifiConnectionMonitor
4 years ago
Sebastian Kaspari 1dca411515 Fix GeckoProvider for beta and release variant. 4 years ago
rxu 686f7bd7c6 Add mozcn safebrowsing 4 years ago
Michael Comella afa080c956 For #15279 - review: set LazyMonitored to private. 4 years ago
Michael Comella c96e16112f For #15279: add component init count to StartupExcessiveResourceUseTest. 4 years ago
Michael Comella 090650485f For #15279: remove redundant lazy wrapper from storage APIs.
They're currently lazy { lazy { value } }. Accessing `lazy.value`
directly allows us to make it lazy { value }. This should be more
performant and prevents us from double-counting these components.
4 years ago
Michael Comella 89541a17f7 For #15279: LazyMonitored implement Lazy + update built-in API use.
By having LazyMonitored implement Lazy, we can continue to pass these
values directly into the ac APIs that require Lazy references. For some
reason, implementing `Lazy.value` can replace `operator fun getValue`
required for delegates.
4 years ago
Michael Comella 901c78684c For #15279: replace lazy with lazyMonitored in component groups.
By component groups, I mean I applied this to any class with the
class kdoc, "Component group for...".

There are a few instances of lazy we had to keep using the old API to
avoid having to update constructor arguments.
4 years ago
Michael Comella f37ace0630 For #15279: add LazyMonitored and tests. 4 years ago
mozilla-l10n-automation-bot de3c4bc635
Import l10n. (#16380) 4 years ago
Kate Glazko 0ae268914b For #352: Delete a download 4 years ago
ekager c0e01373e1 No issue: Update stable androidx and material versions 4 years ago
Mugurell 88bfaaabe7
For #6521 - Remove auto sigin onboarding card (#16315)
With the Fennec -> Fenix migration complete there is no other Mozilla
application that would serve as a custom account provider hence the automatic
signin would not be possible.
Make this more obvious by commenting out the code that would trigger an
onboarding banner for it but keep the code in the app for when #15694 would add
to Fenix the ability to serve as a custom account provider.
4 years ago
Mugurell 1358e09d7e
For #16323 - Use 10dp corner radius for the selected outer border of a grid item (#16364)
This would ensure the corners of the inner and outer borders are aligned, with
no empty gap between them.
4 years ago
Mugurell 172977f698
For #14980 - Effectively disable tabs tray STATE_HALF_EXPANDED (#16052)
STATE_HALF_EXPANDED cannot be disabled while also keeping fitToContents = true
based on which the tabs tray layout is currently set.
To work around this we'll set a a minuscule height for the tab tray when in
this state and then immediately advance to STATE_HIDDEN so to make it
imperceptible to the users.
Since I couldn't write unit tests because of InflateExceptions in Robolectric
I've written UI tests to protect against regressions.
4 years ago
Mihai Adrian Carare db58022fbb
For #13172 - Tab swipe order follows text direction from oldest to newest (#16178) 4 years ago
Rafał Opiłowski 96fb9f4676
For #12971 - Show collection saved snackbar above FAB (#16311) 4 years ago
Oana Horvath c3204b7644
For #15847 - Disables verifyAboutFirefoxPreview UI test (#16346) 4 years ago
Stefan Arentz ed01490512
Uplift #16267 - Make sure we are cleaning up test coroutines (#16350)
Co-authored-by: ekager <emilykager@gmail.com>
4 years ago
Mugurell 34f0c84d46
For #16339 - Initialize FxaAccountManager with also a CrashReporter (#16340) 4 years ago
Sebastian Kaspari baaa85db80 Closes #16256: Introduce build flag for "Mozilla Online" variant.
This patch introduces a build flag that can be used on demand on the command line (`./gradlew -PmozillaOnline [..}`) or
permanently when added to local.properties (`mozillaOnline`).

At runtime `Config.channel.isMozillaOnline` will return `true` if the flag was set at build time.
4 years ago
Oana Horvath 4ff2635423 For #13446 UI tests: wait for historyList to exist 4 years ago
Mozilla L10n Automation Bot e61e5b80dd Import l10n. 4 years ago
Gabriel Luong 2bd2a5651d
For #14636 - Update preference section headers to use correct color, spacing and rulers (#16332) 4 years ago
Michael Comella 2b621fcb1b No issue - review: clarify thread safety of suppressionCount. 4 years ago
Michael Comella bff8a0d6a7 No issue: make StrictMode suppression count thread safe. 4 years ago
Christian Sadilek d7688c8427 For #12062: Switch to consumeFlow and add tests 4 years ago
ekager bd2c407943 For #4652 - Remove activityViewModels workarounds 4 years ago
MarcLeclair 7b1af41b40
15278 detekt rule runblocking (#15942)
* For #15278: added CoroutineManager to count runBlocking calls

* For #15278: Added actual detekt rule for runblocking and its config to the yaml

* For #15278: Added unit test for RunblockingCounter

* For #15278: renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test

* Lint fix

* For #15278: made runblocking a Long to prevent overflow

* For #15278: fixed MozRunblocking name, description and moved RunBlockingCounter to perf package

* For #15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck

* For #15278: Added setup for unit test, since it failed without restting counter

* For #15278: Fixed naming for RunBlocking lint check

* For #15278: removed changes made to test to use runBlockingIncrement

* For #15728: added test exclusion for runBlocking check

* For #15278: changed null check and added Synchronized to count setter

* For #15278: fix for nits

* For #15278: added StartupExcessiveResourceUseTest to CODEOWNERS

* For #15278: fixed for nits

* For #15278: Moved increment function to extension function and fixed indentation

* For #15278: Added tests for Atomic Integer extension and nit fix
4 years ago
ekager d46fc7b142 For #6313 - Remove unneeded delay in BrowserAnimator 4 years ago
Sebastian Kaspari 9f29678e0a
For #16250: Disable remote USB debugging for SDK <23. (#16322)
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
4 years ago
Roger Yang b65c798450
For #16268 - Allowing multiple task while sharing (#16275) 4 years ago
Jocelyne Abi Haidar 1b204158e5
For #15931: Sort Downloads from newest to oldest (#15939) 4 years ago
mcarare 142d7a418c For #15430: Fix StrictMode death on opening app from widget voice search. 4 years ago
mcarare 5b0bdda974 For #15430: Fix StrictMode death on opening app from widget text search. 4 years ago
mcarare adbb262787 For #14552: Do not display back button when there is no tab history. 4 years ago
Mozilla L10n Automation Bot bf69519dc9 Import l10n. 4 years ago
Mugurell a6092c34cc For #15963 - Increase touch target for the close button in the tabs tray grid layout
We need to ensure it has at least 48dp while also not appearing too big.
4 years ago
Mugurell 83bd80c873 For #15757 - Avoid the double spacing issues for grid items in tabs tray
Items should have a 16dp all around padding.
Have them have a 8dp padding that will add to 16 when placed together.
Have the parent have another 8dp that will add to 16 for when items are placed
to the edge of the available screen.
4 years ago
Mugurell 0324baef03 For #15968 - Show a border for the selected tab in the grid based tabs tray
The border for the grid item will now be updated in the same method that
updates the background for the list item.
4 years ago
Mugurell 482739ba8c For #15756 - Add a play/pause button in the tabs tray grid layout
Moved the previous layout in a new, bigger FrameLayout that would serve as a
buffer space for the play/pause button to be translated to the exterior.
Otherwise the button would be clipped.
4 years ago
Gabriel Luong 66210469c0
For #9548 - Ability to rename top sites (#16285)
* Ability to rename top sites, closes #9548

* Highlight the "Remove" top site action as destructive

With more menu items in the top site contextual menu, it makes sense to differentiate

* Added test for the top site renaming action

* Fixed lint check (wildcard imports, blank spaces)

* Applied suggestions from code review

* Apply suggestions from code review

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

* Implemented dialog click listener with manual dismiss/cancel

Co-authored-by: Lorenzo Stanco <lorenzo.stanco@gmail.com>
4 years ago
ekager 9bb3440fce No issue: Make sure we are cleaning up test coroutines 4 years ago
mozilla-l10n-automation-bot d1ec6cac86
Import l10n. (#16274) 4 years ago
ekager 4246293a93 For #16161 - Fixes Saved Login toolbar layout 4 years ago
Codrut Topliceanu 975a5b76ec
For #14637 - Fix sitePermissionsFeature breaking change + AC bump (#16229)
* For #14637 - Compatibility patch for AC - 8554

* Update Android Components version to 65.0.20201029143039

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
4 years ago
mozilla-l10n-automation-bot e21c81a0dd
Import l10n. (#16240) 4 years ago
mcarare 3cb2c83980 For #16250: Disable remote USB debugging for SDK <23. 4 years ago
Mihai Adrian Carare 0ee7e1c28d
For # 15929: Remove the search widget discoverability experiment. (#16081)
* For #15929: Remove SearchWidgetCFR telemetry.

* For #15929: Remove SearchWidgetCFR and search widget experiment.

* For #15929: Remove unit tests references to search widget experiment.
4 years ago
mcarare 9748c65c71 For #15413: Use proper url when bookmarking a page. 4 years ago
Oana Horvath e36e61b2c3 For #10690: re-enable editBookmarkTest 4 years ago
Mozilla L10n Automation Bot 5739140ff3 Import l10n. 4 years ago
Arturo Mejia bb7d821804 Fix AddonsManagementFragment detekt error 4 years ago
Christian Sadilek c330426bb7 No issue: Fix onConfigurationChange crashes in Debug build 4 years ago
Christian Sadilek 601aa19176 Closes #11285: Replace Session[Manager] observers in BaseBrowserFragment 4 years ago
Grisha Kruglov 655a5cbf54 Closes #15816 - Attempt to handle 'allowInPrivate..' pref with detached context 4 years ago
mcarare 21a67de947 For #15379: Use proper url when sharing. 4 years ago
ekager 9b2162fca2 For #16199 - Don't pass BrowserToolbarView in onStart when we just need parent 4 years ago
Arturo Mejia 0ae0b89d65 Fix add-on translation braking changes 4 years ago
Aaron Train b8fff8cef1
For #8169 - Upgrade Mockwebserver (#16186)
Upgrades Mockwebserver to 4.9.0
4 years ago
mozilla-l10n-automation-bot b8d6dbd426
Import l10n. (#16198) 4 years ago
Lorenzo Stanco 90220678cf
For #16122 - Add a dark theme color for the top sites pin icon (#16180) 4 years ago
mozilla-l10n-automation-bot 7d59a58134
Import l10n. (#16163) 4 years ago
Adam Novak 86742d23c4 Merge remote-tracking branch 'upstream/releases/v83.0.0' into upstream-sync 4 years ago
interfect e0fd0613d8
Hide private browsing myths link (#232)
Also turn off Android test for it.

This is easier than actually writing our own documentation, disentangling the
link from the SUMO topic linking system, and changing the tests to respect the
new destination. The downside is that if users don't know what they're doing
with private browsing, we will no longer even try to help them.

This fixes #221.
4 years ago
mozilla-l10n-automation-bot 6353e9979e
Import l10n. (#16154) 4 years ago
ekager e15f50712a For #6313 - Set session ClearColor through Engine DefaultSettings 4 years ago
mozilla-l10n-automation-bot 4acf3c601d
Import l10n. (#16138) 4 years ago
Jocelyne Abi Haidar f514f6099a
For #15508: Show error when trying to save empty or invalid bookmark URL (#15674) 4 years ago
mozilla-l10n-automation-bot c40b93715f
Import l10n. (#16108) 4 years ago
Mugurell 358ca2c87f
For #15543 - Adjust the height of the tabs tray depending on the number of tabs (#15749) 4 years ago
ekager aae43b84eb
For #12062 - Feature Flag return to browser (#16099) 4 years ago
ekager 6b8f2001df
For #16084 - Match elevation of Tab in Collection to header (#16100) 4 years ago
ekager d5cb9c599c
For #15910 - Adds back automatic toggle, disables slider when enabled (#16070) 4 years ago
Arturo Mejia dbe6dbb18c
For #16019 - Fix intermittent test failure TrackingProtectionPolicyFactoryTest (#16056) 4 years ago
mcarare 1a10215caf For #14619: Show half a tab top offset when scrolling to selected tab. 4 years ago
mozilla-l10n-automation-bot 20df97ad57
Import l10n. (#16074) 4 years ago
Mugurell 57462d612f
For #16054 - Enable pull to refresh webpage in Nightly and Debug (#16060) 4 years ago
Elise Richards 7e3c26914c
For #15080: Handle default search engine when editing or removing (#15768) 4 years ago
Juan C. Goncalves eb0712d9b4
For #11397 - Add lint rule for AppCompatResources instead of ContextCompat (#16011) 4 years ago
Sebastian Kaspari 0d97862824 FennecWebAppIntentProcessor: Catch JSONException. 4 years ago
Mihai Adrian Carare b1bc024ff5
For #11631: Move report site issue extension to main menu. (#15884)
* For #11631: Move report site issue extension to main menu.

* For #11631: Update UI test for installing add-on.
4 years ago
Tom Klein 57ba92080f For #15480 - Update the UI when a collection is renamed 4 years ago
mcarare edd613ace2 For #15688: Update UI tests. 4 years ago
mcarare 5f01583f25 For #15688: Update unit tests. 4 years ago
mcarare 9274558e2f For #15688: Navigate to home screen with arguments on new tab action. 4 years ago
Mozilla L10n Automation Bot ae74edecdb Import l10n. 4 years ago
Sebastian Kaspari 2da24cd91d
Update Android Components, Kotlin, Gradle plugin (#16021)
* Closes #13262: Update AGP to 4

* Update to Mozilla Android Components 63.0.20201019090011.

* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.

* Fix new compiler warnings.

* Fix compilation of lint rules module.

* Pin JNA version.

* Fix new lint errors.

Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Mihai Adrian Carare 3ed49d8802
For #14744: Also show Fill link from clipboard with search shortcuts. (#15885) 4 years ago
Christian Sadilek f59cfd961c Configure M5 AMO collection for all builds 4 years ago
mozilla-l10n-automation-bot 46ff7a182a
Import l10n. (#16014) 4 years ago
mozilla-l10n-automation-bot c941bd99b0
Import l10n. (#16001) 4 years ago
mozilla-l10n-automation-bot 1d91f1f087
Import l10n. (#15986) 4 years ago
Gabriel Luong d33bd76e40
For #15796 - Use the device locale for the system locale subtitle (#15975) 4 years ago
Gabriel Luong 87ec7a77ae
For #15937 - Remove topFrecentSite feature flag (#15967)
* For #15937 - Remove the topFrecentSite feature flag

* For #15937 - Hide the "Pull to refresh" preference since its visibility is managed by a feature flag
4 years ago
ekager d208ffe002
For #7345 - Update new shield icons, remove lottie (#15909) 4 years ago
Christian Sadilek c852301c93 Closes #11286: Add TelemetryMiddleware to remove Session[Manager] observers 4 years ago
Gabriel Luong 412b412d5f
For #15796 - show device language under follow device language (#15966) 4 years ago
amkcpu 7ba5e130ba For #10683: Show longer tab titles
Also update tab tray item layout according to specs posted in the issue.
4 years ago
mozilla-l10n-automation-bot a2a4284a1a
Import l10n. (#15945) 4 years ago
Jeff Boek 55515d8f7c
For #15596 - Removes upgrade faq link from fennec builds (#15643) 4 years ago
Gabriel Luong b79df0ba8f For #14922: Use padding instead of margin to use the full screen width for the "Add search engine" button 4 years ago
mcarare 9f14007a98 For #14922: Adjust margins for add search engine preference. 4 years ago
mcarare ba0c005ae9 For #14922: Add divider above address bar preferences. 4 years ago
mcarare 7510b1609f For #15898: Add dividers above subheadings in tabs screen. 4 years ago
mcarare e50cb21fd0 For #15898: Add dividers above subheadings in customise screen. 4 years ago
Michael Comella 439dfc5cb1 For #15644: add comment for why we set the app theme in test. 4 years ago
Michael Comella 4a000ab4f9 For #15644: change apply to with in GleanMetricsService.
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.

I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
4 years ago
Michael Comella 690554b5c6 For #15644: mock package inspection dependencies in GleanMetricsService.
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
4 years ago
ekager 2c7789b1a8 Sets theme in FenixRobolectricTestApplication onCreate 4 years ago
Michael Comella 3a6f74031c For #15644: escalate many Performance check severity in lint.xml.
I exhaustively looked through the list of checks labeled performance and
marked them accordingly. To see all lint checks, type:
  <android-sdk>/tools/bin/lint --show
4 years ago
Michael Comella fc9ae308d3 For #15644: remove unnecessary lint ignore. 4 years ago
Michael Comella ac953ab8ca For #15644: escalate InefficientWeight to error.
All violations of this type were addressed in the previous commit.
4 years ago
ekager 4d348dd26a Fixes existing lint errors 4 years ago
Gabriel Luong 665a71cbb0 For #15907 - Remove the usage of the TabTrayGridItemDecorator 4 years ago
ekager 508ec8b8ff For #15347 - Adds telemetry for tabs settings 4 years ago
ekager b6587455f8 fix detekt errors 4 years ago
Sebastian Kaspari 430282c8ec Use new SearchEngineProvider interface. 4 years ago
Mozilla L10n Automation Bot ce99cc9ccf Import l10n. 4 years ago
Michael Comella ea2bb0df75 For #15280 - review: add license to lint-baseline.xml. 4 years ago
Michael Comella 341a92a10e For #15280: add current ConstraintLayout warnings to lint baseline. 4 years ago
Michael Comella c6b83b10e0 For #15280: suppress new lint rule in migration code. 4 years ago
ekager e56043c485 For #15265 - Save cached top sites for metrics ping 4 years ago
ekager cbe293d3e4 For #12062 - Launch back to browser if we previoulsy had tabs 4 years ago
Mugurell dd83130d9f For #15890 - Ensure app locale switcher works for Windows builds
A hardcoded unix file separator prevented us from building a proper list of
locales for which we actually have packaged translations.
4 years ago
Abhijit Kiran Valluri c769d5a19e
Updated logo to the new design chosen in the poll (#217)
* Updated logo to the new design chosen in the poll

* Small tweak to font size

* Final tweaks to wordmark
4 years ago
Mozilla L10n Automation Bot 399c9c57fb Import l10n. 4 years ago
ekager 7931d66c8e For #15853 - Always set fontSizeFactor setting with new text scale 4 years ago
Mihai Adrian Carare 0e2657e262
For #14735: Remove debug logs from release build. (#15747) 4 years ago
Mozilla L10n Automation Bot 2751da0372 Import l10n. 4 years ago
Gabriel Luong ee5f678442 For #15777 - [Grid View] Set the height of the title to 30dp 4 years ago
Gabriel Luong 463f83a79a For #15758 ⁃ [Grid View] Add a divider between the tab item's title and thumbnail 4 years ago
Mozilla L10n Automation Bot 83b5bae65e Import l10n. 4 years ago
Abhijit Valluri 9dac286d7a Fix failing lint check 4 years ago
Abhijit Valluri e547c93311 Merge remote-tracking branch 'mozilla/master' into mozilla_main 4 years ago
Mozilla L10n Automation Bot 25c9706cfd Import l10n. 4 years ago
Grisha Kruglov 2030580fc8 Closes #15812: Check for a null context during onScanResult 4 years ago
Mozilla L10n Automation Bot d5bef99834 Import l10n. 4 years ago
Shen 45e3f7805b For #13168 - Removed the close button from history navigation bar 4 years ago
Michael Comella 850d41a727 For #10069 - post: link to issue, data review. 4 years ago
Michael Comella 4179ab05bb For #10069 - review: clarify init time for External...Activity. 4 years ago
Michael Comella a1bbd2589e For #10069 - review: change extra name to firstFramePreDrawNanos. 4 years ago
sraturi 8f16f9cb37 for #10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types. 4 years ago
mcarare 6516eff5c8 For #13831: Adjust buttons dimensions to improve a11y.
Margins were also adjusted to maintain relative placements.
4 years ago
mcarare e89b9756ee For #13831: Add ripple for the copy password button. 4 years ago
ekager 881e3d6ccd For #14923 - Removes auto size preference toggle 4 years ago
Sijan Rijal 127d006d66
For #15402: Hide ETP pop-up if the toolbar is not visible (#15667)
For #15402: Hide ETP pop-up when top or bottom toolbar is not visible
4 years ago
Sijan Rijal 70908307fc
For #15497: Hide and remove the three dot menu from the Desktop Bookmarks folder (#15649)
For #15497: Remove and disable the three dot menu button
4 years ago
Mozilla L10n Automation Bot 0fbb28296e Import l10n. 4 years ago
Jonathan Almeida 666781aa62 Fix lint warnings and test in site permissions 4 years ago
Arturo Mejia de521192e0 Add support for local storage permission 4 years ago
Gabriel Luong 5153a3f2c5 For #15115 - Part 9: Fix ui tests for the tabs settings 4 years ago
Gabriel Luong 2dd019c05f For #15115 - Part 8: Add a feature flag for showing the grid view in the tabs setting 4 years ago
Gabriel Luong af0af7f88a For #15115 - Part 7: Draw a border around the selected tab 4 years ago
Gabriel Luong 5fcc486caa For #15115 - Part 6: Display the tab's favicon in the grid view 4 years ago
Gabriel Luong 5fa72cf48c For #15115 - Part 5: Don't draw any background when swiping to delete a tab 4 years ago
Gabriel Luong a001004add For #15115 - Part 4: Formatted TabTrayView.kt 4 years ago
Gabriel Luong 6c77cdab41 For #15115 - Part 3: Implement a grid view layout for the tabs
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
4 years ago
Gabriel Luong 2117dfb524 For #15115 - Part 2: Remove unused xmlns:mozac in component_tabstray.xml 4 years ago
Gabriel Luong ed3986662f For #15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
4 years ago
Michael Comella 7c0d00c800 No issue: fix tests related to inline change.
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
4 years ago
Michael Comella 7b5cd8c165 No issue: remove inline from StrictModeManager.resetAfter.
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet  we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
4 years ago
Mozilla L10n Automation Bot a72b5b0dd6 Import l10n. 4 years ago
Jonathan Almeida ee673348bf Issue #15754: Disable failing notification UI tests 4 years ago
Jonathan Almeida 23d9951e78 Upgrade to Android Component 62.0.20201006190820 with breaking changes 4 years ago
Chenxia Liu fe0ea19b1d Adding link data review request 4 years ago
Chenxia Liu 6e522436b5 startup.timeline 4 years ago
Chenxia Liu 05f37e75fb sync, sync_items, telemetry, theme, toolbar_position,
tracking_protection, default_engine
4 years ago
Chenxia Liu 8892a6ec85 accesssibility, open_links, remote_debugging, search_suggestions,
show_search
4 years ago
Chenxia Liu 5f74e18bca search_count, search_widget, tabs_count, toolbar_position 4 years ago
Chenxia Liu 29970f5cb2 has, count: open_tabs, pwa, top_sites 4 years ago
Chenxia Liu 0b9c50f62e default*browser, mozilla_products 4 years ago
Chenxia Liu 03e6167b5f browser.search, events.total_uri_count, metrics.adjust* 4 years ago
Chenxia Liu ca57a2d3ab first_session 4 years ago
Chenxia Liu 815e159183 user_specified_search_engine, voice_search 4 years ago
Chenxia Liu 2edb812663 top_sites, tracking_protection 4 years ago
Chenxia Liu bf381a6a7c tab, tabs_tray, toolbar_settings 4 years ago
Chenxia Liu bb7515f76e syenc_account, sync_auth 4 years ago
Chenxia Liu 68ba986fd2 search_suggestions, search_shortcuts, search_widget 4 years ago
Chenxia Liu 965af504ad private_browsing, qr_scanner 4 years ago
Chenxia Liu 04d0e59468 pocket, onboarding 4 years ago
Chenxia Liu ac28667995 logins, media_notification, media_state 4 years ago
Chenxia Liu d50fbd062d Issue #14142 - find_in_page, history, reader_mode, tip 4 years ago
mcarare 9845626eca For #15711: Also add custom engines to fallback list. 4 years ago
mozilla-l10n-automation-bot 0ac7feacb4
Import l10n. (#15738) 4 years ago
Elise Richards 13f3304912
For #8765: Use shared list widget in collections (#15733)
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Michael Comella 4302cd20b2 For #13959 - post: decrement expected suppression count.
Running locally, I get the same error: I think that there legitimately
was an reduction in the number of StrictMode suppressions on start up.
4 years ago
Michael Comella 3e96f6b385 For #13959 - review: add clarifying comments. 4 years ago
Michael Comella 50959d997e For #13959: add marker when StrictMode is suppressed. 4 years ago
Michael Comella 3b5d6d58d9 For #13959: add MozillaStrictModeSuppression detekt check. 4 years ago
Michael Comella b222376cb0 For #13959: add test to prevent increasing StrictMode suppression count. 4 years ago
Michael Comella c33aafb024 For #13959: add HomeActivityTestRule.skipOnboarding.
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
  homeScreen { }.dismissOnboarding()

Which opens settings to dismiss onboarding.
4 years ago
Michael Comella 4a4edeb184 For #13959: count StrictMode suppressions on startup. 4 years ago
Jocelyne Abi Haidar a5de2c0352 For #15675: Disable Save button when editing saved login until something has been changed
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
4 years ago