[fenix] For https://github.com/mozilla-mobile/fenix/issues/507 - Leaves a comment to explain the current state

pull/600/head
Jeff Boek 6 years ago
parent dfb4f29848
commit fb009c7f0a

@ -58,10 +58,6 @@ class ToolbarUIView(
url = text
actionEmitter.onNext(SearchAction.TextChanged(text))
}
override fun onStopEditing() {
// actionEmitter.onNext(SearchAction.UrlCommitted(url))
}
})
}

@ -98,6 +98,11 @@ class SearchFragment : Fragment() {
}
}
// Issue: https://github.com/mozilla-mobile/fenix/issues/626
// Currently we were kind of forcing all this logic through the Toolbar Feature.
// But since we cannot actually load a page without an available GeckoSession
// we have to wait until after we navigate to call the use case.
// We should move this logic into a place that makes more sense.
private fun load(text: String) {
val sessionId = SearchFragmentArgs.fromBundle(arguments!!).sessionId
val isPrivate = SearchFragmentArgs.fromBundle(arguments!!).isPrivateTab

Loading…
Cancel
Save