Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-19 09:25:34 +00:00
Code Issues Releases Wiki Activity

[fenix] For https://github.com/mozilla-mobile/fenix/issues/507 - Leaves a comment to explain the current state

Browse Source
This commit is contained in:
Jeff Boek 2019-02-21 10:58:07 -08:00
parent dfb4f29848
commit fb009c7f0a
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarUIView.kt
View File

@ -58,10 +58,6 @@ class ToolbarUIView(
url = text url = text
actionEmitter.onNext(SearchAction.TextChanged(text)) actionEmitter.onNext(SearchAction.TextChanged(text))
} }
override fun onStopEditing() {
// actionEmitter.onNext(SearchAction.UrlCommitted(url))
}
}) })
} }

5
app/src/main/java/org/mozilla/fenix/search/SearchFragment.kt
View File

@ -98,6 +98,11 @@ class SearchFragment : Fragment() {
} }
} }
// Issue: https://github.com/mozilla-mobile/fenix/issues/626
// Currently we were kind of forcing all this logic through the Toolbar Feature.
// But since we cannot actually load a page without an available GeckoSession
// we have to wait until after we navigate to call the use case.
// We should move this logic into a place that makes more sense.
private fun load(text: String) { private fun load(text: String) {
val sessionId = SearchFragmentArgs.fromBundle(arguments!!).sessionId val sessionId = SearchFragmentArgs.fromBundle(arguments!!).sessionId
val isPrivate = SearchFragmentArgs.fromBundle(arguments!!).isPrivateTab val isPrivate = SearchFragmentArgs.fromBundle(arguments!!).isPrivateTab