[fenix] For https://github.com/mozilla-mobile/fenix/issues/24838 - Remove Event.wrapper for Tabs telemetry

pull/600/head
Alexandru2909 2 years ago committed by mergify[bot]
parent bc65fb9e91
commit f52234a98c

@ -16,8 +16,6 @@ sealed class Event {
object HistorySearchGroupOpened : Event() object HistorySearchGroupOpened : Event()
object SearchWidgetInstalled : Event() object SearchWidgetInstalled : Event()
object TabSettingsOpened : Event()
object SyncedTabSuggestionClicked : Event() object SyncedTabSuggestionClicked : Event()
object BookmarkSuggestionClicked : Event() object BookmarkSuggestionClicked : Event()
object ClipboardSuggestionClicked : Event() object ClipboardSuggestionClicked : Event()

@ -13,7 +13,6 @@ import org.mozilla.fenix.GleanMetrics.BrowserSearch
import org.mozilla.fenix.GleanMetrics.Pings import org.mozilla.fenix.GleanMetrics.Pings
import org.mozilla.fenix.GleanMetrics.RecentlyVisitedHomepage import org.mozilla.fenix.GleanMetrics.RecentlyVisitedHomepage
import org.mozilla.fenix.GleanMetrics.SyncedTabs import org.mozilla.fenix.GleanMetrics.SyncedTabs
import org.mozilla.fenix.GleanMetrics.Tabs
import org.mozilla.fenix.GleanMetrics.Messaging import org.mozilla.fenix.GleanMetrics.Messaging
import org.mozilla.fenix.ext.components import org.mozilla.fenix.ext.components
@ -76,9 +75,6 @@ private val Event.wrapper: EventWrapper<*>?
} }
) )
is Event.TabSettingsOpened -> EventWrapper<NoExtraKeys>(
{ Tabs.settingOpened.record(it) }
)
is Event.SyncedTabSuggestionClicked -> EventWrapper<NoExtraKeys>( is Event.SyncedTabSuggestionClicked -> EventWrapper<NoExtraKeys>(
{ SyncedTabs.syncedTabsSuggestionClicked.record(it) } { SyncedTabs.syncedTabsSuggestionClicked.record(it) }
) )

@ -9,11 +9,11 @@ import android.view.View
import androidx.preference.PreferenceCategory import androidx.preference.PreferenceCategory
import androidx.preference.PreferenceFragmentCompat import androidx.preference.PreferenceFragmentCompat
import androidx.preference.SwitchPreference import androidx.preference.SwitchPreference
import mozilla.telemetry.glean.private.NoExtras
import org.mozilla.fenix.FeatureFlags import org.mozilla.fenix.FeatureFlags
import org.mozilla.fenix.GleanMetrics.Events import org.mozilla.fenix.GleanMetrics.Events
import org.mozilla.fenix.GleanMetrics.Tabs
import org.mozilla.fenix.R import org.mozilla.fenix.R
import org.mozilla.fenix.components.metrics.Event
import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.settings import org.mozilla.fenix.ext.settings
import org.mozilla.fenix.ext.showToolbar import org.mozilla.fenix.ext.showToolbar
import org.mozilla.fenix.utils.view.addToRadioGroup import org.mozilla.fenix.utils.view.addToRadioGroup
@ -38,7 +38,7 @@ class TabsSettingsFragment : PreferenceFragmentCompat() {
override fun onViewCreated(view: View, savedInstanceState: Bundle?) { override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState) super.onViewCreated(view, savedInstanceState)
view.context.components.analytics.metrics.track(Event.TabSettingsOpened) Tabs.settingOpened.record(NoExtras())
} }
override fun onResume() { override fun onResume() {

Loading…
Cancel
Save