Remove TabsUseCases methods that take a Session object.

upstream-sync
Sebastian Kaspari 4 years ago committed by Christian Sadilek
parent 3ce9bf93bc
commit f4a7b4c066

@ -13,6 +13,7 @@ import mozilla.components.lib.crash.handler.CrashHandlerService
import mozilla.components.service.sync.logins.GeckoLoginStorageDelegate import mozilla.components.service.sync.logins.GeckoLoginStorageDelegate
import org.mozilla.fenix.Config import org.mozilla.fenix.Config
import org.mozilla.fenix.ext.components import org.mozilla.fenix.ext.components
import org.mozilla.geckoview.ContentBlocking
import org.mozilla.geckoview.GeckoRuntime import org.mozilla.geckoview.GeckoRuntime
import org.mozilla.geckoview.GeckoRuntimeSettings import org.mozilla.geckoview.GeckoRuntimeSettings
import org.mozilla.geckoview.ContentBlocking.SafeBrowsingProvider import org.mozilla.geckoview.ContentBlocking.SafeBrowsingProvider

@ -1070,7 +1070,7 @@ abstract class BaseBrowserFragment : Fragment(), UserInteractionHandler, Activit
getSessionById()?.let { session -> getSessionById()?.let { session ->
return if (session.source == SessionState.Source.ACTION_VIEW) { return if (session.source == SessionState.Source.ACTION_VIEW) {
activity?.finish() activity?.finish()
requireComponents.useCases.tabsUseCases.removeTab(session) requireComponents.useCases.tabsUseCases.removeTab(session.id)
true true
} else { } else {
if (session.hasParentSession) { if (session.hasParentSession) {

@ -10,7 +10,6 @@ import androidx.core.graphics.BlendModeCompat.SRC_IN
import androidx.core.graphics.drawable.toBitmap import androidx.core.graphics.drawable.toBitmap
import mozilla.components.browser.awesomebar.BrowserAwesomeBar import mozilla.components.browser.awesomebar.BrowserAwesomeBar
import mozilla.components.browser.search.DefaultSearchEngineProvider import mozilla.components.browser.search.DefaultSearchEngineProvider
import mozilla.components.browser.session.Session
import mozilla.components.browser.state.search.SearchEngine import mozilla.components.browser.state.search.SearchEngine
import mozilla.components.concept.awesomebar.AwesomeBar import mozilla.components.concept.awesomebar.AwesomeBar
import mozilla.components.concept.engine.EngineSession import mozilla.components.concept.engine.EngineSession
@ -86,10 +85,6 @@ class AwesomeBarView(
} }
private val selectTabUseCase = object : TabsUseCases.SelectTabUseCase { private val selectTabUseCase = object : TabsUseCases.SelectTabUseCase {
override fun invoke(session: Session) {
interactor.onExistingSessionSelected(session.id)
}
override fun invoke(tabId: String) { override fun invoke(tabId: String) {
interactor.onExistingSessionSelected(tabId) interactor.onExistingSessionSelected(tabId)
} }

@ -32,7 +32,6 @@ import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.launch import kotlinx.coroutines.launch
import kotlinx.coroutines.plus import kotlinx.coroutines.plus
import mozilla.appservices.places.BookmarkRoot import mozilla.appservices.places.BookmarkRoot
import mozilla.components.browser.session.Session
import mozilla.components.browser.state.selector.findTab import mozilla.components.browser.state.selector.findTab
import mozilla.components.browser.state.selector.getNormalOrPrivateTabs import mozilla.components.browser.state.selector.getNormalOrPrivateTabs
import mozilla.components.browser.state.selector.normalTabs import mozilla.components.browser.state.selector.normalTabs
@ -105,12 +104,6 @@ class TabTrayDialogFragment : AppCompatDialogFragment(), UserInteractionHandler
requireComponents.useCases.tabsUseCases.selectTab(tabId) requireComponents.useCases.tabsUseCases.selectTab(tabId)
navigateToBrowser() navigateToBrowser()
} }
override fun invoke(session: Session) {
requireContext().components.analytics.metrics.track(Event.OpenedExistingTab)
requireComponents.useCases.tabsUseCases.selectTab(session)
navigateToBrowser()
}
} }
override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
@ -127,12 +120,6 @@ class TabTrayDialogFragment : AppCompatDialogFragment(), UserInteractionHandler
showUndoSnackbarForTab(sessionId) showUndoSnackbarForTab(sessionId)
removeIfNotLastTab(sessionId) removeIfNotLastTab(sessionId)
} }
override fun invoke(session: Session) {
requireContext().components.analytics.metrics.track(Event.ClosedExistingTab)
showUndoSnackbarForTab(session.id)
removeIfNotLastTab(session.id)
}
} }
private fun removeIfNotLastTab(sessionId: String) { private fun removeIfNotLastTab(sessionId: String) {

@ -3,5 +3,5 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
object AndroidComponents { object AndroidComponents {
const val VERSION = "73.0.20210202194906" const val VERSION = "73.0.20210203143122"
} }

Loading…
Cancel
Save