Bug 1848658 - Make shopping analysis field adjustedRating nullable to allow GV to set the default to null

fenix/120.0
Cathy Lu 9 months ago committed by mergify[bot]
parent 0879502a7d
commit e397837bf4

@ -33,7 +33,7 @@ private fun GeckoProductAnalysis.toProductReview(): ProductReviewState =
ProductReviewState.Error.GenericError ProductReviewState.Error.GenericError
} }
} else { } else {
val mappedRating = adjustedRating.toFloatOrNull() val mappedRating = adjustedRating?.toFloatOrNull()
val mappedGrade = grade?.toGrade() val mappedGrade = grade?.toGrade()
val mappedHighlights = highlights?.toHighlights()?.toSortedMap() val mappedHighlights = highlights?.toHighlights()?.toSortedMap()

@ -16,7 +16,7 @@ object ProductAnalysisTestData {
productId: String? = "1", productId: String? = "1",
analysisURL: String = "https://test.com", analysisURL: String = "https://test.com",
grade: String? = "A", grade: String? = "A",
adjustedRating: Double = 4.5, adjustedRating: Double? = 4.5,
needsAnalysis: Boolean = false, needsAnalysis: Boolean = false,
lastAnalysisTime: Long = 0L, lastAnalysisTime: Long = 0L,
deletedProductReported: Boolean = false, deletedProductReported: Boolean = false,

@ -141,7 +141,7 @@ class ProductAnalysisMapperTest {
val actual = val actual =
ProductAnalysisTestData.productAnalysis( ProductAnalysisTestData.productAnalysis(
grade = null, grade = null,
adjustedRating = 0.0, adjustedRating = null,
highlights = null, highlights = null,
).toProductReviewState() ).toProductReviewState()
val expected = ReviewQualityCheckState.OptedIn.ProductReviewState.NoAnalysisPresent() val expected = ReviewQualityCheckState.OptedIn.ProductReviewState.NoAnalysisPresent()

Loading…
Cancel
Save