[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20650: Revert to manually close tab as default setting

pull/600/head
Roger Yang 3 years ago committed by mergify[bot]
parent 724fb8b60f
commit b901490a1b

@ -332,7 +332,7 @@ class Settings(private val appContext: Context) : PreferencesHolder {
var manuallyCloseTabs by booleanPreference( var manuallyCloseTabs by booleanPreference(
appContext.getPreferenceKey(R.string.pref_key_close_tabs_manually), appContext.getPreferenceKey(R.string.pref_key_close_tabs_manually),
default = FeatureFlags.inactiveTabs.not() default = true
) )
var closeTabsAfterOneDay by booleanPreference( var closeTabsAfterOneDay by booleanPreference(
@ -347,7 +347,7 @@ class Settings(private val appContext: Context) : PreferencesHolder {
var closeTabsAfterOneMonth by booleanPreference( var closeTabsAfterOneMonth by booleanPreference(
appContext.getPreferenceKey(R.string.pref_key_close_tabs_after_one_month), appContext.getPreferenceKey(R.string.pref_key_close_tabs_after_one_month),
default = FeatureFlags.inactiveTabs default = false
) )
var allowThirdPartyRootCerts by booleanPreference( var allowThirdPartyRootCerts by booleanPreference(

@ -225,21 +225,21 @@ class SettingsTest {
fun shouldManuallyCloseTabs() { fun shouldManuallyCloseTabs() {
// When just created // When just created
// Then // Then
assertFalse(settings.manuallyCloseTabs) assertTrue(settings.manuallyCloseTabs)
// When // When
settings.manuallyCloseTabs = true settings.manuallyCloseTabs = false
// Then // Then
assertTrue(settings.manuallyCloseTabs) assertFalse(settings.manuallyCloseTabs)
} }
@Test @Test
fun getTabTimeout() { fun getTabTimeout() {
// When just created // When just created
// Then // Then
assertTrue(settings.closeTabsAfterOneMonth) assertTrue(settings.manuallyCloseTabs)
assertEquals(Settings.ONE_MONTH_MS, settings.getTabTimeout()) assertEquals(Long.MAX_VALUE, settings.getTabTimeout())
// When // When
settings.manuallyCloseTabs = false settings.manuallyCloseTabs = false

Loading…
Cancel
Save