[fenix] For https://github.com/mozilla-mobile/fenix/issues/24210: Remove wrapper from home button clicked event.

pull/600/head
mcarare 3 years ago committed by mergify[bot]
parent ba8f7e50fc
commit a333a1765e

@ -156,9 +156,6 @@ sealed class Event {
object HomeScreenViewCount : Event() object HomeScreenViewCount : Event()
object HomeScreenCustomizedHomeClicked : Event() object HomeScreenCustomizedHomeClicked : Event()
// Browser Toolbar
object BrowserToolbarHomeButtonClicked : Event()
// Start on Home // Start on Home
object StartOnHomeEnterHomeScreen : Event() object StartOnHomeEnterHomeScreen : Event()
object StartOnHomeOpenTabsTray : Event() object StartOnHomeOpenTabsTray : Event()

@ -436,10 +436,6 @@ private val Event.wrapper: EventWrapper<*>?
is Event.HomeScreenCustomizedHomeClicked -> EventWrapper<NoExtraKeys>( is Event.HomeScreenCustomizedHomeClicked -> EventWrapper<NoExtraKeys>(
{ HomeScreen.customizeHomeClicked.record(it) } { HomeScreen.customizeHomeClicked.record(it) }
) )
is Event.BrowserToolbarHomeButtonClicked -> EventWrapper<NoExtraKeys>(
{ Events.browserToolbarHomeTapped.record(it) }
)
is Event.StartOnHomeEnterHomeScreen -> EventWrapper<NoExtraKeys>( is Event.StartOnHomeEnterHomeScreen -> EventWrapper<NoExtraKeys>(
{ StartOnHome.enterHomeScreen.record(it) } { StartOnHome.enterHomeScreen.record(it) }
) )

@ -13,6 +13,7 @@ import mozilla.components.browser.state.state.SessionState
import mozilla.components.browser.state.store.BrowserStore import mozilla.components.browser.state.store.BrowserStore
import mozilla.components.concept.engine.EngineView import mozilla.components.concept.engine.EngineView
import mozilla.components.feature.tabs.TabsUseCases import mozilla.components.feature.tabs.TabsUseCases
import mozilla.components.service.glean.private.NoExtras
import mozilla.components.support.ktx.kotlin.isUrl import mozilla.components.support.ktx.kotlin.isUrl
import mozilla.components.ui.tabcounter.TabCounterMenu import mozilla.components.ui.tabcounter.TabCounterMenu
import org.mozilla.fenix.GleanMetrics.Events import org.mozilla.fenix.GleanMetrics.Events
@ -172,8 +173,7 @@ class DefaultBrowserToolbarController(
} }
override fun handleHomeButtonClick() { override fun handleHomeButtonClick() {
metrics.track(Event.BrowserToolbarHomeButtonClicked) Events.browserToolbarHomeTapped.record(NoExtras())
browserAnimator.captureEngineViewAndDrawStatically { browserAnimator.captureEngineViewAndDrawStatically {
navController.navigate( navController.navigate(
BrowserFragmentDirections.actionGlobalHome() BrowserFragmentDirections.actionGlobalHome()

@ -47,7 +47,6 @@ import org.mozilla.fenix.browser.BrowserFragmentDirections
import org.mozilla.fenix.browser.browsingmode.BrowsingMode import org.mozilla.fenix.browser.browsingmode.BrowsingMode
import org.mozilla.fenix.browser.browsingmode.SimpleBrowsingModeManager import org.mozilla.fenix.browser.browsingmode.SimpleBrowsingModeManager
import org.mozilla.fenix.browser.readermode.ReaderModeController import org.mozilla.fenix.browser.readermode.ReaderModeController
import org.mozilla.fenix.components.metrics.Event
import org.mozilla.fenix.components.metrics.MetricController import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.components import org.mozilla.fenix.ext.components
import org.mozilla.fenix.ext.settings import org.mozilla.fenix.ext.settings
@ -351,11 +350,13 @@ class DefaultBrowserToolbarControllerTest {
@Test @Test
fun handleHomeButtonClick() { fun handleHomeButtonClick() {
assertFalse(Events.browserToolbarHomeTapped.testHasValue())
val controller = createController() val controller = createController()
controller.handleHomeButtonClick() controller.handleHomeButtonClick()
verify { navController.navigate(BrowserFragmentDirections.actionGlobalHome()) } verify { navController.navigate(BrowserFragmentDirections.actionGlobalHome()) }
verify { metrics.track(Event.BrowserToolbarHomeButtonClicked) } assertTrue(Events.browserToolbarHomeTapped.testHasValue())
} }
private fun createController( private fun createController(

Loading…
Cancel
Save