Fix and re-enable findInPageTest UI test

pull/543/head
AndiAJ 2 years ago committed by mergify[bot]
parent da77d7137f
commit 96be7af533

@ -9,7 +9,6 @@ import androidx.test.uiautomator.UiDevice
import okhttp3.mockwebserver.MockWebServer import okhttp3.mockwebserver.MockWebServer
import org.junit.After import org.junit.After
import org.junit.Before import org.junit.Before
import org.junit.Ignore
import org.junit.Rule import org.junit.Rule
import org.junit.Test import org.junit.Test
import org.mozilla.fenix.ext.settings import org.mozilla.fenix.ext.settings
@ -108,17 +107,13 @@ class NavigationToolbarTest {
} }
} }
@Ignore("Temp disable broken test - see: https://github.com/mozilla-mobile/fenix/issues/5534")
@Test @Test
fun findInPageTest() { fun findInPageTest() {
val loremIpsumWebPage = TestAssetHelper.getLoremIpsumAsset(mockWebServer) val defaultWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 3)
navigationToolbar { navigationToolbar {
}.enterURLAndEnterToBrowser(loremIpsumWebPage.url) { }.enterURLAndEnterToBrowser(defaultWebPage.url) {
mDevice.waitForIdle() mDevice.waitForIdle()
}
navigationToolbar {
}.openThreeDotMenu { }.openThreeDotMenu {
verifyThreeDotMenuExists() verifyThreeDotMenuExists()
verifyFindInPageButton() verifyFindInPageButton()
@ -126,19 +121,18 @@ class NavigationToolbarTest {
verifyFindInPageNextButton() verifyFindInPageNextButton()
verifyFindInPagePrevButton() verifyFindInPagePrevButton()
verifyFindInPageCloseButton() verifyFindInPageCloseButton()
enterFindInPageQuery("lab") enterFindInPageQuery("a")
verifyFindNextInPageResult("1/3") verifyFindNextInPageResult("1/3")
clickFindInPageNextButton()
verifyFindNextInPageResult("2/3") verifyFindNextInPageResult("2/3")
clickFindInPageNextButton()
verifyFindNextInPageResult("3/3") verifyFindNextInPageResult("3/3")
verifyFindPrevInPageResult("1/3") clickFindInPagePrevButton()
verifyFindPrevInPageResult("3/3")
verifyFindPrevInPageResult("2/3") verifyFindPrevInPageResult("2/3")
enterFindInPageQuery("in") clickFindInPagePrevButton()
verifyFindNextInPageResult("3/7") verifyFindPrevInPageResult("1/3")
verifyFindNextInPageResult("4/7") enterFindInPageQuery("3")
verifyFindNextInPageResult("5/7") verifyFindNextInPageResult("1/1")
verifyFindNextInPageResult("6/7")
verifyFindNextInPageResult("7/7")
}.closeFindInPage { } }.closeFindInPage { }
} }
} }

@ -33,6 +33,8 @@ class FindInPageRobot {
fun verifyFindInPageNextButton() = assertFindInPageNextButton()!! fun verifyFindInPageNextButton() = assertFindInPageNextButton()!!
fun verifyFindInPagePrevButton() = assertFindInPagePrevButton()!! fun verifyFindInPagePrevButton() = assertFindInPagePrevButton()!!
fun verifyFindInPageCloseButton() = assertFindInPageCloseButton()!! fun verifyFindInPageCloseButton() = assertFindInPageCloseButton()!!
fun clickFindInPageNextButton() = findInPageNextButton().click()
fun clickFindInPagePrevButton() = findInPagePrevButton().click()
fun verifyFindInPageSearchBarItems() { fun verifyFindInPageSearchBarItems() {
verifyFindInPageQuery() verifyFindInPageQuery()
@ -51,18 +53,12 @@ class FindInPageRobot {
fun verifyFindNextInPageResult(ratioCounter: String) { fun verifyFindNextInPageResult(ratioCounter: String) {
mDevice.waitNotNull(Until.findObject(By.text(ratioCounter)), waitingTime) mDevice.waitNotNull(Until.findObject(By.text(ratioCounter)), waitingTime)
val element = mDevice.findObject(By.text(ratioCounter))
findInPageResult().check(matches(withText((ratioCounter)))) findInPageResult().check(matches(withText((ratioCounter))))
findInPageNextButton().click()
element.wait(Until.textNotEquals(ratioCounter), waitingTime)
} }
fun verifyFindPrevInPageResult(ratioCounter: String) { fun verifyFindPrevInPageResult(ratioCounter: String) {
mDevice.waitNotNull(Until.findObject(By.text(ratioCounter)), waitingTime) mDevice.waitNotNull(Until.findObject(By.text(ratioCounter)), waitingTime)
val element = mDevice.findObject(By.text(ratioCounter))
findInPageResult().check(matches(withText((ratioCounter)))) findInPageResult().check(matches(withText((ratioCounter))))
findInPagePrevButton().click()
element.wait(Until.textNotEquals(ratioCounter), waitingTime)
} }
class Transition { class Transition {

Loading…
Cancel
Save