[fenix] No issue: use Fact.value as detailText for markers.

This allows Facts emitted from ac to provide more details in markers.
pull/600/head
Michael Comella 3 years ago committed by mergify[bot]
parent 9688a90c29
commit 8fc6c5952f

@ -56,13 +56,14 @@ class ProfilerMarkerFactProcessor @VisibleForTesting(otherwise = PRIVATE) constr
} }
val markerName = fact.item val markerName = fact.item
val detailText = fact.value
// Java profiler markers can only be added from the main thread so, for now, we push all // Java profiler markers can only be added from the main thread so, for now, we push all
// markers to the the main thread (which also groups all the markers together, // markers to the the main thread (which also groups all the markers together,
// making it easier to read). // making it easier to read).
val profiler = profilerProvider() val profiler = profilerProvider()
if (getMyLooper() == mainHandler.looper) { if (getMyLooper() == mainHandler.looper) {
profiler?.addMarker(markerName) profiler?.addMarker(markerName, detailText)
} else { } else {
// To reduce the performance burden, we could early return if the profiler isn't active. // To reduce the performance burden, we could early return if the profiler isn't active.
// However, this would change the performance characteristics from when the profiler is // However, this would change the performance characteristics from when the profiler is
@ -71,7 +72,7 @@ class ProfilerMarkerFactProcessor @VisibleForTesting(otherwise = PRIVATE) constr
mainHandler.post { mainHandler.post {
// We set now to both start and end time because we want a marker of without duration // We set now to both start and end time because we want a marker of without duration
// and if end is omitted, the duration is created implicitly. // and if end is omitted, the duration is created implicitly.
profiler?.addMarker(markerName, now, now, null) profiler?.addMarker(markerName, now, now, detailText)
} }
} }
} }

Loading…
Cancel
Save