Bug 1882123 - Message middleware use store dispatch due to possibility of dispatching in IO thread

fenix/125.0
Roger Yang 4 months ago committed by mergify[bot]
parent d20b65c304
commit 4e76e98717

@ -47,10 +47,10 @@ class MessagingMiddleware(
context.state.messaging.messages, context.state.messaging.messages,
) )
if (message != null) { if (message != null) {
context.dispatch(UpdateMessageToShow(message)) context.store.dispatch(UpdateMessageToShow(message))
onMessagedDisplayed(message, context) onMessagedDisplayed(message, context)
} else { } else {
context.dispatch(ConsumeMessageToShow(action.surface)) context.store.dispatch(ConsumeMessageToShow(action.surface))
} }
} }
@ -86,7 +86,7 @@ class MessagingMiddleware(
message: Message, message: Message,
) { ) {
val newMessages = removeMessage(context, message) val newMessages = removeMessage(context, message)
context.dispatch(UpdateMessages(newMessages)) context.store.dispatch(UpdateMessages(newMessages))
consumeMessageToShowIfNeeded(context, message) consumeMessageToShowIfNeeded(context, message)
coroutineScope.launch { coroutineScope.launch {
controller.onMessageDismissed(message) controller.onMessageDismissed(message)
@ -103,7 +103,7 @@ class MessagingMiddleware(
} }
// Update app state. // Update app state.
val newMessages = removeMessage(context, message) val newMessages = removeMessage(context, message)
context.dispatch(UpdateMessages(newMessages)) context.store.dispatch(UpdateMessages(newMessages))
consumeMessageToShowIfNeeded(context, message) consumeMessageToShowIfNeeded(context, message)
} }
@ -113,7 +113,7 @@ class MessagingMiddleware(
) { ) {
val current = context.state.messaging.messageToShow[message.surface] val current = context.state.messaging.messageToShow[message.surface]
if (current?.id == message.id) { if (current?.id == message.id) {
context.dispatch(ConsumeMessageToShow(message.surface)) context.store.dispatch(ConsumeMessageToShow(message.surface))
} }
} }

Loading…
Cancel
Save