For #6997 Avoid overwriting empty_search_string error (#6998)

Setting error twice also clips error message

app/src/main/java/org/mozilla/fenix/settings/search/AddSearchEngineFragment.kt

@@ -141,6 +141,7 @@ class AddSearchEngineFragment : Fragment(), CompoundButton.OnCheckedChangeListen
         }
     }
 
+    @Suppress("ComplexMethod")
     private fun createCustomEngine() {
         custom_search_engine_name_field.error = ""
         custom_search_engine_search_string_field.error = ""
@@ -167,15 +168,15 @@ class AddSearchEngineFragment : Fragment(), CompoundButton.OnCheckedChangeListen
             hasError = true
         }
 
-        if (searchString.isEmpty()) {
+        custom_search_engine_search_string_field.error = when {
-            custom_search_engine_search_string_field
+            searchString.isEmpty() ->
-                .error = resources.getString(R.string.search_add_custom_engine_error_empty_search_string)
+                resources.getString(R.string.search_add_custom_engine_error_empty_search_string)
-            hasError = true
+            !searchString.contains("%s") ->
+                resources.getString(R.string.search_add_custom_engine_error_missing_template)
+            else -> null
         }
 
-        if (!searchString.contains("%s")) {
+        if (custom_search_engine_search_string_field.error != null) {
-            custom_search_engine_search_string_field
-                .error = resources.getString(R.string.search_add_custom_engine_error_missing_template)
             hasError = true
         }