[fenix] change name for isFirstRun to isFirstNimbusRun and move setter to after experiments are set

pull/600/head
Charlie Humphreys 2 years ago committed by mergify[bot]
parent 028c519532
commit 367678cad4

@ -80,7 +80,7 @@ fun createNimbus(context: Context, url: String?): NimbusApi {
// and would mostly produce the value `Beta` and rarely would produce `beta`. // and would mostly produce the value `Beta` and rarely would produce `beta`.
channel = BuildConfig.BUILD_TYPE, channel = BuildConfig.BUILD_TYPE,
customTargetingAttributes = mapOf( customTargetingAttributes = mapOf(
"isFirstRun" to context.settings().isFirstRun.toString() "isFirstRun" to context.settings().isFirstNimbusRun.toString()
) )
) )
Nimbus(context, appInfo, serverSettings, errorReporter).apply { Nimbus(context, appInfo, serverSettings, errorReporter).apply {
@ -101,9 +101,9 @@ fun createNimbus(context: Context, url: String?): NimbusApi {
globalUserParticipation = enabled globalUserParticipation = enabled
} }
if (context.settings().isFirstRun || url.isNullOrBlank()) { if (context.settings().isFirstNimbusRun || url.isNullOrBlank()) {
context.settings().isFirstRun = false
setExperimentsLocally(R.raw.initial_experiments) setExperimentsLocally(R.raw.initial_experiments)
context.settings().isFirstNimbusRun = false
} }
// We may have downloaded experiments on a previous run, so let's start using them // We may have downloaded experiments on a previous run, so let's start using them

@ -347,7 +347,7 @@ class Settings(private val appContext: Context) : PreferencesHolder {
default = false default = false
) )
val isFirstRun: Boolean by booleanPreference( var isFirstNimbusRun: Boolean by booleanPreference(
appContext.getPreferenceKey(R.string.pref_key_is_first_run), appContext.getPreferenceKey(R.string.pref_key_is_first_run),
default = true default = true
) )

Loading…
Cancel
Save