[fenix] For https://github.com/mozilla-mobile/fenix/issues/26087 re-enable UI tests disabled due to tabs tray migration to compose

pull/600/head
AndiAJ 2 years ago committed by mergify[bot]
parent 960ad784e3
commit 2e0f14882a

@ -17,7 +17,6 @@ import androidx.test.uiautomator.Until
import okhttp3.mockwebserver.MockWebServer import okhttp3.mockwebserver.MockWebServer
import org.junit.After import org.junit.After
import org.junit.Before import org.junit.Before
import org.junit.Ignore
import org.junit.Rule import org.junit.Rule
import org.junit.Test import org.junit.Test
import org.mozilla.fenix.R import org.mozilla.fenix.R
@ -164,7 +163,6 @@ class MenuScreenShotTest : ScreenshotTest() {
} }
@Test @Test
@Ignore("Failing after compose migration. See: https://github.com/mozilla-mobile/fenix/issues/26087")
fun tabMenuTest() { fun tabMenuTest() {
val defaultWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) val defaultWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1)
navigationToolbar { navigationToolbar {

@ -17,7 +17,6 @@ import mozilla.components.concept.engine.mediasession.MediaSession
import okhttp3.mockwebserver.MockWebServer import okhttp3.mockwebserver.MockWebServer
import org.junit.After import org.junit.After
import org.junit.Before import org.junit.Before
import org.junit.Ignore
import org.junit.Rule import org.junit.Rule
import org.junit.Test import org.junit.Test
import org.mozilla.fenix.IntentReceiverActivity import org.mozilla.fenix.IntentReceiverActivity
@ -524,7 +523,6 @@ class SmokeTest {
} }
@Test @Test
@Ignore("Failing after compose migration. See: https://github.com/mozilla-mobile/fenix/issues/26087")
fun shareTabsFromTabsTrayTest() { fun shareTabsFromTabsTrayTest() {
val firstWebsite = TestAssetHelper.getGenericAsset(mockWebServer, 1) val firstWebsite = TestAssetHelper.getGenericAsset(mockWebServer, 1)
val secondWebsite = TestAssetHelper.getGenericAsset(mockWebServer, 2) val secondWebsite = TestAssetHelper.getGenericAsset(mockWebServer, 2)
@ -572,7 +570,6 @@ class SmokeTest {
} }
@Test @Test
@Ignore("Failing after compose migration. See: https://github.com/mozilla-mobile/fenix/issues/26087")
fun privateTabsTrayWithOpenedTabTest() { fun privateTabsTrayWithOpenedTabTest() {
val website = TestAssetHelper.getGenericAsset(mockWebServer, 1) val website = TestAssetHelper.getGenericAsset(mockWebServer, 1)
@ -582,7 +579,6 @@ class SmokeTest {
homeScreen { homeScreen {
}.openNavigationToolbar { }.openNavigationToolbar {
}.enterURLAndEnterToBrowser(website.url) { }.enterURLAndEnterToBrowser(website.url) {
mDevice.waitForIdle()
}.openTabDrawer { }.openTabDrawer {
verifyNormalBrowsingButtonIsSelected(false) verifyNormalBrowsingButtonIsSelected(false)
verifyPrivateBrowsingButtonIsSelected(true) verifyPrivateBrowsingButtonIsSelected(true)
@ -592,7 +588,8 @@ class SmokeTest {
verifyExistingTabList() verifyExistingTabList()
verifyExistingOpenTabs(website.title) verifyExistingOpenTabs(website.title)
verifyCloseTabsButton(website.title) verifyCloseTabsButton(website.title)
verifyOpenedTabThumbnail() // Disabled step due to ongoing tabs tray compose refactoring, see: https://github.com/mozilla-mobile/fenix/issues/21318
// verifyOpenedTabThumbnail()
verifyPrivateBrowsingNewTabButton() verifyPrivateBrowsingNewTabButton()
} }
} }

@ -234,7 +234,6 @@ class TabbedBrowsingTest {
} }
@Test @Test
@Ignore("Failing after compose migration. See: https://github.com/mozilla-mobile/fenix/issues/26087")
fun verifyPrivateTabUndoSnackBarTest() { fun verifyPrivateTabUndoSnackBarTest() {
val genericURL = TestAssetHelper.getGenericAsset(mockWebServer, 1) val genericURL = TestAssetHelper.getGenericAsset(mockWebServer, 1)
@ -314,7 +313,6 @@ class TabbedBrowsingTest {
} }
@Test @Test
@Ignore("Failing after compose migration. See: https://github.com/mozilla-mobile/fenix/issues/26087")
fun verifyOpenTabDetails() { fun verifyOpenTabDetails() {
val defaultWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1) val defaultWebPage = TestAssetHelper.getGenericAsset(mockWebServer, 1)
@ -328,7 +326,8 @@ class TabbedBrowsingTest {
verifyTabsTrayCounter() verifyTabsTrayCounter()
verifyExistingTabList() verifyExistingTabList()
verifyNormalBrowsingNewTabButton() verifyNormalBrowsingNewTabButton()
verifyOpenedTabThumbnail() // Disabled step due to ongoing tabs tray compose refactoring, see: https://github.com/mozilla-mobile/fenix/issues/21318
// verifyOpenedTabThumbnail()
verifyExistingOpenTabs(defaultWebPage.title) verifyExistingOpenTabs(defaultWebPage.title)
verifyCloseTabsButton(defaultWebPage.title) verifyCloseTabsButton(defaultWebPage.title)
}.openTab(defaultWebPage.title) { }.openTab(defaultWebPage.title) {

@ -397,9 +397,9 @@ private fun assertCloseTabsButton(title: String) =
assertTrue( assertTrue(
mDevice.findObject( mDevice.findObject(
UiSelector() UiSelector()
.resourceId("$packageName:id/mozac_browser_tabstray_close") .descriptionContains("Close tab"),
.descriptionContains("Close tab $title"), ).getFromParent(UiSelector().textContains(title))
).waitForExists(waitingTime), .waitForExists(waitingTime),
) )
private fun normalBrowsingButton() = onView( private fun normalBrowsingButton() = onView(

Loading…
Cancel
Save