For #13959: rename to attachListenerToDisablePenaltyDeath for clarity.

pull/184/head
Michael Comella 4 years ago committed by Michael Comella
parent c03c7ef793
commit 2c1befaa25

@ -150,7 +150,7 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity {
private lateinit var navigationToolbar: Toolbar private lateinit var navigationToolbar: Toolbar
final override fun onCreate(savedInstanceState: Bundle?) { final override fun onCreate(savedInstanceState: Bundle?) {
StrictModeManager.changeStrictModePolicies(supportFragmentManager) StrictModeManager.attachListenerToDisablePenaltyDeath(supportFragmentManager)
// There is disk read violations on some devices such as samsung and pixel for android 9/10 // There is disk read violations on some devices such as samsung and pixel for android 9/10
StrictMode.allowThreadDiskReads().resetPoliciesAfter { StrictMode.allowThreadDiskReads().resetPoliciesAfter {
super.onCreate(savedInstanceState) super.onCreate(savedInstanceState)

@ -46,11 +46,11 @@ object StrictModeManager {
} }
/** /**
* Revert strict mode to disable penalty. Tied to fragment lifecycle since strict mode * Revert strict mode to disable penalty based on fragment lifecycle since strict mode
* needs to switch to penalty logs. Using the fragment life cycle allows decoupling from any * needs to switch to penalty logs. Using the fragment life cycle allows decoupling from any
* specific fragment. * specific fragment.
*/ */
fun changeStrictModePolicies(fragmentManager: FragmentManager) { fun attachListenerToDisablePenaltyDeath(fragmentManager: FragmentManager) {
fragmentManager.registerFragmentLifecycleCallbacks(object : fragmentManager.registerFragmentLifecycleCallbacks(object :
FragmentManager.FragmentLifecycleCallbacks() { FragmentManager.FragmentLifecycleCallbacks() {
override fun onFragmentResumed(fm: FragmentManager, f: Fragment) { override fun onFragmentResumed(fm: FragmentManager, f: Fragment) {

@ -63,7 +63,7 @@ class StrictModeManagerTest {
fun `test changeStrictModePolicies`() { fun `test changeStrictModePolicies`() {
val callbacks = slot<FragmentManager.FragmentLifecycleCallbacks>() val callbacks = slot<FragmentManager.FragmentLifecycleCallbacks>()
StrictModeManager.changeStrictModePolicies(fragmentManager) StrictModeManager.attachListenerToDisablePenaltyDeath(fragmentManager)
verify { fragmentManager.registerFragmentLifecycleCallbacks(capture(callbacks), false) } verify { fragmentManager.registerFragmentLifecycleCallbacks(capture(callbacks), false) }
confirmVerified(fragmentManager) confirmVerified(fragmentManager)

Loading…
Cancel
Save