For #20367 - Fixes removeAllTabs adding to recently closed

`removeAllTabs` will now no longer allow `UndoMiddleware` from recovering the tabs.
upstream-sync
codrut.topliceanu 3 years ago committed by mergify[bot]
parent d6ad8ba413
commit 2040af6a5d

@ -39,7 +39,7 @@ class DefaultDeleteBrowsingDataController(
override suspend fun deleteTabs() { override suspend fun deleteTabs() {
withContext(coroutineContext) { withContext(coroutineContext) {
removeAllTabs.invoke() removeAllTabs.invoke(false)
} }
} }

@ -71,7 +71,7 @@ class DefaultDeleteBrowsingDataControllerTest {
controller.deleteTabs() controller.deleteTabs()
verify { verify {
removeAllTabs.invoke() removeAllTabs.invoke(false)
} }
} }

@ -75,7 +75,7 @@ class DeleteAndQuitTest {
verifyOrder { verifyOrder {
snackbar.show() snackbar.show()
removeAllTabsUseCases.invoke() removeAllTabsUseCases.invoke(false)
activity.finishAndRemoveTask() activity.finishAndRemoveTask()
} }

@ -106,7 +106,7 @@ class CloseOnLastTabBindingTest {
binding.start() binding.start()
browserStore.dispatch(TabListAction.RemoveAllTabsAction) browserStore.dispatch(TabListAction.RemoveAllTabsAction())
browserStore.waitUntilIdle() browserStore.waitUntilIdle()

@ -135,7 +135,7 @@ class TelemetryMiddlewareTest {
assertEquals(2, settings.openTabsCount) assertEquals(2, settings.openTabsCount)
verify(exactly = 1) { metrics.track(Event.HaveOpenTabs) } verify(exactly = 1) { metrics.track(Event.HaveOpenTabs) }
store.dispatch(TabListAction.RemoveAllTabsAction).joinBlocking() store.dispatch(TabListAction.RemoveAllTabsAction()).joinBlocking()
assertEquals(0, settings.openTabsCount) assertEquals(0, settings.openTabsCount)
verify(exactly = 1) { metrics.track(Event.HaveNoOpenTabs) } verify(exactly = 1) { metrics.track(Event.HaveNoOpenTabs) }
} }

Loading…
Cancel
Save