[fenix] For https://github.com/mozilla-mobile/fenix/issues/18770 - Correct addons position in three dot menu based on toolbar position (https://github.com/mozilla-mobile/fenix/pull/18828)

pull/600/head
Elise Richards 4 years ago committed by GitHub
parent 242ea763de
commit 16c4823bef

@ -83,13 +83,13 @@ open class DefaultToolbarMenu(
} else { } else {
oldCoreMenuItems oldCoreMenuItems
}, },
endOfMenuAlwaysVisible = !shouldUseBottomToolbar, endOfMenuAlwaysVisible = shouldUseBottomToolbar,
store = store, store = store,
webExtIconTintColorResource = primaryTextColor, webExtIconTintColorResource = primaryTextColor,
onAddonsManagerTapped = { onAddonsManagerTapped = {
onItemTapped.invoke(ToolbarMenu.Item.AddonsManager) onItemTapped.invoke(ToolbarMenu.Item.AddonsManager)
}, },
appendExtensionSubMenuAtStart = !shouldUseBottomToolbar appendExtensionSubMenuAtStart = shouldUseBottomToolbar
) )
} }
@ -374,6 +374,7 @@ open class DefaultToolbarMenu(
menuItems.reversed() menuItems.reversed()
} }
} }
val newTabItem = BrowserMenuImageText( val newTabItem = BrowserMenuImageText(
context.getString(R.string.library_new_tab), context.getString(R.string.library_new_tab),
R.drawable.ic_new, R.drawable.ic_new,
@ -402,21 +403,21 @@ open class DefaultToolbarMenu(
id = WebExtensionPlaceholderMenuItem.MAIN_EXTENSIONS_MENU_ID id = WebExtensionPlaceholderMenuItem.MAIN_EXTENSIONS_MENU_ID
) )
val accountManager = context.components.backgroundServices.accountManager val accountManager = context.components.backgroundServices.accountManager
val account = accountManager.authenticatedAccount() val account = accountManager.authenticatedAccount()
val syncItemTitle = if (account != null && accountManager.accountProfile()?.email != null) { val syncItemTitle = if (account != null && accountManager.accountProfile()?.email != null) {
context.getString(R.string.sync_signed_as, accountManager.accountProfile()?.email) context.getString(R.string.sync_signed_as, accountManager.accountProfile()?.email)
} else { } else {
context.getString(R.string.sync_menu_sign_in) context.getString(R.string.sync_menu_sign_in)
} }
val syncedTabs = BrowserMenuImageText( val syncedTabs = BrowserMenuImageText(
syncItemTitle, syncItemTitle,
R.drawable.ic_synced_tabs, R.drawable.ic_synced_tabs,
primaryTextColor() primaryTextColor()
) { ) {
onItemTapped.invoke(ToolbarMenu.Item.SyncedTabs) onItemTapped.invoke(ToolbarMenu.Item.SyncedTabs)
} }
val findInPageItem = BrowserMenuImageText( val findInPageItem = BrowserMenuImageText(
label = context.getString(R.string.browser_menu_find_in_page), label = context.getString(R.string.browser_menu_find_in_page),

Loading…
Cancel
Save