For issue #9647 Crash when tapping settings after quickly

enabling/disabling add-on
fennec/production
Arturo Mejia 4 years ago
parent 3789f50423
commit 025656d8fd

@ -168,6 +168,7 @@ class InstalledAddonDetailsFragment : Fragment() {
val optionsPageUrl = addon.installedState?.optionsPageUrl val optionsPageUrl = addon.installedState?.optionsPageUrl
isVisible = !optionsPageUrl.isNullOrEmpty() isVisible = !optionsPageUrl.isNullOrEmpty()
setOnClickListener { setOnClickListener {
val settingUrl = addon.installedState?.optionsPageUrl ?: return@setOnClickListener
val directions = if (addon.installedState?.openOptionsPageInTab == true) { val directions = if (addon.installedState?.openOptionsPageInTab == true) {
val components = it.context.components val components = it.context.components
val shouldCreatePrivateSession = val shouldCreatePrivateSession =
@ -176,9 +177,9 @@ class InstalledAddonDetailsFragment : Fragment() {
?: false ?: false
if (shouldCreatePrivateSession) { if (shouldCreatePrivateSession) {
components.tabsUseCases.addPrivateTab(optionsPageUrl as String) components.tabsUseCases.addPrivateTab(settingUrl)
} else { } else {
components.tabsUseCases.addTab(optionsPageUrl as String) components.tabsUseCases.addTab(settingUrl)
} }
InstalledAddonDetailsFragmentDirections InstalledAddonDetailsFragmentDirections

Loading…
Cancel
Save