Commit Graph

647 Commits

Author SHA1 Message Date
Josh Rabinowitz
aec3ac1ae2
Add note about writing tests. Fix typo. (#471)
Also use affect, not effect, as appropriate.
2019-04-29 18:21:30 -04:00
Simon Massey
2164e822d2
remove dead code for keys/mapping.cfg (#464) 2019-04-29 20:36:08 +01:00
Simon Massey
78287b7b98
git secret hide docs warns about -F but not -m behaviour #467 (#468) 2019-04-29 06:56:34 +01:00
Josh Rabinowitz
05421347ff
Merge pull request #463 from sobolevn/improve_assert_keychain_contains_emails
break loop when email found in keyring
2019-04-28 12:13:43 -04:00
Josh Rabinowitz
c65766924b
Merge branch 'master' into improve_assert_keychain_contains_emails 2019-04-28 09:48:47 -04:00
Josh Rabinowitz
ee8938c512
Merge pull request #461 from sobolevn/simbo1905-patch-1
missing word in CONTRIBUTING.md
2019-04-28 09:48:35 -04:00
Simon Massey
0e4e432727 break loop when email found in keyrig 2019-04-27 22:21:06 +01:00
Simon Massey
8ed0f21635
missing word 2019-04-27 21:35:23 +01:00
Josh Rabinowitz
44a8745e02
remove duplicate test (#458) 2019-04-01 15:00:42 -04:00
Josh Rabinowitz
bbb4d9d3e5
Tmp cleanups (#457)
* Only show 'cleaning up temp file' messages if one
  of SECRETS_VERBOSE or SECRETS_TEST_VERBOSE is set.
* Adjust tests to reflect the change.
* Add note about suppressing 'cleaning up' msgs to CHANGELOG.md and reorder entries
* add comments showing examples of tmpfiles returned
2019-04-01 12:53:19 -04:00
Josh Rabinowitz
24bfc86b74
Fail on extra params (#448)
* fail if user passes unexpected filenames or unknown params
* mention fix of #390
2019-03-30 20:13:54 -04:00
Josh Rabinowitz
2341d1433b
Temp dir fixes (#449)
* perform our test install into TMPDIR
* fix typo
* remove duplicate entry in CHANGELOG.md
* improve commenting
2019-03-29 18:11:52 -04:00
Josh Rabinowitz
cb1636a6dc
experimental SECRETS_TEST_VERBOSE shows debug info during tests (#446)
* add a travis target using SECRETS_TEST_VERBOSE=1
* Document SECRETS_TEST_VERBOSE as experimental
* note experimental feature may change or be removed
2019-03-28 07:41:07 -04:00
Josh Rabinowitz
fc85d05fc0
Use /tmp/subdir for testing, not /tmp. (#442) 2019-03-27 01:10:07 -04:00
Josh Rabinowitz
f6d4de1adf
Use git check-ignore (#440)
* improve how we check for ignored files using 'git check-ignore'
* mention use of git check-ignore in changelog
* don't mkdir/rmdir when testing for ignored files
2019-03-25 15:00:46 -04:00
Josh Rabinowitz
8334d7beef
Reveal verbose (#447)
* add -v option to reveal, for #395
* update reveal man page
* shellcheck exception
* changelog update for 'reveal -v'
2019-03-25 11:37:24 -04:00
Josh Rabinowitz
07af0c19b6
Varnames output and typos (#441)
* rename variable, fix typo, improve comments and output
* fix directory removal after testing
* mention improved user messaging in CHANGELOG.md
2019-03-23 19:48:08 -04:00
Josh Rabinowitz
be88da4c0c
test 'DESTDIR=/dir/here make install' support (#438) 2019-03-21 21:32:36 -04:00
Josh Rabinowitz
4bcf6c054a
respect DESTDIR as per GNU/debian/etc (#437) 2019-03-21 16:10:13 -04:00
Josh Rabinowitz
ec4232faec
Update to mention git-secret packaging in Fedora (#436) 2019-03-20 23:04:14 -04:00
Gergely Gombos
dd02a6f657 Update readme - add Fedora package link (#434) 2019-03-20 20:55:22 -04:00
Josh Rabinowitz
ce8c6b3ae0
Change 'add' to add to .gitignore by default. (#429)
* Change 'add' to add to .gitignore by default.
Also add _message() function and improve output from 'git-secret-add',
alter tests for new code behavior, and update docs.
* change tests since 'add' always adds to .gitignore
* improve output: prepend more message with 'git-secret:'.
* update man page for git-secret-add
2019-03-20 08:03:28 -04:00
Josh Rabinowitz
71f3d3a4ac
Make sure we name temp files 'git-secret-*' (#428)
* pass mktemp a template on linux
* name tempfiles git_secret, not gitsecrets
2019-03-17 19:32:42 -04:00
Josh Rabinowitz
8737bdb26c
show full commands, including args, in Makefile (#422)
* show full commands, including args, run from Makefile
 As per recommendations at https://wiki.debian.org/UpstreamGuide
2019-03-17 16:54:35 -04:00
Simon Massey
6a93549179
Automate the GitHub release (#411) 2019-03-17 16:23:34 +00:00
Josh Rabinowitz
70fd1bcd80
Revert "Re enable testing on travis windows (#423)" (#425)
This reverts commit 9b83d9cee6.
2019-03-15 13:29:25 -04:00
Josh Rabinowitz
9b83d9cee6
Re enable testing on travis windows (#423)
* re-enable testing on windows with travis
* add diagnostic/debug output
2019-03-15 12:06:52 -04:00
Josh Rabinowitz
7a730e4a4f
do lint/shellcheck tests on travis mac builds (#415)
* perform lint/shellcheck tests on travis mac builds
* move osx builds first in travis
* install shellcheck on macos
* show if the lint test passed or failed
* don't have travis install ruby 2.6 on osx for now
2019-03-12 15:41:54 -04:00
Josh Rabinowitz
3c4f00922b
disable windows travis test because of #409 (#410)
Windows travis tests disabled because they work on
PRs but not on master.
2019-03-09 21:27:38 -05:00
Josh Rabinowitz
f68a56ecd8
Add to changelog, rename function, add comment. (#408) 2019-03-09 20:12:45 -05:00
Jonas Karlsson
54f74ede6a Fix for windows (#375)
* add test for travis-ci windows support
* Make 'ps' command options platform specific *nix/windows
* Add _clean_path for windows,  apply to all homedir input arguments
* export GITSECRET_DIST="windows" in git hook if running windows
* Bash lint fixes
2019-03-09 18:49:45 -05:00
Josh Rabinowitz
8adb7d5741
Revert "use pgrep & kill $pid, not ps+gawk+regex+system+kill (#400)" (#405)
This reverts commit a2a9bd32ba.
2019-03-09 13:14:44 -05:00
Josh Rabinowitz
a2a9bd32ba
use pgrep & kill $pid, not ps+gawk+regex+system+kill (#400)
* use pgrep & kill, not ps+gawk+regex+system+kill
* install shellcheck and enable lint on macos/brew.
* add shellcheck fixes and exception
* reorder CHANGELOG entries
2019-03-09 10:14:47 -05:00
Josh Rabinowitz
792226c624
Categorize each CHANGELOG.md entry by type (#401)
* categorize entries as Feature/Fix/Doc/Test/Build
* filled in CHANGELOG.md for initial release 0.1.0
* use section headers as suggested by @sobolevn
2019-03-08 09:33:02 -05:00
Josh Rabinowitz
52b46ae700
Add docs for SECRETS_VERBOSE, env vars (#398) 2019-03-07 20:25:06 -05:00
Josh Rabinowitz
22fe1ed2d4
Add support for SECRETS_VERBOSE env var (#393)
* Support SECRETS_VERBOSE env var in addition to -v
* don't use --quiet when decrypting in verbose mode
* show output of gpg encryption in verbose mode
* add tests for SECRETS_VERBOSE env var set to 0 and 1
* update changelog, reorder entries.
* add tests for 'cat' and 'hide' with SECRETS_VERBOSE=1
2019-03-07 17:46:51 -05:00
Josh Rabinowitz
c4331693f3
use 'kill', not 'kill -9' (#379) 2019-03-07 15:17:51 -05:00
Josh Rabinowitz
cdad4aba37
Add man page header, for debian lintian (#392)
* Add man page header, for debian lintian
* update man/man7/git-secret.7 to match .ronn
2019-03-06 17:01:59 -05:00
Josh Rabinowitz
faa03c7380
alter changelog for fix of #389 (#391) 2019-03-05 22:01:13 -05:00
Josh Rabinowitz
bab5c739ff
Use SECRETS_GPG_COMMAND in gpg version check (#389)
Closes #388
2019-03-05 16:51:59 -05:00
Josh Rabinowitz
b1d3cb99c5
remove deprecated git-secret.plugin.zsh (#387) 2019-03-05 15:05:35 -05:00
Josh Rabinowitz
7b06b25c0a
Respect secrets dir on init, and document (#366)
* respect SECRETS_DIR and SECRETS_EXTENSION in tests
* add line regarding fixes to CHANGELOG.md
* test with non-standard SECRETS_EXTENSION
* Add details about init, mention SECRETS_EXTENSION in init page
* update git-secret-init man page
2019-03-05 08:41:13 -05:00
Josh Rabinowitz
e2754adebe
Doc changes 2019 02 for #351 (#353)
* clarification about killperson and secrets, rephrasing.
* how to develop without docker/test-kitchen
* doc changes about gh-pages branch. other clarifications.
* OSX has been renamed MacOS (except in travis-ci)
2019-03-05 07:09:27 -05:00
Josh Rabinowitz
5360384085
Import bats core (#380)
* bats-core v1.1.0 imported
* target 'install-test' removed from Makefile
* info re: bats-core import added in vendor/bats-core/README.md
2019-03-04 18:52:53 -05:00
Josh Rabinowitz
505cb1fe42 have lint target run shellcheck over tests (closes #373)
* have lint target run shellcheck over tests

* lint and fix tests/ since shellcheck knows bats

* lint and fix tests/ since shellcheck knows bats

* revert debug output

* changes for shellcheck

* revert unintended change

  [tests/_test_base.bash]

* use 'local' for user/filename vars, not 'export'

* add note about Shellcheck and tests/

* local can only be used in functions - use export

* restore shbang edited in error
2019-03-04 17:40:35 +03:00
Josh Rabinowitz
ae465c0142
Upgrade bats core (#371)
* upgrade bats-core to v1.1.0, note in CHANGELOG.md
2019-03-02 12:03:17 -05:00
Josh Rabinowitz
6188d14539
Documentation additions about code style and philosophy (#361)
* code style in CONTRIBUTING.md and PR template
* make link to CONTRIBUTING.md in .github/PULL_REQUEST_TEMPLATE.md
* mention shellcheck and 'make lint'
* mention that you should update CHANGELOG.md 
* mention spellchecking with aspell
* more spelling fixes
* add to CHANGELOG about style guide/dev philosophy
* remind contributors to update .ronn file/man page
2019-02-21 18:04:23 -05:00
Josh Rabinowitz
83b03b61bc
Aspell fixes (#365)
* spellcheck fixes from aspell
2019-02-21 15:20:34 -05:00
Josh Rabinowitz
9778d20791
track recent changes to git-secret (#363) 2019-02-21 13:01:58 -05:00
Flávio Caetano
9e9803d561 add secret files pattern to .gitignore on init (#359) 2019-02-20 00:10:18 +03:00