Add to changelog, rename function, add comment. (#408)

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Features
 
+- Support automated testing on windows with Travis CI (#372)
 - Support SECRETS_VERBOSE env var to enable verbosity (#323)
 - Use gpg without --quiet when decrypting in verbose mode (#394)
 - Add -v 'verbose' option to 'tell', showing gpg output (#320)

src/_utils/_git_secret_tools.sh

@@ -147,8 +147,9 @@ function _os_based {
 
 # File System:
 
-function _clean_path {
+function _clean_windows_path {
   # This function transforms windows paths to *nix paths
+  # such as  c:\this\that.file -> /c/this/that/file
   # shellcheck disable=SC2001
   echo "$1" | sed 's#^\([a-zA-Z]\):/#/\1/#'
 }
@@ -365,7 +366,7 @@ function _get_git_root_path {
   # since `.gitsecret` (or value set by SECRETS_DIR env var) must be on the same level.
 
   local result
-  result=$(_clean_path "$(git rev-parse --show-toplevel)")
+  result=$(_clean_windows_path "$(git rev-parse --show-toplevel)")
   echo "$result"
 }
 

src/commands/git_secret_cat.sh

@@ -13,7 +13,7 @@ function cat {
 
       p) passphrase=$OPTARG;;
 
-      d) homedir=$(_clean_path "$OPTARG");;
+      d) homedir=$(_clean_windows_path "$OPTARG");;
 
       *) _invalid_option_for 'cat';;
     esac

src/commands/git_secret_changes.sh

@@ -11,7 +11,7 @@ function changes {
 
       p) passphrase=$OPTARG;;
 
-      d) homedir=$(_clean_path "$OPTARG");;
+      d) homedir=$(_clean_windows_path "$OPTARG");;
 
       *) _invalid_option_for 'changes';;
     esac

src/commands/git_secret_reveal.sh

@@ -22,7 +22,7 @@ function reveal {
 
       p) passphrase=$OPTARG;;
 
-      d) homedir=$(_clean_path "$OPTARG");;
+      d) homedir=$(_clean_windows_path "$OPTARG");;
 
       *) _invalid_option_for 'reveal';;
     esac

src/commands/git_secret_tell.sh

@@ -34,7 +34,7 @@ function tell {
 
       m) self_email=1;;
 
-      d) homedir=$(_clean_path "$OPTARG");;
+      d) homedir=$(_clean_windows_path "$OPTARG");;
 
       *) _invalid_option_for 'tell';;
     esac