Panic when fzf was built without version information

So that the package maintainers would immediately know that the build is
incorrect. But is there a way to make build simply fail?

Related: https://github.com/junegunn/fzf.vim/issues/1150
pull/2233/head 0.24.0-1
Junegunn Choi 4 years ago
parent 0d5f862daf
commit 3304f284a5
No known key found for this signature in database
GPG Key ID: 254BC280FEF9C627

@ -17,20 +17,11 @@ make
# Build fzf binary and copy it to bin directory # Build fzf binary and copy it to bin directory
make install make install
# Build 32-bit and 64-bit executables and tarballs in target # Build fzf binaries and archives for all platforms using goreleaser
make release make build
# Make release archives for all supported platforms in target
make release-all
```
### Using `go get`
Alternatively, you can build fzf directly with `go get` command without # Publish GitHub release
manually cloning the repository. make release
```sh
go get -u github.com/junegunn/fzf
``` ```
Third-party libraries used Third-party libraries used

@ -9,6 +9,9 @@ var version string
var revision string var revision string
func main() { func main() {
if len(version) == 0 {
panic("Invalid build: version information missing")
}
protector.Protect() protector.Protect()
fzf.Run(fzf.ParseOptions(), version, revision) fzf.Run(fzf.ParseOptions(), version, revision)
} }

Loading…
Cancel
Save