replace trait object BufRead by generic

pull/199/head
TA Thanh Dinh 6 years ago committed by David Peter
parent 94ccc646e8
commit 037861e588

@ -86,25 +86,26 @@ fn print_file(
printer: &mut Printer, printer: &mut Printer,
filename: Option<&str>, filename: Option<&str>,
) -> Result<()> { ) -> Result<()> {
let stdin = io::stdin(); // TODO: this is not always needed printer.print_header(filename)?;
{
let reader: Box<BufRead> = match filename { let highlighter = HighlightLines::new(syntax, theme);
None => Box::new(stdin.lock()), match filename {
Some(filename) => Box::new(BufReader::new(File::open(filename)?)), None => {
}; let stdin = io::stdin(); // TODO: this is not always needed
print_file_ranges(printer, stdin.lock(), highlighter, &printer.config.line_range)?;
let highlighter = HighlightLines::new(syntax, theme); },
Some(filename) => {
printer.print_header(filename)?; print_file_ranges(printer, BufReader::new(File::open(filename)?), highlighter, &printer.config.line_range)?
print_file_ranges(printer, reader, highlighter, &printer.config.line_range)?; },
printer.print_footer()?;
} }
printer.print_footer()?;
Ok(()) Ok(())
} }
fn print_file_ranges<'a>( fn print_file_ranges<T: BufRead>(
printer: &mut Printer, printer: &mut Printer,
mut reader: Box<BufRead + 'a>, mut reader: T,
mut highlighter: HighlightLines, mut highlighter: HighlightLines,
line_ranges: &Option<LineRange>, line_ranges: &Option<LineRange>,
) -> Result<()> { ) -> Result<()> {

Loading…
Cancel
Save