Use new FactoryGirl syntax exclusively

openid
Marcin Kulik 12 years ago
parent 42f8ea63de
commit 67a182d6ca

@ -2,8 +2,8 @@ require 'spec_helper'
describe Api::CommentsController do describe Api::CommentsController do
let(:user) { Factory(:user) } let(:user) { FactoryGirl.create(:user) }
let(:asciicast) { Factory(:asciicast) } let(:asciicast) { FactoryGirl.create(:asciicast) }
before do before do
login_as(user) login_as(user)
@ -83,7 +83,7 @@ describe Api::CommentsController do
end end
context "when user is not creator of comment" do context "when user is not creator of comment" do
let(:other_user) { Factory(:user) } let(:other_user) { FactoryGirl.create(:user) }
before do before do
comment.stub(:user).and_return(other_user) comment.stub(:user).and_return(other_user)

@ -5,7 +5,7 @@ describe HomeController do
describe "GET 'show'" do describe "GET 'show'" do
describe 'when there is at least one featured cast' do describe 'when there is at least one featured cast' do
before do before do
Factory(:asciicast, :featured => true) FactoryGirl.create(:asciicast, :featured => true)
end end
it "returns http success" do it "returns http success" do
@ -16,7 +16,7 @@ describe HomeController do
describe 'when there is no featured cast but any cast exists' do describe 'when there is no featured cast but any cast exists' do
before do before do
Factory(:asciicast, :featured => false) FactoryGirl.create(:asciicast, :featured => false)
end end
it "returns http success" do it "returns http success" do

@ -19,7 +19,7 @@ describe SessionsController do
context "user exists" do context "user exists" do
before do before do
Factory(:user, :provider => provider, :uid => uid) FactoryGirl.create(:user, :provider => provider, :uid => uid)
post :create post :create
end end

@ -2,7 +2,7 @@ require 'spec_helper'
describe UserTokensController do describe UserTokensController do
describe '#create' do describe '#create' do
let(:user) { Factory(:user) } let(:user) { FactoryGirl.create(:user) }
let(:user_token) { FactoryGirl.build(:user_token, :user => nil) } let(:user_token) { FactoryGirl.build(:user_token, :user => nil) }
before do before do

@ -6,10 +6,10 @@ describe Asciicast do
end end
describe '.assign_user' do describe '.assign_user' do
let(:user) { Factory(:user) } let(:user) { FactoryGirl.create(:user) }
let(:token) { 'token' } let(:token) { 'token' }
let!(:asciicast) do let!(:asciicast) do
Factory(:asciicast, :user => nil, :user_token => token) FactoryGirl.create(:asciicast, :user => nil, :user_token => token)
end end
subject { Asciicast.assign_user(token, user) } subject { Asciicast.assign_user(token, user) }
@ -47,13 +47,13 @@ describe Asciicast do
end end
describe '#assign_user' do describe '#assign_user' do
let(:user) { Factory(:user) } let(:user) { FactoryGirl.create(:user) }
let(:asciicast) do let(:asciicast) do
Factory(:asciicast, :user => nil, :user_token => user_token) FactoryGirl.create(:asciicast, :user => nil, :user_token => user_token)
end end
context 'when user exists with given token' do context 'when user exists with given token' do
let(:user_token) { Factory(:user_token, :user => user).token } let(:user_token) { FactoryGirl.create(:user_token, :user => user).token }
it 'assigns user and resets user_token' do it 'assigns user and resets user_token' do
asciicast.assign_user asciicast.assign_user

@ -9,7 +9,7 @@ describe User do
end end
describe "validation" do describe "validation" do
let(:user) { Factory(:user) } let(:user) { FactoryGirl.create(:user) }
it "validates nickname uniqueness" do it "validates nickname uniqueness" do
new_user = FactoryGirl.build(:user) new_user = FactoryGirl.build(:user)
@ -65,7 +65,7 @@ describe User do
end end
context "when nickname is taken" do context "when nickname is taken" do
let!(:user) { Factory(:user) } let!(:user) { FactoryGirl.create(:user) }
let(:nickname) { user.nickname } let(:nickname) { user.nickname }
it "doesn't create user" do it "doesn't create user" do
@ -91,7 +91,7 @@ describe User do
end end
context "when user doesn't have given token" do context "when user doesn't have given token" do
let(:existing_token) { Factory(:user_token, :user => user) } let(:existing_token) { FactoryGirl.create(:user_token, :user => user) }
let(:token) { existing_token.token } let(:token) { existing_token.token }
it 'returns existing UserToken' do it 'returns existing UserToken' do

Loading…
Cancel
Save