Move presentation to decorator

app/controllers/asciicasts_controller.rb

@@ -1,23 +1,32 @@
 class AsciicastsController < ApplicationController
   PER_PAGE = 20
 
-  before_filter :load_resource, :only => [:edit, :update, :destroy]
+  before_filter :load_resource, :only => [:show, :edit, :update, :destroy]
   before_filter :ensure_authenticated!, :only => [:edit, :update, :destroy]
   before_filter :ensure_owner!, :only => [:edit, :update, :destroy]
 
   respond_to :html, :json
 
   def index
-    @asciicasts = Asciicast.
+    collection = Asciicast.
-      order("created_at DESC").
+                   order("created_at DESC").
-      page(params[:page]).
+                   page(params[:page]).
-      per(PER_PAGE)
+                   per(PER_PAGE)
+
+    @asciicasts = AsciicastDecorator.decorate(collection)
   end
 
   def show
-    @asciicast = AsciicastDecorator.find(params[:id])
+    respond_to do |format|
-    @title = @asciicast.smart_title
+      format.html do
-    respond_with @asciicast.model
+        @asciicast = AsciicastDecorator.new(@asciicast)
+        @title = @asciicast.smart_title
+      end
+
+      format.json do
+        respond_with @asciicast
+      end
+    end
   end
 
   def edit

app/decorators/asciicast_decorator.rb

@@ -4,6 +4,30 @@ class AsciicastDecorator < ApplicationDecorator
   THUMBNAIL_WIDTH = 20
   THUMBNAIL_HEIGHT = 10
 
+  def os
+    if uname =~ /Linux/
+      'Linux'
+    elsif uname =~ /Darwin/
+      'OSX'
+    else
+      uname.split(' ', 2)[0]
+    end
+  end
+
+  def shell_name
+    File.basename(shell.to_s)
+  end
+
+  def smart_title
+    if title.present?
+      title
+    elsif command.present?
+      "$ #{command}"
+    else
+      "##{id}"
+    end
+  end
+
   def thumbnail
     if @thumbnail.nil?
       lines = model.snapshot.split("\n")

app/models/asciicast.rb

@@ -38,20 +38,6 @@ class Asciicast < ActiveRecord::Base
     self.terminal_type    = data['term']['type']
   end
 
-  def os
-    if uname =~ /Linux/
-      'Linux'
-    elsif uname =~ /Darwin/
-      'OSX'
-    else
-      uname.split(' ', 2)[0]
-    end
-  end
-
-  def shell_name
-    File.basename(shell.to_s)
-  end
-
   def as_json(opts = {})
     super :methods => [:escaped_stdout_data, :stdout_timing_data]
   end
@@ -83,14 +69,4 @@ class Asciicast < ActiveRecord::Base
       end
     end
   end
-
-  def smart_title
-    if title.present?
-      title
-    elsif command.present?
-      "$ #{command}"
-    else
-      "##{id}"
-    end
-  end
 end