Archives/OpenTTD-patches
2
0
Fork 0
mirror of https://github.com/JGRennison/OpenTTD-patches.git synced 2024-11-17 21:25:40 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,462 Commits 12 Branches 180 Tags 451 MiB
caeabecea2
Commit Graph

89 Commits

Author SHA1 Message Date
Darkvater
990270fda9 (svn r7637) -Codechange: Change ShowQueryString to use a window pointer as a parent. If the 
query has no parent (eg give money, rename waypoint), the global function
 HandleOnEditText is used.
 2006-12-30 01:17:53 +00:00
Darkvater
04628a1979 (svn r7565) -Codechange: Rework DEBUG functionality. Look for appropiate debugging levels to 
use in debug.h. grfmsg() is now used as a specific debug-function for grf.
 2006-12-26 17:36:18 +00:00
Darkvater
0fabe8f8ef (svn r7446) -Feature: Double the length of the cargo and rating indicators in the station list window, 
thanks for the inspiration Rince. Workings of the small 1-pixel wide bar have changed a
 little. Up till now it was pretty random, now it is only drawn for stations with minimal
 amount of cargo (<=30) and 1-pixel height is 5 units.
 2006-12-09 00:46:02 +00:00
Darkvater
8559b4e726 (svn r7445) -Codechange (r4822): Properly draw the cargo colours in the station list and centre the 
cargo abbreviations. The window at least looks a lot better this way.
 2006-12-09 00:41:25 +00:00
Darkvater
259967a78c (svn r7444) -Codechange: Use one (global) cargo-colours array for drawing cargo-colours. Change Food 
colour to pink everywhere (fixes FS#303)
 2006-12-09 00:37:02 +00:00
belugas
a999104645 (svn r7432) -Fix(r7413) : The NO(cargo waiting) button of the StationList Window is now part of the cargo selection scheme. Again. 2006-12-08 02:25:04 +00:00
belugas
4b95605807 (svn r7428) -Codechange: Give a more explicit name to the enum STATIONLIST_WIDGET_CARGONONE. 
It is not "No Cargo selected", but rather station with no cargo waiting, thus STATIONLIST_WIDGET_NOCARGOWAITING.
Hoping it is now clearer for everyone (mainly me...).
Will fix the behaviour next time.
 2006-12-07 21:21:02 +00:00
belugas
5b4d3daf0e (svn r7413) -Fix[FS#386,#412]: Station list window NONE button now behaves correctly. 
-Fix: Clicking on SORT button (same window) does not reset everything anymore.
-Featurette: cargo, NONE and both ALL buttons are now shown fully down on pressed, as the text is deported by one pixel on y and y
Some widgets enum and code clean-up
 2006-12-07 04:12:29 +00:00
matthijs
e6ade36de1 (svn r7372) - CodeChange: Rename all GetXXXArraySize() functions to GetNumXXX() and add GetMaxXXXIndex() functions. This prepares for the new pool interface. 2006-12-05 13:58:20 +00:00
peter1138
7fe387708f (svn r7209) -Codechange: Alter position of scroll bar in the station list; the filter line isn't scrollable... 2006-11-18 17:34:20 +00:00
Darkvater
c01c294afb (svn r7205) -Fix [FS#350, SF#1560913]: Window allocation and deletion messed with the actual window 
structs inside their array, and possibly invalidating pointers higher up.
 Meaning that any function called within an wndproc could cause unknown/invalid pointers
 once control was returned to this function. Solved by the introduction of an extra
 abstraction layer, an array of z-window positions that is only concerned with the
 pointers.
 2006-11-18 16:47:02 +00:00
Darkvater
e786cd5c6b (svn r7128) -Codechange: Replace magic numbers by magic enums (windowdesc positioning WDP_AUTO = -1) 2006-11-10 19:24:14 +00:00
peter1138
bc92e4ee9b (svn r7080) -Codechange: Remove negative array indexes, and only add ", " when needed, when building station acceptance lists. 2006-11-06 15:25:02 +00:00
Darkvater
0e1485f55e (svn r7022) -Fix [FS#292]: Properly guard against viewing company-sensitive information from 
invalid players (eg spectators) which could lead to crashes.
 2006-10-31 21:15:56 +00:00
Darkvater
c7c65ce6d5 (svn r6925) -Codechange: Be more strict with widget distinctions. WWT_PANEL is only plain panel, 
WWT_IMGBTN must contain an image for drawing. Renamed WWT_PANEL_2 to WWT_IMGBTN_2
 because that is what it is. Added WWT_PUSHBTN that is either just a pushable button,
 or a textbutton, which text's drawn dynamically independent of widget.
 2006-10-24 14:15:17 +00:00
Darkvater
494c56475f (svn r6884) -Codechange: Add strict bounds checking in string formatting system. 
The last parameter should point to the end of the buffer (eg lastof(buf))
 Courtesy of Tron.
 2006-10-21 23:31:34 +00:00
peter1138
68dda86c5b (svn r6855) - Codechange: When displaying a "quantity of cargo" string, use the {CARGO} command and supply the cargo type and quantity, instead of manually looking up the cargo type's string. 2006-10-20 11:53:29 +00:00
belugas
3319eb0b3f (svn r6639) -CodeChange : Conversion of SetWidgetLoweredState to SetWindowWidgetLoweredState, in order to follow pre-established standard 2006-10-04 19:11:43 +00:00
belugas
688da1d940 (svn r6631) -Codechange: Use accessors for click_state. 
Another step toward merging XTDwidget.
The only two files not converted (window.h and widget.c) will be done at the very last commit)
 2006-10-03 20:16:20 +00:00
belugas
cf210fdf6b (svn r6619) -Codechange: Use accessors for disabled_state. 
Another step toward merging XTDwidget.
The only two files not converted (window.h and widget.c) will be done at the very last commit)
 2006-10-03 02:08:15 +00:00
bjarni
1f2ed9d731 (svn r6562) -Codechange: merged the vehicle list window widget arrays 
It made no sense to maintain 8 nearly identically arrays when a single one can do the job
  Also made the two buttons always use half of the bottom width each, even when resizing
 2006-09-28 23:05:03 +00:00
belugas
98ba395277 (svn r6499) -Codechange: Finally, got "byte event" outside of the union WindowEvent, which is now a struct 2006-09-23 02:39:24 +00:00
rubidium
21ac20aeca (svn r6381) -Cleanup: make the '/* */' comments that span multiple lines more uniform. 
-Cleanup: whitespace alignment of a few tables.
 2006-09-04 20:40:33 +00:00
Darkvater
9f73fce941 (svn r6169) -Codechange: Use GetString() instead of GetStringWithArgs() which should be 
integral to strings.c
 2006-08-27 10:04:33 +00:00
truelight
15aff22c96 (svn r6055) -Codechange: added GetXXXArraySize, which returns HighestID + 1 (or, will do that). 
It isn't the best name, but we couldn't find any better.
  This unifies the pool-system even more.
 2006-08-22 20:41:26 +00:00
truelight
505566da5c (svn r6047) -Codechange: FOR_ALL now _only_ loops valid items, and skips invalid ones 
-Codechange: use IsValidXXX where ever possible
  Note: both changes to prepare for new pool system, which needs those changes.
  For every pool there are 2 ugly lines, which will be removed when done
  implementing new pool system.
  Based on FS#13 by blathijs, partly implemented.
 2006-08-22 15:33:35 +00:00
rubidium
908d3bcfe6 (svn r6045) -Cleanup: align all table-like structures using spaces, i.e. whitespace fixes only except for a few comments to make them uniform for the whole enum/struct. 2006-08-22 14:38:37 +00:00
truelight
d3f2180438 (svn r5944) -Merge TGP (r5578, r5579, r5724, r5726): -Feature: filter for textboxes to only 
allow certain patterns (like numbers only)
 2006-08-19 09:31:22 +00:00
Darkvater
b293c7a4e1 (svn r5910) Fix some more warnings on MSVC by using (void*) casts. Followup of r5907. 2006-08-15 09:28:27 +00:00
tron
5cf43b9f3c (svn r5907) Remove more indirection by using pointers instead of IDs. Also fix some bogus warnings on MSVC by using (void*) casts 2006-08-15 07:07:17 +00:00
tron
c3d407a5ba (svn r5896) Remove pointless indirection similar to r5894 and remove an unnecessary global variable 2006-08-14 21:02:48 +00:00
rubidium
9fc837ad85 (svn r5887) -Cleanup: move date related functions, defines and variables to date.[ch] 
-Cleanup: fix whitespace related coding style issues in date.[ch]
-Cleanup: make original comments doxygen compatible and remove/change outdated comments
 2006-08-14 14:21:15 +00:00
Darkvater
8fbed228a3 (svn r4891) - Fix (r4822): The station list window had some overlapping widgets (peter1138) 2006-05-16 18:01:20 +00:00
Darkvater
bd3ccca31a (svn r4830) - Codechange: simplify station sorting a bit by recalculating the clicked-states on drawing the window. This also allows the 'Sort by' button to be visually clickable 2006-05-11 15:14:50 +00:00
celestar
53e034cd9b (svn r4823) -Fix: Improved tooltips for sortable station lists. 
-Credit: Chrishuebsch for initial idea and implementation of station filters
 2006-05-11 11:24:09 +00:00
celestar
b5dd3ddbd5 (svn r4822) -Feature: Station List View can now be sorted and filtered (by waiting cargo type and facilities) 2006-05-11 10:33:58 +00:00
belugas
6ac73b104e (svn r4426) Code Cleaning : replacing tabs with spaces, removing obvious comments, aligning arrays etc... 2006-04-15 03:08:14 +00:00
peter1138
5f3dc36983 (svn r3270) Correct all (mis)uses of WWT_CLOSEBOX / WWT_TEXTBTN to reflect their actual use, and add "Close Window" tooltip where missing. 2005-12-07 15:48:52 +00:00
tron
9d0e7b6458 (svn r3181) -Bracing 
-Indentation
-Whitespace
-DeMorgan's Law
-Test with NULL or 0 for non-booleans
-'\0' instead of 0 for chars
-Remove redundantly redundant comments (like DoFoo(); // Do foo)
-Join multiple short lines with a single statement
-Split single lines with multiple statements
-Avoid assignments in if
 2005-11-14 19:48:04 +00:00
tron
a7843e1546 (svn r3180) Replace some magic numbers by symbolic names 2005-11-14 15:22:12 +00:00
tron
81e5b16d71 (svn r3172) static, const 2005-11-13 13:43:55 +00:00
tron
181d586a7c (svn r3078) Some more stuff, which piled up: 
- const, whitespace, indentation, bracing, GB/SB, pointless casts
- use the trinary operator where appropriate
- data types (uint[] -> AcceptedCargo, ...)
- if cascade -> switch
- if (ptr) -> if (ptr != NULL)
- DeMorgan's Law
- Fix some comments
- 0 -> '\0', change magic numbers to symbolic constants
 2005-10-23 13:04:44 +00:00
tron
d7cbd0d4c3 (svn r3073) int/byte -> EngineID/PlayerID/VehicleID 
0/-1 -> INVALID_ENGINE
0x10 -> OWNER_NONE
 2005-10-20 17:43:13 +00:00
tron
6d16862126 (svn r3072) CMD_RENAME_STATION isn't interested in the tile coordinates, so don't pass them 2005-10-20 17:23:33 +00:00
tron
f556128dde (svn r3030) More work for GB/SB, this time concerning the waiting_acceptance attribute of stations 2005-10-11 13:54:21 +00:00
tron
8980891b09 (svn r3024) -Codechange: Another batch of replacements of int/uint/int16/byte/-1 with proper types and constants 2005-10-07 07:35:15 +00:00
tron
6d7c7e67b2 (svn r3010) Get rid of quite some dubious casts, either by using GB(), proper types or just removing them 2005-10-03 21:20:01 +00:00
tron
980808dac2 (svn r3001) s/Player*/const Player*/ 
s/byte/PlayerID/
s/int/PlayerID/
and related changes
 2005-09-30 20:37:25 +00:00
tron
647cbd6bdd (svn r2701) Insert Id tags into all source files 2005-07-24 14:12:37 +00:00
tron
54cbd01825 (svn r2673) Include functions.h directly, not globally via openttd.h 2005-07-22 07:02:20 +00:00