Commit Graph

59121 Commits

Author SHA1 Message Date
Jonathan G Rennison
a71f8b6703 Github: Temporarily disable vcpkg caching for linux generic builds
To avoid problems where dependencies downloaded via apt change,
causing the cache contents to be incorrect
2024-07-11 01:13:45 +01:00
Jonathan G Rennison
93ecef7de2 Fix parameter forwarding in Rail90DegTurnDisallowed helpers 2024-07-10 22:15:59 +01:00
Jonathan G Rennison
9ae96d2fdb Fix YAPF not considering signalled tunnel/bridges as safe waiting tiles
In search for any safe waiting tile mode
2024-07-10 22:15:31 +01:00
Jonathan G Rennison
7152f534e8 Tunnel/bridge: Fix comments for some map accessor functions 2024-07-10 21:59:38 +01:00
Peter Nelson
e2a796dbcd Codefix: Potential unterminated string returned from convert_to_fs.
Converting from UTF-8 to UTF-16 could have resulted in a buffer overflow if the buffer size was exactly the length of the converted string.

Pass string_view/span to convert_from/to_fs instead, and ensure the buffer is terminated. This replaces passing a pointer to the buffer and the buffer size as separate parameters, allowing the compiler to pass both in one parameter.

Removes use of `lengthof()`.
2024-07-10 20:57:02 +01:00
Peter Nelson
b37954722b Codefix: Don't copy path string to itself.
When determining base paths on Windows the path is converted to UCS-16, and then copied into the same buffer.
2024-07-10 20:57:02 +01:00
Peter Nelson
e22eb89b92 Codechange: Call BSWAP32() in the default_grf_overrides initializer.
This causes the BSWAP32 calls to happen only on first initialisation (BSWAP32 is not constexpr), instead of every time GRFs are reloaded.
2024-07-10 20:56:35 +01:00
Peter Nelson
b090c8e9bd Codechange: Replace default overrides arrays with std::pair and use range-for.
This avoids indexed array access and use of lengthof.
2024-07-10 20:56:35 +01:00
Peter Nelson
70d63f87b8 Codechange: Re-order ResultSpriteGroup to reduce its size. 2024-07-10 13:22:22 +01:00
Peter Nelson
db0ae42d45 Codechange: Set base type of spritegroup related enums.
This has a small impact on SpriteGroup object sizes.
2024-07-10 13:22:22 +01:00
Peter Nelson
55acc1b36d Codechange: Don't format strings passed to GrfMsg unless the message will be used.
This makes GrfMsg() behave more like Debug().
2024-07-10 12:53:23 +01:00
Peter Nelson
ba0acb87eb Fix #12832: Sanitise strings from NewGRF before logging them in Debug output.
NewGRF strings may not be UTF-8 encoded, which causes issues on Windows.
2024-07-10 12:53:23 +01:00
Peter Nelson
93eb27d8df
Codechange: Use reference for always_accepted output parameter of AddAcceptedCargo. (#12854)
This parameter should always present (see tile_cmd.h:186), so use a reference to ensure it is.
2024-07-10 12:30:14 +01:00
Peter Nelson
60c3913a99
Codechange: Use range-for and std::size with _plural_forms. (#12852)
This removes indexed array access and use of `lengthof()` macro.
2024-07-10 09:41:28 +00:00
Peter Nelson
b4bcb330c7
Codechange: Replace GetSavegameFormat's compression output pointer with std::pair return. (#12850)
This avoids using an unchecked pointer as an out-parameter.
2024-07-09 18:57:47 +01:00
Peter Nelson
100dd7b6d1
Codechange: Use find_if to get default writeable saveload format. (#12849)
* Codechange: Use find_if to get default writeable savegame format.

This removes the last of lastof, and so the lastof macro is removed.
2024-07-09 17:07:40 +01:00
Peter Nelson
56b0eac2e9
Codechange: Use std::span/std::string_view for strecpy. (#12848)
This avoids needing to manually pass the last character of the destination buffer, and allows use of standard library functions.
2024-07-09 00:05:42 +01:00
J0anJosep
86e32631d7 Doc: Amend landscape grid after #12572. 2024-07-08 21:15:07 +02:00
Jonathan G Rennison
a07b02ebe4 Saveload: Use table format for new signal style mapping chunk 2024-07-08 19:37:27 +01:00
Jonathan G Rennison
94e5555419 Extend description text for station cargo distribution setting 2024-07-08 19:22:04 +01:00
Jonathan G Rennison
c2a4ddea7e Saveload: Use table format for XBSS chunk 2024-07-08 19:12:20 +01:00
Jonathan G Rennison
2bf05321bb Saveload: Use table format for tunnel chunk 2024-07-08 18:48:37 +01:00
Jonathan G Rennison
3035b91b5c Saveload: Use table format for speed adaptation chunk 2024-07-08 18:48:25 +01:00
Jonathan G Rennison
3202fc2ce3 Saveload: Change type of read-only chunks to CH_READONLY 2024-07-08 18:23:22 +01:00
Jonathan G Rennison
8d9c988767 Saveload: Rename CH_UNUSED to CH_READONLY 2024-07-08 18:20:30 +01:00
Jonathan G Rennison
cf573d4bf8 Saveload: Use table format for tracerestrict chunks 2024-07-08 18:00:59 +01:00
Jonathan G Rennison
724c6800c9 Saveload: Fix table chunk array type length headers 2024-07-08 17:50:37 +01:00
Peter Nelson
aee04e7bc6
Codechange: Pass span to StrValid instead of first and last - 1. (#12846)
`std::span` is used instead of `std::string_view` as this is only used for fixed-length buffers.

This removes some callers of `lastof()`
2024-07-08 08:36:57 +01:00
translators
23bcd592a4 Update: Translations from eints
chinese (simplified): 27 changes by WenSimEHRP
italian: 9 changes by ciampix
esperanto: 7 changes by ciampix
2024-07-08 04:43:44 +00:00
Peter Nelson
6120165433
Fix #12839: Truncated help text dialog on Windows. (#12844)
Replace fixed-length buffer message conversion with std::string.
2024-07-07 18:05:53 +01:00
Jonathan G Rennison
d6b3ba6045 Saveload: Use table format for debug info
No longer add wrapper text around config
2024-07-07 16:11:22 +01:00
Jonathan G Rennison
61f920138f Saveload: Add helper to skip chunk contents 2024-07-07 15:34:09 +01:00
Jonathan G Rennison
0dc4be2aa0 Fix minor code style issue 2024-07-07 15:00:50 +01:00
Jonathan G Rennison
95245d5a57 Fix crash opening landscape window when there are no available objects
See: #713
2024-07-06 18:45:41 +01:00
Jonathan G Rennison
15f4e62936 Merge branch 'master' into jgrpp
# Conflicts:
#	src/network/network.cpp
#	src/pathfinder/yapf/yapf.h
#	src/pathfinder/yapf/yapf_ship.cpp
#	src/saveload/afterload.cpp
#	src/ship_cmd.cpp
#	src/station_cmd.cpp
#	src/vehicle.cpp
#	src/vehicle_gui.cpp
2024-07-06 18:24:53 +01:00
Jonathan G Rennison
21793af8dd Fix accel/braking percentage setting changes not updating running trains 2024-07-06 16:41:15 +01:00
Jonathan G Rennison
61b39296e1 Fix crash when replacing recolour sprite with normal sprite
See: #712
2024-07-06 13:34:44 +01:00
Jonathan G Rennison
18ef0741e7 Use hash map instead of btree for SpritePointerHolder cache 2024-07-06 13:18:59 +01:00
translators
f59ab67672 Update: Translations from eints
english (us): 2 changes by 2TallTyler
dutch: 1 change by Afoklala
french: 2 changes by ottdfevr
2024-07-06 04:42:37 +00:00
Qwest8K
3fd71b2821 Update russian.txt 2024-07-05 22:52:02 +01:00
Jonathan G Rennison
2d6c9c2f90 Fix 05915b21: One-way behaviour of signalled bridge exit applied to bypassing track 2024-07-05 22:42:34 +01:00
translators
5395d5731e Update: Translations from eints
latvian: 3 changes by lexuslatvia
2024-07-05 04:43:57 +00:00
Peter Nelson
4976a0140e
Codefix: [UI] Incorrect initialisation order for rail/road toolbars. (#12843)
The toolbar state was set after the widget tree is created, during which toolbar state is needed.
2024-07-04 22:04:41 +01:00
Edmond Chui
2dc0a33eb7 Fix #12840, ff3be45: "Show industry names" blank panel not initialized properly 2024-07-04 22:51:06 +02:00
translators
794af62286 Update: Translations from eints
english (au): 1 change by krysclarke
swedish: 7 changes by joeax910
chinese (simplified): 2 changes by WenSimEHRP
korean: 1 change by telk5093
french: 2 changes by ottdfevr
2024-07-04 04:43:03 +00:00
Jonathan G Rennison
b3e20ec9b6 Version: Committing version data for tag: jgrpp-0.60.1 2024-07-03 22:12:02 +01:00
Jonathan G Rennison
ae516b4a86 Fix text truncation in Win32 help dialog 2024-07-03 22:04:39 +01:00
TELK
dcd4295d4e
Update: Korean translation up to 0.60.0 (#710) 2024-07-03 18:08:25 +01:00
Jonathan G Rennison
5dc0bb61ea Test: Check that game packet ID to string mappings are correct/complete 2024-07-03 17:52:20 +01:00
translators
cd4233bedc Update: Translations from eints
english (au): 1 change by krysclarke
chinese (simplified): 2 changes by WenSimEHRP
greek: 1 change by gh658804
russian: 2 changes by Ln-Wolf
finnish: 1 change by hpiirai
catalan: 2 changes by J0anJosep
portuguese: 1 change by azulcosta
portuguese (brazilian): 1 change by pasantoro
polish: 1 change by pAter-exe
2024-07-03 04:42:36 +00:00