refactor: modified prepResponseView to prioritize query.response and trigger re-render after a failed generation is retried

pull/988/head
utin-francis-peter 4 weeks ago
parent 8d2ebe9718
commit 414ec08dee

@ -79,7 +79,7 @@ export default function Conversation() {
queries[queries.length - 1].error && setLastQueryReturnedErr(true); queries[queries.length - 1].error && setLastQueryReturnedErr(true);
queries[queries.length - 1].response && setLastQueryReturnedErr(false); //considering a query that initially returned error can later include a response property on retry queries[queries.length - 1].response && setLastQueryReturnedErr(false); //considering a query that initially returned error can later include a response property on retry
} }
}, [queries]); }, [queries[queries.length - 1]]);
const scrollIntoView = () => { const scrollIntoView = () => {
endMessageRef?.current?.scrollIntoView({ endMessageRef?.current?.scrollIntoView({
@ -105,17 +105,7 @@ export default function Conversation() {
const prepResponseView = (query: Query, index: number) => { const prepResponseView = (query: Query, index: number) => {
let responseView; let responseView;
if (query.error) { if (query.response) {
responseView = (
<ConversationBubble
ref={endMessageRef}
className={`${index === queries.length - 1 ? 'mb-32' : 'mb-7'}`}
key={`${index}ERROR`}
message={query.error}
type="ERROR"
></ConversationBubble>
);
} else if (query.response) {
responseView = ( responseView = (
<ConversationBubble <ConversationBubble
ref={endMessageRef} ref={endMessageRef}
@ -130,6 +120,16 @@ export default function Conversation() {
} }
></ConversationBubble> ></ConversationBubble>
); );
} else if (query.error) {
responseView = (
<ConversationBubble
ref={endMessageRef}
className={`${index === queries.length - 1 ? 'mb-32' : 'mb-7'}`}
key={`${index}ERROR`}
message={query.error}
type="ERROR"
></ConversationBubble>
);
} }
return responseView; return responseView;
}; };

Loading…
Cancel
Save