diff --git a/trezor_agent/gpg/encode.py b/trezor_agent/gpg/encode.py index 9f6824c..0ab3df8 100644 --- a/trezor_agent/gpg/encode.py +++ b/trezor_agent/gpg/encode.py @@ -228,17 +228,24 @@ class Signer(object): keygrip = agent.get_keygrip(user_id) log.info('adding as subkey to %s (%s)', user_id, keygrip) data_to_sign = primary['_to_hash'] + self._pubkey_data_to_hash() + hashed_subpackets = [ + subpacket_time(self.created)] # signature creaion time + back_sign = self._make_signature(visual='Add subkey', + data_to_sign=data_to_sign, + sig_type=0x19, # Primary Key Binding Signature + hashed_subpackets=hashed_subpackets) + log.info('back_sign: %r', back_sign) hashed_subpackets = [ subpacket_time(self.created), # signature creaion time subpacket_byte(0x1B, 2)] # key flags (certify & sign) - _conn = self.conn self.conn = AgentSigner(user_id, curve_name=formats.CURVE_NIST256) self.key_id = lambda: primary['key_id'] signature = self._make_signature(visual='Add subkey', data_to_sign=data_to_sign, sig_type=0x18, # Subkey Binding Signature - hashed_subpackets=hashed_subpackets) + hashed_subpackets=hashed_subpackets, + unhashed=[subpacket(32, bytes(back_sign))]) self.conn = _conn sign_packet = packet(tag=2, blob=signature) @@ -259,7 +266,7 @@ class Signer(object): return packet(tag=2, blob=blob) def _make_signature(self, visual, data_to_sign, - hashed_subpackets, sig_type=0): + hashed_subpackets, sig_type=0, unhashed=()): curve_info = SUPPORTED_CURVES[self.conn.curve_name] header = struct.pack('>BBBB', 4, # version @@ -269,7 +276,8 @@ class Signer(object): hashed = subpackets(*hashed_subpackets) log.info('key_id: %s', util.hexlify(self.key_id())) unhashed = subpackets( - subpacket(16, self.key_id()) # issuer key id + subpacket(16, self.key_id()), # issuer key id + *unhashed ) tail = b'\x04\xff' + struct.pack('>L', len(header) + len(hashed)) data_to_hash = data_to_sign + header + hashed + tail diff --git a/trezor_agent/gpg/test.sh b/trezor_agent/gpg/test.sh new file mode 100644 index 0000000..fd7975d --- /dev/null +++ b/trezor_agent/gpg/test.sh @@ -0,0 +1,7 @@ +set -x +(cd ~/.gnupg && rm -r openpgp-revocs.d/ private-keys-v1.d/ pubring.kbx* trustdb.gpg /tmp/log *.gpg; killall gpg-agent) +gpg2 --full-gen-key --expert +gpg2 --export > romanz.pub +NOW=`date +%s`; trezor-gpg -t $NOW "romanz" -o subkey.pub +gpg2 -vv --import <(cat romanz.pub subkey.pub) +gpg2 -k