[fix] use raw response with etree.parsefromstring - Unicode strings with encoding declaration are not supported

7 years ago · 8db527c1d2
parent 259735f309
commit 8db527c1d2
2 changed files with 7 additions and 7 deletions
--- a/searx/engines/bing_news.py
+++ b/searx/engines/bing_news.py
@ -85,7 +85,7 @@ def request(query, params):
 def response(resp):
    results = []

-    rss = etree.fromstring(resp.text)
+    rss = etree.fromstring(resp.content)

    ns = rss.nsmap

--- a/tests/unit/engines/test_bing_news.py
+++ b/tests/unit/engines/test_bing_news.py
@ -36,10 +36,10 @@ class TestBingNewsEngine(SearxTestCase):
        self.assertRaises(AttributeError, bing_news.response, '')
        self.assertRaises(AttributeError, bing_news.response, '[]')

-        response = mock.Mock(text='<html></html>')
+        response = mock.Mock(content='<html></html>')
        self.assertEqual(bing_news.response(response), [])

-        response = mock.Mock(text='<html></html>')
+        response = mock.Mock(content='<html></html>')
        self.assertEqual(bing_news.response(response), [])

        html = """<?xml version="1.0" encoding="utf-8" ?>
@ -74,7 +74,7 @@ class TestBingNewsEngine(SearxTestCase):
        </item>
    </channel>
 </rss>"""  # noqa
-        response = mock.Mock(text=html.encode('utf-8'))
+        response = mock.Mock(content=html.encode('utf-8'))
        results = bing_news.response(response)
        self.assertEqual(type(results), list)
        self.assertEqual(len(results), 2)
@ -113,7 +113,7 @@ class TestBingNewsEngine(SearxTestCase):
        </item>
    </channel>
 </rss>"""  # noqa
-        response = mock.Mock(text=html.encode('utf-8'))
+        response = mock.Mock(content=html.encode('utf-8'))
        results = bing_news.response(response)
        self.assertEqual(type(results), list)
        self.assertEqual(len(results), 1)
@ -136,11 +136,11 @@ class TestBingNewsEngine(SearxTestCase):
    </channel>
 </rss>"""  # noqa

-        response = mock.Mock(text=html.encode('utf-8'))
+        response = mock.Mock(content=html.encode('utf-8'))
        results = bing_news.response(response)
        self.assertEqual(type(results), list)
        self.assertEqual(len(results), 0)

        html = """<?xml version="1.0" encoding="utf-8" ?>gabarge"""
-        response = mock.Mock(text=html.encode('utf-8'))
+        response = mock.Mock(content=html.encode('utf-8'))
        self.assertRaises(lxml.etree.XMLSyntaxError, bing_news.response, response)