Fixing issue #136. Improved logic in tooltip.js for handling <svg> and <g> tags.

11 years ago · ba44aa3053
parent 9fc096f3a4
commit ba44aa3053
3 changed files with 11 additions and 11 deletions
--- a/nv.d3.js
+++ b/nv.d3.js
@ -135,11 +135,11 @@ d3.time.monthEnds = d3_time_range(d3.time.monthEnd, function(date) {
    gravity = gravity || 's';
    dist = dist || 20;

-    if (parentContainer.tagName.match(/g|svg/i)) {
+    var body = parentContainer;
+    if ( !parentContainer || parentContainer.tagName.match(/g|svg/i)) {
        //If the parent element is an SVG element, place tooltip in the <body> element.
-        parentContainer = null;
+        body = document.getElementsByTagName('body')[0];
    }
-    var body = parentContainer ? parentContainer : document.getElementsByTagName('body')[0];

    container.innerHTML = content;
    container.style.left = 0;
--- a/nv.d3.min.js
+++ b/nv.d3.min.js
--- a/src/tooltip.js
+++ b/src/tooltip.js
@ -16,11 +16,11 @@
    gravity = gravity || 's';
    dist = dist || 20;

-    if (parentContainer.tagName.match(/g|svg/i)) {
+    var body = parentContainer;
+    if ( !parentContainer || parentContainer.tagName.match(/g|svg/i)) {
        //If the parent element is an SVG element, place tooltip in the <body> element.
-        parentContainer = null;
+        body = document.getElementsByTagName('body')[0];
    }
-    var body = parentContainer ? parentContainer : document.getElementsByTagName('body')[0];

    container.innerHTML = content;
    container.style.left = 0;