blob42
/
nvd3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed major bug that throws lots of errors everytime a point is overed over then transitioned... this was 95% of all errors seen in console

Browse Source
master-patched
Bob Monteverde 12 years ago
parent a0cb28a3fb
commit 6e4eaea547
4 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File

12
nv.d3.js
Unescape Escape View File

@ -5317,7 +5317,7 @@ nv.models.scatter = function() {
var wrap = d3.select(this).selectAll('g.wrap.scatter').data([data]);
var wrapEnter = wrap.enter().append('g').attr('class', 'wrap nvd3 scatter');
var wrapEnter = wrap.enter().append('g').attr('class', 'wrap nvd3 scatter chart-' +id);
var defsEnter = wrapEnter.append('defs');
var gEnter = wrapEnter.append('g');
var g = wrap.select('g')
@ -5422,12 +5422,14 @@ nv.models.scatter = function() {
});
dispatch.on('elementMouseover.point', function(d) {
wrap.select('.series-' + d.seriesIndex + ' .point-' + d.pointIndex)
//wrap.select('.series-' + d.seriesIndex + ' .point-' + d.pointIndex)
d3.select('.chart-' + id + ' .series-' + d.seriesIndex + ' .point-' + d.pointIndex)
.classed('hover', true);
});
dispatch.on('elementMouseout.point', function(d) {
wrap.select('.series-' + d.seriesIndex + ' .point-' + d.pointIndex)
//wrap.select('.series-' + d.seriesIndex + ' .point-' + d.pointIndex)
d3.select('.chart-' + id + ' .series-' + d.seriesIndex + ' .point-' + d.pointIndex)
.classed('hover', false);
});
@ -5730,8 +5732,8 @@ nv.models.scatterChart = function() {
var wrap = container.selectAll('g.wrap.scatterWithLegend').data([data]);
var gEnter = wrap.enter().append('g').attr('class', 'wrap nvd3 scatterWithLegend').append('g');
var wrap = container.selectAll('g.wrap.scatterChart').data([data]);
var gEnter = wrap.enter().append('g').attr('class', 'wrap nvd3 scatterChart').append('g');
gEnter.append('g').attr('class', 'legendWrap');
gEnter.append('g').attr('class', 'x axis');

2
nv.d3.min.js vendored
View File

File diff suppressed because one or more lines are too long

8
src/models/scatter.js
Unescape Escape View File

@ -71,7 +71,7 @@ nv.models.scatter = function() {
var wrap = d3.select(this).selectAll('g.wrap.scatter').data([data]);
var wrapEnter = wrap.enter().append('g').attr('class', 'wrap nvd3 scatter');
var wrapEnter = wrap.enter().append('g').attr('class', 'wrap nvd3 scatter chart-' +id);
var defsEnter = wrapEnter.append('defs');
var gEnter = wrapEnter.append('g');
var g = wrap.select('g')
@ -176,12 +176,14 @@ nv.models.scatter = function() {
});
dispatch.on('elementMouseover.point', function(d) {
wrap.select('.series-' + d.seriesIndex + ' .point-' + d.pointIndex)
//wrap.select('.series-' + d.seriesIndex + ' .point-' + d.pointIndex)
d3.select('.chart-' + id + ' .series-' + d.seriesIndex + ' .point-' + d.pointIndex)
.classed('hover', true);
});
dispatch.on('elementMouseout.point', function(d) {
wrap.select('.series-' + d.seriesIndex + ' .point-' + d.pointIndex)
//wrap.select('.series-' + d.seriesIndex + ' .point-' + d.pointIndex)
d3.select('.chart-' + id + ' .series-' + d.seriesIndex + ' .point-' + d.pointIndex)
.classed('hover', false);
});

4
src/models/scatterChart.js
Unescape Escape View File

@ -69,8 +69,8 @@ nv.models.scatterChart = function() {
var wrap = container.selectAll('g.wrap.scatterWithLegend').data([data]);
var gEnter = wrap.enter().append('g').attr('class', 'wrap nvd3 scatterWithLegend').append('g');
var wrap = container.selectAll('g.wrap.scatterChart').data([data]);
var gEnter = wrap.enter().append('g').attr('class', 'wrap nvd3 scatterChart').append('g');
gEnter.append('g').attr('class', 'legendWrap');
gEnter.append('g').attr('class', 'x axis');

Write Preview
Loading…
Cancel
Save