From b1b7f3541cc9cb75a2e0309ef5ba248d8b3e4f38 Mon Sep 17 00:00:00 2001 From: mbchang Date: Tue, 23 May 2023 20:31:45 -0700 Subject: [PATCH] fix: fix current_time=Now bug for aadd_documents in TimeWeightedRetriever (#5155) # Same as PR #5045, but for async Fixes #4825 I had forgotten to update the asynchronous counterpart `aadd_documents` with the bug fix from PR #5045, so this PR also fixes `aadd_documents` too. ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: @dev2049 --- langchain/retrievers/time_weighted_retriever.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/langchain/retrievers/time_weighted_retriever.py b/langchain/retrievers/time_weighted_retriever.py index f715337b..b46325f4 100644 --- a/langchain/retrievers/time_weighted_retriever.py +++ b/langchain/retrievers/time_weighted_retriever.py @@ -127,7 +127,9 @@ class TimeWeightedVectorStoreRetriever(BaseRetriever, BaseModel): self, documents: List[Document], **kwargs: Any ) -> List[str]: """Add documents to vectorstore.""" - current_time = kwargs.get("current_time", datetime.datetime.now()) + current_time = kwargs.get("current_time") + if current_time is None: + current_time = datetime.datetime.now() # Avoid mutating input documents dup_docs = [deepcopy(d) for d in documents] for i, doc in enumerate(dup_docs):