From 7ee87eb0c8df10315b45ebbddcad36a72b7fe7b9 Mon Sep 17 00:00:00 2001
From: Boris Feld <lothiraldan@gmail.com>
Date: Fri, 14 Apr 2023 22:19:58 +0200
Subject: [PATCH] Comet callback updates (#2889)

I'm working with @DN6 and I made some small fixes and
improvements after playing with the integration.
---
 docs/ecosystem/comet_tracking.ipynb      | 52 ++++++++++++------------
 langchain/callbacks/comet_ml_callback.py | 12 +++---
 2 files changed, 31 insertions(+), 33 deletions(-)

diff --git a/docs/ecosystem/comet_tracking.ipynb b/docs/ecosystem/comet_tracking.ipynb
index fa8b1217..4d33bd00 100644
--- a/docs/ecosystem/comet_tracking.ipynb
+++ b/docs/ecosystem/comet_tracking.ipynb
@@ -1,7 +1,6 @@
 {
  "cells": [
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -9,7 +8,6 @@
    ]
   },
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -17,7 +15,6 @@
    ]
   },
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -31,7 +28,6 @@
    ]
   },
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -39,7 +35,6 @@
    ]
   },
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -52,14 +47,13 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "!pip install comet_ml\n",
-    "!pip install langchain\n",
-    "!pip install openai\n",
-    "!pip install google-search-results"
+    "%pip install comet_ml langchain openai google-search-results spacy textstat pandas\n",
+    "\n",
+    "import sys\n",
+    "!{sys.executable} -m spacy download en_core_web_sm"
    ]
   },
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -67,7 +61,6 @@
    ]
   },
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -86,7 +79,6 @@
    ]
   },
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -94,7 +86,6 @@
    ]
   },
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -109,12 +100,12 @@
    "source": [
     "import os\n",
     "\n",
-    "%env OPENAI_API_KEY=\"...\"\n",
-    "%env SERPAPI_API_KEY=\"...\""
+    "os.environ[\"OPENAI_API_KEY\"] = \"...\"\n",
+    "#os.environ[\"OPENAI_ORGANIZATION\"] = \"...\"\n",
+    "os.environ[\"SERPAPI_API_KEY\"] = \"...\""
    ]
   },
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -149,7 +140,6 @@
    ]
   },
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -185,12 +175,11 @@
     "synopsis_chain = LLMChain(llm=llm, prompt=prompt_template, callback_manager=manager)\n",
     "\n",
     "test_prompts = [{\"title\": \"Documentary about Bigfoot in Paris\"}]\n",
-    "synopsis_chain.apply(test_prompts)\n",
+    "print(synopsis_chain.apply(test_prompts))\n",
     "comet_callback.flush_tracker(synopsis_chain, finish=True)"
    ]
   },
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -232,7 +221,6 @@
    ]
   },
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -240,7 +228,6 @@
    ]
   },
   {
-   "attachments": {},
    "cell_type": "markdown",
    "metadata": {},
    "source": [
@@ -256,7 +243,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "!pip install rouge-score"
+    "%pip install rouge-score"
    ]
   },
   {
@@ -336,16 +323,29 @@
     "                 \"\"\"\n",
     "    }\n",
     "]\n",
-    "synopsis_chain.apply(test_prompts)\n",
+    "print(synopsis_chain.apply(test_prompts))\n",
     "comet_callback.flush_tracker(synopsis_chain, finish=True)"
    ]
   }
  ],
  "metadata": {
-  "language_info": {
-   "name": "python"
+  "kernelspec": {
+   "display_name": "Python 3 (ipykernel)",
+   "language": "python",
+   "name": "python3"
   },
-  "orig_nbformat": 4
+  "language_info": {
+   "codemirror_mode": {
+    "name": "ipython",
+    "version": 3
+   },
+   "file_extension": ".py",
+   "mimetype": "text/x-python",
+   "name": "python",
+   "nbconvert_exporter": "python",
+   "pygments_lexer": "ipython3",
+   "version": "3.9.15"
+  }
  },
  "nbformat": 4,
  "nbformat_minor": 2
diff --git a/langchain/callbacks/comet_ml_callback.py b/langchain/callbacks/comet_ml_callback.py
index c716d43d..6f061f14 100644
--- a/langchain/callbacks/comet_ml_callback.py
+++ b/langchain/callbacks/comet_ml_callback.py
@@ -34,12 +34,10 @@ def _get_experiment(
 ) -> Any:
     comet_ml = import_comet_ml()
 
-    experiment = comet_ml.config.get_global_experiment()
-    if experiment is None:
-        experiment = comet_ml.Experiment(  # type: ignore
-            workspace=workspace,
-            project_name=project_name,
-        )
+    experiment = comet_ml.Experiment(  # type: ignore
+        workspace=workspace,
+        project_name=project_name,
+    )
 
     return experiment
 
@@ -132,7 +130,7 @@ class CometCallbackHandler(BaseMetadataCallbackHandler, BaseCallbackHandler):
         warning = (
             "The comet_ml callback is currently in beta and is subject to change "
             "based on updates to `langchain`. Please report any issues to "
-            "https://github.com/comet_ml/issue_tracking/issues with the tag "
+            "https://github.com/comet-ml/issue_tracking/issues with the tag "
             "`langchain`."
         )
         comet_ml.LOGGER.warning(warning)