lint

browsers/firefox/config.go

@@ -85,25 +85,6 @@ type FirefoxConfig struct {
 
 func setBookmarkDir(fc *FirefoxConfig) {
 	var err error
-	// pm := FirefoxProfileManager
-
-	// expand environment variables in path
-	// pm.ConfigDir = filepath.Join(os.ExpandEnv(FirefoxBaseDir))
-
-	// Check if base folder exists
-	// handled by profiles.Detect()
-	// exists, err := utils.CheckDirExists(pm.ConfigDir)
-	// if !exists {
-	// 	log.Criticalf("the base firefox folder <%s> does not exist", pm.ConfigDir)
-	// }
-
-	// if err != nil {
-	// 	log.Fatal(err)
-	// 	return
-	// }
-
-	// Set in NewMozProfileManager
-	// ffProfileLoader.BasePath = pm.ConfigDir
 
 	// load the default profile from the one defined in the config
 	var profile *profiles.Profile

cmd/profile_cmds.go

@@ -22,7 +22,6 @@
 package cmd
 
 import (
-	"errors"
 	"fmt"
 
 	"github.com/urfave/cli/v2"
@@ -57,12 +56,13 @@ var listProfilesCmd = &cli.Command{
 		//Create a browser instance
 		brmod, ok := br.ModInfo().New().(modules.BrowserModule)
 		if !ok {
-			log.Criticalf("module <%s> is not a BrowserModule", br.ModInfo().ID)
+			log.Criticalf("<%s> is not a BrowserModule", br.ModInfo().ID)
 		}
 
 		pm, isProfileManager := brmod.(profiles.ProfileManager)
 		if !isProfileManager{
-			return errors.New("not profile manager")
+			log.Warningf("<%s> is not a profile manager", br.ModInfo().ID)
+			continue
 		}
 
 		flavours := pm.ListFlavours()