blob42/gosuki
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

update firefox tests, skip not implmented

Browse Source
This commit is contained in:
blob42 2023-09-05 11:59:58 +02:00
parent 0404cedfea
commit 848b8ed889
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
firefox/firefox_test.go
View File

@ -76,7 +76,7 @@ func runPlacesTest(name string, t *testing.T, test func(t *testing.T)) {
func Test_addUrlNode(t *testing.T) {
testUrl := struct {
testURL := struct {
url string
id sqlid
title string
@ -97,7 +97,7 @@ func Test_addUrlNode(t *testing.T) {
testNewUrl := "new urlNode: url is not yet in URLIndex"
t.Run(testNewUrl, func(t *testing.T) {
ok, urlNode := ff.addURLNode(testUrl.url, testUrl.title, testUrl.desc)
ok, urlNode := ff.addURLNode(testURL.url, testURL.title, testURL.desc)
if !ok {
t.Fatalf("expected %v, got %v", true, false)
}
@ -105,12 +105,12 @@ func Test_addUrlNode(t *testing.T) {
t.Fatal("url node was not returned", testNewUrl)
}
_, ok = ff.URLIndex.Get(testUrl.url)
_, ok = ff.URLIndex.Get(testURL.url)
if !ok {
t.Fatal("url was not added to url index")
}
if !utils.InList(ff.URLIndexList, testUrl.url) {
if !utils.InList(ff.URLIndexList, testURL.url) {
t.Fatal("url was not added to url index list")
}
@ -118,8 +118,8 @@ func Test_addUrlNode(t *testing.T) {
testUrlExists := "return existing urlNode found in URLIndex"
t.Run(testUrlExists, func(t *testing.T) {
_, origNode := ff.addURLNode(testUrl.url, testUrl.title, testUrl.desc)
ok, urlNode := ff.addURLNode(testUrl.url, testUrl.title, testUrl.desc)
_, origNode := ff.addURLNode(testURL.url, testURL.title, testURL.desc)
ok, urlNode := ff.addURLNode(testURL.url, testURL.title, testURL.desc)
if ok {
t.Fatalf("expected %v, got %v", false, true)
}
@ -132,12 +132,12 @@ func Test_addUrlNode(t *testing.T) {
t.Fatal("existing node does not match retrieved node from url index")
}
_, ok = ff.URLIndex.Get(testUrl.url)
_, ok = ff.URLIndex.Get(testURL.url)
if !ok {
t.Fatal("url was not added to url index")
}
if !utils.InList(ff.URLIndexList, testUrl.url) {
if !utils.InList(ff.URLIndexList, testURL.url) {
t.Fatal("url was not added to url index list")
}
@ -678,11 +678,11 @@ func Test_FindModifiedBookmarks(t *testing.T) {
})
}
func Test_FindModifiedFolders(t *testing.T) {
t.Error("modified folder names should change the corresponding bookmark tags")
}
func TestBrowserImplProfileManager(t *testing.T) {
assert.Implements(t, (*profiles.ProfileManager)(nil), NewFirefox())
}
func Test_FindModifiedFolders(t *testing.T) {
t.Skip("modified folder names should change the corresponding bookmark tags")
}