From ac0ad4f91dbf4e82c22a8fd059891f0b5c138f0d Mon Sep 17 00:00:00 2001 From: Alex Merkel Date: Sun, 21 Jun 2020 12:06:01 +0200 Subject: [PATCH] [postprocessor/embedthumbnail] Close file before possible renaming --- youtube_dl/postprocessor/embedthumbnail.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/youtube_dl/postprocessor/embedthumbnail.py b/youtube_dl/postprocessor/embedthumbnail.py index 74928be55..7673b4fd1 100644 --- a/youtube_dl/postprocessor/embedthumbnail.py +++ b/youtube_dl/postprocessor/embedthumbnail.py @@ -44,12 +44,12 @@ class EmbedThumbnailPP(FFmpegPostProcessor): #Check for mislabeled webp file with open(encodeFilename(thumbnail_filename), "rb") as f: b = f.read(16) - if b'\x57\x45\x42\x50' in b: #Binary for WEBP - [thumbnail_filename_path, thumbnail_filename_extension] = os.path.splitext(thumbnail_filename) - if not thumbnail_filename_extension == ".webp": - webp_thumbnail_filename = thumbnail_filename_path + ".webp" - os.rename(thumbnail_filename, webp_thumbnail_filename) - thumbnail_filename = webp_thumbnail_filename + if b'\x57\x45\x42\x50' in b: #Binary for WEBP + [thumbnail_filename_path, thumbnail_filename_extension] = os.path.splitext(thumbnail_filename) + if not thumbnail_filename_extension == ".webp": + webp_thumbnail_filename = thumbnail_filename_path + ".webp" + os.rename(thumbnail_filename, webp_thumbnail_filename) + thumbnail_filename = webp_thumbnail_filename #If not a jpg or png thumbnail, convert it to jpg using ffmpeg if not os.path.splitext(thumbnail_filename)[1].lower() in ['.jpg', '.png']: