Byron Hambly
90494ba4a5
fix: monero wallet refresh ( #1596 )
...
This PR changes the following behaviour in the refresh functionality of the monero wallet
- Allows for multiple retries because in some cases users have experienced an issue where the wallet rpc returns `no connection to daemon` even though the daemon is available. I'm not 100% sure why this happens but retrying often fixes the issue
- Print the current sync height after each failed attempt at syncing to see how far we've come
- The `monero-wallet-rpc` is started with the `--no-initial-sync` flag which ensures that as soon as it's started, it's ready to respond to requests
- The `monero-wallet-rpc` was upgraded to `v0.18.3.1` because this PR https://github.com/monero-project/monero/pull/8941 has improved some of the issues mentioned above
This PR is part of a larger effort to fix this issue https://github.com/comit-network/xmr-btc-swap/issues/1432
2024-06-10 18:53:52 +02:00
dependabot[bot]
1930540c1f
build(deps): bump reqwest from 0.11.27 to 0.12.4 ( #1588 )
...
* build(deps): bump reqwest from 0.11.27 to 0.12.0
Bumps [reqwest](https://github.com/seanmonstar/reqwest ) from 0.11.27 to 0.12.0.
- [Release notes](https://github.com/seanmonstar/reqwest/releases )
- [Changelog](https://github.com/seanmonstar/reqwest/blob/master/CHANGELOG.md )
- [Commits](https://github.com/seanmonstar/reqwest/compare/v0.11.27...v0.12.0 )
---
updated-dependencies:
- dependency-name: reqwest
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* wip
* wip
* ci: lock sqlx-cli install
* bump reqwest to 0.12.2
* deps: reqwest to 0.12.4
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Byron Hambly <byron@hambly.dev>
2024-05-30 10:27:48 +02:00
Byron Hambly
acdba8474b
build(deps): update rust-toolchain to 1.67 and bump uuid to 1.4
...
some of the dependency updates are requiring a higher version of the
rust toolchain. bump to 1.67 and fix new clippy lints.
also fix dprint to 0.39.1 because 0.40 has breaking changes.
2023-07-31 11:49:28 +02:00
dependabot[bot]
9970b4a328
build(deps): bump hex-literal from 0.3.4 to 0.4.1
...
Bumps [hex-literal](https://github.com/RustCrypto/utils ) from 0.3.4 to 0.4.1.
- [Release notes](https://github.com/RustCrypto/utils/releases )
- [Commits](https://github.com/RustCrypto/utils/compare/hex-literal-v0.3.4...hex-literal-v0.4.1 )
---
updated-dependencies:
- dependency-name: hex-literal
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-04-18 11:58:22 +00:00
Byron Hambly
00cfce57c7
chore: fix dprint config and run fmt
2023-03-15 14:19:57 +02:00
Byron Hambly
4ca1f8da5e
ci: update msrv and github actions toolchains
2023-01-10 14:57:09 +02:00
Byron Hambly
f224c49584
fix(asb): use unlocked monero balance for quotes
2022-11-07 09:52:58 +02:00
Byron Hambly
5a3675a06f
Update dependencies and rust-toolchain to 1.59
...
This commit updates the rust-toolchain to the current stable version
1.59, and fixes a number of new clippy warnings from that change.
Other changes:
- updates backoff to 0.4
- updates swap to 2021 edition
- updates comfy-table to 5.0
- updates monero-wallet to 2021 edition
- updates moneor-harness to 2021 edition
- updates bdk and rust_decimal
- updates tokio-util to 0.7
- updates workflow to use actions/setup-python@3
- updates pem and serde_with
- adds stable rust toolchain notice to readme
2022-03-12 13:05:36 +02:00
Thomas Eizinger
25b123d6ed
Load wallet in monero-wallet-rpc on demand if necessary
...
Previously, we relied on the wallet in the `monero-wallet-rpc` daemon
to be loaded as we do on startup. As a consequence of this expectation,
restarting `monero-wallet-rpc` to fix bugs like #652 resulted in the
ASB no longer operating correctly.
To fix this, we now load the wallet on-demand in case the daemon responds
with the error code -13.
Ideally, we would implement this behaviour generically using the proxy
pattern on the `MoneroWalletRpc` trait. Unfortunately, when attempting
to do so we uncover a limitation in the design of `jsonrpc_client`.
This limitation is tracked in https://github.com/thomaseizinger/rust-jsonrpc-client/issues/47 .
Once fixed, we can implement this logic in a more robust way that is not
tied to the `check_tx_key` RPC call but applies to any RPC call automatically.
2021-08-27 09:39:29 +10:00
dependabot[bot]
3818cb4f48
Bump jsonrpc_client from 0.6.0 to 0.7.0
...
Bumps [jsonrpc_client](https://github.com/thomaseizinger/rust-jsonrpc-client ) from 0.6.0 to 0.7.0.
- [Release notes](https://github.com/thomaseizinger/rust-jsonrpc-client/releases )
- [Changelog](https://github.com/thomaseizinger/rust-jsonrpc-client/blob/master/CHANGELOG.md )
- [Commits](https://github.com/thomaseizinger/rust-jsonrpc-client/compare/v0.6.0...0.7.0 )
---
updated-dependencies:
- dependency-name: jsonrpc_client
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-08-20 08:23:08 +00:00
Thomas Eizinger
2f2b3b8a19
Update metadata and remove outdated config files / READMEs
2021-05-17 11:03:43 +10:00
Thomas Eizinger
dd6bfd3bf4
Extend RPC client for monerod with binary requests
2021-04-30 10:28:45 +10:00
Thomas Eizinger
1820139786
Use dprint for formatting Cargo.toml files
...
Invoking cargo tomlfmt on all files is a PITA and as we can see from
the CI scripts, it is often forgotten to as new crates are added to
the workspace.
Using dprint for toml files fixes this.
Unfortunately, we can't use dprint for Rust code yet because there
hasn't been a release of rustfmt in quite a while but we are already
using features from a newer rustfmt via rustup.
2021-04-29 17:35:02 +10:00
Thomas Eizinger
0970c2bc72
Initialize reqwest clients with verbose logging
2021-04-26 18:12:56 +10:00
Thomas Eizinger
6d06db3259
Use macro-based JSON-RPC client
2021-04-26 12:45:35 +10:00
bors[bot]
19766b9759
Merge #405
...
405: Concurrent swaps with same peer r=da-kami a=da-kami
Fixes #367
- [x] Concurrent swaps with same peer
Not sure how much more time I should invest into this. We could just merge the current state and then do improvements on top...?
Improvements:
- [x] Think `// TODO: Remove unnecessary swap-id check` through and remove it
- [x] Add concurrent swap test, multiple swaps with same Bob
- [ ] Save swap messages without matching swap in execution in the database
- [ ] Assert the balances in the new concurrent swap tests
- [ ] ~~Add concurrent swap test, multiple swaps with different Bobs~~
- [ ] ~~Send swap-id in separate message, not on top of `Message0`~~
Co-authored-by: Daniel Karzel <daniel@comit.network>
2021-04-13 08:50:44 +00:00
Daniel Karzel
99268c2715
Workaround to avoid overflow in check_tx_key
...
`check_tx_key` can run into an overflow error when handling `-1` values for confirmations.
This most likely happens when a transaction is not in mempool yet.
In order to avoid unwanted side effects in the tests (i.e. failure because the transfer is seemingly confirmed, when it is not yet),
we add a guard that checks for values close to u64::MAX.
Note that we cannot check for the exact value of u64::MAX, because it seems that there is an addition somewhere in monerod/wallet-rpc,
that results in `-1` (first), `-2` (second) (...) until the transaction is in mempool.
2021-04-13 17:43:00 +10:00
Daniel Karzel
6c4d72704a
Correct debug log for check_tx_key
2021-04-13 16:35:27 +10:00
Daniel Karzel
489696ee08
Swap-id as file name for generated Monero wallet
...
Instead of using the private view-key as wallet filename we use the swap-id, to be able to identify which wallet is associated with which swap.
2021-04-08 19:23:54 +10:00
bors[bot]
6fb495b6ab
Merge #383 #385 #386
...
383: Improve resilience of balance assertions r=thomaseizinger a=thomaseizinger
The final commit is the relevant patch!
It sits on top of several refactoring commits that happened while I was debugging why things didn't work as expected. Turned out to be reasonably useful so I just left them in :)
385: Bump anyhow from 1.0.39 to 1.0.40 r=thomaseizinger a=dependabot[bot]
Bumps [anyhow](https://github.com/dtolnay/anyhow ) from 1.0.39 to 1.0.40.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dtolnay/anyhow/releases ">anyhow's releases</a>.</em></p>
<blockquote>
<h2>1.0.40</h2>
<ul>
<li>Reduce memory footprint of errors on Rust versions 1.51+ (<a href="https://github-redirect.dependabot.com/dtolnay/anyhow/issues/145 ">#145</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="704622f25d64ac0c00a9https://github-redirect.dependabot.com/dtolnay/anyhow/issues/145 ">#145</a> from dtolnay/addrof</li>
<li><a href="ef082670ea1295b1fef9be89adf403ac64560c422987c9b59e827bb9d4c6ce0041866dhttps://github-redirect.dependabot.com/dtolnay/anyhow/issues/144 ">#144</a> from dtolnay/ptr</li>
<li><a href="3c32aa7dcdhttps://github.com/dtolnay/anyhow/compare/1.0.39...1.0.40 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
386: Bump hyper from 0.14.4 to 0.14.5 r=thomaseizinger a=dependabot[bot]
Bumps [hyper](https://github.com/hyperium/hyper ) from 0.14.4 to 0.14.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/hyperium/hyper/releases ">hyper's releases</a>.</em></p>
<blockquote>
<h2>v0.14.5</h2>
<h2>Bug Fixes</h2>
<ul>
<li><strong>client:</strong> omit default port from automatic Host headers (<a href="https://github-redirect.dependabot.com/hyperium/hyper/issues/2441 ">#2441</a>) (<a href="0b11eee9bdhttps://github-redirect.dependabot.com/hyperium/hyper/issues/2471 ">#2471</a>) (<a href="48fdaf1606https://github-redirect.dependabot.com/hyperium/hyper/issues/2470 ">#2470</a>)</li>
<li><strong>server:</strong> skip automatic Content-Length headers when not allowed (<a href="https://github-redirect.dependabot.com/hyperium/hyper/issues/2216 ">#2216</a>) (<a href="8cbf9527dfhttps://github-redirect.dependabot.com/hyperium/hyper/issues/2215 ">#2215</a>)</li>
</ul>
<h2>Features</h2>
<ul>
<li><strong>client:</strong> allow HTTP/0.9 responses behind a flag (<a href="https://github-redirect.dependabot.com/hyperium/hyper/issues/2473 ">#2473</a>) (<a href="68d4e4a3dbhttps://github-redirect.dependabot.com/hyperium/hyper/issues/2468 ">#2468</a>)</li>
<li><strong>server:</strong> add <code>AddrIncoming::from_listener</code> constructor (<a href="https://github-redirect.dependabot.com/hyperium/hyper/issues/2439 ">#2439</a>) (<a href="4c946af49chttps://github.com/hyperium/hyper/blob/master/CHANGELOG.md ">hyper's changelog</a>.</em></p>
<blockquote>
<h3>v0.14.5 (2021-03-26)</h3>
<h4>Bug Fixes</h4>
<ul>
<li><strong>client:</strong> omit default port from automatic Host headers (<a href="https://github-redirect.dependabot.com/hyperium/hyper/issues/2441 ">#2441</a>) (<a href="0b11eee9bdhttps://github-redirect.dependabot.com/hyperium/hyper/issues/2471 ">#2471</a>) (<a href="48fdaf1606https://github-redirect.dependabot.com/hyperium/hyper/issues/2470 ">#2470</a>)</li>
<li><strong>server:</strong> skip automatic Content-Length headers when not allowed (<a href="https://github-redirect.dependabot.com/hyperium/hyper/issues/2216 ">#2216</a>) (<a href="8cbf9527dfhttps://github-redirect.dependabot.com/hyperium/hyper/issues/2215 ">#2215</a>)</li>
</ul>
<h4>Features</h4>
<ul>
<li><strong>client:</strong> allow HTTP/0.9 responses behind a flag (<a href="https://github-redirect.dependabot.com/hyperium/hyper/issues/2473 ">#2473</a>) (<a href="68d4e4a3dbhttps://github-redirect.dependabot.com/hyperium/hyper/issues/2468 ">#2468</a>)</li>
<li><strong>server:</strong> add <code>AddrIncoming::from_listener</code> constructor (<a href="https://github-redirect.dependabot.com/hyperium/hyper/issues/2439 ">#2439</a>) (<a href="4c946af49c98e7e0bd15895e4cf3fbhttps://github-redirect.dependabot.com/hyperium/hyper/issues/2478 ">#2478</a>)</li>
<li><a href="68d4e4a3dbhttps://github-redirect.dependabot.com/hyperium/hyper/issues/2473 ">#2473</a>)</li>
<li><a href="51ed71b0a6https://hyper.rs/guide ">https://hyper.rs/guide </a>...</li>
<li><a href="41f99578a5https://github-redirect.dependabot.com/hyperium/hyper/issues/2472 ">#2472</a>)</li>
<li><a href="48fdaf1606https://github-redirect.dependabot.com/hyperium/hyper/issues/2471 ">#2471</a>)</li>
<li><a href="eb0e718696https://github-redirect.dependabot.com/hyperium/hyper/issues/2464 ">#2464</a>)</li>
<li><a href="297a068454https://github-redirect.dependabot.com/hyperium/hyper/issues/2456 ">#2456</a>)</li>
<li><a href="34085afef6https://github-redirect.dependabot.com/hyperium/hyper/issues/2451 ">#2451</a>)</li>
<li><a href="8cbf9527dfhttps://github-redirect.dependabot.com/hyperium/hyper/issues/2216 ">#2216</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/hyperium/hyper/compare/v0.14.4...v0.14.5 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-29 22:31:43 +00:00
Thomas Eizinger
5616683d7d
Monero confirmations are a u64
...
Trying to deserialize the number as a u32 caused deserialization
errors.
2021-03-29 12:14:19 +11:00
rishflab
bc902ea63a
Use language agnostic heuristic to check if monero_wallet_rpc is ready
...
Our strategy of searching for a english string to determine if
monero_wallet_rpc is ready is not compatible with languages other than
english. Instead we assume the monero rpc is ready if it has stopped
writing to stdout. We make a json rpc request to confirm this. A better
solution would have been to configure the monero_wallet_rpc to always
output in english but there is not command line argument to configure
the language.
Closes #353 .
2021-03-25 18:13:06 +11:00
Thomas Eizinger
febc68c780
Enforce consistent formatting of Markdown files
2021-03-25 11:11:57 +11:00
Thomas Eizinger
f0a2134f76
Remove unused field
2021-03-11 15:34:27 +11:00
Daniel Karzel
2e3c2d8edf
Remove Arcs in favour of references
2021-03-03 17:23:07 +11:00
Daniel Karzel
0b4c0758bb
Turbofish syntax
...
This way, we are co-locating the type with the expression that requires it.
This makes it easier to take this expression and compose it with other ones
without having to touch the type hint on the variable.
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
2021-03-03 17:15:37 +11:00
Daniel Karzel
66c8401c95
Sweep all from generated wallet to user wallet
...
The default implementation for the command was removed because it does not
add additional value if we have a mandatory parameter anyway.
2021-03-03 17:15:37 +11:00
Daniel Karzel
684cbe4d0b
Remember monero wallet-height for Alice's refund scenario
2021-02-25 00:34:05 +11:00
Thomas Eizinger
498fae9f64
Remove native-tls feature from monero-rpc
...
1. `monero-rpc` is not in the position to decide about the TLS backend
an application should use.
2. We don't use TLS encrypted communication to my knowledge so we don't
have to activate this feature anywhere else.
2021-02-23 14:30:20 +11:00
Thomas Eizinger
03078f328c
Split monero-harness into harness and rpc
...
This allows us to move `monero-harness` and `bitcoin-harness` into
`[dev-dependencies]` of `swap`.
2021-02-23 14:30:20 +11:00
