Commit Graph

441 Commits (5d215caf350ed09860eadead3525af48106731ee)

Author SHA1 Message Date
bors[bot] 5d215caf35
Merge #188
188: Tor cleanup r=da-kami a=da-kami

We never removed Tor install from CI. I don't think it should be necessary given that Tor was removed in code.

Co-authored-by: Daniel Karzel <daniel@comit.network>
4 years ago
Franck Royer f36f5acaf1
Remove unnecessary async block 4 years ago
Franck Royer 65e0e5b731
Use Remote handle to access ongoing swaps on Alice 4 years ago
bors[bot] a0753e24dc
Merge #189
189: The first message is more of a quote request than a swap request r=D4nte a=D4nte



Co-authored-by: Franck Royer <franck@coblox.tech>
4 years ago
Franck Royer 5d78556665
Give a more specific name to the CLI binary: `swap-cli`
The current binary name is very generic `cli`. `swap-cli` better
describes what this binary does.
4 years ago
Franck Royer 8fada42074
Make `config` argument global
The `config` argument apply to all commands. It is now optional and
needs to be passed before a command.
E.g. `cli --config ./config.toml history`
4 years ago
Franck Royer 83dcf4ba3c
Add `nectar` binary 4 years ago
Daniel Karzel c166232daf Remove unnecessary mention of Tor in comment 4 years ago
Franck Royer 9ded728879
The first message is actually a quote or rate request 4 years ago
Franck Royer ee43125bdd
Add `nectar` binary 4 years ago
Franck Royer fac5b59d17
Remove unnecessary specification of the types 4 years ago
Franck Royer 7805a6d684
Move cli specific modules under cli folder
nectar will also have its own folder with a separate config.
4 years ago
Franck Royer 901c9e89c9
No evident added value of having separate `Seed` structs
Hence, reducing complexity of the codebase. Note that the seed will be
used by both nectar and the cli whereas the config mod will be different
so this changes helps with the next step of having a dedicated config
module for each binary.
4 years ago
Franck Royer 7d392c3086
This files contains `Command` and `Arguments` structs 4 years ago
Franck Royer 45dccb8be2
Rename the config struct `Config` 4 years ago
Franck Royer eb39add5ff
Fix typo 4 years ago
Franck Royer 6e6dc320b4
Alice event loop now handles the creation of new swaps 4 years ago
Franck Royer 15eb9a2fe4
Remove punish test
The punish test needs re-work due to the fact that Alice runs continuously

Currently focusing on the CLI (Bob), so we can re-introduce this test
once we want to ensure that nectar (Alice) punishes.
4 years ago
Franck Royer 3bc8b58b6a
Remove Bob restart tests after communication
The test do not work without acks as we stop the event loop as soon
as a message is considered as "sent" when actually the event loop
and swarm may not have yet sent the message.

The ack allow to avoid this issue as the message was considered "sent"
only once the other party sent a response. However, the ack brings
other issue so a review needs to be done to select the appropriate
solution.
4 years ago
Franck Royer fd9f633a77
Remove Alice restarts tests
Current focus is on CLI UX. Fair amount of change needs to happen to
cater for Alice (nectar) restart scenarios.
4 years ago
Franck Royer bfc19d5628
Remove acknowledgements processing
We are aware of issues of timeouts when waiting for acknowledgements.
Also, to properly supports acks in a multiple swap context, we need to
revert to doing event processing on the behaviour so that we can link
leverage the `RequestResponse` libp2p behaviour and link the messages
requests ids to swap ids when receiving an ack or response.

Acks are usefully for specific scenarios where we queue a message on the
behaviour to be sent, save as sent in the DB but crash before the
message is actually sent. With acks we are able to resume the swap,
without ack, the swap will abort (refund).
4 years ago
Franck Royer cc8b855117
Make it possible to clone a handle
This will be used for new swaps.
4 years ago
Franck Royer 1b2be804ed
Remove unnecessary channels
`alice::swap::run_until` will be called once the execution setup is
done. The steps before are directly handled by the event loop,
hence no channels are needed for said steps: connection established,
swap request/response & execution setup.
4 years ago
Franck Royer f5ca5faabf
Process execution setup failure similarly to other failures
By merging it in the failure event of the root behaviour.
4 years ago
Franck Royer 4ade5df0e5
Remove unnecessary impl block 4 years ago
Franck Royer 60e0b9382c
Introduced from float API for Monero quantities 4 years ago
Franck Royer b5b990257a
Move `Behaviour` in dedicated module 4 years ago
Franck Royer 87be9aeb2a
Prepare separation of event loop initialisation to swap initialisation
As for Alice, the event loop will be started with the program and will
be the one starting swaps (`run_until`) based on libp2p events (swap
request).
4 years ago
Franck Royer 530b9b2ea8
Remove possible mix up of timelocks when using `State0::new` 4 years ago
Franck Royer f35ed436ce
Allow `EventLoop` to hold a database ready to pass to `alice::Buider`
The `EventLoop` will use the `Builder` interface to instantiate a
`Swap` upon receiving a `SwapRequest` and successfully doing an
execution setup.
Before this change, the `EventLoop` would have to hold the path to the
db and re-open the db everytime it wants to construct a swap.

With this change, we can open the DB once and then hold a
`Arc<Database>` in the `EventLoop` and pass it to new `Swap`s structs.
4 years ago
Franck Royer 39a46baa2c
Preemptively box cancel tx to avoid size difference in enum 4 years ago
Franck Royer 69363e43a3
Preemptively box encrypted signature to avoid size difference in enum 4 years ago
Franck Royer fd084b764d
Move generation of keys inside `State0::new`
The event loop will now use this function so I want to simplify its
usage to avoid having to instantiate too many items to use it.
4 years ago
Franck Royer 788445964a
Move main.rs to cli.rs to prepare for nectar binary 4 years ago
Franck Royer 311ba74cd6
Remove sell-xmr from CLI 4 years ago
Daniel Karzel 0a0bce1552 Rename temporary wallet to blockchain monitoring wallet 4 years ago
Daniel Karzel 1e29433bd2 Open or create temporary Monero wallet upon wallet initialization 4 years ago
Daniel Karzel dac4443bbd Add functionality to open monero wallet through rpc 4 years ago
Daniel Karzel 62605a318a Add CreateWallet trait to expose create_wallet 4 years ago
Daniel Karzel 53fcd9224c Give finding the refund tx priority over waiting for the punish transaction to be finalized.
This was introduced due to a CI run, where Bob included tx_refund, but Alice had waited until T2 had expired,
and then went for punishing Bob instead of refunding.
Weirdly, Alice's punich transaction did not fail in that scenario.
4 years ago
Daniel Karzel 86290649e7 work in review comments 4 years ago
Daniel Karzel c930ad84a4 Add --force flag for cancel and refund 4 years ago
Daniel Karzel 02f8eb7f18 Add test for cancel/refund before timelock expired 4 years ago
Daniel Karzel 2d5d70d856 Timeout for Alice waiting for ack for sending transfer proof
If dialing Bob fails Alice waits for the acknowledgement of the transfer proof indefinitely.
The timout prevents her execution from hanging.
Added a ToDo to re-visit the ack receivers. They don't add value at the moment and should be removed.
4 years ago
Daniel Karzel c9adbde5d5 Add test for Bob's manual cancel and refund 4 years ago
Daniel Karzel ad2aefc2a5 Refund Command 4 years ago
Daniel Karzel 0600a7048e Cancel command 4 years ago
Franck Royer dee8c1e335
Remove scopes 4 years ago
Franck Royer a48823a665
Re-organise Alice state to be more coherent with the msg sequence 4 years ago
Franck Royer eefb1b3b16
Use event_process = false for Bob
As we do not process the event, we can just implement the needed `From`
traits.
4 years ago