96 Commits (5a3675a06fcafe2dcc2ab9ff2c0096423362431c)

Author	SHA1	Message	Date
Byron Hambly	5a3675a06f	Update dependencies and rust-toolchain to 1.59 ... This commit updates the rust-toolchain to the current stable version 1.59, and fixes a number of new clippy warnings from that change. Other changes: - updates backoff to 0.4 - updates swap to 2021 edition - updates comfy-table to 5.0 - updates monero-wallet to 2021 edition - updates moneor-harness to 2021 edition - updates bdk and rust_decimal - updates tokio-util to 0.7 - updates workflow to use actions/setup-python@3 - updates pem and serde_with - adds stable rust toolchain notice to readme	2 years ago
devbordecraft	250d25ada6	Fix electrum query failing (CloseNotify bug) and use a more stable mainnet electrum server.	2 years ago
bors[bot]	bf9e2d0f77	Merge #806 ... 806: Upgrade bitcoin and bdk to latest version r=rishflab a=thomaseizinger The latest version allows us to access `miniscript` via `bdk` which removes the need for declaring it as an extra dependency. Co-authored-by: Thomas Eizinger <thomas@eizinger.io>	3 years ago
Thomas Eizinger	4de8b0ebc4	Upgrade bitcoin and bdk to latest version ... The latest version allows us to access `miniscript` via `bdk` which removes the need for declaring it as an extra dependency.	3 years ago
rishflab	e42812ba37	Add subcommand to print internal bitcoin wallet descriptor ... Example: cargo run --package swap --bin swap -- export-bitcoin-wallet {"descriptor":"wpkh(xprv9s21ZrQH143K2q85eUf2ppCtti2Zar6aDCW5dCC5DG9VvutJ3cpe3Qf9wZpQeraNf9JEuGem1RyJZQMEWCN2DpWyL5WbsvmSW6wbL7Jq53H/84'/0'/0'/0/*)","blockheight":0,"label":"cli-bitcoin"}	3 years ago
devbordecraft	7a12a847a0	Fetch multiple UTXOs when we do max_giveable	3 years ago
rishflab	8598bcade1	Configure electrum client to retry 5 times	3 years ago
Thomas Eizinger	0296509110	Upgrade to bdk 0.10 ... This fixes #546. I don't know why, but I can't reproduce the problem with the updated dependency.	3 years ago
Thomas Eizinger	475057abda	Add proptest for max_giveable and signing PSBT	3 years ago
Thomas Eizinger	e4b5e28a93	Introduce WalletBuilder for creating test instances of wallet	3 years ago
Thomas Eizinger	46ffc34f40	Don't spam on transaction status change	3 years ago
Thomas Eizinger	991dbf496e	Extract `print_status_change` so it is easily testable	3 years ago
Thomas Eizinger	9119ce5cc4	Tidy up log messages across the codebase ... 1. Clearly separate the log messages from any fields that are captured. The log message itself should be meaningful because it depends on the underlying formatter, how/if the fields are displayed. 2. Some log messages had very little context, expand that. 3. Wording of errors was inconsistent, hopefully all errors should now start with `Failed to ...`. 4. Some log messages were duplicated across multiple layers (like opening the database). 5. Some log messages were split into two where one part is now an `error!` and the 2nd part is an `info!` on what is happening next. 6. Where appropriate, punctuation has been removed to not interrupt the reader's flow.	3 years ago
Thomas Eizinger	1d0d38cd48	Explain why we clear the `bip32_derivation` map	3 years ago
Thomas Eizinger	5463bde4f8	Add a mandatory `--change-address` parameter to `buy-xmr` ... Fixes #513.	3 years ago
Thomas Eizinger	8b59ac26ba	Replace sorting with slice pattern matching ... Sorting `psbt.output` by `witness_script` is at times pointless because it might be set to `None`. To be more robust, we pattern match against the produced transaction.	3 years ago
dependabot[bot]	9577875834	Bump bdk from 0.7.0 to 0.8.0 ... Bumps [bdk](https://github.com/bitcoindevkit/bdk) from 0.7.0 to 0.8.0. - [Release notes](https://github.com/bitcoindevkit/bdk/releases) - [Changelog](https://github.com/bitcoindevkit/bdk/blob/master/CHANGELOG.md) - [Commits](https://github.com/bitcoindevkit/bdk/compare/v0.7.0...v0.8.0) --- updated-dependencies: - dependency-name: bdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	3 years ago
bors[bot]	7f2aa59880	Merge #504 #547 #556 #563 #564 ... 504: Bump bdk from 0.6.0 to 0.7.0 r=thomaseizinger a=dependabot[bot] Bumps [bdk](https://github.com/bitcoindevkit/bdk) from 0.6.0 to 0.7.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/bitcoindevkit/bdk/blob/v0.7.0/CHANGELOG.md">bdk's changelog</a>.</em></p> </details> <details> <summary>Commits</summary> <ul> <li><a href="766570abfd"><code>766570a</code></a> Bump version to 0.7.0</li> <li><a href="934ec366d9"><code>934ec36</code></a> Use the released <code>testutils-macros</code></li> <li><a href="d0733e9496"><code>d0733e9</code></a> Bump version in <code>src/lib.rs</code></li> <li><a href="3c7a1f5918"><code>3c7a1f5</code></a> Bump <code>testutils-macros</code> to <code>v0.6.0</code></li> <li><a href="85aadaccd2"><code>85aadac</code></a> Update changelog in preparation of <code>v0.7.0</code></li> <li><a href="fad0fe9f30"><code>fad0fe9</code></a> Update create transaction example code</li> <li><a href="47f26447da"><code>47f2644</code></a> continue signing when finding already finalized inputs</li> <li><a href="3608ff9f14"><code>3608ff9</code></a> Merge commit 'refs/pull/341/head' of github.com:bitcoindevkit/bdk into releas...</li> <li><a href="898dfe6cf1"><code>898dfe6</code></a> get psbt inputs with bounds check</li> <li><a href="7961ae7f8e"><code>7961ae7</code></a> Check index out of bound also for tx inputs not only for psbt inputs</li> <li>Additional commits viewable in <a href="https://github.com/bitcoindevkit/bdk/compare/v0.6.0...v0.7.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 547: Print the Bitcoin address to the terminal as a QR code r=thomaseizinger a=xscd It helps to fund the Bitcoin address with your mobile device without a need to copy-paste the receive address. Here is how it looks like under different terminals: 1) Gnome Terminal:  2) Alacritty:  3) Kitty:  4) Konsole:  556: Bump rust_decimal from 1.14.1 to 1.14.2 r=thomaseizinger a=dependabot[bot] Bumps [rust_decimal](https://github.com/paupino/rust-decimal) from 1.14.1 to 1.14.2. <details> <summary>Commits</summary> <ul> <li><a href="16b41cc58c"><code>16b41cc</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/paupino/rust-decimal/issues/394">#394</a> from paupino/version/1.14.2</li> <li><a href="c7bd3bf987"><code>c7bd3bf</code></a> Version 1.14.2</li> <li><a href="c0117ddc36"><code>c0117dd</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/paupino/rust-decimal/issues/393">#393</a> from paupino/issue/392</li> <li><a href="a231fbf12c"><code>a231fbf</code></a> Fixes issue with remainder overflow</li> <li>See full diff in <a href="https://github.com/paupino/rust-decimal/compare/1.14.1...1.14.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 563: Bump tokio from 1.6.0 to 1.7.0 r=thomaseizinger a=dependabot[bot] Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.6.0 to 1.7.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/tokio-rs/tokio/releases">tokio's releases</a>.</em></p> <blockquote> <h2>Tokio v1.7.0</h2> <h1>1.7.0 (June 15, 2021)</h1> <h3>Added</h3> <ul> <li>net: add named pipes on windows (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3760">#3760</a>)</li> <li>net: add <code>TcpSocket</code> from <code>std::net::TcpStream</code> conversion (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3838">#3838</a>)</li> <li>sync: add <code>receiver_count</code> to <code>watch::Sender</code> (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3729">#3729</a>)</li> <li>sync: export <code>sync::notify::Notified</code> future publicly (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3840">#3840</a>)</li> <li>tracing: instrument task wakers (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3836">#3836</a>)</li> </ul> <h3>Fixed</h3> <ul> <li>macros: suppress <code>clippy::default_numeric_fallback</code> lint in generated code (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3831">#3831</a>)</li> <li>runtime: immediately drop new tasks when runtime is shut down (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3752">#3752</a>)</li> <li>sync: deprecate unused <code>mpsc::RecvError</code> type (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3833">#3833</a>)</li> </ul> <h3>Documented</h3> <ul> <li>io: clarify EOF condition for <code>AsyncReadExt::read_buf</code> (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3850">#3850</a>)</li> <li>io: clarify limits on return values of <code>AsyncWrite::poll_write</code> (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3820">#3820</a>)</li> <li>sync: add examples to Semaphore (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3808">#3808</a>)</li> </ul> <h2>Tokio v1.6.2</h2> <h3>Fixes</h3> <ul> <li>test: sub-ms <code>time:advance</code> regression introduced in 1.6 (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3852">#3852</a>)</li> </ul> <p><a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3852">#3852</a>: <a href="https://github-redirect.dependabot.com/tokio-rs/tokio/pull/3852">tokio-rs/tokio#3852</a></p> <h2>Tokio v1.6.1</h2> <p>This release reverts <a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3518">#3518</a> because it doesn't work on some kernels due to a kernel bug. (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3803">#3803</a>)</p> <p><a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3518">#3518</a>: <a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3518">tokio-rs/tokio#3518</a> <a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3803">#3803</a>: <a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3803">tokio-rs/tokio#3803</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="34c6a26c01"><code>34c6a26</code></a> chore: prepare Tokio v1.7.0 (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3863">#3863</a>)</li> <li><a href="97e7830364"><code>97e7830</code></a> net: provide NamedPipe{Client, Server} types and builders (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3760">#3760</a>)</li> <li><a href="606206ecad"><code>606206e</code></a> Merge branch 'tokio-1.6.x' into merge-1.6.x</li> <li><a href="dfe4013ff2"><code>dfe4013</code></a> chore: prepare Tokio 1.6.2 release (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3859">#3859</a>)</li> <li><a href="18779aa2e2"><code>18779aa</code></a> time: fix time::advance() with sub-ms durations (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3852">#3852</a>)</li> <li><a href="2c24a028f6"><code>2c24a02</code></a> chore: re-enable test_socket_pair on FreeBSD (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3844">#3844</a>)</li> <li><a href="f55b77aadd"><code>f55b77a</code></a> tracing: emit waker op as str instead as Debug (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3853">#3853</a>)</li> <li><a href="21de476ae7"><code>21de476</code></a> sync: export sync::notify::Notified future publicly (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3840">#3840</a>)</li> <li><a href="cb147a2b3f"><code>cb147a2</code></a> sync: deprecate mpsc::RecvError (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3833">#3833</a>)</li> <li><a href="f759240254"><code>f759240</code></a> chore: update version in README.md (<a href="https://github-redirect.dependabot.com/tokio-rs/tokio/issues/3851">#3851</a>)</li> <li>Additional commits viewable in <a href="https://github.com/tokio-rs/tokio/compare/tokio-1.6.0...tokio-1.7.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 564: Bump thomaseizinger/create-pull-request from 1.0.0 to 1.1.0 r=thomaseizinger a=dependabot[bot] Bumps [thomaseizinger/create-pull-request](https://github.com/thomaseizinger/create-pull-request) from 1.0.0 to 1.1.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/thomaseizinger/create-pull-request/blob/master/CHANGELOG.md">thomaseizinger/create-pull-request's changelog</a>.</em></p> <blockquote> <h2>[1.1.0] - 2021-06-16</h2> <h3>Added</h3> <ul> <li>Git hook to make sure we always run <code>yarn build</code> before committing any Typescript changes. This should prevent dist/index.js from getting out of date.</li> <li>Support for setting a proxy using the <code>HTTPS_PROXY</code> environment variable</li> <li>Support for GitHub Enterprise by reading <code>process.env.GITHUB_REPOSITORY</code></li> </ul> <h3>Fixed</h3> <ul> <li>action.yml suggested to use <code>github-token</code> as the input where as in reality, we are looking for an input <code>github_token</code> (note the underscore!)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="285345fb83"><code>285345f</code></a> Add support for creating PR's in ghes and behind proxy (<a href="https://github-redirect.dependabot.com/thomaseizinger/create-pull-request/issues/41">#41</a>)</li> <li><a href="13c98abb44"><code>13c98ab</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/thomaseizinger/create-pull-request/issues/37">#37</a> from orestesgaolin/patch-1</li> <li><a href="5c8c2b6c09"><code>5c8c2b6</code></a> Fix parameters in the example</li> <li><a href="1dde00b9ad"><code>1dde00b</code></a> Adapt LICENSE</li> <li><a href="655db51f4a"><code>655db51</code></a> Automatically set the hookspath to our git hooks</li> <li><a href="cedbbbb2ba"><code>cedbbbb</code></a> Update README.md</li> <li><a href="2cd3e70bc6"><code>2cd3e70</code></a> Add readme note about inputs</li> <li><a href="faf5ed2aa5"><code>faf5ed2</code></a> Define Inputs type through type magic on payloads types</li> <li><a href="3fb1c8b1be"><code>3fb1c8b</code></a> Fixing git url in package.json</li> <li><a href="e46f94e6ae"><code>e46f94e</code></a> Add git hook for making sure we update index.js</li> <li>Additional commits viewable in <a href="https://github.com/thomaseizinger/create-pull-request/compare/1.0.0...1.1.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: xscd <xscd@pm.me>	3 years ago
bors[bot]	eb705d3e9c	Merge #515 ... 515: Make it easier to create a bitcoin::Wallet for testing r=thomaseizinger a=thomaseizinger Forcing the user to create an implementation of `EstimateFeeRate` every time they want to create a wallet for testing is tedious and leads to duplicated code. The implementation for tests is rarely dynamic and thus can be simplified to static arguments. This also allows us to provide convenience constructors to make tests that don't care about fees less distracting by reducing the number of constants that are floating around. Co-authored-by: Thomas Eizinger <thomas@eizinger.io>	3 years ago
dependabot[bot]	6badf09394	Bump bdk from 0.6.0 to 0.7.0 ... Bumps [bdk](https://github.com/bitcoindevkit/bdk) from 0.6.0 to 0.7.0. - [Release notes](https://github.com/bitcoindevkit/bdk/releases) - [Changelog](https://github.com/bitcoindevkit/bdk/blob/v0.7.0/CHANGELOG.md) - [Commits](https://github.com/bitcoindevkit/bdk/compare/v0.6.0...v0.7.0) Signed-off-by: dependabot[bot] <support@github.com>	3 years ago
Thomas Eizinger	51316d8183	Make it easier to create a bitcoin::Wallet for testing ... Forcing the user to create an implementation of `EstimateFeeRate` every time they want to create a wallet for testing is tedious and leads to duplicated code. The implementation for tests is rarely dynamic and thus can be simplified to static arguments. This also allows us to provide convenience constructors to make tests that don't care about fees less distracting by reducing the number of constants that are floating around.	3 years ago
Daniel Karzel	202f6d1fa0	Bitcoin network check when building PSBT ... This ensures that funds are not sent to an address on the wrong network.	3 years ago
Daniel Karzel	6694e4f4e0	Ensure that output of lock script is at tx-output index `0` ... We subscribe to transactions upon broadcast, where we use output index `0` for the subscription. In order to ensure that this subscription is guaranteed to be for the locking script (and not a change output) we now ensure that the locking script output is always at index `0` of the outputs of the transaction. We chose this solution because otherwise we would have to add more information to broadcasting a transaction. This solution is less intrusive, because the order of transaction outputs should not have any side effects and ensuring index `0` makes the whole behaviour more deterministic.	3 years ago
Daniel Karzel	bae38a712f	Sync on interval instead of ping ... Since we don't rely on long running subscriptions anymore we can remove the ping that was used to ensure a connection refresh.	3 years ago
Daniel Karzel	efb51820b1	Poll block headers for latest block on each iteration ... The Electrum block-header subscription did not provide us with block headers, because upon the connection being closed by a node the subscription would end. Re-newing the the subscription upon re-connect is not easily achievable, that's why we opted for a polling mode for now, where we start a block header subscription on every update iteration, that is only used once (when the subscription is made).	3 years ago
Philipp Hoenisch	7fc5a47619	Add checks to max_giveable amount. ... We need to check two things: - balance to be higher than dust amount (546). - balance to be higher than min-relay fee. Additionally, the tx_builder might fail if not enough funds are in the wallet to pay for the overall transaction fees.	3 years ago
Philipp Hoenisch	26e0383e17	Apply suggestions from code review ... Co-authored-by: Daniel Karzel <daniel.karzel@coblox.tech>	3 years ago
Philipp Hoenisch	316f95c65b	Always log whole causality chain for errors.	3 years ago
Philipp Hoenisch	c011e95062	Improve logging by adding details as fields instead of into the msg.	3 years ago
Philipp Hoenisch	b5073e3052	Use rust_decimal in estimate_fee function.	3 years ago
Philipp Hoenisch	e93eeb81a2	Added some proptests.	3 years ago
Philipp Hoenisch	040cce1eb6	Format all the files	3 years ago
Philipp Hoenisch	aebdb063f1	Remove TODO	3 years ago
Philipp Hoenisch	e69a2c9111	Apply suggestions from code review ... Co-authored-by: Daniel Karzel <daniel.karzel@coblox.tech>	3 years ago
Philipp Hoenisch	dc8dd5af28	Add relative and absolute max transaction fee.	3 years ago
Philipp Hoenisch	14c5a4f025	Add upper bound for bitcoin fees of 100,000 satoshi. ... Fees are hard to compute and it is too easy to get wrong and lose a lot of money. Hence, a hardcoded maximum of 100,000 satoshi for a single transaction is in place.	3 years ago
Philipp Hoenisch	ee90c228b4	Dynamically calculate fees using electrum's estimate_fee. ... Electrum has an estimate-fee feature which takes as input the block you want a tx to be included. The result is a recommendation of BTC/vbyte. Using this recommendation and the knowledge about the size of our transactions we compute an appropriate fee. The size of the transactions were taken from real transactions as published on bitcoin testnet. Note: in reality these sizes might fluctuate a bit but not for much.	3 years ago
Philipp Hoenisch	d5c1b6693e	Dynamically chose fee for TxRedeem. ... Alice chooses the fee for TxRedeem because she is the one that cares. Note must be taken here because if the fee is too low (e.g. < min tx fee) then she might not be able to publish TxRedeem at all.	3 years ago
Thomas Eizinger	39eea61538	Upgrade to bdk 0.6	3 years ago
Daniel Karzel	0341e7c9fc	Point BDK to commit that fixes overflow error ... Edge cases of UTXOs where value < fee cause the BDK's `coin_select` calculation to panic. This issue was fixed upstream thus we point the BDK dependency against the commit of the merged fix.	3 years ago
Thomas Eizinger	52b9a78de2	Alice to validate Bob's PSBT for correctness ... In order for the re-construction of TxLock to be meaningful, we limit `Message2` to the PSBT instead of the full struct. This is a breaking change in the network layer. The PSBT is valid if: - It has at most two outputs (we allow a change output) - One of the outputs pays the agreed upon amount to a shared output script Resolves #260.	3 years ago
Thomas Eizinger	8576894c10	Split bitcoin::Wallet functions into various impl blocks ... This allows us to construct instances of bitcoin::Wallet for test purposes that use a different blockchain and database implementation. We also parameterize the electrum-client to make it possible to construct a bitcoin::Wallet for tests that doesn't have one. This is necessary because the client validates the connection as it is constructed and we don't want to provide an Electrum backend for unit tests.	3 years ago
Thomas Eizinger	01739eddb1	Introduce a more flexible transaction subscription system ... Instead of watching for status changes directly on bitcoin::Wallet, we return a Subscription object back to the caller. This subscription object can be re-used multiple times. Among other things, this now allows callers of `broadcast` to decide on what to wait for given the returned Subscription object. The new API is also more concise which allows us to remove some of the functions on the actor states in favor of simple inline calls. Co-authored-by: rishflab <rishflab@hotmail.com>	3 years ago
Thomas Eizinger	96b2a76971	Take advantage of upgraded electrum-client dependency ... The new version implements std::error::Error and fixes a bug that allows us to use the default config again.	3 years ago
Thomas Eizinger	ce78075932	Make Monero and Bitcoin wallet use a generalized sync interval ... We define the sync interval as 1/10th of the blocktime. For the special case of our tests, we however check at max once per second. The tests have a super fast blocktime. As such we shouldn't hammer the nodes with a request every 100ms.	3 years ago
Thomas Eizinger	09c41f89c4	Rename ExecutionParams to EnvironmentConfig	3 years ago
Thomas Eizinger	bc43ed6ebd	Pass execution params directly into wallet for initialization ... This reduces the amount of parameters that we need to pass in.	3 years ago
Thomas Eizinger	273cf15631	Introduce `Watchable` abstraction for Bitcoin wallet ... We have a repeated pattern where we construct one of our Tx{Cancel,Redeem,Punish,Refund,Lock} transactions and wait until the status of this transaction changes. We can make this more ergonomic by creating and implementing a `Watchable` trait that gives access to the TxId and relevant script for this transaction. This allows us to remove a parameter from the `watch_until_status` function. Additionally, there is a 2nd pattern: "Completing" one of these transaction and waiting until they are confirmed with the configured number of blocks for finality. We can make this more ergonomic by returning a future from `broadcast` that callers can await in case they want to wait for the broadcasted transaction to reach finality.	3 years ago
Thomas Eizinger	a0830f099f	Pass relevant execution params into wallet instead of via functions ... The execution params don't change throughout the lifetime of the program. They can be set in the wallet at the very beginning. This simplifies the interface of the wallet functions.	3 years ago
rishflab	e5c0158597	Greatly reduce load onto the Electrum backend ... We achieve our optimizations in three ways: 1. Batching calls instead of making them individually. To get access to the batch calls, we replace all our calls to the HTTP interface with RPC calls. 2. Never directly make network calls based on function calls on the wallet. Instead, inquiring about the status of a script always just returns information based on local data. With every call, we check when we last refreshed the local data and do so if the data is considered to be too old. This interval is configurable. 3. Use electrum's notification feature to get updated with the latest blockheight. Co-authored-by: Thomas Eizinger <thomas@eizinger.io> Co-authored-by: Rishab Sharma <rishflab@hotmail.com>	3 years ago