Merge #996
996: Implement `Identify` protocol to make network and version of ASB available to peers r=delta1 a=binarybaron As suggested by `@thomaseizinger,` this PRs implement the [Identify](https://github.com/libp2p/specs/blob/master/identify/README.md) protocol for the ASB. It makes the rendezvous namespace (network) and the version available to other peers. This is not a breaking change yet because Bob does not rely on it yet. This can for example be used by application building on top of this project (e.g [unstoppableswap-gui](http://github.com/UnstoppableSwap/unstoppableswap-gui/)) or might serve for some kind of compatibility insurance in the future. I'd love some feedback on this from the more experienced developers. I might very well have made some obvious mistake. > In line with [HTTP user agent strings](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent) (which is what the `agentVersion` field in identify is based on), we could do something like: > > `asb/0.8.0 (Mainnet)` > > A PR adding `/identify` with these details is likely going to be accepted. (https://github.com/comit-network/xmr-btc-swap/discussions/492#discussioncomment-970294) Co-authored-by: binarybaron <86064887+binarybaron@users.noreply.github.com>pull/1019/head
commit
46c649f0da
Loading…
Reference in New Issue