[scripts] Allow pipefail for convenience

scripts/tools/install.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-set -e -o pipefail
+set -e
 
 USAGE="$0 --name=STRING [--channel=STRING]"
 
@@ -21,7 +21,7 @@ for i in "$@"; do
       shift
       ;;
     *)
-      echo $USAGE
+      echo "$USAGE"
       exit 1
       ;;
   esac
@@ -30,7 +30,7 @@ done
 current_version() {
   local crate="$1"
   $CARGO install --list | \
-    grep $crate | \
+    grep "$crate" | \
     head -n 1 | \
     cut -d ' ' -f 2 | \
     sed 's/v\(.*\):/\1/g'
@@ -38,15 +38,15 @@ current_version() {
 
 upstream_version() {
   local crate="$1"
-  $CARGO search $crate | \
-    grep $crate | \
+  $CARGO search "$crate" | \
+    grep "$crate" | \
     head -n 1 | \
     cut -d' ' -f 3 | \
     sed 's/"//g'
 }
 
 if [ "$NAME" == "" ]; then
-  echo $USAGE
+  echo "$USAGE"
   exit 1
 fi
 
@@ -54,12 +54,12 @@ if [ "$CHANNEL" != "" ]; then
   CARGO+=" +$CHANNEL"
 fi
 
-CURRENT_VERSION="$(current_version $NAME)"
-UPSTREAM_VERSION="$(upstream_version $NAME)"
+CURRENT_VERSION=$(current_version "$NAME")
+UPSTREAM_VERSION=$(upstream_version "$NAME")
 
-if [ "$CURRENT_VERSION" != "$UPSTREAM_VERSION" ]; then
+if [[ "$CURRENT_VERSION" != "$UPSTREAM_VERSION" ]]; then
   echo "WARN: Latest version of $NAME not installed: $CURRENT_VERSION -> $UPSTREAM_VERSION"
-  $CARGO install --force $NAME
+  $CARGO install --force "$NAME"
 else
   echo "INFO: Latest version of $NAME already installed ($CURRENT_VERSION)"
 fi