Commit Graph

120 Commits (9640e7a3517f95e59cbf4c9f3fe07900a1d52a20)

Author SHA1 Message Date
Romain 00dac76983 test(exiftool): add tests for batch exiftool streaming 6 years ago
Romain 79dd36f77b test(core): add unit tests for the relationship/action mapping, e.g. “photo:large” 6 years ago
Romain 832673f322 refactor(tests): integration tests as part of the Mocha suite
Some benefits:
- no need to check-in a full website to compare against
- targeted asserts, instead of a “should be 100% the same”
- more robust against cosmetic theme changes
- allows for testing more edge cases in the future
- can’t forget to run the integration tests since they’re part of “npm test”
6 years ago
Romain 7dd714c957 refactor(tests): dynamically generate test folders to check more edge cases 6 years ago
Romain fb4c4fb89f test(all): add unit tests for Album and Problem 6 years ago
Romain 6d94b6339f chore(tests): handle rejected promises during tests 6 years ago
Romain 3fd0ee9ba3 chore(tests): capture all logs during the tests so they don’t pollute the output + can be asserted on 6 years ago
Romain 3fa8867757 test(all): add unit tests for theme + cleanup logic 6 years ago
Romain 72a23807f1 chore(build): require all source files in the tests so the coverage report shows untested files 6 years ago
Felix Eckhofer 81a85004c2 Fix behavior for non-traversable directories (#108)
fix(index): Continue on errors during find

This ensures the gallery is created even when some files are
inaccessible (for example due to invalid names or file permissions).

Requires running the test in Docker as non-root to allow file access test
6 years ago
Romain bd86ab6535 test(themes): add integration tests using a mock file system
This replaces the basic unit tests that used private methods
and didn’t have a very clear intent
6 years ago
Romain deee049650 refactor(themes): extract the {{relative}} helper to be standalone + add some tests 6 years ago
Romain be0ee25c64 test(index): don’t run the invalid filename test on macOS 6 years ago
Felix Eckhofer 124d1857b1 test(index): Add test for invalid filename behavior 6 years ago
Romain 899a89e516 test(mapper): fix unit test that relied on a folder called “tmp” to already exist 6 years ago
Romain e9beb830a2 feat(core): skip files that can’t be processed + show a summary at the end
Thumbsup used to stop at the first problem processing a file.
This was a problem on large galleries where you’d need to run it again and again, fixing files as you went.
This change:
- skips problematic files and shows a summary at the end
- logs all warnings/errors to <thumbsup.log> when running the default output

Also refactor and cleanup of the logging logic.
6 years ago
Romain 7208642d95 test(all): increase unit test coverage 6 years ago
Romain 8bbe1186c5 fix(core): custom album mappers using file:// can use a relative path 6 years ago
Romain 0adef54dc8 feat(core): add support for static and animated GIFs
GraphicsMagick can’t process animated GIFs well unless all frames are coalesced, which creates very large files.
This means there is a new dependency on Gifsicle which is very good at working with animated GIFs.

- Thumbnails are still processed through GraphicsMagick (more options, e.g. centre-crop)
- Large previews of animated GIFs go through Gifsicle

The startup checks are updated to check for the Gifsicle binary.

Fixes #96.
6 years ago
Romain e1517d2fbd feat(core): when building thumbnails, fallback to JPG if the source is not a browser-friendly format
If the source is browser-friendly (jpg, jpeg, png) then keep the exact original extension.
6 years ago
Romain 03a9c9a319 refactor: themes are now standalone folders, to prepare for external loading
Every theme is made of { Handlebars + Less + Partials + Helpers + Public }
6 years ago
Romain 3c946621ec feat(core): new --gm-args flag to pass additional options to GraphicsMagick
Example: thumbsup --gm-args ‘modulate 120’ --gm-args ‘equalize’
Closes #89.
6 years ago
Romain dd282f92d4 chore(dependencies): update all dependencies to the latest version 6 years ago
klemens 424d2c8b8b spelling fixes 6 years ago
Romain 03c3b38e82 fix(model): ignore the EXIF date if it’s not valid e.g. 0000:00:00
Closes #94
6 years ago
Romain e5f6df3d28 refactor(cli): deprecated options logic now handled in <options> module 7 years ago
Romain 286dc8d15f feat(albums): --albums-from can be a list of patterns with special keywords
- %path expands to the path of the photo/video
- %keywords expands to the IPTC keywords of the photo
- {format} expands to the photo's EXIF date, e.g. {YYYY MM}
7 years ago
Romain 23f19566d0 test(cli): add unit tests for options parsing, especially custom logic on top of yargs 7 years ago
Romain fce8d8d8af refactor(model): album mappers can also return '/' to mean the root album 7 years ago
Romain 81ee517062 feat(index): ignore files in a root #recycle folder (Synology recycle bin) 7 years ago
Romain 91528ad076 test(index): cleanup thumbsup.db between test runs, otherwise the test does nothing 7 years ago
Romain d0bbf94b1c fix(index): don’t crash when trying to parse exiftool output for a badly encoded file 7 years ago
Romain 3152361e65 Fix #83: handle IPTC keywords returned as string or array 7 years ago
Romain f66208e052 New options for the {{date}} helper: custom date format + how long ago 7 years ago
Romain 515ce3e8c1 Fix bug in #compare and #times Handlebars templates introduced in 3e0982e
When declared with () => instead of function (), the context is missing from child blocks.
7 years ago
Romain 3e098e2328 Extract Handlebars helpers to prepare for theme structure + add unit tests 7 years ago
Romain 2a0a8d6631 Upgrade mock-fs to support Node 8 (includes dynamic require workaround) 7 years ago
Romain cbf8a1f3b4 Don’t index media from Synology thumbnail folders (@eaDir) nor folders starting with “.” 7 years ago
Romain ac520d40ad Fix case insensitive glob + add unit tests for globbing 7 years ago
Romain 24b2f9bd7c Major optimisations: SQLite index + faster disk glob + new exiftool streaming
1. Move from a JSON index to a SQLite database.
  - This allows the indexing to be interrupted & resumed
  - Updating the index consumes less RAM than loading / saving an entire JSON object
  - Loading the index consumes less RAM since it can be streamed, only exacting the properties we need every time (instead of loading all EXIF data in memory, only to discard most of it later)
  - These make a big difference when processing 10,000+ photos

2. Switch from <glob> to a manual <readdir>
  - Glob would take several hundred or GB of RAM when asked to find several thousand files
  - Manual approach with <micromatch> library does the same thing in a fraction of the time / memory usage

3. Exiftool optimisations
  - Run 1 exiftool process per CPU, still in batch mode (divide all files to be read into 1 bucket per CPU)
  - Stream the exiftool output instead of buffering it in memory
7 years ago
Romain b92724472e Fix #71: read both Quicktime CreationDate and CreateDate 7 years ago
Romain 0b27d37881 Read metadata from Picasa.ini if present 7 years ago
Romain 3e64d2ab38 Create a Metadata model attached to input files
- for easier unit testing
- to enable input filtering (e.g. only include photos with this keyword)
7 years ago
Romain d24c5110cc Fix #70: files in the root of the source folder get added to the root gallery (index.html)
Before, they were added to an album called “.” which didn’t look good,
and the corresponding “.html” file (no base name) caused issues on web servers
7 years ago
Romain dc40fbac09 Fix inferring data from the filename: was getting confused if the folder contained digits 7 years ago
Romain 80f7a88c35 Fix #61: new options to avoid copying original photos to the output folder 7 years ago
Romain 3531f1e533 Try to infer dates from the filename if there is no "date" metadata 7 years ago
Romain a7ad8dc9fc Fix reading the original creation date of QuickTime and H264 movies 7 years ago
Romain 39ee2adf05 Read XMP ratings 7 years ago
Romain 449ee0b180 Read the caption from all standard EXIF/IPTC/XMP tags (issue #24) 7 years ago
Romain 7e73e6a10b Refactor album mapping code to be much simpler based on (media) => string 7 years ago
Romain 59b9bdbbd2 Use <standard> for code style, which removed lots of unused variables/requires 7 years ago
Romain e71e5d4207 Replace custom "make" DSL with the output task list (#60) 7 years ago
Romain e719bf15b1 Single source of truth for input/outputs + view model for display (#58) 7 years ago
Romain d3781b8fcf Fix parsing of MIME Type into Media type (image/video)
This fixes download links, and being able to right-click on a video and save-as
7 years ago
Romain 3a01c678eb Support for IPTC captions 7 years ago
Romain 8dccb88f25 Use [exiftool-json-db] to maintain the JSON database of media files 7 years ago
Romain e36464a76a New --albums-output-folder option to write all albums to a subfolder (cleaner output)
The main changes are
- this introduces relative paths, since some HTML files have to go ".." to get to public/media
- it also introduces the difference between album.path (OS dependent) and album.url (forward slashes)
8 years ago
Romain e930af7f49 Add GIF support, fixes #22.
One major change here is that thumbnails will always be generated as ".jpg".
This is potentially a breaking change, in the sense that all "png" or "jpeg" thumbnails
would be to re-calculated and re-uploaded.
8 years ago
Romain 4209466c14 More unit tests for the Album model (tests split into 2 files for legibility) 8 years ago
Romain 6772e9c9d9 Fix final options for nested albums, not being passed recursively 8 years ago
Romain f235675f86 Don't concatenate the root album name to be 100% compatible with existing version for flat albums 8 years ago
Romain 0208babae1 Pick 10 previews per album, to make the mosaic theme work 8 years ago
Romain b10e7ca6c9 Unit tests for album constructor + sorting 8 years ago
Romain 93ffff1e90 Move album.previews() test one level up 8 years ago
Romain fd9bf181fd Extract model from website generation 8 years ago
Romain Prieto 72fd69bb79 by-date generator supports nested albums + custom album title format 8 years ago
Romain Prieto f69d2e3d48 Add support for nested folders 8 years ago
Romain Prieto 9c0071c00d Work in progress: support multiple themes 8 years ago
Romain Prieto c2f290bbd6 thumbsup v2: rewrite the website around 'albums' 8 years ago