From 9a2da3e5eadf54ae1731c884fcd299f18fc6f3fe Mon Sep 17 00:00:00 2001 From: Romain Date: Fri, 24 Nov 2017 22:35:22 +1100 Subject: [PATCH] Temporarily remove the recursive nav from the Classic theme - The recursive call within Handlebars was causing huge memory spikes - It seems it deep cloned (?) the entire Album objects at every recursive call - This itself could bloat to several hundred megs of RAM for very large galleries Replacing it with a simple breadcrumbs navigation for now. --- templates/themes/classic/nav.hbs | 10 ---------- templates/themes/classic/theme.hbs | 12 ++++++++---- templates/themes/classic/theme.less | 4 +++- 3 files changed, 11 insertions(+), 15 deletions(-) delete mode 100644 templates/themes/classic/nav.hbs diff --git a/templates/themes/classic/nav.hbs b/templates/themes/classic/nav.hbs deleted file mode 100644 index e075754..0000000 --- a/templates/themes/classic/nav.hbs +++ /dev/null @@ -1,10 +0,0 @@ -{{#compare id '==' @root.album.id}} -
  • -{{else}} -
  • -{{/compare}} - - {{title}} - -
  • -{{#each albums}}{{> nav}}{{/each}} diff --git a/templates/themes/classic/theme.hbs b/templates/themes/classic/theme.hbs index 7e4d361..509a174 100644 --- a/templates/themes/classic/theme.hbs +++ b/templates/themes/classic/theme.hbs @@ -5,11 +5,15 @@ + {{#compare album.depth '!=' 0}} -