4822516d72
Remove redundant parameter type declaration
2 years ago
e699244291
Support Azure tokens from managed identities not associated with a VM
2 years ago
15b1049f19
Fix json tag for Azure.ObjectIDs.
2 years ago
6f46cdb432
Merge pull request #829 from vijayjt/new-azure-token-authz-options
...
Add subscription and object ID validation options to Azure provisioner
2 years ago
a79d4af19b
change return value of generateProvisionerConfig to value
...
- always used as value (rather than pointer)
2 years ago
6030f8bc2e
Validate provisioner configuration before storing in DB
2 years ago
b128e37090
Add SubscriptionIDs and ObjectIDs to provisioner-linkedca conversion functions
2 years ago
4a10f2c584
Rename new fields as per feedback to remove AAD from the name
2 years ago
8b68bedffa
Add support for validation of certificate requests using Azure subscription and AAD object IDs. See #735
2 years ago
c3c6f3da72
Merge branch 'master' into herman/allow-deny
2 years ago
abe951d416
Fix name of the variable in comment.
2 years ago
a0cf808393
Make the X5C leaf certificate available to the templates.
...
X509 and SSH templates of the X5C provisioner will have now access
to the leaf certificate used to sign the token using the template
variable .AuthorizationCrt
Fixes #433
2 years ago
c0525381eb
Merge branch 'master' into feat/vault
2 years ago
4ebf43c011
Merge pull request #820 from smallstep/herman/acme-api
...
Refactor ACME Admin API
2 years ago
5b713a564c
Change CM link
2 years ago
5cb23c6029
Merge pull request #804 from smallstep/herman/normalize-ipv6-dns-names
...
Normalize IPv6 hostname addresses
2 years ago
d00729df0b
Refactor ACME Admin API
2 years ago
62690ab52e
Fix linting errors and pin linter version in release action
2 years ago
d384b534c7
Merge pull request #814 from smallstep/x509-enforcer
...
Authority enforcer option
2 years ago
bfa2245abb
Merge branch 'master' into herman/normalize-ipv6-dns-names
2 years ago
e887ccaa07
Ensure the CA TLS certificate represents IPv6 DNS names as IP in cert
...
If an IPv6 domain name (i.e. [::1]) is provided manually in the `ca.json`,
this commit will ensure that it's represented as an IP SAN in the TLS
certificate. Before this change, the IPv6 would become a DNS SAN.
2 years ago
300c19f8b9
Add a custom enforcer that can be used to modify a cert.
2 years ago
88c7b63c9d
Split SSH user and cert policy configuration and execution
2 years ago
acd13cb92d
Merge branch 'master' of github.com:smallstep/certificates into herman/allow-deny
2 years ago
c1424036bf
Merge branch 'master' into herman/allow-deny
2 years ago
c7c5c3c94e
Merge branch 'master' into herman/scep-macos-renewal-fixes
2 years ago
9617edf0c2
Improve internationalized domain name handling
...
This PR improves internationalized domain name handling according
to rules of IDNA and based on the description in RFC 5280, section 7:
https://datatracker.ietf.org/doc/html/rfc5280#section-7 .
Support for internationalized URI(s), so-called IRIs, still needs to
be done.
2 years ago
512b8d6730
Refactor instantiation of policy engines
...
Instead of using the `base` struct, the x509 and SSH policy
engines are now added to each provisioner directly.
2 years ago
066bf32086
Fix part of PR comments
2 years ago
fd9845e9c7
Add cursor and limit to ACME EAB DB interface
2 years ago
3b72d241e0
Add LinkedCA integration for improved SCEP provisioner
2 years ago
868cc4ad7f
Increase test coverage for additional indexes
2 years ago
8838961b68
Merge branch 'master' into hs/acme-eab
2 years ago
716b946e7a
Normalize IPv6 hostname addresses
2 years ago
64680bb16d
Fix PR comments
2 years ago
3612eefc31
Cleanup
2 years ago
6440870a80
Clean up, improve test cases and coverage
2 years ago
1e808b61e5
Merge logic for X509 and SSH policy
2 years ago
6bc301339f
Improve test case and code coverage
2 years ago
91d51c2b88
Add allow/deny to Nebula provisioner
2 years ago
d9c56d67cc
Merge branch 'master' into herman/allow-deny
2 years ago
9c6580ccd2
Fix macOS SCEP client issues
...
Fixes #746
2 years ago
68b980d689
feat(authority): avoid hardcoded cn in authority csr
2 years ago
988efc8cd4
Merge pull request #792 from smallstep/herman/improve-template-errors
...
Improve errors related to template execution failures
2 years ago
50c3bce98d
Change if/if to if/else-if when checking the type of JSON error
2 years ago
4afcdd55ff
Update doc line on WithSSHGetHosts
2 years ago
a3cf6bac36
Add special handling for *json.UnmarshalTypeError
2 years ago
0475a4d26f
Refactor extraction of JSON template syntax errors
2 years ago
a5455d3572
Improve errors related to template execution failures (slightly)
3 years ago
de549adf2d
Do not add extra new lines when creating nebula provisioners
3 years ago
0920224816
Fix error message.
3 years ago
ef16febf40
Refactor ACME EAB queries
...
The ACME EAB keys are now also indexed by the provisioner. This
solves part of the issue in which too many EAB keys may be in
memory at a given time.
3 years ago
449a9fdfd6
Address review comments.
3 years ago
b424aa3dc1
Add nebula header and use der version of certificate.
3 years ago
30859d3c83
Remove server-side paging logic for ExternalAccountKeys
3 years ago
f49a4b326f
Add missing comments.
3 years ago
6600f1253e
Fix error messages after review.
3 years ago
6a1d0cb9f8
Add linkedca conversions.
3 years ago
de51c2edfb
More unit tests for nebula.
3 years ago
99845d38bb
Add some extra unit tests for nebula.
3 years ago
76794ce613
Use default SANs without sans in the token.
...
Fix step claim condition in SSH
3 years ago
6bc0513468
Add more tests
3 years ago
9ec0276887
Update certificate set with new api.
3 years ago
9539729bd9
Add initial implementation of x509 and SSH allow/deny policy engine
3 years ago
cb72796a2d
Fix decoding of certificate.
3 years ago
32390a2964
Add initial implementation of a nebula provisioner.
...
A nebula provisioner will generate a X509 or SSH certificate with
the identities in the nebula certificate embedded in the token.
The token is signed with the private key of the nebula certificate.
3 years ago
5fe9909174
Refactor AdminAuthority interface
3 years ago
f9ae875f9d
Use short if-style statements
3 years ago
5f224b729e
Add tests for Provisioner Admin API
3 years ago
43a78f495f
Add tests for Admin API
3 years ago
bd169f505f
Add Admin API Middleware tests
3 years ago
d799359917
Merge branch 'master' into hs/acme-eab
3 years ago
63371a8fb6
Add additional tests for ACME EAB Admin
3 years ago
3bc3957b06
Merge branch 'master' into hs/acme-revocation
3 years ago
2215a05c28
Add tests for ACME EAB Admin
...
Refactored some of the existing bits for testing the Authority
API by creation of a new LinkedAuthority interface and changing
visibility of the MockAuthority to be usable by other packages.
At this time, not all of the functions of MockAuthority it usable
yet. Will refactor when needed or requested.
3 years ago
d0c23973cc
Merge branch 'master' into hs/acme-eab
3 years ago
e0fee84694
Add comment about public key validator.
3 years ago
47a8a3c463
Add test case for ACME Revoke to Authority
3 years ago
a7fbbc4748
Add tests for GetCertificateBySerial
3 years ago
2d357da99b
Add tests for ACME revocation
3 years ago
c9cd876a7d
Merge branch 'master' into hs/acme-revocation
3 years ago
d35848f7a9
Fix unit tests.
3 years ago
c3f98fd04d
Change some bad requests to forbidded.
...
Change in the sign options bad requests to forbidded if is the
provisioner the one adding a restriction, e.g. list of dns names,
validity, ...
3 years ago
ff04873a2a
Change the default error type to forbidden in Sign.
...
The errors will also be propagated from sign options.
3 years ago
b9beab071d
Fix unit tests.
3 years ago
507a272b4d
Return always http errors in sign options.
3 years ago
a33709ce8d
Fix sign ssh options tests.
3 years ago
1da7ea6646
Return always http errors in sign ssh options.
3 years ago
031d4d7000
Return BadRequest when validating sign options.
3 years ago
bb26799583
Modify errs.Wrap with forbidden errors.
3 years ago
2d50c96d99
Merge branch 'master' into hs/acme-revocation
3 years ago
b6ebd118fc
Update temporal solution for sending message to users
3 years ago
668d3ea6c7
Modify errs.Wrap() with bad request to send messages to users.
3 years ago
8c8db0d4b7
Modify errs.BadRequestErr() to always return an error to the client.
3 years ago
8ce807a6cb
Modify errs.BadRequest() calls to always send an error to the client.
3 years ago
de2ce5cf9f
Merge pull request #692 from smallstep/max/context
...
Context management
3 years ago
440616cffa
Merge pull request #750 from smallstep/duration-errors
...
Report duration errors directly to the cli.
3 years ago
acd0bac025
Remove extra and in comment.
3 years ago
1aadd63cef
Use always badRequest on duration errors.
3 years ago
41fec1577d
Report duration errors directly to the cli.
3 years ago
7fac8c96c3
Merge branch 'master' into max/context
3 years ago
922d239171
Simplify conditional
3 years ago
a7d144996f
SSH backwards compat updates
...
- use existence of new value in data map as boolean
- add tests for backwards and forwards compatibility
- fix old tests that used static dir locations
3 years ago
507be61e8c
Use a more distint map key to indicate template version
...
- make the key a variable that can be reused on the CLI side.
3 years ago
f426c152a9
backwards compatibility for version of cli older than v0.18.0
3 years ago
ed4b56732e
updates after rebase to keep up with master
3 years ago
e7a988b2cd
Pin golangci-lint to v1.43.0 and fix issues
3 years ago
3151255a25
Merge branch 'master' into hs/acme-revocation
3 years ago
4d726d6b4c
Add pagination to ACME EAB credentials endpoint
3 years ago
bc5f0e429b
Fix gocritic remark
3 years ago
d354d55e7f
Improve handling duplicate ACME EAB references
3 years ago
dd4b4b0435
Fix remaining gocritic remarks
3 years ago
e0b495e4c8
Merge branch 'master' into hs/acme-eab
3 years ago
c26041f835
Add ACME EAB nosql tests
3 years ago
933b40a02a
Introduce gocritic linter and address warnings
3 years ago
f34d68897a
Refactor retrieval of provisioner into middleware
3 years ago
9d4cafc4bd
Merge branch 'master' into hs/acme-eab
3 years ago
9fb6df3abb
Fix ssh template variables when CA is injected using options.
3 years ago
aedd7fcc05
Be able to start a SSH host or SSH user only CA
...
In previous versions if the host or user CA is not configured, the
start of step-ca was crashing. This allows to configure a user or
host only ssh ca.
3 years ago
a50654b468
Check for admins in both emails and groups.
3 years ago
2d5bfd3485
fix comment
3 years ago
c2bc1351c6
Add provisioner to remove endpoint and clear reference index on delete
3 years ago
746c5c9fd9
Disallow creation of EAB keys with non-unique references
3 years ago
9c0020352b
Add lookup by reference and make reference optional
3 years ago
02cd3b6b3b
Fix PR comments
3 years ago
6729c79253
Add support for setting individual password for ssh and tls keys
...
This change add the following flags:
* --ssh-host-password-file
* --ssh-user-password-file
Fixes #693
3 years ago
66464ae302
Merge branch 'master' into hs/acme-eab
3 years ago
141c519171
Simplify check of principals in a case insensitive way
...
Fixes #679
3 years ago
7a94b0c157
Converts group and subgroup to lowercase for comparison.
...
Fixes #679
3 years ago
f919535475
Add an extra way to distinguish Azure and Azure OIDC tokens.
...
We used to distinguish these tokens using the azp claim, but this
claim does not appear on new azure oidc tokens, at least on some
configurations.
This change will try to load by audience (client id) if the token
contains an email, required for OIDC.
3 years ago
097a918da7
Fix tests when we create re-use a token with a new authority.
3 years ago
f11c0cdc0c
Add endpoint for listing ACME EAB keys
3 years ago
9d09f5e575
Add support for deleting ACME EAB keys
3 years ago
a98fe03e80
Merge branch 'master' into hs/acme-eab
3 years ago
1dba8698e3
Use LinkedCA.EABKey type in ACME EAB API
3 years ago
40e77f6e9a
Initialize required variables on GetIdentityToken
...
Fixes smallstep/cli#465
3 years ago
42fde8ba28
Merge branch 'master' into linkedca
3 years ago
61b8bfda1a
Fix comment typos.
3 years ago
da2802504b
Use Default min version if not specified.
3 years ago
d4ae267add
Fix ErrAllowTokenReuse comment.
3 years ago
9e5762fe06
Allow the reuse of azure token if DisableTrustOnFirstUse is true
...
Azure caches tokens for 24h and we cannot issue a new certificate
for the same instance in that period of time.
The meaning of this parameter is to allow the signing of multiple
certificate in one instance. This is possible in GCP, because we
get a new token, and is possible in AWS because we can generate
a new one. On Azure there was no other way to do it unless you
wait for 24h.
Fixes #656
3 years ago
492ff4b632
Ask for the first provisioner password if none is provided.
3 years ago
28e882c9b3
Add deployment type to export.
3 years ago
072ba4227c
Add deployment type to config.
...
This field is ignored except for the start of the ca. If the type
is linked and the token is not passed, it will fail with an error.
3 years ago
f31ca4f6a4
Add tests for validateExternalAccountBinding
3 years ago
492256f2d7
Add first test cases for EAB and make provisioner unique per EAB
...
Before this commit, EAB keys could be used CA-wide, meaning that
an EAB credential could be used at any ACME provisioner. This
commit changes that behavior, so that EAB credentials are now
intended to be used with a specific ACME provisioner. I think
that makes sense, because from the perspective of an ACME client
the provisioner is like a distinct CA.
Besides that this commit also includes the first tests for EAB.
The logic for creating the EAB JWS as a client has been taken
from github.com/mholt/acmez. This logic may be moved or otherwise
sourced (i.e. from a vendor) as soon as the step client also
(needs to) support(s) EAB with ACME.
3 years ago
71b3f65df1
Add processing of RequireEAB through Linked CA
3 years ago
536536c92d
Wrap json errors.
3 years ago
9d51c2cceb
Fix linter errors in the name of export methods.
3 years ago
16d3afb92a
Remove unused method.
3 years ago
d72fa953ac
Remove debug statements.
3 years ago
3f07eb597a
Implement revocation using linkedca.
3 years ago
798b90c359
Move linkedca configuration to the main package.
3 years ago
384be6e205
Do not show provisioners if they are not required.
...
For deployment types like linked ca, the list of provisioners in
the ca.json are not required, so we should tag the json as omitempty.
3 years ago
b0e0f2b89d
Use linkedca GetAdmin and GetProvisioner.
3 years ago
91a369f618
Automatically enable admin properly on linked cas.
3 years ago
26122a2cbf
Enable admin automatically if a token is provided.
3 years ago
2620c38aee
Add is converting provisioners to linkedca.
...
The ids are required to be able to link admins with provisioners.
3 years ago
e62d7988b8
Do not store password on exports.
3 years ago
4f27f4b002
Change default ciphersuites to newer names.
3 years ago
07f7316851
Add bastion to export.
3 years ago
0730a165fd
Add collection of files and authority template.
3 years ago
c7f8516142
Add to export all the information in the ca.json
3 years ago
887423ee6e
Update TLS cipher suites.
3 years ago
dc1ec18b52
Create a way to export ca configurations.
3 years ago
3a00b6b396
Properly marshal a certificate when we send it to linkedca.
3 years ago
4ad82a2f76
Check linkedca for revocation.
3 years ago
7dad7038c3
Fix missing ACME EAB API endpoints
3 years ago
c6a4c4ecba
Change ACME EAB endpoint
3 years ago
c6bfc6eac2
Fix PR comments
3 years ago
b65a588d5b
Make authentication work for /admin/eak
3 years ago
f7542a5bd9
Move check of ssh revocation from provisioner to the authority.
3 years ago
71f8019243
Store x509 and ssh certificates on linkedca if enabled.
3 years ago
8fb5340dc9
Use a token at start time to configure linkedca.
...
Instead of using `step-ca login` we will use a new token provided
as a flag to configure and start linkedca. Certificates will be kept
in memory and refreshed automatically.
3 years ago
f81d49d963
Add first working version of External Account Binding
3 years ago
dd9850ce4c
Add working implementation of the linkedca.
...
Replaces the authority adminDB with a new impmentation that users the
linkedca client to retrieve the data.
Note that this implementation still hardcodes the endpoint to localhost.
3 years ago
49c1427d15
Use authorityId instead of authorityID.
...
In json or javascript world authorityId, userId, ... are more common
than authorityID, ...
3 years ago
258efca0fa
Improve revocation authorization
3 years ago
8f7e700f09
Merge branch 'master' into hs/acme-revocation
3 years ago
1df21b9b6a
Addressing comments in PR review
...
- added a bit of validation to admin create and update
- using protojson where possible in admin api
- fixing a few instances of admin -> acme in errors
3 years ago
5679c9933d
Fixes from PR review
3 years ago
77fdfc9fa3
Merge branch 'master' into max/cert-mgr-crud
3 years ago
9fdef64709
Admin level API for provisioner mgmt v1
3 years ago
84e7d468f2
Improve handling of ACME revocation
3 years ago
7e82bd6ef3
Add setup for Authority tests
3 years ago
a64974c179
Fix small typo in divisible
3 years ago
d46a4eaca4
Change fmt to errors package for formatting errors
3 years ago
2beea1aa89
Add configuration option for specifying the minimum public key length
...
Instead of using the defaultPublicKeyValidator a new validator called
publicKeyMinimumLengthValidator has been implemented that uses a
configurable minimum length for public keys in CSRs.
It's also an option to alter the defaultPublicKeyValidator to also
take a parameter, but that would touch quite some lines of code. This
might be a viable option after merging SCEP support.
3 years ago
4168449935
Fix typo
3 years ago
fa100a5138
Mask challenge password after it has been read
3 years ago
13fe7a0121
Make serving SCEP endpoints optional
...
Only when a SCEP provisioner is enabled, the SCEP endpoints
will now be available.
The SCEP endpoints will be served on an "insecure" server,
without TLS, only when an additional "insecureAddress" and a
SCEP provisioner are configured for the CA.
3 years ago
97b88c4d58
Address (most) PR comments
3 years ago
be528da709
Make tests green
3 years ago
57a62964b1
Make tests not fail hard on ECDSA keys
...
All tests for the Authority failed because the test data
contains ECDSA keys. ECDSA keys are no crypto.Decrypter,
resulting in a failure when instantiating the Authority.
3 years ago
491c2b8d93
Improve initialization of SCEP authority
3 years ago
2d85d4c1c1
Add non-TLS server and improve crypto.Decrypter interface
...
A server without TLS was added to serve the SCEP endpoints. According
to the RFC, SCEP has to be served via HTTP. The `sscep` client, for
example, will stop any URL that does not start with `http://` from
being used, so serving SCEP seems to be the right way to do it.
This commit adds a second server for which no TLS configuration is
configured. A distinct field in the configuration, `insecureAddress`
was added to specify the address for the insecure server.
The SCEP endpoints will also still be served via HTTPS. Some clients
may be able to work with that.
This commit also improves how the crypto.Decrypter interface is
handled for the different types of KMSes supported by step. The
apiv1.Decrypter interface was added. Currently only SoftKMS
implements this interface, providing a crypto.Decrypter required
for SCEP operations.
3 years ago
e7cb80f880
Fix linter issues
3 years ago
4fe7179b95
Add support for configuring capabilities (cacaps)
3 years ago
3b86550dbf
Add support for challenge password
3 years ago
da65f46d0f
Add AuthorizeSign method to SCEP authority
3 years ago
vijayjt
Mariano Cano
Mariano Cano
max furman
Herman Slatman
Herman Slatman
Ahmet DEMIR
Fearghal O Floinn