Commit Graph

1065 Commits (da5d2b405c0e0d885ec70b9892ead24218f2daec)

Author SHA1 Message Date
Herman Slatman e9f5a1eb98
Improve policy bad request handling 2 years ago
Herman Slatman b72430f4ea
Block all APIs when using linked deployment mode 2 years ago
Herman Slatman fb81407d6f
Fix ACME policy comments 2 years ago
Herman Slatman a2cfbe3d54
Fix (part of) PR comments 2 years ago
Herman Slatman 3eecc4f7bb
Improve test coverage for reloadPolicyEngines 2 years ago
Herman Slatman 72bbe53376
Add additional policy options 2 years ago
Herman Slatman 9a21208f22
Add deduplication of policy configuration values 2 years ago
Herman Slatman f2f9cb899e
Add conditional defaults to policy protobuf request bodies 2 years ago
Herman Slatman 647538e9e8
Merge branch 'herman/allow-deny' into herman/allow-deny-options 2 years ago
Herman Slatman ad2de16299
Merge branch 'master' into herman/allow-deny 2 years ago
Herman Slatman 7f9034d22a
Add additional policy options 2 years ago
Mariano Cano fe9c3cf753
Merge branch 'master' into ahmet2mir-feat/vault 2 years ago
Herman Slatman def9438ad6
Improve handling of bad JSON protobuf bodies 2 years ago
Herman Slatman 2ca5c0170f
Fix flaky test behavior for protobuf messages 2 years ago
Herman Slatman abcad679ff
Merge branch 'master' into herman/allow-deny 2 years ago
Herman Slatman 8d15a027a7
Fix if-else linting issue 2 years ago
Mariano Cano c066694c0c Allow renew token issuer to be the provisioner name.
For consistency with AuthorizeAdminToken, AuthorizeRenewToken will
allow the issuer to be either the fixed string 'step-ca-client/1.0'
or the provisioner name.
2 years ago
Herman Slatman 99702d3648
Fix case of no authority policy existing 2 years ago
Herman Slatman d6be9450be
Merge branch 'master' into herman/allow-deny 2 years ago
Herman Slatman 30d5d89a13
Improve test coverage for Policy Admin API 2 years ago
Mariano Cano d3b6bc3c75 Merge branch 'master' into fix/adminra 2 years ago
Mariano Cano ad5aedfa60 Fix backward compatibility in AuthorizeAdminToken
This commit validates both new and old issuers.
2 years ago
Mariano Cano 5f714f2485 Fix tests for AuthorizeRenewToken 2 years ago
Mariano Cano 674dc3c844 Rename unreleased claim to allowRenewalAfterExpiry for consistency. 2 years ago
Mariano Cano 4e4d4e882f Use a fixed string for renewal token issuer. 2 years ago
Mariano Cano 0a5dc237df Fix typo in comment. 2 years ago
Mariano Cano 00cd0f5f21
Apply suggestions from code review
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
2 years ago
Mariano Cano ea5f7f2acc
Fix SANs for step-ca certificate
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
2 years ago
Mariano Cano 37b521ec6c
Merge branch 'master' into feat/vault 2 years ago
Mariano Cano c8c59d68f5 Allow mTLS renewals if the provisioner extension does not exists.
This fixes a backward compatibility issue with with the new
LoadProvisionerByCertificate.
2 years ago
Herman Slatman 256fe113f7
Improve tests for ACME account policy 2 years ago
Panagiotis Siatras f2cf9cf828
authority/status: removed the package (#892) 2 years ago
Mariano Cano af8fcf5b01 Use always LoadProvisionerByCertificate on authority package 2 years ago
Mariano Cano 1d1e095447 Add tests for LoadProvisionerByCertificate. 2 years ago
Herman Slatman 0bb15e16f9
Fix missing ACME provisioner option 2 years ago
Herman Slatman 9797b3350e
Merge branch 'master' into herman/allow-deny 2 years ago
Mariano Cano dfdc9c06ed Fix linter error importShadow 2 years ago
Mariano Cano 8abd568f03 Merge branch 'master' into fix/adminra 2 years ago
Mariano Cano b7e11da480 Merge branch 'master' into feat/linkedra 2 years ago
Mariano Cano c55b27a2fc Refactor admin token to use with RAs. 2 years ago
Herman Slatman 034b7943fe
Merge branch 'master' into herman/allow-deny 2 years ago
Herman Slatman 7df52dbb76
Add ACME EAB policy 2 years ago
Mariano Cano db337debcd Load provisioner from the database instead of the extension. 2 years ago
Mariano Cano df8ffb35af Remove unnecessary database in provisioner config. 2 years ago
Carl Tashian 150eee70df Updates based on Herman's feedback 2 years ago
Carl Tashian 4b9f44982d Merge branch 'master' into startup-info 2 years ago
Carl Tashian 43f2c655b9 More info on startup 2 years ago
Herman Slatman 679e2945f2
Disallow name constraint wildcard notation 2 years ago
Herman Slatman 96f4c49b0c
Improve how policy errors are returned and used 2 years ago
Herman Slatman d8776d8f7f
Add K8sSA SSH user policy back
According to the docs, the K8sSA provisioner can be configured
to issue SSH user certs.
2 years ago
Herman Slatman 571b21abbc
Fix (most) PR comments 2 years ago
Carl Tashian 1ba1584c7a Formatted. 2 years ago
Carl Tashian a13e58e340 Update GetAuthorityInfo -> GetInfo 2 years ago
Carl Tashian 90cb6315b1 Progress. 2 years ago
Carl Tashian 055e75f394 Progress? 2 years ago
Herman Slatman bfa4d809fd
Improve middleware test coverage 2 years ago
Herman Slatman 6da243c34d
Add policy precheck for all admins 2 years ago
Herman Slatman 628d7448de
Don't return policy in provisioner JSON 2 years ago
Herman Slatman 2fbdf7d5b0
Merge branch 'master' into herman/allow-deny 2 years ago
Herman Slatman 0e052fe299
Add authority policy API 2 years ago
Panagiotis Siatras 00634fb648
api/render, api/log: initial implementation of the packages (#860)
* api/render: initial implementation of the package

* acme/api: refactored to support api/render

* authority/admin: refactored to support api/render

* ca: refactored to support api/render

* api: refactored to support api/render

* api/render: implemented Error

* api: refactored to support api/render.Error

* acme/api: refactored to support api/render.Error

* authority/admin: refactored to support api/render.Error

* ca: refactored to support api/render.Error

* ca: fixed broken tests

* api/render, api/log: moved error logging to this package

* acme: refactored Error so that it implements render.RenderableError

* authority/admin: refactored Error so that it implements render.RenderableError

* api/render: implemented RenderableError

* api/render: added test coverage for Error

* api/render: implemented statusCodeFromError

* api: refactored RootsPEM to work with render.Error

* acme, authority/admin: fixed pointer receiver name for consistency

* api/render, errs: moved StatusCoder & StackTracer to the render package
2 years ago
Mariano Cano 955d4cf80d Add authority.WithX509SignerFunc
This change adds a new authority option that allows to pass a callback
that returns the certificate chain and signer used to sign X.509
certificates.

This option will be used by Caddy, they renew the intermediate
certificate weekly and there's no other way to replace it without
re-creating the embedded CA.

Fixes #874
2 years ago
Mariano Cano 6851842841 Fix unit tests. 2 years ago
Mariano Cano 580a9c1476 Get linked RA configuration using the linked ca client. 2 years ago
vijayjt 37207793f9 Pass in the resource name regardless of if its a VM or managed identity 2 years ago
vijayjt 7e47c70af2 Remove redundant parameter type declaration 2 years ago
vijayjt 7b605b2d16 Support Azure tokens from managed identities not associated with a VM 2 years ago
Mariano Cano 5ab79f53be Fix linter errors 2 years ago
Herman Slatman b49307f326
Fix ACME order tests with mock ACME CA 2 years ago
Herman Slatman 9e0edc7b50
Add early authority policy evaluation to ACME order API 2 years ago
Herman Slatman 613c99f00f
Fix linting issues 2 years ago
Herman Slatman dc23fd23bf
Merge branch 'master' into herman/allow-deny-next 2 years ago
Herman Slatman 6b620c8e9c
Improve protobuf unmarshaling error handling 2 years ago
Mariano Cano 082734474b
Merge pull request #845 from vijayjt/azure-user-mi-token
WIP: Support Azure tokens generated by managed identities
2 years ago
Carl Tashian 25cc9a1728
Update authority/authority.go
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
2 years ago
Mariano Cano 9d027c17d0 Send current provisioner on PostCertificate 2 years ago
Mariano Cano b401376829 Add current provisioner to AuthorizeSign SignOptions.
The original provisioner cannot be retrieved from a certificate
if a linked ra is used.
2 years ago
vijayjt 24a963766e Pass in the resource name regardless of if its a VM or managed identity 2 years ago
Carl Tashian baf3c40fef Print some basic configuration info on startup 2 years ago
Mariano Cano ad8a813abe Fix linter errors 2 years ago
Herman Slatman 101ca6a2d3
Check admin subjects before changing policy 2 years ago
Panagiotis Siatras 4fb38afc57
authority/admin/api: refactored to use the read package 2 years ago
Herman Slatman 81b0c6c37c
Add API implementation for authority and provisioner policy 2 years ago
Mariano Cano 6d532045dc Fix validity check for sshpop provisioner. 2 years ago
Mariano Cano c903f00cd4 Rename claim to allowRenewAfterExpiry. 2 years ago
Mariano Cano 4690fa64ed Add public methods to retrieve the provisioner extensions. 2 years ago
Mariano Cano 616490a9c6 Refactor renew after expiry token authorization
This changes adds a new authority method that authorizes the
renew after expiry tokens.
2 years ago
Mariano Cano 79349b4d7c Add options to use custom renewal methods. 2 years ago
Mariano Cano 389815642d Fix tests: certs are truncated to seconds. 2 years ago
Mariano Cano 8ef8f4f665 Use the provisioner controller in Nebula renewals 2 years ago
Mariano Cano 259e95947c Add support for the provisioner controller
The claimer, audiences and custom callback methods are now managed
by the provisioner controller in an uniform way.
2 years ago
Mariano Cano 3c2ff33ca9 Add provisioner controller tests. 2 years ago
Mariano Cano fd6a2eeb9c Add provisioner controller
The provisioner controller has the implementation of the identity
function as well as the renew methods with renew after expiry
support.
2 years ago
Herman Slatman 3ec9a7310c
Fix ACME order identifier allow/deny check 2 years ago
Herman Slatman 7c541888ad
Refactor configuration of allow/deny on authority level 2 years ago
Herman Slatman af53a17bb4
Merge branch 'master' into herman/allow-deny 2 years ago
vijayjt 4822516d72 Remove redundant parameter type declaration 2 years ago
vijayjt e699244291 Support Azure tokens from managed identities not associated with a VM 2 years ago
Mariano Cano 15b1049f19 Fix json tag for Azure.ObjectIDs. 2 years ago
Mariano Cano 6f46cdb432
Merge pull request #829 from vijayjt/new-azure-token-authz-options
Add subscription and object ID validation options to Azure provisioner
2 years ago
max furman a79d4af19b change return value of generateProvisionerConfig to value
- always used as value (rather than pointer)
2 years ago
max furman 6030f8bc2e Validate provisioner configuration before storing in DB 2 years ago
vijayjt b128e37090 Add SubscriptionIDs and ObjectIDs to provisioner-linkedca conversion functions 2 years ago
vijayjt 4a10f2c584 Rename new fields as per feedback to remove AAD from the name 2 years ago
vijayjt 8b68bedffa Add support for validation of certificate requests using Azure subscription and AAD object IDs. See #735 2 years ago
Herman Slatman c3c6f3da72
Merge branch 'master' into herman/allow-deny 2 years ago
Mariano Cano abe951d416 Fix name of the variable in comment. 2 years ago
Mariano Cano a0cf808393 Make the X5C leaf certificate available to the templates.
X509 and SSH templates of the X5C provisioner will have now access
to the leaf certificate used to sign the token using the template
variable .AuthorizationCrt

Fixes #433
2 years ago
Mariano Cano c0525381eb Merge branch 'master' into feat/vault 2 years ago
Herman Slatman 4ebf43c011
Merge pull request #820 from smallstep/herman/acme-api
Refactor ACME Admin API
2 years ago
Herman Slatman 5b713a564c
Change CM link 2 years ago
Herman Slatman 5cb23c6029
Merge pull request #804 from smallstep/herman/normalize-ipv6-dns-names
Normalize IPv6 hostname addresses
2 years ago
Herman Slatman d00729df0b
Refactor ACME Admin API 2 years ago
max furman 62690ab52e Fix linting errors and pin linter version in release action 2 years ago
Mariano Cano d384b534c7
Merge pull request #814 from smallstep/x509-enforcer
Authority enforcer option
2 years ago
Herman Slatman bfa2245abb
Merge branch 'master' into herman/normalize-ipv6-dns-names 2 years ago
Herman Slatman e887ccaa07
Ensure the CA TLS certificate represents IPv6 DNS names as IP in cert
If an IPv6 domain name (i.e. [::1]) is provided manually in the `ca.json`,
this commit will ensure that it's represented as an IP SAN in the TLS
certificate. Before this change, the IPv6 would become a DNS SAN.
2 years ago
Mariano Cano 300c19f8b9 Add a custom enforcer that can be used to modify a cert. 2 years ago
Herman Slatman 88c7b63c9d
Split SSH user and cert policy configuration and execution 2 years ago
Herman Slatman acd13cb92d
Merge branch 'master' of github.com:smallstep/certificates into herman/allow-deny 2 years ago
Herman Slatman c1424036bf
Merge branch 'master' into herman/allow-deny 2 years ago
Herman Slatman c7c5c3c94e
Merge branch 'master' into herman/scep-macos-renewal-fixes 2 years ago
Herman Slatman 9617edf0c2
Improve internationalized domain name handling
This PR improves internationalized domain name handling according
to rules of IDNA and based on the description in RFC 5280, section 7:
https://datatracker.ietf.org/doc/html/rfc5280#section-7.

Support for internationalized URI(s), so-called IRIs, still needs to
be done.
2 years ago
Herman Slatman 512b8d6730
Refactor instantiation of policy engines
Instead of using the `base` struct, the x509 and SSH policy
engines are now added to each provisioner directly.
2 years ago
Herman Slatman 066bf32086
Fix part of PR comments 2 years ago
Herman Slatman fd9845e9c7
Add cursor and limit to ACME EAB DB interface 2 years ago
Herman Slatman 3b72d241e0
Add LinkedCA integration for improved SCEP provisioner 3 years ago
Herman Slatman 868cc4ad7f
Increase test coverage for additional indexes 3 years ago
Herman Slatman 8838961b68
Merge branch 'master' into hs/acme-eab 3 years ago
Herman Slatman 716b946e7a
Normalize IPv6 hostname addresses 3 years ago
Herman Slatman 64680bb16d
Fix PR comments 3 years ago
Herman Slatman 3612eefc31
Cleanup 3 years ago
Herman Slatman 6440870a80
Clean up, improve test cases and coverage 3 years ago
Herman Slatman 1e808b61e5
Merge logic for X509 and SSH policy 3 years ago
Herman Slatman 6bc301339f
Improve test case and code coverage 3 years ago
Herman Slatman 91d51c2b88
Add allow/deny to Nebula provisioner 3 years ago
Herman Slatman d9c56d67cc
Merge branch 'master' into herman/allow-deny 3 years ago
Herman Slatman 9c6580ccd2
Fix macOS SCEP client issues
Fixes #746
3 years ago
Ahmet DEMIR 68b980d689
feat(authority): avoid hardcoded cn in authority csr 3 years ago
Herman Slatman 988efc8cd4
Merge pull request #792 from smallstep/herman/improve-template-errors
Improve errors related to template execution failures
3 years ago
Herman Slatman 50c3bce98d
Change if/if to if/else-if when checking the type of JSON error 3 years ago
max furman 4afcdd55ff Update doc line on WithSSHGetHosts 3 years ago
Herman Slatman a3cf6bac36
Add special handling for *json.UnmarshalTypeError 3 years ago
Herman Slatman 0475a4d26f
Refactor extraction of JSON template syntax errors 3 years ago
Herman Slatman a5455d3572
Improve errors related to template execution failures (slightly) 3 years ago
Mariano Cano de549adf2d Do not add extra new lines when creating nebula provisioners 3 years ago
Mariano Cano 0920224816 Fix error message. 3 years ago
Herman Slatman ef16febf40
Refactor ACME EAB queries
The ACME EAB keys are now also indexed by the provisioner. This
solves part of the issue in which too many EAB keys may be in
memory at a given time.
3 years ago
Mariano Cano 449a9fdfd6 Address review comments. 3 years ago
Mariano Cano b424aa3dc1 Add nebula header and use der version of certificate. 3 years ago
Herman Slatman 30859d3c83
Remove server-side paging logic for ExternalAccountKeys 3 years ago
Mariano Cano f49a4b326f Add missing comments. 3 years ago
Mariano Cano 6600f1253e Fix error messages after review. 3 years ago
Mariano Cano 6a1d0cb9f8 Add linkedca conversions. 3 years ago
Mariano Cano de51c2edfb More unit tests for nebula. 3 years ago
Mariano Cano 99845d38bb Add some extra unit tests for nebula. 3 years ago
Mariano Cano 76794ce613 Use default SANs without sans in the token.
Fix step claim condition in SSH
3 years ago
Herman Slatman 6bc0513468
Add more tests 3 years ago
Mariano Cano 9ec0276887 Update certificate set with new api. 3 years ago
Herman Slatman 9539729bd9
Add initial implementation of x509 and SSH allow/deny policy engine 3 years ago
Mariano Cano cb72796a2d Fix decoding of certificate. 3 years ago
Mariano Cano 32390a2964 Add initial implementation of a nebula provisioner.
A nebula provisioner will generate a X509 or SSH certificate with
the identities in the nebula certificate embedded in the token.
The token is signed with the private key of the nebula certificate.
3 years ago
Herman Slatman 5fe9909174
Refactor AdminAuthority interface 3 years ago
Herman Slatman f9ae875f9d
Use short if-style statements 3 years ago
Herman Slatman 5f224b729e
Add tests for Provisioner Admin API 3 years ago
Herman Slatman 43a78f495f
Add tests for Admin API 3 years ago
Herman Slatman bd169f505f
Add Admin API Middleware tests 3 years ago
Herman Slatman d799359917
Merge branch 'master' into hs/acme-eab 3 years ago
Herman Slatman 63371a8fb6
Add additional tests for ACME EAB Admin 3 years ago
Herman Slatman 3bc3957b06
Merge branch 'master' into hs/acme-revocation 3 years ago
Herman Slatman 2215a05c28
Add tests for ACME EAB Admin
Refactored some of the existing bits for testing the Authority
API by creation of a new LinkedAuthority interface and changing
visibility of the MockAuthority to be usable by other packages.

At this time, not all of the functions of MockAuthority it usable
yet. Will refactor when needed or requested.
3 years ago
Herman Slatman d0c23973cc
Merge branch 'master' into hs/acme-eab 3 years ago
Mariano Cano e0fee84694 Add comment about public key validator. 3 years ago
Herman Slatman 47a8a3c463
Add test case for ACME Revoke to Authority 3 years ago
Herman Slatman a7fbbc4748
Add tests for GetCertificateBySerial 3 years ago
Herman Slatman 2d357da99b
Add tests for ACME revocation 3 years ago
Herman Slatman c9cd876a7d
Merge branch 'master' into hs/acme-revocation 3 years ago
Mariano Cano d35848f7a9 Fix unit tests. 3 years ago
Mariano Cano c3f98fd04d Change some bad requests to forbidded.
Change in the sign options bad requests to forbidded if is the
provisioner the one adding a restriction, e.g. list of dns names,
validity, ...
3 years ago
Mariano Cano ff04873a2a Change the default error type to forbidden in Sign.
The errors will also be propagated from sign options.
3 years ago
Mariano Cano b9beab071d Fix unit tests. 3 years ago
Mariano Cano 507a272b4d Return always http errors in sign options. 3 years ago
Mariano Cano a33709ce8d Fix sign ssh options tests. 3 years ago
Mariano Cano 1da7ea6646 Return always http errors in sign ssh options. 3 years ago
Mariano Cano 031d4d7000 Return BadRequest when validating sign options. 3 years ago
Mariano Cano bb26799583 Modify errs.Wrap with forbidden errors. 3 years ago
Herman Slatman 2d50c96d99
Merge branch 'master' into hs/acme-revocation 3 years ago
Mariano Cano b6ebd118fc Update temporal solution for sending message to users 3 years ago
Mariano Cano 668d3ea6c7 Modify errs.Wrap() with bad request to send messages to users. 3 years ago
Mariano Cano 8c8db0d4b7 Modify errs.BadRequestErr() to always return an error to the client. 3 years ago
Mariano Cano 8ce807a6cb Modify errs.BadRequest() calls to always send an error to the client. 3 years ago
Max de2ce5cf9f
Merge pull request #692 from smallstep/max/context
Context management
3 years ago
Mariano Cano 440616cffa
Merge pull request #750 from smallstep/duration-errors
Report duration errors directly to the cli.
3 years ago
Mariano Cano acd0bac025 Remove extra and in comment. 3 years ago
Mariano Cano 1aadd63cef Use always badRequest on duration errors. 3 years ago
Mariano Cano 41fec1577d Report duration errors directly to the cli. 3 years ago
max furman 7fac8c96c3 Merge branch 'master' into max/context 3 years ago
max furman 922d239171 Simplify conditional 3 years ago
max furman a7d144996f SSH backwards compat updates
- use existence of new value in data map as boolean
- add tests for backwards and forwards compatibility
- fix old tests that used static dir locations
3 years ago
max furman 507be61e8c Use a more distint map key to indicate template version
- make the key a variable that can be reused on the CLI side.
3 years ago