d8eeebfd51
Fix error string in tests
...
This commit fixes a test checking an error string from an external
dependency.
1 year ago
c952e9fc9d
Use `NewDetailedError` instead
1 year ago
f3c24fe875
Change how multiple identifiers are printed in errors
1 year ago
a0cdad335d
Add test for `WithAdditionalErrorDetail`
1 year ago
9a52675865
Return descriptive error when using unsupported format
1 year ago
0d3338ff3a
Return consistent ACME error types for specific cases
1 year ago
df22b8a303
Cleanup some leftover TODOs
1 year ago
dd9bf1e915
Add error details for the `step` format
1 year ago
9cbbd1d575
Add error details to ACME `tpm` format validation errors
1 year ago
d5dd8feccd
Prevent internal errors from being returned to ACME clients
1 year ago
979e0f8f51
Add error details to select error cases for `apple` format
1 year ago
a5801b3c74
Fix TPM simulator initialization for tests
1 year ago
7731edd816
Store and verify Acme account location ( #1386 )
...
* Store and verify account location on acme requests
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
Co-authored-by: Mariano Cano <mariano@smallstep.com>
1 year ago
e71b62e95c
Merge branch 'master' into herman/update-crypto-v0.29.4
1 year ago
8b256f0351
address linter warning for go 1.19
1 year ago
0c2b00f6a1
Depend on our fork of `go-attestation`
1 year ago
d9aa2c110f
Increase test coverage for AK certificate properties
2 years ago
ed1a62206e
Add additional verification of AK certificate
2 years ago
1c38e252a6
Cast `alg` to a valid `COSEAlgorithmIdentifier`
2 years ago
e25acff13c
Simplify `alg` validity check
2 years ago
9cd4b362f7
Extract the `ParseSubjectAlternativeNames` function
2 years ago
b6957358fc
Fix PR remarks
...
- Root CA error message improved
- Looping through intermediate certs
- Change checking unhandled extensions to using `if`
2 years ago
09bd7705cd
Fix linting issues
2 years ago
f88ef6621f
Add `PermanentIdentifier` SAN parsing and tests
2 years ago
52023d6083
Add tests for `doTPMAttestationFormat`
2 years ago
ae30f6e96b
Add failing TPM simulator test
2 years ago
bf53b394a1
Add `tpm` format test with simulated TPM
2 years ago
094f0521e2
Remove check for `PermanentIdentifier` from `tpm` format validation
2 years ago
589a62df74
Make validation of `tpm` format stricter
2 years ago
213b31bc2c
Simplify processing logic for unhandled critical extension
2 years ago
e1c7e8f00b
Return the CSR public key fingerprint for `tpm` format
2 years ago
6297bace1a
Merge branch 'master' into herman/acme-da-tpm
2 years ago
69489480ab
Add more complete `tpm` format validation
2 years ago
5ff0dde819
Remove json tag in acme.Authorization fingerprint
2 years ago
6ba20209c2
Verify CSR key fingerprint with attestation certificate key
...
This commit makes sure that the attestation certificate key matches the
key used on the CSR on an ACME device attestation flow.
2 years ago
3a6fc5e0b4
Remove dependency on `smallstep/assert` in ACME challenge tests
2 years ago
0f1c509e4b
Remove debug utility
2 years ago
0f9128c873
Fix linting issue and order of test SUT
2 years ago
2ab9beb7ed
Add tests for `deviceAttest01Validate`
2 years ago
ed61c5df5f
Cleanup some leftover debug statements
2 years ago
60a9e41c1c
Remove `Identifier` from top level ACME `Errors`
2 years ago
edee01c80c
Refactor debug utility
2 years ago
1c38113e44
Add ACME `Subproblem` for more detailed ACME client-side errors
...
When validating an ACME challenge (`device-attest-01` in this case,
but it's also true for others), and validation fails, the CA didn't
return a lot of information about why the challenge had failed. By
introducing the ACME `Subproblem` type, an ACME `Error` can include
some additional information about what went wrong when validating
the challenge.
This is a WIP commit. The `Subproblem` isn't created in many code
paths yet, just for the `step` format at the moment. Will probably
follow up with some more improvements to how the ACME error is
handled. Also need to cleanup some debug things (q.Q)
2 years ago
f1724ea8c5
Merge branch 'master' into herman/acme-da-tpm
2 years ago
64d9ad7b38
Validate Subject Common Name for Orders with Permanent Identifier
2 years ago
817edcbba5
Remove `charset=utf-8` from ACME certificate requests
2 years ago
4cf25ede24
Merge branch 'master' into herman/acme-da-tpm
2 years ago
3eae04928f
Add tests for ACME Meta object
2 years ago
02d679e160
Merge branch 'master' into herman/ignore-empty-acme-meta
2 years ago
e27c6c529b
Add support for custom acme ports
...
This change adds the flags --acme-http-port, --acme-tls-port, that
combined with --insecure can be used to set custom ports for ACME
http-01 and tls-alpn-01 challenges. These flags should only be used
for testing purposes.
Fixes #1015
2 years ago
b9f238ad4d
Add additional ACME `meta` properties to provisioner configuration
2 years ago
c9793561ff
Make `meta` object optional in ACME directory response
...
Harware appliances from Kemp seem to validate the contents of the
`meta` object, even if none of the properties in the `meta` object
is set. According to the RFC, the `meta` object, as well as its
properties are optional, so technically this should be fixed by
the manufacturer.
This commit is to see if we validation of the `meta` object is
skipped if it's not available in the response.
2 years ago
a7e597450a
Update acme/challenge_test.go
...
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
2 years ago
7a78c76199
Add test simulating YubiKey v5.2.4
...
There are YubiKeys v5.2.4 where the attestation intermediate (f9)
does not have a basic constraint extension, so that certificate
is not marked as a CA. The test and CA in this commit imitates
that use case. Currently the test case returns an error as we
don't support it. But if we change the verification to support
this use case, the test should change accordingly.
2 years ago
21666ba887
Revert "Set timestamp when marking an acme challenge invalid"
...
This reverts commit 5f130895f3
2 years ago
8538ff06b7
Add missing error case.
2 years ago
5f130895f3
Set timestamp when marking an acme challenge invalid
2 years ago
7101fbb0ee
Provisioner webhooks ( #1001 )
2 years ago
a8125846dd
Add TPM attestation
2 years ago
f3d1863ec6
A few more linter errors
2 years ago
99299faeeb
Add AuthorizeChallenge unit tests
2 years ago
f0a24bd8ca
Add acme property to enable challenges
...
Fixes #1027
2 years ago
191d9e8629
Use go.step.sm/crypto to set the permanent identifier
2 years ago
2b3b2c283a
Add attestation certificate validation for Apple devices
2 years ago
5f5315260a
iOS 16 beta 1 support
2 years ago
de5b0ef5c2
Verify key authorization is contained within the TPM quote extraData field
2 years ago
6f2b4d3042
Add ACME permanent-identifier identifier type
2 years ago
ab0d2503ae
Standardize linting file and fix or ignore lots of linting errors
2 years ago
7dc2067cb2
Update acme/errors.go
...
Co-authored-by: Max <mx.furman@gmail.com>
2 years ago
226d36f66f
Fix unit tests
2 years ago
8cf6675ce4
Return the internal error instead of the ACME error
...
For ACME errors, return the internal error string instead of the
ACME one on the "Error() string" function. This way the logs will
have more information about the cause of an error.
Fixes #1057
2 years ago
34c6c65671
Pass attestation information to the Sign method
...
Attestation information might be useful in authorizing webhooks
2 years ago
498549c95c
Extract common function used in tests
2 years ago
829530ae90
Fix linter errors
2 years ago
6b73a020e3
Add unit tests for apple and step attestations
2 years ago
0f651799d0
Reject not enabled attestation formats
2 years ago
fd4e96d1f4
Rename method to IsChallengeEnabled
2 years ago
c77b4ff9c5
Fix linter errors
2 years ago
59c5219a07
Use a type for acme challenges
2 years ago
a89bea701d
Format comment
2 years ago
5df9434286
Fix old comment, device-attest-01 uses the acme payload
2 years ago
c5d3714a63
Fix acme error map
2 years ago
08815c5e90
Reneame attestation statement error
2 years ago
3cd72ac72a
Remove debug statements
2 years ago
e75e7e7cd6
Fix linter warnings
2 years ago
54d92095ac
Validate proof of possession signature
...
On the step format, validate proof of possession of the private
key validating the signature in the attestation statement.
2 years ago
59b7603d1e
Use a clientAuth only cert for device-attest-01
2 years ago
ca412e77cc
Return error on attestation validation
...
The method storeError returns a nil error
2 years ago
ab5f916bd3
Define ErrorBadAttestationStatement
2 years ago
735c9d49b0
Add support for yubikey attestation
2 years ago
df96b126dc
Add AuthorizeChallenge unit tests
2 years ago
bca311b05e
Add acme property to enable challenges
...
Fixes #1027
2 years ago
ae8d4d8757
Fix unit test
2 years ago
693dc39481
Merge branch 'master' into device-attestation
2 years ago
23b8f45b37
Address gosec warnings
...
Most if not all false positives
2 years ago
c040e4b459
Add unit tests
2 years ago
b7c2f6c482
Check for DNS name validity
2 years ago
b62f4d1000
Add lgtm comments on some security warnings
2 years ago
2f7cb9225f
Use go.step.sm/crypto to set the permanent identifier
2 years ago
2ab1e6658e
Fix nonce validation
...
The attestation certificate contains the nonce as raw bytes in the
extension 1.2.840.113635.100.8.11.1
2 years ago
66356cff43
Add attestation certificate validation for Apple devices
2 years ago
274f6ccb41
iOS 16 beta 2 support
2 years ago
7e1b0bebd9
iOS 16 beta 1 support
2 years ago
77c6d10fd6
Verify key authorization is contained within the TPM quote extraData field
2 years ago
e1ec31c0ed
Implement TPM attestation statement verification
2 years ago
2ac8b69da2
Add ACME permanent-identifier identifier type
2 years ago
aacd6f4cc6
Add device-attest-01 challenge type
2 years ago
860baeb1c5
Verbose debug logging
2 years ago
fe04f93d7f
all: reformat all go files with the next gofmt (Go 1.19)
...
There are some changes that manually edited, for example using '-' as
default list and grouping imports.
2 years ago
abfbbc8d49
Merge pull request #946 from smallstep/herman/acme-csr-padding
...
Strip base64-url padding from ACME CSR
2 years ago
fd546287ac
Strip base64-url padding from ACME CSR
...
This commit strips the padding from a base64-url encoded CSR
submitted by a client that doesn't use raw base64-url encoding.
2 years ago
e7f4eaf6c4
Remove explicit deprecation notice
...
This will avoid linter errors on other projects for now.
2 years ago
d461918eb0
Merge branch 'master' into context-authority
2 years ago
2ea0c70344
Move acme context middleware to deprecated handler
2 years ago
9147356d8a
Fix linter errors
2 years ago
2ab7dc6f9d
Fix acme tests.
2 years ago
ba499eeb2a
Fix acme/api tests.
2 years ago
6f9d847bc6
Fix panic in acme/api tests.
2 years ago
d82e51b748
Update AllowWildcardNames configuration name
2 years ago
d1f75f1720
Refactor ACME api.
2 years ago
fddd6f7d95
Move linker to the acme package.
2 years ago
55b0f72821
Add context methods for the acme linker.
2 years ago
bb8d85a201
Fix unit tests - work in progress
2 years ago
42435ace64
Use scep authority from context
...
This commit also converts all the methods from the handler to
functions.
2 years ago
d13537d426
Use context in the acme handlers.
2 years ago
bd412c9f42
Add context methods for the acme database
2 years ago
6e1f8dd7ab
Refactor policy engines into container
2 years ago
2a7620641f
Fix more PR comments
2 years ago
fb81407d6f
Fix ACME policy comments
2 years ago
7f9034d22a
Add additional policy options
2 years ago
a9f033ece5
Fix JSON property name for ACME policy
3 years ago
256fe113f7
Improve tests for ACME account policy
3 years ago
034b7943fe
Merge branch 'master' into herman/allow-deny
3 years ago
7df52dbb76
Add ACME EAB policy
3 years ago
479c6d2bf5
Fix ACME IPv6 HTTP-01 challenges
...
Fixes #890
3 years ago
2fbdf7d5b0
Merge branch 'master' into herman/allow-deny
3 years ago
00634fb648
api/render, api/log: initial implementation of the packages ( #860 )
...
* api/render: initial implementation of the package
* acme/api: refactored to support api/render
* authority/admin: refactored to support api/render
* ca: refactored to support api/render
* api: refactored to support api/render
* api/render: implemented Error
* api: refactored to support api/render.Error
* acme/api: refactored to support api/render.Error
* authority/admin: refactored to support api/render.Error
* ca: refactored to support api/render.Error
* ca: fixed broken tests
* api/render, api/log: moved error logging to this package
* acme: refactored Error so that it implements render.RenderableError
* authority/admin: refactored Error so that it implements render.RenderableError
* api/render: implemented RenderableError
* api/render: added test coverage for Error
* api/render: implemented statusCodeFromError
* api: refactored RootsPEM to work with render.Error
* acme, authority/admin: fixed pointer receiver name for consistency
* api/render, errs: moved StatusCoder & StackTracer to the render package
3 years ago
b49307f326
Fix ACME order tests with mock ACME CA
3 years ago
9e0edc7b50
Add early authority policy evaluation to ACME order API
3 years ago
101ca6a2d3
Check admin subjects before changing policy
3 years ago
3ec9a7310c
Fix ACME order identifier allow/deny check
3 years ago
af53a17bb4
Merge branch 'master' into herman/allow-deny
3 years ago
b6f6bd879c
Fix PR comment and add tests for ACME prerequisites checker
3 years ago
e47dd0a666
Add ACME configuration prerequisites check
3 years ago
c3c6f3da72
Merge branch 'master' into herman/allow-deny
3 years ago
bfa2245abb
Merge branch 'master' into herman/normalize-ipv6-dns-names
3 years ago
1fe7362bee
Normalize IPv6 addresses in ACME linker
3 years ago
c1424036bf
Merge branch 'master' into herman/allow-deny
3 years ago
bf21319e76
Fix PR comments and issue with empty string slices
3 years ago
fd9845e9c7
Add cursor and limit to ACME EAB DB interface
3 years ago
Mariano Cano
Herman Slatman
Max
Mariano Cano
Andrew Reed
Brandon Weeks
Shulhan
Herman Slatman
Panagiotis Siatras